summaryrefslogtreecommitdiffstats
path: root/chrome/browser/omnibox_search_hint.cc
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-061-1/+1
| | | | | | | | | | | | | 1/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6689029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-091-3/+3
| | | | | | | | | | | Second part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6639008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77396 0039d316-1c4b-4281-b951-d872f2087c98
* Split infobar_delegate.[cc,h] into separate pieces for the different classes ↵tfarina@chromium.org2011-03-031-1/+1
| | | | | | | | | | | defined within, so that each piece is shorter and clearer. BUG=None TEST=None Review URL: http://codereview.chromium.org/6598057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76677 0039d316-1c4b-4281-b951-d872f2087c98
* Update the includes to the old tab_contents.hjam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6596103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76552 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-02-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | * Change int to size_t in a few APIs. * Rename infobar_delegate_count() to infobar_count() in preparation for TabContents owning InfoBars rather than InfoBarDelegates. * Move some code from PluginInstallerInfoBarDelegate to PluginObserver since it's more related to who's instantiating the infobar(delegate)s. * Unify InfoBarDelegate behavior by making no delegates auto-add themselves to tabs (callers now all do this explicitly). * Eliminate unused member TabContentsSSLHelper::SSLAddCertData::handler_. * De-inline a couple classes. * Make more functions private. * Add some consts. * Change DCHECK() to DCHECK_EQ() where possible. * Rename the delegates in plugin_observer.cc to have "Delegate" in the names. * Remove unnecessary qualifiers. * Simplify. * Misc. style issues, naming issues, etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6250172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74086 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-01-261-0/+1
| | | | | | | | | | | | | * Remove AlertInfoBarDelegate. There are basically no users of this (the only one is in autofill which is really trying to make something like a confirm info bar). * Change the default button set for a ConfirmInfoBarDelegate from 0 buttons to 2 to match how practically every caller uses it. Note that this doesn't remove views' AlertInfoBar yet. AlertInfoBar is now only used as a base for ConfirmInfoBar, but actually moving that functionality into ConfirmInfoBar is to come in a subsequent patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/6262018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72726 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from autocomplete.avi@chromium.org2011-01-251-2/+2
| | | | | | | | | | | Recommit of r72380. BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6306011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72380 - Remove wstring from autocomplete.avi@chromium.org2011-01-241-2/+2
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6256010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from autocomplete.avi@chromium.org2011-01-241-2/+2
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72380 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-1/+1
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to ↵pkasting@chromium.org2011-01-211-62/+85
| | | | | | | | | | "PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff BUG=none TEST=none Review URL: http://codereview.chromium.org/6249010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72166 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-201-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70281 - Revert 70271 - Remove wstring from l10n_util. Part 3.avi@chromium.org2010-12-291-2/+4
| | | | | | | | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6051012 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/5989012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70283 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70271 - Remove wstring from l10n_util. Part 3.avi@chromium.org2010-12-291-4/+2
| | | | | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6051012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70281 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 3.avi@chromium.org2010-12-291-2/+4
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70271 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h.thestig@chromium.org2010-12-171-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5875005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69507 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Added unit tests for omnibox highlightingscr@chromium.org2010-10-271-0/+2
| | | | | | | | | | BUG=55418 TEST=unit_tests --gtest_filter=AutocompletePopupViewGtkTest.\* should run tests on GTK but not Windows or Mac. Review URL: http://codereview.chromium.org/4082002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64169 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-1/+1
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the number of files that recompile when changing template_url.h or ↵levin@chromium.org2010-08-311-0/+1
| | | | | | | | | | | | | | | | | | template_url_model.h. Separated out the TemplateURL::IDType which is now TemplateURLId into its own file, since this was a primary reason for including template_url.h in another header. Similarly separate out the TemplateURLModelObserver from template_url_model.h to reduce how often that file is included. BUG=None TEST=Compiling. Review URL: http://codereview.chromium.org/3270011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58080 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Convert infobar APIs to UTF-16.evan@chromium.org2010-08-131-4/+5
| | | | | | | | | | | | | | | | | The critical change is the base class in infobar_delegate.h. The remainder is just adapting all users to that change. I grepped for all instances of the three base functions whose types I changed to be more sure that I found all classes that tried to overload these functions. I sure wish C++ had an @Override annotation. :~( TEST=compiles BUG=23581 Review URL: http://codereview.chromium.org/3127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56066 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r53603 - Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.tfarina@chromium.org2010-07-301-3/+1
| | | | | | | | | | | | | | | | | This reverts commit 893e3e083fe8d77949860cdb1af7fc14a371651e. It was reverted due to a LINK failure, but reverting didn't fixed either, so I'm relanding it again. BUG=39102 TEST=trybots Review URL: http://codereview.chromium.org/2805096/ TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/3057018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54259 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-291-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53603 - Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.pam@chromium.org2010-07-261-1/+3
| | | | | | | | | | | | | | | | | | | | | With this, this infobar gets the blue style to match with the mocks. Also did a cleanup to get rid of INFO_TYPE that is not more needed. [Rollback: Following this patch, the Chromium XP debug builder started having persistent link failures (LINK1318 error). This is a test to see if it fixes the problems.] BUG=39102 TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2805096 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/2884038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53631 0039d316-1c4b-4281-b951-d872f2087c98
* Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.tfarina@chromium.org2010-07-251-3/+1
| | | | | | | | | | | | | | With this, this infobar gets the blue style to match with the mocks. Also did a cleanup to get rid of INFO_TYPE that is not more needed. BUG=39102 TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2805096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53603 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt four at landing the "histogram.h removed from message_loop.h" patch.erg@chromium.org2010-07-151-0/+1
| | | | | | | | | | | | | | Previously committed as r52349 and r52336. Related commits: r52367, r52364 and r52343. Rerunning trybots due to previous trybot breakage. TEST=none BUG=none Review URL: http://codereview.chromium.org/2965015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
* Revert everything related to the relanding.erg@chromium.org2010-07-141-1/+0
| | | | | | Review URL: http://codereview.chromium.org/2982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52336.erg@chromium.org2010-07-141-0/+1
| | | | | | | | | | | | | | (I accidentally committed a previous version of the patch (the fixed version was in codereview since I had switched to my mac to address this exact compile failure.) BUG=none TEST=none TBR=evan Review URL: http://codereview.chromium.org/2937010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52336 - More header cleanup:erg@chromium.org2010-07-141-1/+0
| | | | | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52343 0039d316-1c4b-4281-b951-d872f2087c98
* More header cleanup:erg@chromium.org2010-07-141-0/+1
| | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52336 0039d316-1c4b-4281-b951-d872f2087c98
* Try to cut down Browser/TabContents header dependencies.erg@chromium.org2010-07-091-0/+1
| | | | | | | | | | | | | - Forward declare printing::PrintViewManager in TabContents - tab_contents.h shouldn't depend on autocomplete_edit.h - Pull logging out of Browser through PageTransitionTypes BUG=none TEST=none Review URL: http://codereview.chromium.org/2934004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51995 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select all when autofocusing the location bar on New Tab creation. ↵pkasting@chromium.org2010-04-231-2/+2
| | | | | | | | | | Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten. BUG=41466 TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading. Review URL: http://codereview.chromium.org/1738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-2/+2
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-1/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-121-0/+1
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds an infobar instructing users they can do search directly from ↵jcampan@chromium.org2009-07-231-0/+204
the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it. Review URL: http://codereview.chromium.org/159242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21438 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 14:28:21 +0000