| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/3597008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code is basically duplicated twice on each platform. This consolidates all
that into PageInfoModel::GetIconImage() and renames the SectionInfo.state to icon_id.
BUG=none
TEST=Page info windows and bubbles work as they did before across all platforms.
Review URL: http://codereview.chromium.org/3560004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52430,52916
TEST=Enable Page Info Bubble in about:labs and click on the lock icon.
Review URL: http://codereview.chromium.org/3461016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SECURITY_STYLE_AUTHENTICATION_BROKEN, like the Omnibox does.
Started using...
a) the Info icon (blue i) for the first visit section and
b) the yellow exclamation point for http connections (instead of the skull and crossbones).
BUG=http://crbug.com/52916
TEST=None
Review URL: http://codereview.chromium.org/3367007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves
three megs off browser.a.
- Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only
shaved 100k off browser.a/renderer.a.
- Adding/Moving dtors of objects that used some form of base::*Timer<> was
negligible; there were only a few classes that had a Timer but had a
ctor/dtor in the header after the previous cleanups.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3278006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/52916
TEST=Navigate to a page with mixed http and https content. The gray padlock should appear in the Omnibox icon and in the infobubble when you click it.
Review URL: http://codereview.chromium.org/3171031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added Certificate Information link.
- Changed iconography to be:
Identity : Green check mark vs. Red skull and bones
Connection: Green padlock vs. Orange exclamation point.
(This used to be Green checkmark and Orange Exclamation point for both sections.
- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.
BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.
Review URL: http://codereview.chromium.org/3187019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added Certificate Information link.
- Changed iconography to be:
Identity : Green check mark vs. Red skull and bones
Connection: Green padlock vs. Orange exclamation point.
(This used to be Green checkmark and Orange Exclamation point for both sections.
- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.
BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.
Review URL: http://codereview.chromium.org/3136031
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3170043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added Certificate Information link.
- Changed iconography to be:
Identity : Green check mark vs. Red skull and bones
Connection: Green padlock vs. Orange exclamation point.
(This used to be Green checkmark and Orange Exclamation point for both sections.
- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.
BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.
Review URL: http://codereview.chromium.org/3136031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
Review URL: http://codereview.chromium.org/2856051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than using a XIB, the window is now built entirely in code. The Controller's
unit test has been removed because after this it is functionally useless. A new test
for the bridge has been added.
This also fixes the text clipping bug for the mixed content warning.
BUG=23438,30843
TEST=No functional change; partially covered by unit tests.
Review URL: http://codereview.chromium.org/2066003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r24792.
TBR=estade
Review URL: http://codereview.chromium.org/179028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11598
TEST=Visit an HTTPS page, click the lock icon, the page info should show.
Review URL: http://codereview.chromium.org/159521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=5116
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well.
TBR=ben
Review URL: http://codereview.chromium.org/155753
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It breaks the release build on Windows.
TBR=ben
Review URL: http://codereview.chromium.org/155736
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well.
Review URL: http://codereview.chromium.org/155336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21032 0039d316-1c4b-4281-b951-d872f2087c98
|