| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Fix issue 6520 by ensuring that InfoBarClosed is called whenever a tab is ↵ | tim@chromium.org | 2009-01-21 | 1 | -16/+1 |
| | | | | | | | | | | | | closed or a navigation to a URL that is not supported by the current TabContentsType takes place by invoking it on all InfoBarDelegates from TabContents::Destroy(), which is the best least-common-denominator I've found for doing this work. Alternatively I could have made InfoBarDelegate listen for TAB_CONTENTS_DESTROYED and self-invoke InfoBarClosed but that seemed unorthodox (relatively speaking). This prevents InfoBarDelegates from leaking in these cases. BUG=6520 Review URL: http://codereview.chromium.org/18381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8406 0039d316-1c4b-4281-b951-d872f2087c98 | ||||
| * | Porting in chrome/browser/ | phajdan.jr@chromium.org | 2009-01-20 | 2 | -73/+82 |
| | | | | | | | Review URL: http://codereview.chromium.org/17606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8280 0039d316-1c4b-4281-b951-d872f2087c98 | ||||
| * | Fix issue 6296 by using a dedicated delegate instance for each infobar that ↵ | tim@chromium.org | 2009-01-16 | 2 | -66/+88 |
| | | | | | | | | | | | | | | the PasswordManager opens, rather than always using the PasswordManager itself as the delegate. The crash was occuring because before one infobar completely finished closing (i.e during its close animation), another password infobar would be opened, and for a moment in time two infobars are pointing to the same delegate. When the initial closing animation completes, it would null-out a field (pending_decision_manager_), which the now visible infobar would depend on when the user clicks one of the native buttons. This click would dereference a null member, hence causing the crash. Other clients of infobars seem to be immune to this problem because they either all create dedicated delegate instances per infobar, or they don't reset any state on InfoBarClosed. I think (at the very least) the infobar code should document that it can be risky to use a "shared" delegate due to the possibility of two simultaneously visible infobars referring to the same delegate. Review URL: http://codereview.chromium.org/18065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8236 0039d316-1c4b-4281-b951-d872f2087c98 | ||||
| * | Move password manager files into a subdir | ben@chromium.org | 2009-01-15 | 10 | -0/+1651 |
| Review URL: http://codereview.chromium.org/18259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8066 0039d316-1c4b-4281-b951-d872f2087c98 | |||||
 |
index : chromium_src.git | |
| central chromium sources |
| summaryrefslogtreecommitdiffstats |