summaryrefslogtreecommitdiffstats
path: root/chrome/browser/password_manager
Commit message (Collapse)AuthorAgeFilesLines
* Move remaining Autofill code to //components/autofill.joi@chromium.org2013-03-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This leaves behind all browser tests, the AutofillCCInfobarDelegate and PersonalDataManagerFactory, which remain Chrome-specific. All source files were moved using //tools/git/move_source_file.py, which updates includes of moved files, sorts include order, and updates header guards. The only manual bits of this change were: - Move .proto file - Move .cc.utf8 file - Update .gypi files - Update DEPS files - Remove an unnecessary include from autofill_manager.cc TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/12434004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187173 0039d316-1c4b-4281-b951-d872f2087c98
* Separate WebDatabase management from WebDataService.caitkp@chromium.org2013-03-081-3/+6
| | | | | | | | | | | | | | | This is so that we can have multiple XXXWebDataServices interacting with the same DB. TEST=No noticable change, all unit-tests pass BUG=166488 TBR=tim@chromium.org,rlp@chromium.org,bauerb@chromium.org (for WebDataService API changes in unit tests) Review URL: https://chromiumcodereview.appspot.com/12220084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186824 0039d316-1c4b-4281-b951-d872f2087c98
* Establish components/autofill and move some fileskaiwang@chromium.org2013-03-074-4/+4
| | | | | | | | | | | | | Moving autofill related only files under chrome/common/ to components/autofill/common We are going to move autofill to components/autofill to componentize it. This is the first moving CL. BUG=140037 Review URL: https://chromiumcodereview.appspot.com/12543010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186632 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce //components/user_prefs.joi@chromium.org2013-03-063-3/+3
| | | | | | | | | | | | | | | | | | The user_prefs component provides: a) The UserPrefs class, used to map PrefService objects to BrowserContext. This addresses a TODO to get rid of PrefServiceFromBrowserContext from base/prefs/pref_service.h, where clearly a mention of a content class did not belong. b) A place for PrefRegistrySyncable to live, where it can be used by components that need to register prefs. We also use (b) in this change to eliminate Autofill's dependency on chrome/browser/prefs. Work is ongoing to move Autofill to //components/autofill. TBR=ben@chromium.org BUG=155525,140037 Review URL: https://chromiumcodereview.appspot.com/12340111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186301 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Update include paths of string_split.h to its new location.tfarina@chromium.org2013-02-281-1/+1
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12378016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185315 0039d316-1c4b-4281-b951-d872f2087c98
* Move the UI related code from AutofillExternalDelegate to ↵kaiwang@chromium.org2013-02-271-1/+2
| | | | | | | | | | | | | | | | | AutofillManagerDelegate Move the UI related code (autofill popup controlling) to AutofillManagerDelegate (implementated by TabAutofillManagerDelegate), which is a better place for UI dependencies, and many other UI dependencies are already there. Note: work in progress. Will modify tests BUG=140037 Review URL: https://chromiumcodereview.appspot.com/12340065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184881 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 184352brettw@chromium.org2013-02-245-23/+22
| | | | | | | | | | | | | | | | | > Add utf_string_conversions to base namespace. > > This adds "using"s for all functions so those can be fixed in a separate pass. > > This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. > > BUG= > > Review URL: https://codereview.chromium.org/12314090 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/12315071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184355 0039d316-1c4b-4281-b951-d872f2087c98
* Add utf_string_conversions to base namespace.brettw@chromium.org2013-02-245-22/+23
| | | | | | | | | | | | This adds "using"s for all functions so those can be fixed in a separate pass. This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. BUG= Review URL: https://codereview.chromium.org/12314090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184352 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-242-2/+2
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Split testing_pref_service.h/.cc into two parts, generic vs. Chrome-specific.joi@chromium.org2013-02-121-1/+1
| | | | | | | | | | TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/12223091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182026 0039d316-1c4b-4281-b951-d872f2087c98
* Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.joi@chromium.org2013-02-119-9/+9
| | | | | | | | | | | | | | This is a mostly-automated change, using ./tools/git/move_source_file.py to move files and fix up include guards and #includes from other files. Manual edits were limited to fixing up .gypi files and adding BASE_PREFS_EXPORT where needed. TBR=ben@chromium.org BUG=155525 Review URL: https://codereview.chromium.org/12211105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181707 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.joi@chromium.org2013-02-106-23/+27
| | | | | | | | | | | Minimize usage of PrefServiceSyncable. It is mostly an implementation detail of ProfileImpl and the sync integration. TBR=ben@chromium.org BUG=155525 Review URL: https://codereview.chromium.org/12079097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181648 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'master' into file_path_browserbrettw@chromium.org2013-02-106-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version control markers Merge branch 'master' into file_path_browser remove version control Fix typo Merge branch 'master' into file_path_browser Conflicts: chrome/browser/intents/native_services_browsertest.cc chrome/browser/ui/intents/native_file_picker_service.cc Merge branch 'master' into file_path_browser Conflicts: chrome/browser/chromeos/drive/drive_file_system.cc chrome/browser/chromeos/drive/drive_file_system.h chrome/browser/chromeos/drive/drive_file_system_interface.h chrome/browser/chromeos/drive/drive_file_system_unittest.cc chrome/browser/chromeos/drive/file_system/drive_operations.cc chrome/browser/chromeos/login/wallpaper_manager.cc chrome/browser/chromeos/login/wallpaper_manager.h chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc chrome/browser/google_apis/gdata_wapi_operations.cc chrome/browser/google_apis/gdata_wapi_operations.h chrome/browser/google_apis/gdata_wapi_operations_unittest.cc chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/profiles/profile_impl_io_data.cc chrome/browser/profiles/profile_impl_io_data.h chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc chrome/browser/ui/webui/options/manage_profile_handler.cc Long lines long lines some long lines. long lines long lines Beginning of lines. Rename FilePath -> base::FilePath in chrome/browser git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
* Rename FilePath to base::FilePath and use new location of ↵brettw@chromium.org2013-02-082-2/+2
| | | | | | | | string_number_conversions in some chrome subdirectories. Review URL: https://codereview.chromium.org/12218065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
* Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ↵yuki@chromium.org2013-02-071-16/+16
| | | | | | | | | | | | | | ownership in comments. Replaces Response* with scoped_ptr<Response> in dbus code and its related code. BUG=163231 TEST=no regression / no behavior changes Review URL: https://chromiumcodereview.appspot.com/12092061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181266 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition.rsleevi@chromium.org2013-02-071-20/+28
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://codereview.chromium.org/12212048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181164 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PasswordStoreTest memory leakkaiwang@chromium.org2013-01-221-1/+1
| | | | | | | | | | | | | We have to stop DB thread first. Because it may post some clean up task to UI thread. BUG=170332 Review URL: https://chromiumcodereview.appspot.com/11871029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178038 0039d316-1c4b-4281-b951-d872f2087c98
* Change infobar creation to use a public static Create() method on the ↵pkasting@chromium.org2013-01-081-22/+33
| | | | | | | | | | | | | | | | | | | | | | | infobar delegate classes. Make constructors as private as possible. This has several purposes: * By preventing direct instantiation, it prevents callers from leaking if they create an infobar and don't add it to an InfoBarService. * By moving decision-making about when to show infobars into these Create() functions, there's a pattern for where such code should go, and caller code becomes simpler and easier to read. * The two bullets above together mean that for infobars which should only be displayed in certain circumstances, code can't accidentally bypass the decision logic. * It enables us to eliminate a common InfoBarService* temp on the caller side since the caller no longer needs to both pass the pointer to the infobar _and_ call AddInfoBar() on the pointer. This was also a somewhat redundant-looking pattern. * It makes it easier to change the ownership model for infobars in the future by limiting the affected callsites to only the Create() functions. Note that right now, this still feels pretty redundant since we pass all the same args to Create() functions as constructors most times. In the new ownership model constructors will no longer need to take InfoBarService*s, which will make this better. Additionally, this makes AddInfoBar()/ReplaceInfoBar() take scoped_ptr<>s to indicate they're receiving ownership. This sort of change is easy to make since we only need change the create functions. This change also has a functional effect: it eliminates some cases where we tried to only show infobars when no other infobars were already showing (discussed and approved by Glen). BUG=none TEST=none Review URL: https://codereview.chromium.org/11644059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175467 0039d316-1c4b-4281-b951-d872f2087c98
* DEFINE_WEB_CONTENTS_USER_DATA_KEY now requires a semicolon.avi@chromium.org2013-01-072-2/+2
| | | | | | | | | | BUG=168549 TEST=none; tested by compile Review URL: https://chromiumcodereview.appspot.com/11783012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175378 0039d316-1c4b-4281-b951-d872f2087c98
* Small fixes to allow unit tests to compile with gcc 4.7.x (tested with gcc ↵kamil.jiwa@gmail.com2013-01-031-1/+1
| | | | | | | | 4.7.2) Review URL: https://chromiumcodereview.appspot.com/11568033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174956 0039d316-1c4b-4281-b951-d872f2087c98
* Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.joi@chromium.org2012-12-227-13/+17
| | | | | | | | | | | | | | | | | | | | | The first two (PrefServiceSimple is a subclass of PrefService) know nothing about sync or any Chrome or content concepts. The third (PrefServiceSyncable, a separate subclass of PrefService) knows about sync and requires users to choose whether each individual preference is syncable or not when it is registered. BrowserProcess::local_state() is a PrefServiceSimple after this change, and Profile::prefs() is a PrefServiceSyncable. COLLABORATOR=kaiwang@chromium.org TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11570009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174531 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: add library loader for GNOME keyring."phajdan.jr@chromium.org2012-12-203-86/+154
| | | | | | | | | | | | Causes crashes on Ubuntu Lucid. TBR=brettw BUG=166913, 162733 Review URL: https://codereview.chromium.org/11647041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174238 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all uses of InfoBarTabHelper -> InfoBarService. Make InfoBarTabHelperpkasting@chromium.org2012-12-201-8/+8
| | | | | | | | | | an implementation detail by declaring all its functions private. BUG=none TEST=none Review URL: https://codereview.chromium.org/11442041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174196 0039d316-1c4b-4281-b951-d872f2087c98
* Remove straggling TabContents references.avi@chromium.org2012-12-141-1/+1
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11577020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173207 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents includes.avi@chromium.org2012-12-141-1/+0
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11570024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173206 0039d316-1c4b-4281-b951-d872f2087c98
* Convert PasswordStore::GetLogins to not depend on CancelableRequestkaiwang@chromium.org2012-12-1421-200/+291
| | | | | | | | | | | | | | | | | Please note, in order to reduce the CL size, I only converted GetLogins. There will be another CL to convert GetAutofillableLogins and GetBlackListLogins. As a result, there's a bunch of old code I can not get rid of now. e.g. PasswordStore::GetLoginRequest PasswordStore::Schedule PasswordStoreConsumer::OnPasswordStoreRequestDone etc Will clean them up in next CL BUG=155883,162337 Review URL: https://chromiumcodereview.appspot.com/11415106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173076 0039d316-1c4b-4281-b951-d872f2087c98
* Move PrefMember to base/prefs/public now that it has no bad dependencies.joi@chromium.org2012-12-121-1/+1
| | | | | | | | | | | | | | | | | | Move PrefObserver out of base/prefs/public to base/prefs/ since it is now an internal implementation detail. Update .gyp(i) files to match. The rest is just mechanical updates to include paths and such, generated by the tools/git/move_source_file.py script. TBR=brettw@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172581 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore autocomplete=off when password manager is saving the generated ↵zysxqn@google.com2012-12-122-1/+70
| | | | | | | | | | | passwords during account creation. Note that for the entire feature to work we also need to ignore autocomplete=off when autofill manager is autofilling the generated passwords during log-in, which will be addressed in later CLs. BUG=120779 Review URL: https://chromiumcodereview.appspot.com/11446028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172557 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add library loader for GNOME keyring.phajdan.jr@chromium.org2012-12-063-154/+86
| | | | | | | | BUG=162733 Review URL: https://codereview.chromium.org/11437025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171573 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to display an errors that occur during the chrome sign in processrogerta@chromium.org2012-12-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to the user as a bubble on the NTP. BUG=81265 TEST=Gaia related errors, such as incorrect email, password and/or otp are handled by the gaia sign in page itself. These errors are reported just like on any gaia sign in attempt. Errors that occur after sign in, such as an account already connected with another profile, or an account prohibited by policy, and so on are displayed as bubbles on the ntp. Test scenarios that should be considered: - all sign in access points: first run, ntp, wrench menu, settings, and one-click sin in - use account with and without 2-factor enabled - scenarios where you type the correct password and/or otp the first time, incorrect once and correct the second time, incorrect twice and correct the third time. Its important to test with multiple failures in a row before typing the password correctly, but I would't bother past 3 failed attempts followed by a successful attempt - try closing the tab used for the sign in before actually signing in. Or simply navigate to another page and start browsing with it - on the settings page, make sure that the advanced configuration dialog works as expected when signed in. Try it multiple times, changing the options and saving or cancelling - open two windows, and a settings page in each one. Try to sign in with one while clicking on buttons on the other - make sure that one-click behaviour is not changed. That is, it should only be offered once per profile. Also make sure that the four other access points do continue to be offered after having used one-click sign in - make sure that rejected emails wrt one-click sign in do not prohibit that account from signing in with the four other access points - create a second profile and do the same tests. in particular, try to use the same account as the first profile (it should not be allowed) Note that gaia currently does not support sign in for chrome using "re-auth". That is, if you see a sign in page where the email address is already filled in and unchangeable, then this is a re-auth. This will land in gaia soon. How does this affect testing? In the following scenario: - sign in to chrome once (for example, with first run) - go to settings and disconnect the profile - sign in to chrome again (for exaample, from the settings page) In this case, you will see a re-auth screen. To proceed, click the sign out link at the bottom of the form and then sign in again. Review URL: https://chromiumcodereview.appspot.com/11411267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171190 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last usages of PrefObserver outside of Prefs.joi@chromium.org2012-12-041-1/+1
| | | | | | | | | | | | | | | | | | This involved: a) Removing methods that used PrefObserver from PrefChangeRegistrar and PrefMember. b) Removing implementation of PrefObserver from a few remaining classes. c) Removing NULL PrefObserver parameter for classes using PrefMember but not wishing for a callback. d) Updating unit tests and test utility classes. Also fixed what was most likely a bug (or at least an unintentional change in behavior) that I had introduced in CoreChromeOSOptionsHandler in a previous change. Before my series of PrefObserver-related changes, there was polymorphism involved and the subclass was only handling pref changes for a couple of preferences (kProxy and kUseSharedProxy, only one of which it registers for itself) if the PrefService was the standard one, not the incognito one, otherwise delegating to the parent class. TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11316163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171002 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Fix crash seen when PasswordDataTypeController::StartModels failsrsimha@chromium.org2012-11-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | In the case where PasswordDataTypeController::StartModels fails due to the unavailability of the password store, we currently attempt to call NonFrontendDataTypeController::StartDoneImpl. This is bad, because StartDoneImpl attempts to run its callback, which is null, in cases where NonFrontendDataTypeController::StartAssociating has not yet been called. This patch does the following: 1) Makes PasswordDataTypeController::StartModels simply return false in cases where the password store is unavailable, which prevents the running of a null callback. 2) Fixes a bug in ModelAssociationManager::ModelLoadCallback, where if a model failed to load, the error was not being plumbed back to the caller. We now call TypeStartCallback with the right error to allow forward progress. 3) Adds the unit test ProfileSyncServicePasswordTest.FailPasswordStoreLoad. TBR=tim@chromium.org BUG=146417 TEST=ProfileSyncServicePasswordTest.FailPasswordStoreLoad Review URL: https://codereview.chromium.org/11414045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169098 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/browser: Update calls from RunAllPending() to RunUntilIdle().tfarina@chromium.org2012-11-172-2/+2
| | | | | | | | | | | | RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11413050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168416 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-164-9/+9
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* Fill passwords if password manager is disabled.ttr314@googlemail.com2012-11-093-16/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | As of now, filling passwords is directly dependent on the manager being enabled in the settings. However, the password manager is supposed to fill previously stored passwords even when disabled. Changes introduced by the patch are as following: - Remove IsFillingEnabled() and update code relying on method accordingly. - Add test to ensure that password saving depends on manager enabled preference. - Add test to ensure that passwords are filled on a disabled password manager. - Add myself to AUTHORS file. Contributed by Timo Reimann <ttr314@googlemail.com> R=isherman@chromium.org BUG=158296 Review URL: https://chromiumcodereview.appspot.com/11361142/ Review URL: https://chromiumcodereview.appspot.com/11361142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166878 0039d316-1c4b-4281-b951-d872f2087c98
* Remove alias from ChromeRenderViewHostTestHarness.avi@chromium.org2012-10-191-2/+3
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11236010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163071 0039d316-1c4b-4281-b951-d872f2087c98
* Make the WebContentsUserData locator key private.avi@chromium.org2012-10-121-1/+1
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11085055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161630 0039d316-1c4b-4281-b951-d872f2087c98
* Switch InfoBarTabHelper to use WebContentsUserData.avi@chromium.org2012-10-111-4/+4
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11030045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161255 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: IWYU for base/time.h. Also fix misc lint errors.thestig@chromium.org2012-10-101-2/+1
| | | | | | | | TBR=ben,brettw,oshima,rdsmith Review URL: https://chromiumcodereview.appspot.com/11087021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160999 0039d316-1c4b-4281-b951-d872f2087c98
* Switch PasswordManager and PasswordManagerImpl to use WebContentsUserData.avi@chromium.org2012-10-095-22/+64
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11026057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160979 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Move some private kwallet declarations out of the header and into ↵thestig@chromium.org2012-10-092-84/+72
| | | | | | | | an anonymous namespace. Review URL: https://chromiumcodereview.appspot.com/11065030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160750 0039d316-1c4b-4281-b951-d872f2087c98
* Switch AutofillManager to be UserData on WebContents.avi@chromium.org2012-10-081-1/+3
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160706 0039d316-1c4b-4281-b951-d872f2087c98
* Move forms/ out of webkit/.blundell@chromium.org2012-10-0539-212/+198
| | | | | | | | | | | | | | | | | | | | | | The motivation for this CL is to move PasswordForm and friends (which are totally unrelated to WebKit) out of webkit/ and into a target that platforms that do not use WebKit (such as iOS) can logically depend on. As such, this CL does three things: 1. Separates the WebKit-related code in webkit/forms from the non-WebKit-related code. Concretely, this means having the WebKit::WebFormElement->PasswordForm conversion function in its own file. 2. Moves the core, non-WebKit-related forms code to chrome/common and content/public/common depending on where its usage points are. 3. Moves the above-mentioned conversion function to content/public/renderer. It cannot stay in webkit/ as it (now) has a dependency on content/, and as it is used only in chrome/renderer and content/renderer, this is a good place for it. The rest of this CL is churn due to namespace, file location, and GYP target changes. BUG= Review URL: https://chromiumcodereview.appspot.com/11000016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160280 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY proxy authentication support.piatek@google.com2012-09-281-0/+8
| | | | | | | | | BUG=147591 Review URL: https://chromiumcodereview.appspot.com/10913238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159342 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new field in password_form to distinguish generated passwords from ↵guohui@chromium.org2012-09-271-0/+3
| | | | | | | | manually entered ones Review URL: https://chromiumcodereview.appspot.com/10861009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158955 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes the issue that password save prompt is suppressed when the ↵guohui@chromium.org2012-09-244-21/+90
| | | | | | | | | | action URL is modified prior to submit. BUG=27246 TEST= Login to the website http://ikariam.com/ and verify password save prompt is shown after navigation. Review URL: https://chromiumcodereview.appspot.com/10892011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158301 0039d316-1c4b-4281-b951-d872f2087c98
* Move cancelable_request.cc/h to chrome/browser/common.kaiwang@chromium.org2012-09-222-2/+2
| | | | | | | | | | It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
* Moving google_apis and GaiaClient to src/google_apis.joi@chromium.org2012-09-071-1/+1
| | | | | | | | | | TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. ↵thestig@chromium.org2012-09-062-4/+4
| | | | | | | | Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for failing unit tests PasswordStoreDefaultTest.*cramya@chromium.org2012-08-301-1/+8
| | | | | | | | | | | | | | | | | | There seems to a bug in STLport for Android because of which copying a vector into a set using expectations(first.begin(), first.end()) causes a crash. If we instead use std::copy(first.begin(), first.end(), std::inserter(expectations, expectations.begin())); there is no crash. BUG=144161 Review URL: https://chromiumcodereview.appspot.com/10885019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154214 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 08:05:57 +0000