summaryrefslogtreecommitdiffstats
path: root/chrome/browser/password_manager
Commit message (Collapse)AuthorAgeFilesLines
* Linux: fix several bugs in KWallet password store support.mdm@chromium.org2010-08-102-4/+36
| | | | | | | | | | | | * Don't disable kwallet support if the first site visited with a login form has no saved passwords. * Don't crash when there are certain types of invalid entries stored in the wallet that fail to deserialize. TEST=start with --password-store=detect in KDE and check that the above happens BUG=49968 Review URL: http://codereview.chromium.org/3048052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55535 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 4)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-035-3/+7
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-311-2/+2
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-302-3/+5
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-291-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2617-0/+17
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECKs to check PasswordStore's threadingdavidben@chromium.org2010-07-263-2/+11
| | | | | | | | | | | | | | PasswordStore can only be queried from one thread, although the implementation doesn't immediately look it. This adds DCHECKs to ensure we don't mess this up in future. R=wtc,stuartmorgan BUG=none TEST=PasswordManagerTest.* Review URL: http://codereview.chromium.org/3056008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53707 0039d316-1c4b-4281-b951-d872f2087c98
* Header Cleanup2: Remove another include of sqlite_utils.h that is not needed.tfarina@chromium.org2010-07-181-3/+6
| | | | | | | | | | | BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2843062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52837 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: access GNOME Keyring on the GLib main thread, rather than the DB thread.mdm@chromium.org2010-07-162-208/+490
| | | | | | | | | I was unable to reproduce the crash, but it's happening to a lot of people and the web suggests that moving access to GNOME Keyring to the GLib main thread should fix the problem. BUG=48343, 25404 TEST=hopefully it won't crash for some people any more Review URL: http://codereview.chromium.org/2953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52729 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the PasswordManagerDelegate out of PasswordManager.erg@chromium.org2010-07-164-33/+53
| | | | | | | | | | | | | | | Previously, anyone who included tab_contents.h would bring in a bunch of implementation details of the password manager from webkit_glue. This breaks the delegate interface out of the rest of password manager system and makes FillData not an inner-class so anyone can forward declare FillData instead of having to include the header to meet a delegate interface. BUG=none TEST=none Review URL: http://codereview.chromium.org/2877022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52726 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill credit cards should be obfuscated on Linuxdhollowa@chromium.org2010-07-162-13/+106
| | | | | | | | | | | AutoFill credit card information now gets stored in obfuscated form on disc. BUG=42038, 49115 TEST=EncryptorTest.CypherTextDiffers, EncryptorTest.DecryptError Review URL: http://codereview.chromium.org/2931020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52596 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill credit cards should be encrypted on the Macdhollowa@chromium.org2010-07-166-24/+392
| | | | | | | | | | | These changes add encryption support on Mac for the Encryptor class. AES 128 bit is used for the encryption, and the auto-generated password is stored now in the Mac Keychain. This implies the Encryptor class on Mac can now block for user input, and can fail if access is denied. BUG=42038, 49131 TEST=EncryptorTest.CypherTextDiffers, EncryptorTest.DecryptError, EncryptorPasswordTest.* Review URL: http://codereview.chromium.org/2943014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52590 0039d316-1c4b-4281-b951-d872f2087c98
* Implement UMA tracking for every form that the password manager sees.dpranke@chromium.org2010-07-014-22/+124
| | | | | | | | | | | | | | We will track how the manager first interprets the form (match found or not, etc.), what action if any the user takes to change the values, and the result (form submitted or not, and did it succeed or fail). BUG=45946 R=jcivelli@chromium.org, jar@chromium.org TEST=manual testing using about:histograms/PasswordManager and verifying the stats Review URL: http://codereview.chromium.org/2831033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51455 0039d316-1c4b-4281-b951-d872f2087c98
* Don't re-store deleted passwords on form submit on the Macstuartmorgan@chromium.org2010-06-294-31/+224
| | | | | | | | | | | | Adds test coverage for the various update cases to make sure they are all handled correctly. Also fixes a regression during the recent PasswordStore refactoring that caused the Mac implementation to run queries on the wrong thread (found by the new unit tests). BUG=35603 TEST=See bug; other password update cases should continue to work as before. Review URL: http://codereview.chromium.org/2818035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51135 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: delete the unencrypted login database file after a successful ↵mdm@chromium.org2010-06-295-77/+81
| | | | | | | | | | password store migration, since otherwise fragments of password data may be left in it. BUG=25404 TEST=the "Login Data" file should get deleted and recreated from scratch after migration Review URL: http://codereview.chromium.org/2866023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51094 0039d316-1c4b-4281-b951-d872f2087c98
* linux: work around gnome keyring memory corruptionevan@chromium.org2010-06-241-105/+171
| | | | | | | | | | | | | | | | | Older versions of gnome keyring corrupt memory if you fetch too much data from it. Despite our best efforts, we couldn't come up with a way to tell if you're using the broken old version so that we could blacklist it. Instead, we fetch passwords one-by-one, which is slow but tolerable since we do it on a background thread anyway. While I'm here, refactor the code a bit to simplify it. TEST=password manager doesn't crash when using mdm's sample 100 password db with --password-store=gnome on hardy Review URL: http://codereview.chromium.org/2838023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50771 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Password Manager aggregate metrics reportingdpranke@chromium.org2010-06-244-0/+27
| | | | | | | | | | | | This patch implements UMA histograms for the total number of saved passwords and the number of usernames per site/realm. BUG=45946 R=jcivelli@chromium.org TEST=none Review URL: http://codereview.chromium.org/2834009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50677 0039d316-1c4b-4281-b951-d872f2087c98
* linux: initialize glib-dbus threading during startupevan@chromium.org2010-06-231-6/+0
| | | | | | | | | | | | Rather than scattering init calls through the code, just inititialize it once. (In particular, the gnome-keyring support also needs this function called, and I didn't want to copy it one more time.) TEST=no threading-related crash during gnome-keyring startup Review URL: http://codereview.chromium.org/2873015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50652 0039d316-1c4b-4281-b951-d872f2087c98
* Take #3 - attempt to resubmit the ReportMetrics() change for the ↵dpranke@chromium.org2010-06-237-0/+21
| | | | | | | | | | | | | | | | PasswordStore object. Attempting to resubmit this CL. It looks like the previous CLs failed because of some weird issue with GMock on Windows - moving the ordering of the method declarations in password_manager_unittest seems to fix things. TBR=jcivelli@chromium.org BUG=45946 TEST=unit_tests stays green Review URL: http://codereview.chromium.org/2810023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50564 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::SHA1HashString in ie7_password::GetUrlHashdavidben@chromium.org2010-06-222-71/+15
| | | | | | | | | | | | This saves a considerable amount of code. It also removes the call to CryptAcquireContext without CRYPT_VERIFYCONTEXT which is not recommended if passing a NULL container. (We were only computing a hash, so CRYPT_VERIFYCONTEXT was sufficient.) R=wtc BUG=none TEST=PasswordStoreWinTest.ConvertIE7Login Review URL: http://codereview.chromium.org/2875002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50516 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: detect old and broken versions of GNOME Keyring and don't use them. ↵mdm@chromium.org2010-06-211-36/+52
| | | | | | | | | | Also some code cleanup. (Still disabled.) TEST=should fail to load GNOME Keyring 2.22 (e.g. Ubuntu 8.04), but will load newer versions BUG=none Review URL: http://codereview.chromium.org/2814020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50384 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: jcivelli@chromium.orgdpranke@chromium.org2010-06-187-20/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50291 0039d316-1c4b-4281-b951-d872f2087c98
* Re-submit 50177 - implement stubs of reporting usage metrics for the passworddpranke@chromium.org2010-06-187-0/+20
| | | | | | | | | | | | manager. BUG=45946 R=jcivelli TEST=none Review URL: http://codereview.chromium.org/2841017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50289 0039d316-1c4b-4281-b951-d872f2087c98
* Unreviewed - revert 50177, 50181, 50184dpranke@chromium.org2010-06-187-20/+0
| | | | | | Review URL: http://codereview.chromium.org/2814018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50185 0039d316-1c4b-4281-b951-d872f2087c98
* Unreviewed build fix - fix typo in last unreviewd build fix :(dpranke@chromium.org2010-06-181-1/+1
| | | | | | | | | | R=none BUG=none TEST=none Review URL: http://codereview.chromium.org/2850013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50184 0039d316-1c4b-4281-b951-d872f2087c98
* build fix in password manager unit tests.dpranke@chromium.org2010-06-181-0/+1
| | | | | | | | | | R=none TEST=none BUG=none Review URL: http://codereview.chromium.org/2822018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50181 0039d316-1c4b-4281-b951-d872f2087c98
* Implement stubs of a method to report usage metrics for the password manager.dpranke@chromium.org2010-06-186-0/+19
| | | | | | | | | | | | | | This function does nothing for now but I'm submitting it to minimize the size of the CLs to review (there will be at least two subsequent CLs, one for Win and Linux and one for Mac). BUG=45946 R=jcivelli@chromium.org TEST=none Review URL: http://codereview.chromium.org/2813013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50177 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor GNOME Keyring and KWallet integration to allow migration ↵mdm@chromium.org2010-06-169-365/+1507
| | | | | | | | | | from the default store, and add unit tests. Still disabled. BUG=12351, 25404 TEST=unit tests work Review URL: http://codereview.chromium.org/2806002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50034 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary header dependency and fix misleading comment.dpranke@chromium.org2010-06-153-12/+12
| | | | | | | | | | | | | | | PasswordFormManager() doesn't directly depend on the web_data_service, so I'm removing the #include; doing so exposed a missing dependency of the safe_browsing_service (which was failing to include chrome_thread.h directly). Also, the comment above the constructor was wrong. R=tim@chromium.org BUG=none TEST=things still compile Review URL: http://codereview.chromium.org/2770009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49755 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two rare memory leaks in the password storage system.mdm@chromium.org2010-06-143-4/+7
| | | | | | | | | They occur when canceling outstanding requests and when removing logins from a range of timestamps. BUG=none TEST=none Review URL: http://codereview.chromium.org/2819001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49694 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Update comments for a few disabled tests.jhawkins@chromium.org2010-06-121-0/+1
| | | | | | | | | | TBR=thestig BUG=none TEST=none Review URL: http://codereview.chromium.org/2786015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49618 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the password manager code to report at startup whether it is enableddpranke@chromium.org2010-06-071-0/+25
| | | | | | | | | | | | (by generating one of two UserActions). BUG=none R=tim@chromium.org, jar@chromium.org TEST=none Review URL: http://codereview.chromium.org/2638001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49123 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-062-4/+4
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make GNOME keyring password store able to use libgnome-keyring via ↵mdm@chromium.org2010-06-051-2/+120
| | | | | | | | | | | dlopen. The GNOME keyring password store is still disabled. BUG=25404 TEST=gnome keyring password store can be loaded with dlopen Review URL: http://codereview.chromium.org/2696002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48996 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: bring GNOME Keyring and KWallet integration back into a compilable ↵mdm@chromium.org2010-06-045-180/+532
| | | | | | | | | | | state. Still disabled, however. BUG=12351,25404 TEST=both now seem to work correctly when enabled (but this CL does not enable them) Review URL: http://codereview.chromium.org/2407001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48983 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show "save password" infobar on broken pages, which we cannot autofill.georgey@chromium.org2010-05-194-0/+46
| | | | | | | | BUG=33992 TEST=For the second page in the bug InfoBar should not appear anymore. Review URL: http://codereview.chromium.org/2089014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47601 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PasswordStoreWinTest.MultipleWDSQueriesOnDifferentThreads while Ialbertb@chromium.org2010-05-181-1/+1
| | | | | | | | | | | investigate why it hangs every now and then. BUG=43836 TEST=none Review URL: http://codereview.chromium.org/2051012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47532 0039d316-1c4b-4281-b951-d872f2087c98
* Update password store for synczork@chromium.org2010-05-116-5/+63
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1999005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46978 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of MetaTableHelper class and make use of the app/sql API in the ↵stuartmorgan@chromium.org2010-05-112-161/+161
| | | | | | | | | | | | | LoginDatabase. BUG=None TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1700017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46929 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Add a bunch of missing includes.thestig@chromium.org2010-05-101-1/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2018001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46850 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a possible crash introduced by r46412 by not accessing the result ↵evan@chromium.org2010-05-061-5/+4
| | | | | | | | | | | | | variable before the NULL check BUG=43408 TEST=none Patch by Benjamin Jemlich <pcgod99@gmail.com>. Review URL: http://codereview.chromium.org/2035003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46614 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate web data service logins to the login database correctly on win.albertb@chromium.org2010-05-044-13/+194
| | | | | | | | | BUG=43054 TEST=PasswordStoreWinTest.Migration Review URL: http://codereview.chromium.org/1874001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46412 0039d316-1c4b-4281-b951-d872f2087c98
* Send out notifications when logins are changed on Win and Linux.albertb@chromium.org2010-04-302-5/+182
| | | | | | | | | BUG=35039 TEST=PasswordStoreDefaultTest.Notifications Review URL: http://codereview.chromium.org/1758020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46132 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PasswordStoreWin to store logins in a LoginDatabase instead ofalbertb@chromium.org2010-04-3010-462/+562
| | | | | | | | | | | the WebDataService. BUG=35038 TEST=PasswordStoreDefaultTest.* Review URL: http://codereview.chromium.org/1572040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46075 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak introduced in r45841.snej@chromium.org2010-04-281-1/+1
| | | | | | | | | BUG=none TEST=PasswordManagerTest::FormSubmitFailedLogin + valgrind Review URL: http://codereview.chromium.org/1795008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45884 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 1752007: Send out notifications when logins are changed through ↵albertb@chromium.org2010-04-282-35/+105
| | | | | | | | | | | PasswordStoreMac so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1803006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix password mgr heuristics for sites that keep the login form around after ↵snej@chromium.org2010-04-283-22/+87
| | | | | | | | | | | | signin The test for whether the login form reappeared on the next page load now ignores invisible forms. BUG=28911 TEST=none (manual testing with reduced web pages) Review URL: http://codereview.chromium.org/1656005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45841 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45640 - Send out notifications when logins are changed through ↵akalin@chromium.org2010-04-272-106/+35
| | | | | | | | | | | | | | | | PasswordStoreMac so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1752007 TBR=albertb@chromium.org Review URL: http://codereview.chromium.org/1763013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45661 0039d316-1c4b-4281-b951-d872f2087c98
* Send out notifications when logins are changed through PasswordStoreMacalbertb@chromium.org2010-04-262-35/+106
| | | | | | | | | | | so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1752007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45640 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 14:11:39 +0000