summaryrefslogtreecommitdiffstats
path: root/chrome/browser/pdf_unsupported_feature.cc
Commit message (Collapse)AuthorAgeFilesLines
* Define the public interface for content browser RenderProcessHost. This ↵ananta@chromium.org2011-11-181-2/+2
| | | | | | | | | | | | | | | interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes. The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now. Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unnecessary includes of view_messages.h.jam@chromium.org2011-11-171-1/+0
| | | | | | | | BUG=98716 TBR=ananta Review URL: http://codereview.chromium.org/8590033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110522 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking on infobar to install Adobe Reader should open download page in a ↵tfarina@chromium.org2011-11-101-1/+1
| | | | | | | | | | | | new tab. BUG=77953 TEST=see bug R=pkasting@chromium.org Review URL: http://codereview.chromium.org/8510033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109365 0039d316-1c4b-4281-b951-d872f2087c98
* Remove needless include of the content/browser/render_process_host.h header ↵ananta@chromium.org2011-11-041-1/+0
| | | | | | | | | | | file. Part 1 of upcoming changes to move RPH/BRPH to a public interface. BUG=98716 Review URL: http://codereview.chromium.org/8451012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108608 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-131-1/+1
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar handling to a tab helper.avi@chromium.org2011-09-301-14/+12
| | | | | | | | | | | | | | Part 2: - Removed TabContentsWrapper from core infobar classes - Made InfoBarTabHelper the owner of the infobar delegates - Removed all owner references from the delegate subclasses BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7862003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103463 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the PluginService interface to be an async wrapper around PluginList.rsesek@chromium.org2011-09-231-18/+35
| | | | | | | | | | | | | This adds additional methods to PluginService so that most callers can be moved off PluginList and use the new asynchronous interface. This is in preparation for moving plugin probing out-of-process on Mac and Linux. BUG=17863,95114 TEST=none Review URL: http://codereview.chromium.org/7980011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102421 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of synchronous calls to getting plugins to help with ↵jam@chromium.org2011-09-221-7/+1
| | | | | | | | | | | http://codereview.chromium.org/7980011/. The PluginExceptionsTableModel isn't used anymore. Change print preview and using Reader with unsupported PDFs to tell the plugin filter which plugin name they want to use, instead of giving it the plugin directly. This makes the former not need to block on getting the plugins. The later still does, to know if Reader is installed or not, however it's trivial to make PDFHasUnsupportedFeature() get the plugins asynchronously because it's just a dispatcher for an async message. Review URL: http://codereview.chromium.org/7977042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102284 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the sending of the following content IPC messages out of chrome and ↵ananta@chromium.org2011-09-191-2/+1
| | | | | | | | | | | | | | | | | | | | | replaced them with corresponding API's on the RenderWidgetHost object. 1. ViewMsg_Zoom. 2. ViewMsg_ReloadFrame. 3. ViewMsg_Find. 4. ViewMsg_CSSInsertRequest. 5. ViewMsg_DisableScrollbarsForSmallWindows. 6. ViewMsg_EnablePreferredSizeChangedMode. Continuing fixes to ensure that IPC messages don't span across content and chrome. BUG=87335. TEST=no change in functionality. Review URL: http://codereview.chromium.org/7923023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101855 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r101269: Store plug-in enabled/disabled state in PluginPrefs instead ↵bauerb@chromium.org2011-09-151-10/+11
| | | | | | | | | | | | | | | | | of WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile. The relanded version fixes GViewRequestInterceptorTest on ChromeOS and a memory leak in PluginListTest.GetPluginGroup. Original review URL: http://codereview.chromium.org/7848025 TBR=jam@chromium.org BUG=80794 TEST=Open two profiles, disable different plugins in them. Review URL: http://codereview.chromium.org/7904009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101297 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 101269 - Store plug-in enabled/disabled state in PluginPrefs instead ↵bauerb@chromium.org2011-09-151-11/+10
| | | | | | | | | | | | | | of WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile. BUG=80794 TEST=Open two profiles, disable different plugins in them. Review URL: http://codereview.chromium.org/7848025 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/7901015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101272 0039d316-1c4b-4281-b951-d872f2087c98
* Store plug-in enabled/disabled state in PluginPrefs instead of ↵bauerb@chromium.org2011-09-151-10/+11
| | | | | | | | | | | WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile. BUG=80794 TEST=Open two profiles, disable different plugins in them. Review URL: http://codereview.chromium.org/7848025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101269 0039d316-1c4b-4281-b951-d872f2087c98
* Add PluginServiceFilter interface and ChromePluginServiceFilter.bauerb@chromium.org2011-09-021-11/+11
| | | | | | | | | | | This should get rid of all references to webkit::npapi::IsPluginEnabled in content/. BUG=80794 TEST=none Review URL: http://codereview.chromium.org/7387010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99355 0039d316-1c4b-4281-b951-d872f2087c98
* Add an icon for the PDFUnsupportedFeature infobar.rsesek@chromium.org2011-09-021-0/+8
| | | | | | | | | | BUG=94110 TEST=Get a PDF that can't be opened in the built-in reader. Get an infobar. It has an icon. Review URL: http://codereview.chromium.org/7809018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99302 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar handling to a tab helper, part 1.avi@chromium.org2011-09-011-3/+5
| | | | | | | | | | | | | | | | | | Revert revert of r99187. This reverts r99198. BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7810002 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7827017 Review URL: http://codereview.chromium.org/7826014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99187 (speculative revert for ↵thakis@chromium.org2011-09-011-5/+3
| | | | | | | | | | | | | | | | ProfileSyncServiceSessionTest.FailModelAssociation on 10.5) - Move infobar handling to a tab helper, part 1. BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7810002 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7827017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99198 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar handling to a tab helper, part 1.avi@chromium.org2011-09-011-3/+5
| | | | | | | | | BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7810002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99187 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r96364: Rename PluginUpdater to PluginPrefs and make it per-profile.bauerb@chromium.org2011-08-191-5/+5
| | | | | | | | | BUG=80794 TEST=none Review URL: http://codereview.chromium.org/7639017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97452 0039d316-1c4b-4281-b951-d872f2087c98
* Make WebPluginInfo more genericcpu@chromium.org2011-08-141-2/+2
| | | | | | | | | | | | | - To account for pepper plugins, it grows a type field - move WebPluginInfo from webkit::npapi to webkit:: and move the files as well. This will allow us to remove hacks to get pepper plugins to load soon BUG=89248 TEST=none Review URL: http://codereview.chromium.org/7648017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96718 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r96364, it's breaking a NaCl test.mnissler@chromium.org2011-08-111-5/+5
| | | | | | | | | | TEST= BUG= TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/7627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96430 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 96409 - Speculatively revert r96364, it's the best bet on the NaCL ↵mrossetti@chromium.org2011-08-111-5/+5
| | | | | | | | | | | | | | | breakage. TEST= BUG= TBR=bauerb@chromium.org,mnissler@chromium.org Review URL: http://codereview.chromium.org/7627001 TBR=mnissler@chromium.org Review URL: http://codereview.chromium.org/7618013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96411 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively revert r96364, it's the best bet on the NaCL breakage.mnissler@chromium.org2011-08-111-5/+5
| | | | | | | | | | TEST= BUG= TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/7627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96409 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PluginUpdater to PluginPrefs and make it per-profile.bauerb@chromium.org2011-08-111-5/+5
| | | | | | | | | BUG=80794 TEST=none Review URL: http://codereview.chromium.org/7564006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96364 0039d316-1c4b-4281-b951-d872f2087c98
* Update UMA user actions parsing, primarily to include WebUI metrics.isherman@chromium.org2011-08-091-2/+3
| | | | | | | | | | | | | | | * Update extract_actions.py to scan for metrics specified in the WebUI code. A common pattern is <input pref="blah" metric="Options_Blah" type="checkbox">. * Clean up almost all of the existing warnings thrown by extract_actions.py. There is one remaining use of RecordComputedAction that is a bit too subtle for me to lump into this patch. * Add a new warning to extract_actions.py that scans for uses of UserMetricsAction with a non-literal string. Any such uses are going to be missed by the script, and hence should use RecordComputedAction instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7314020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95925 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 3.avi@chromium.org2011-07-281-2/+6
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7522018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94511 0039d316-1c4b-4281-b951-d872f2087c98
* Adobe reader actually becomes default browser when user says so!aayushkumar@chromium.org2011-07-121-1/+4
| | | | | | | | | | | | | BUG=77856 TEST= 1) Ensure that the chrome pdf viewer plugin is enabled and the adobe reader is disabled. 2) Open a pdf that has to be opened in adobe reader (eg. http://www.irs.gov/pub/irs-pdf/p17.pdf) 3) Agree to open this pdf in adobe reader. You will also get an option asking if you want adobe reader as your default reader. Accept. 4) Restart the browser. Ensure that adobe reader plugin is still your default pdf viewer. Review URL: http://codereview.chromium.org/7285024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92153 0039d316-1c4b-4281-b951-d872f2087c98
* Remove functions in RenderViewHost and RenderWidgetHost that just send an ↵jam@chromium.org2011-05-191-1/+3
| | | | | | | | IPC message and are called by one or two places. Have the callers send the message instead. Also remove functions which dispatch an IPC only to call TabContents. Dispatch in TabContents instead. Review URL: http://codereview.chromium.org/7037041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85990 0039d316-1c4b-4281-b951-d872f2087c98
* Move the little infobar code from TabContents to TabContentsWrapper.jam@chromium.org2011-05-181-14/+17
| | | | | | | BUG=76792 Review URL: http://codereview.chromium.org/7010017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85703 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the virtual InfoBarDelegate::InfoBarClosed() function with a ↵pkasting@chromium.org2011-05-051-176/+162
| | | | | | | | | | | | | | | | non-virtual one. This is a step along the way to killing it entirely. This also adds a lot of OVERRIDE markers and does some other cleanup in a few places. The original (stupid) design for the delegate class left subclasses great flexibility in how they mapped infobars to delegates. In practice, no one ever wanted multiple infobars driven off a single delegate, so the mapping was always one-to-one. As a result, it was always correct for InfoBarClosed() to "delete this", but because the base class did not do so, every subclass needed to. Most did; the others leaked memory and failed to run their destructors. This change forces the base class to delete itself. This fixes the delegate leaks in the couple subclasses that failed to do this. It also eliminates a lot of copy-and-pasted "delete this" implementations. Ultimately, we'll be moving to a model where the InfoBar "view" class owns the delegate and deletes it directly, which will eliminate InfoBarClosed() completely. BUG=62154 TEST=none Review URL: http://codereview.chromium.org/6926001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84195 0039d316-1c4b-4281-b951-d872f2087c98
* Adopt InterstitialPage to RenderViewHost message changes which were ↵markusheintz@chromium.org2011-05-031-4/+4
| | | | | | | | | | | | introduced by http://codereview.chromium.org/6883177. This makes the buttons on interstitial pages work again. Committed by sfeuz Review URL: http://codereview.chromium.org/6904159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83880 0039d316-1c4b-4281-b951-d872f2087c98
* Move UserMetrics to content.michaeln@google.com2011-04-271-1/+1
| | | | | | | | | | | | | | Just the class that provides the action logging API which is used all over the place is being moved. The UserMetrics class uses the notification system to inform the core of the user metrics system of each event, that core part is not being moved. Also take care of a TODO to remove the class methods that take a Profile* as a paramter (since Profile is verbotten in /content). BUG=78499 Review URL: http://codereview.chromium.org/6883021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83251 0039d316-1c4b-4281-b951-d872f2087c98
* Move PepperPluginRegistry to content, while leaving the Chrome specific bits ↵jam@chromium.org2011-04-181-2/+2
| | | | | | | | (NaCl, registration of Chrome plugins like pdf/remoting/flash) behind. Review URL: http://codereview.chromium.org/6869051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81959 0039d316-1c4b-4281-b951-d872f2087c98
* Update link we use to install/update Reader.jam@chromium.org2011-03-101-2/+5
| | | | | | Review URL: http://codereview.chromium.org/6621058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77657 0039d316-1c4b-4281-b951-d872f2087c98
* Split infobar_delegate.[cc,h] into separate pieces for the different classes ↵tfarina@chromium.org2011-03-031-1/+1
| | | | | | | | | | | defined within, so that each piece is shorter and clearer. BUG=None TEST=None Review URL: http://codereview.chromium.org/6598057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76677 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temporary headers left behind in chrome\browser. I've left ↵jam@chromium.org2011-03-011-5/+5
| | | | | | | | | browser_thread.h for another change, since 450 files include it. TBR=avi Review URL: http://codereview.chromium.org/6596060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the infobar to ask the user if they want to enable Reader to open ↵jam@chromium.org2011-02-151-3/+0
| | | | | | | | PDFs by default. Review URL: http://codereview.chromium.org/6480088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75021 0039d316-1c4b-4281-b951-d872f2087c98
* Update pdf infobar stringsjam@chromium.org2011-02-151-2/+2
| | | | | | Review URL: http://codereview.chromium.org/6523007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75011 0039d316-1c4b-4281-b951-d872f2087c98
* Really don't show the set Adobe Reader by default infobar. Also don't show ↵jam@chromium.org2011-02-091-12/+31
| | | | | | | | it again if the user clicks No. Review URL: http://codereview.chromium.org/6476001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74346 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the use-reader-by-default infobar for now.jam@chromium.org2011-01-271-0/+5
| | | | | | Review URL: http://codereview.chromium.org/6397010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72854 0039d316-1c4b-4281-b951-d872f2087c98
* Reverse the Yes and No buttons for the PDF infobars.jam@chromium.org2011-01-271-44/+62
| | | | | | Review URL: http://codereview.chromium.org/6320018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72767 0039d316-1c4b-4281-b951-d872f2087c98
* If a user chooses to open a PDF with Reader, ask them if they want to do so ↵jam@chromium.org2011-01-271-26/+144
| | | | | | | | always. Review URL: http://codereview.chromium.org/6278017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72735 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break from previous change (files moved in between try bot run and ↵jam@chromium.org2011-01-221-2/+2
| | | | | | | | commit). Review URL: http://codereview.chromium.org/6379003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72241 0039d316-1c4b-4281-b951-d872f2087c98
* When we detect a PDF with an unsupported feature, ask the user if they want ↵jam@chromium.org2011-01-221-0/+231
to view it with Adobe Reader if it's installed. If it's not, ask them if they want to launch the url to install it. If it's installed and out of date, show an interstitial. BUG=65339 Review URL: http://codereview.chromium.org/6259008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72240 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-26 21:23:20 +0000