| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OpenItem and ShowItemInFolder must now be called from the UI thread only - add
a comment to this effect in the header.
Dispatch the implementations to the FILE thread on chromeos/win/linux.
Fix usage of OpenItem/ShowItemInFolder in DownloadsDomHandler and
ChromeContentBrowserClient.
Rename ShowFullTabUrl to ViewFolder and get rid of unused Profile* arg.
Use anonymous namespace for functions in file_manager_util.cc and platform_util_chromeos.cc
Replace NewRunnableFunction with Bind.
Add additional threading DCHECKs.
Fix lint errors.
BUG=chromium-os:21585
TEST=go to downloads page (ctrl-j), click on Open Downloads Folder.
Review URL: http://codereview.chromium.org/8457004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7601014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the CanSetAsDefaultBrowser / ProtocolClient functions next to the
routines which do the setting of Chrome to be the default browser and
client.
BUG=88196
TEST=Manual testing performed
Review URL: http://codereview.chromium.org/7334003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_version_info_*
BUG=37186
TEST=No behavior change. Manually confirm that build succeeds on Linux, Mac and Windows if we comment out '#if defined(GOOGLE_CHROME_BUILD)' in chrome_version_info_*.
Review URL: http://codereview.chromium.org/7249003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac/win.
Note this is unused currently, but will be hooked up to
navigator.registerProtocolHandler in a subsequent change.
BUG=83556
TEST=Manual
Review URL: http://codereview.chromium.org/6961013
Patch from Ben Wells <benwells@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about the channel name to use the new platform_util::GetInstallationChannel.
GetVersionStringModifier should only be used for display purposes. Use
GetInstallationChannel to determine the channel name for comparisons.
Fix the upgrade detector to treat the canary channel the same way that it
treats the dev channel, using a shorter notification interval.
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6899034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes some light refactoring to give all platforms a
platform_util::CanSetAsDefaultBrowser() function. The .xib change links the
set-as-default button with the new IBOutlet.
BUG=79814
TEST=Canary.app should never offer to set as the default browser in the
first run dialog or in an infobar.
Review URL: http://codereview.chromium.org/6881058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This way Linux and Windows can share.
BUG=58937
TEST=manual
Review URL: http://codereview.chromium.org/4157004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear. 95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.
We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.
Review URL: http://codereview.chromium.org/3135028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recommitting of r46101.
BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. A confirmation
dialog box should be shown. No other visible change.
Review URL: http://codereview.chromium.org/1745024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the user
chooses to sync, but the window is already open and obscured by another window. For now
this only works on Mac due to how browser dialogs are handled on different platforms.
BUG=30649
TEST=Choose to 'Sync' when the sync window is already open behind a browser window.
Review URL: http://codereview.chromium.org/2121017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This time around i've tested it on the mac with a full build. Fixed string16 issues.
Review URL: http://codereview.chromium.org/2133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stable or dev. Initially just use the same url twice.
Review URL: http://codereview.chromium.org/2013017
TBR=chron@chromium.org
Review URL: http://codereview.chromium.org/2074001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Initially just use the same url twice.
Review URL: http://codereview.chromium.org/2013017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark alert.
BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. An confirmation
dialog box should be shown. No other visible change.
Review URL: http://codereview.chromium.org/1687017
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/1783014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. An confirmation
dialog box should be shown. No other visible change.
Review URL: http://codereview.chromium.org/1687017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1705009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
|