| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins@chromium.org
BUG=124396
Review URL: https://chromiumcodereview.appspot.com/10933044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
everytime we update Chrome.
The previous code doesn't migrate settings for those internal plugins that live in a subdirectory of chrome::DIR_INTERNAL_PLUGINS.
Pepper Flash lives in <DIR_INTERNAL_PLUGINS>\PepperFlash, so we break Pepper Flash settings with every update.
BUG=150596
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10942018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=PluginPrefsTest.UnifiedPepperFlashState
Review URL: https://chromiumcodereview.appspot.com/10928006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also takes care of turning on bundled Pepper Flash, if NPAPI Flash is enabled while Pepper Flash is disabled.
BUG=146869
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10911137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
methods doesn't rely on PluginGroup class instead use PluginList's method versions that directly use WebPluginInfo.
CL in the series to delete PluginGroup and move hardcoded plugin group definitions to metadata files.
BUG=124396
Review URL: https://chromiumcodereview.appspot.com/10872034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make PluginPrefsTest work with background threads, PluginPrefs::EnablePlugin and PluginPrefs::EnablePluginGlobally need a callback, so we need to update their callers as well.
BUG=120902
TEST=none
Review URL: http://codereview.chromium.org/9977008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous attempts to share code between ProfileKeyedServiceFactory and RefcountedProfileKeyedServiceFactory were ill advised. The core logic code must maintain refcounted data in a scoped_refptr<> for the entire lifecycle, across interface and implementation, preventing any real abstraction here.
This removes the common ProfileKeyedBase and splits the two worlds entirely in two. This has quite a bit of exact code with different types now.
Fallout from this is far reaching:
- Since there isn't one common heiarchy, now the testing methods either return ProfileKeyedServices or scoped_refptr<RefcountedProfileKeyedService>s. This is a lot of change.
- Many consumers handled the refcounted ptrs as raw pointers, which probably isn't a good idea.
- There is now a bunch of code duplication.
BUG=118196,77155
R=mirandac,tim
TBR=jhawkins,sky,scottbyer
Review URL: http://codereview.chromium.org/9703038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9595007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9572036
TBR=tedvessenes@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9597005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9572036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=77155
TEST=compiles
Review URL: http://codereview.chromium.org/9363040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part that deals with memory storage.
This patch rips apart the dependency tracking parts of ProfileKeyedServiceFactory into a base class. Derived classes from ProfileKeyedBaseFactory now exist to deal with memory management and lifecycle events. ProfileKeyedBase is the most generic thing that can be tracked (it is simply a virtual destructor).
For example, I've created RefcountedKeyedServiceFactory, which derives from ProfileKeyedBaseFactory. Everything tracked via that Factory must be a RefcountedProfileKeyedService. The storage layer uses scoped_refptr<>s in a map instead of normal pointers. This patch converts CookieSettings over (I'm ignoring the rest that could be ported due to how large the patch would be).
Other than some minor changes to the testing interface, this doesn't change ProfileKeyedServiceFactory usage.
BUG=77155
R=mirandac, jochen, sky, jhawkins
TBR=tim
Review URL: http://codereview.chromium.org/9360008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=101628
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9212053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/9166031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/9006036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103788,chromium-os:22447
TEST=unit_tests --gtest_filter=PluginPrefs*
Review URL: http://codereview.chromium.org/8515021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify code in chrome to call wrapper functions on PluginService
TBR=rsesek@chromium.org, jam@chromium.org
BUG=90442
TEST=browser_tests PluginServiceTest.* pass on the Mac
Review URL: http://codereview.chromium.org/8493026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on PluginService"
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8475020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than calling into webkit::npapi::PluginList directly.
This change is necessary to ensure we only have one list when we switch
content to the component build.
R=jam@chromium.org
TBR=cpu@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8440058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=owners
BUG=98716
Review URL: http://codereview.chromium.org/8437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.
A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.
Also moved BrowserProcessSubThread into content/ namespace. As part
of follow-up cleanup, chrome/ will stop using this class.
BUG=98716
TEST=existing
Review URL: http://codereview.chromium.org/8392042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser.
BUG=98716
Review URL: http://codereview.chromium.org/8342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves all browser-side synchronous callers to use the asynchronous
PluginService interface.
BUG=17863,95114
TEST=Covered by tests. Plugins still work.
Review URL: http://codereview.chromium.org/8071013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, unify the behavior when we detect that plug-ins on disk have changed. We should purge the caches in that case, but not force a page reload.
BUG=99459
TEST=
Review URL: http://codereview.chromium.org/8231007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefernces.
To allow us to compile individual features in/out of a chrome build, we need to
attack browser_prefs.cc, which is a giant static registration. This used to be
done through another big code path starting in ProfileImpl which call
browser::RegisterUserPrefs() which linked to other static methods. Now this is
done through overridding ProfileKeyedServiceFactory::RegisterUserPrefs(), and
there are no additional dependencies.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104412
Review URL: http://codereview.chromium.org/7901027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specify its user prefernces.
I believe this broke chromeos with:
/usr/bin/ld: out/Release/obj.target/unit_tests/chrome/browser/chromeos/gview_request_interceptor_unittest.o: in function chromeos::(anonymous namespace)::GViewRequestInterceptorTest::SetUp():gview_request_interceptor_unittest.cc(.text._ZN8chromeos12_GLOBAL__N_127GViewRequestInterceptorTest5SetUpEv+0xd8): error: undefined reference to 'PluginPrefs::RegisterPrefs(PrefService*)'
To allow us to compile individual features in/out of a chrome build, we need to
attack browser_prefs.cc, which is a giant static registration. This used to be
done through another big code path starting in ProfileImpl which call
browser::RegisterUserPrefs() which linked to other static methods. Now this is
done through overridding ProfileKeyedServiceFactory::RegisterUserPrefs(), and
there are no additional dependencies.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7901027
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/8196005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefernces.
To allow us to compile individual features in/out of a chrome build, we need to
attack browser_prefs.cc, which is a giant static registration. This used to be
done through another big code path starting in ProfileImpl which call
browser::RegisterUserPrefs() which linked to other static methods. Now this is
done through overridding ProfileKeyedServiceFactory::RegisterUserPrefs(), and
there are no additional dependencies.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7901027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=35223
TEST=none
Review URL: http://codereview.chromium.org/8066004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97179
TEST=chrome/test/functional/enterprise.py
Review URL: http://codereview.chromium.org/7976005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile.
The relanded version fixes GViewRequestInterceptorTest on ChromeOS and a memory leak in PluginListTest.GetPluginGroup.
Original review URL: http://codereview.chromium.org/7848025
TBR=jam@chromium.org
BUG=80794
TEST=Open two profiles, disable different plugins in them.
Review URL: http://codereview.chromium.org/7904009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile.
BUG=80794
TEST=Open two profiles, disable different plugins in them.
Review URL: http://codereview.chromium.org/7848025
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/7901015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile.
BUG=80794
TEST=Open two profiles, disable different plugins in them.
Review URL: http://codereview.chromium.org/7848025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80757
TEST=see bug
Review URL: http://codereview.chromium.org/7839032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=23
CID=100941,100986,100987,101015,101016,101017,101227,101229,101230,101332,101333,101334,101335,101336,101337,101355,101356,101359,101362,101363,101381,101389,101417
BUG=none
TEST=none
R=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7780013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GViewRequestInterceptor.
BUG=80794
TEST=GViewRequestInterceptorTest.*
Review URL: http://codereview.chromium.org/7541076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should get rid of all references to webkit::npapi::IsPluginEnabled in content/.
BUG=80794
TEST=none
Review URL: http://codereview.chromium.org/7387010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on-by-default.
This is a mirror change of http://codereview.chromium.org/7720021/ for trunk (some files have changed so it was necessary to check into the branch and trunk separately instead of merging)
BUG=93984
TEST=manual
Review URL: http://codereview.chromium.org/7693030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80794
TEST=none
Review URL: http://codereview.chromium.org/7639017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=
BUG=
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/7627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
breakage.
TEST=
BUG=
TBR=bauerb@chromium.org,mnissler@chromium.org
Review URL: http://codereview.chromium.org/7627001
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/7618013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=
BUG=
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/7627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=80794
TEST=none
Review URL: http://codereview.chromium.org/7564006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96364 0039d316-1c4b-4281-b951-d872f2087c98
|