| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:29917
TEST=Configure pinned apps device policy in retail mode, check that launcher shows configured apps (those need to be installed!).
Review URL: https://chromiumcodereview.appspot.com/10384036
TBR=mnissler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10398007
git-svn-id: svn://svn.chromium.org/chrome/branches/1132/src@136846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher.
This declares the policy so the policy subsystem can enforce it and
shows it in about:policy.
BUG=chromium-os:29917
TEST=Configure pinned apps, log in as a managed user, observe that the launcher shows the pinned apps as configured.
Review URL: https://chromiumcodereview.appspot.com/10316022
TBR=mnissler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382147
git-svn-id: svn://svn.chromium.org/chrome/branches/1132/src@136845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements device location reporting for Enterprise-enrolled Chrome OS devices. The position is determined using the existing Chrome geolocation stack.
This CL depends on https://chromiumcodereview.appspot.com/10344016/
ISSUE=chromium-os:18710
TEST=unit_tests including new DeviceStatusCollectorTest.Location
Review URL: http://codereview.chromium.org/10103029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enterprise admins need some form of control to reduce the spikes in bandwidth consumption when a new Chrome Device update is made available. This CL introduces a new policy to randomly distribute those downloads over a configured amount of time to reduce the spikes.
BUG=chromeos-29615: Implement scattering of downloads in UpdateEngine
TEST=update_engine works fine with new policy code.
Review URL: http://codereview.chromium.org/10281005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open chrome://policy with "RestoreOnStartup" policy set to 0
Review URL: http://codereview.chromium.org/10265016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles and passes tests, no observable changes
R=pastarmovj@chromium.org, binzhao@google.com, wan@google.com
Review URL: http://codereview.chromium.org/10306008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:policy webui to read policy from the PolicyService instead.
Also displays unknown policies that were found in about:policy, to help identify typos in configurations.
BUG=108993,100032
TEST=All works as before; about:policy also shows invalid policy names
Review URL: http://codereview.chromium.org/10161029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed users of BrowserPolicyConnector::RefreshPolicies to use the new interface.
BUG=108999
TEST=unit_tests green, pyauto tests green, all works as before
Review URL: http://codereview.chromium.org/10236003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=103867
R=mnissler@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10192002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10068036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=124374
TEST=PolicyServiceTest.* in unit_tests are green
Review URL: http://codereview.chromium.org/10191005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=124027
TEST=pyauto:policy.PolicyTest.testStartupOptionsHomepage
Review URL: http://codereview.chromium.org/10035043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ReplaceSearchTerms() a bit less verbose, and will be useful later when UIThreadSearchTermsData starts taking a Profile*.
One downside is that there are a number of const_cast<>()s added when we try to access the profile() of a const TemplateURL*. These will all go away soon when TemplateURLService is switched to using "const" much less, so I didn't worry too much about them.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10173001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=124374
TEST=PolicyServiceTest.NotifyObservers is green
Review URL: http://codereview.chromium.org/10174003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, we might trigger additional notifications inadvertently.
BUG=chromium-os:29245
TEST=See bug.
Review URL: http://codereview.chromium.org/10137001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should already have been true in non-test code: the keyword editor, the importer, the extension system, and the search engine autodetection code all tried to ensure that the URLs are non-empty. However, because we've seen problems occur, this change tries to sanitize the pref, database, and sync inputs to expunge any bogus entries.
We also fix tests, add some more DCHECKs to make this assertion clearer in some of the TemplateURL-adding paths, and then remove conditionals that checked for empty URLs.
This also cleans up a silly design where TemplateURLService listened for changes to the default search provider prefs -- meaning that anyone who tried to write them wound up calling back to the observer as every single pref was written. This led to reading back bad state. Eliminating this ought to allow for some other cleanups in TemplateURLService, but I haven't tried to make them here.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10014033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=On KIOSK Chrome OS device, check that device-level proxy is mandatory.
Review URL: http://codereview.chromium.org/10097007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/10094010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:15189
TEST=unit tests
Review URL: http://codereview.chromium.org/7233006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boolean flag.
This is just prep work for a large CL that rewrites the JSON parser. Splitting
out this interface change will make it easier to review the other CL.
BUG=121469
TEST=No functional change.
Review URL: https://chromiumcodereview.appspot.com/9960077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURLData. This allows us to eliminate the TemplateURL NULL constructor, most public non-const TemplateURL functions, and most TemplateURL friend declarations.
This is also a necessary precursor to changing TemplateURLService's APIs to convert most "const TemplateURL*" cases to "TemplateURL*", which I'll explain once I actually make the change.
There is some awkwardness here around keywords, as keyword autogeneration requires a TemplateURL but the state bits are kept on TemplateURLData. This will go away in the future when I remove keyword autogeneration from TemplateURL entirely.
This differs from r131019 in that it fixes a memory error in chrome/browser/search_engines/util.cc:MergeEnginesFromPrepopulateData() where when we updated the vector to contain a new TemplateURL*, we didn't also update |default_search_engine| to point at the new URL if necessary.
BUG=none
TEST=none
TBR=sky,mnissler,atwilson
Review URL: https://chromiumcodereview.appspot.com/10021008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move most TemplateURL data members to a new struct, TemplateURLData. This allows us to eliminate the TemplateURL NULL constructor, most public non-const TemplateURL functions, and most TemplateURL friend declarations.
This is also a necessary precursor to changing TemplateURLService's APIs to convert most "const TemplateURL*" cases to "TemplateURL*", which I'll explain once I actually make the change.
There is some awkwardness here around keywords, as keyword autogeneration requires a TemplateURL but the state bits are kept on TemplateURLData. This will go away in the future when I remove keyword autogeneration from TemplateURL entirely.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9982018
TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9949059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have "protected"
virtual destructors, not "public".
By having a public destructor, it becomes possible to stack
allocate the derived class. Stack allocating a RCTS is a
dangerous behaviour, since there may still be a caller who
holds a reference when the object goes out of scope.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9958145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move files in chrome/browser/chromeos/dbus/ to chromeos/dbus
Add chromeos/dbus/DEPS
Add chromeos.gyp:chromeos_test_support and chromeos.gyp:chromeos_unittests
Add CHROMEOS_EXPORT to classes
Move power related proto targets to chromeos.gyp
Rewrite and sort #includes
BUG=119583
TEST=component chromeos build success, checkdeps success
Review URL: https://chromiumcodereview.appspot.com/9838085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allows us to eliminate the TemplateURL NULL constructor, most public non-const TemplateURL functions, and most TemplateURL friend declarations.
This is also a necessary precursor to changing TemplateURLService's APIs to convert most "const TemplateURL*" cases to "TemplateURL*", which I'll explain once I actually make the change.
There is some awkwardness here around keywords, as keyword autogeneration requires a TemplateURL but the state bits are kept on TemplateURLData. This will go away in the future when I remove keyword autogeneration from TemplateURL entirely.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9982018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None, comment-only change.
R=pastarmovj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9965103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The policy fetch was racing against the installation-time attributes
write. Enrollment would fail if the policy fetch won the race. This
change explicitly prevents policy fetches until the device policy
machinery is ready to accept them.
BUG=chromium:28248
TEST=Hard. Enroll devices a lot, preferably with a slow TPM and against a fast server. Enrollment shouldn't fail.
Review URL: https://chromiumcodereview.appspot.com/9982005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
start up.
The KioskModeSettings class will observe the device mode and make sure to
restart the session if the mode changes from UNKNOWN to KIOSK.
BUG=chromium-os:28586
TEST=Enroll in kiosk mode and reboot. Even if the device goes into normal mode first it should restart and change to kiosk almost immediately.
Review URL: https://chromiumcodereview.appspot.com/9982002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURL. This will make it easier to move the data members of TemplateURL into a new class later.
This changes the accessors for TemplateURL's TemplateURLRefs. There are now separate accessors for the URLs as strings and as TemplateURLRefs, and the latter have changed to returning a const ref, meaning they no longer return NULL when the corresponding URL string is empty. This makes a number of callers clearer.
This differs from r130431 only by including changes to fix the compile on official builds, which enable some #ifdefs that guarded additional points that needed migrating.
BUG=none
TEST=none
TBR=sky,mnissler,atwilson
Review URL: https://chromiumcodereview.appspot.com/9960016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURL. This will make it easier to move the data members of TemplateURL into a new class later.
This changes the accessors for TemplateURL's TemplateURLRefs. There are now separate accessors for the URLs as strings and as TemplateURLRefs, and the latter have changed to returning a const ref, meaning they no longer return NULL when the corresponding URL string is empty. This makes a number of callers clearer.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9968016
TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9965143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will make it easier to move the data members of TemplateURL into a new class later.
This changes the accessors for TemplateURL's TemplateURLRefs. There are now separate accessors for the URLs as strings and as TemplateURLRefs, and the latter have changed to returning a const ref, meaning they no longer return NULL when the corresponding URL string is empty. This makes a number of callers clearer.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9968016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only call SetFetchingDone() (which fires observers) once the policy
store/reload cycle completes.
BUG=chromium-os:28804
TEST=Change device policy configuration. Hit reload on chrome://policy. Make sure the first reload results in the page being updated.
Review URL: http://codereview.chromium.org/9963063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=117407
Review URL: http://codereview.chromium.org/9963067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108999
TEST=All unit_tests still pass, policy works as before
Review URL: http://codereview.chromium.org/9375014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mnissler@chromium.org
BUG=None
TEST=chromeos memory bots go green
Review URL: http://codereview.chromium.org/9950047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stays initialized.
Also added device policy command line flags to InProcessBrowserTest, so that browser_tests run with this provider on ChromeOS.
BUG=120967
TEST=Everything works as before
Review URL: http://codereview.chromium.org/9911029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
local_state.
BUG=108999
TEST=Everything works as before
Review URL: http://codereview.chromium.org/9918028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
device_policy_cache.
BUG=chromium-os:18710
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9968013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This in turn allows us to avoid passing in TemplateURLs to a few other APIs, and will be critical later when adding Profile*s and keeping URL strings on the owner.
This also moves some definitions in template_url.cc around to match declaration order, and makes the TemplateURL::SupportsReplacement() family of functions non-static.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9930002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:28700
TEST=Setup Kiosk Mode with an AppPack. Remove some bytes from a file in /var/cache/app_pack before starting the demo. After a restart, that extension will be restored.
Review URL: http://codereview.chromium.org/9911026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actually meaningfully set by the browser:
* TemplateURLRef: |index_offset_|, |page_offset_|
* TemplateURL: |description_|, |languages_|
Also remove TemplateURL::ImageRef and the |image_refs_| field and replace with a simple GURL |favicon_url_|. We only used the vector inside the parser, and we ended up only caring about a single favicon-sized, appropriately-typed image, so just move those conditions into the parser and simplify everyone else.
Finally, convert a number of pass-or-return-by-value functions in template_url_h to use const refs.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9917001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102833, 102995
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9860044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure that we only start device policy fetches once device
settings are available in order to ensure the first device policy fetch
uploads the configured reporting bits.
BUG=chromium-os:26251
TEST=Manual.
Review URL: https://chromiumcodereview.appspot.com/9857011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do this when writing to install attributes and on checking policy responses. This fixes the issue with enrollment failing for mixed-case users.
BUG=chromium-os:28232
TEST=See bug.
Review URL: http://codereview.chromium.org/9854017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
include chromeos-specific headers on other platforms.
This was causing problems for my try jobs.
TBR=mnissler@chromium.org
BUG=none
TEST=ran trybots
Review URL: http://codereview.chromium.org/9808105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:28062
TEST=Send more bits with --enterprise-enrollment-initial-modulus than the server expects. AE still succeeds.
Review URL: http://codereview.chromium.org/9835021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppPack cache.
BUG=chromium-os:25463
TEST=The screensaver in retail mode works after a reboot
Review URL: http://codereview.chromium.org/9835011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=mnissler@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9814011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add preferences kDisableGData, kDisableGDataOverCellular, kDisableGDataHostedFiles, and register/handle these.
* CommandLinePrefStore is used to set kDisableGData preference based on switch.
* Add GDataDisabled and GDataDisabledOverCellular to policy template, add to simple pref-policy handler list.
* Cros specific tests for new gdata policies.
BUG=chromium-os:27168
TEST=--disable-gdata works as expected. GDataDisabled in /etc/chromium/policies/managed/test_policy.json works as expected.
Review URL: https://chromiumcodereview.appspot.com/9719008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Infer keyword from the hostname if not specified. Force it to never be empty in any case. This will be needed by an upcoming change that makes TemplateURL keywords non-optional.
* Shorten code and comments.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9768009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127999 0039d316-1c4b-4281-b951-d872f2087c98
|