| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
R=grt@chromium.org
Review URL: https://codereview.chromium.org/122383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the code applying the AllowDataRoaming settings from DeviceSettings to the NetworkConfigurationUpdater which is responsible to apply all other device wide network policies.
- As additional code is required in the updater (listen for device setting changes), this also adds the so far missing (because not strictly required) DeviceNetworkConfigurationUpdater.
- For unit tests of the updater, a interface and implementation of the NetworkDeviceHandler had to be separated.
- The actual application of the AllowDataRoaming setting is now handled in chromeos/network/ .
BUG=323537
Review URL: https://codereview.chromium.org/101593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/106543008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/104493005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland 241611. Reverting it didn't help.
> Revert 241611 "Changing all Get*UserProfileOrOffTheRecord() to G..."
>
> Speculative. This bot has been red continuously since this build:
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10024
>
> ...and this is a CL that looks somewhat related to DeviceLocalAccountTest.
>
> > Changing all Get*UserProfileOrOffTheRecord() to Get*UserProfile() calls
> >
> > BUG=322682
> > TEST=covered by existing unit tests
> >
> > Review URL: https://codereview.chromium.org/108653010
>
> TBR=skuhne@chromium.org
>
> Review URL: https://codereview.chromium.org/120493003
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/120613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative. This bot has been red continuously since this build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10024
...and this is a CL that looks somewhat related to DeviceLocalAccountTest.
> Changing all Get*UserProfileOrOffTheRecord() to Get*UserProfile() calls
>
> BUG=322682
> TEST=covered by existing unit tests
>
> Review URL: https://codereview.chromium.org/108653010
TBR=skuhne@chromium.org
Review URL: https://codereview.chromium.org/120493003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new enum value to Policy.AssociationState, indicating that
the server side dropped the client from management. The association
state is now also surfaced in the Status line in about:policy.
BUG=chromium:329834
Review URL: https://codereview.chromium.org/117253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=322682
TEST=covered by existing unit tests
Review URL: https://codereview.chromium.org/108653010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This enables building that class on the iOS build.
BUG=271392
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/102973005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::WorkerPool isn't flushed in tests, and some of the blacklist tests
post a background task that owns allocated memory. This task never gets flushed
and leak the memory.
This fix uses PostTaskAndReplyWithResult using a scoped_ptr to pass the data
across the threads instead.
BUG=271392
R=pastarmovj@chromium.org
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/106093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class will be moved into the policy component so that it can be reused
on iOS. This change removes direct dependencies on chrome/ and content/ code
so that it can be subsequently moved into the component.
BUG=271392
Review URL: https://codereview.chromium.org/110643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move extension_set.h/cc and extension_set_unittest to extensions/common/.
Remove unused includes.
Add includes where transitive includes were used.
Update DEPS.
No functional changes.
BUG=162530
TBR=sky@chromium.org (c/b/autocomplete, c/b/ui, c/test)
TBR=jam@chromium.org (c/b/automation)
TBR=atwilson@chromium.org (c/b/background, c/b/sync, c/b/policy)
TBR=bauerb@chromium.org (c/b/browsing_data, c/b/content_settings, c/b/managed_mode)
TBR=satorux@chromium.org (c/b/chromeos)
TBR=yurys@chromium.org (c/b/devtools)
TBR=thestig@chromium.org (c/b/media_galleries)
TBR=stevenjb@chromium.org (c/b/notifications)
TBR=battre@chromium.org (c/b/profile_resetter)
TBR=dmazzoni@chromium.org (c/b/speech)
TBR=kinuko@chromium.org (c/b/sync_file_system)
TBR=pkotwicz@chromium.org (c/b/themes)
Review URL: https://codereview.chromium.org/102103005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows having newlines in strings in the JSON configuration file,
making it much easier to embed ONC configuration blobs.
BUG=None
Review URL: https://codereview.chromium.org/116203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- policy_transformations.cc is not needed anymore, since PolicyServiceImpl
can now refer to the generated policies by name.
- moved generate_policy_source_unittest.cc into the component.
- removed stale .gitignore entries.
BUG=271392
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/113813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This move enables using the files derived from policy_templates.json in iOS
builds. List of changes:
- cloud_policy_codegen.gyp and policy_templates.gypi have been merged into
components/policy.gypi
- policy_templates.json moved into components/policy/resources/
- policy_templates.grd and *.xtb files moved into components/policy/resources/
- syntax_check_policy_templates_json.py and
chrome/tools/build/generate_policy_source.py moved into
components/policy/tools
BUG=271392
R=jochen@chromium.org, pastarmovj@chromium.org
Review URL: https://codereview.chromium.org/108513011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows using that code in builds that don't include extensions without
having to introduce layering exceptions. This is meant for inclusion on the
iOS build.
BUG=271392
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/113903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=326799
TBR=jochen
Review URL: https://codereview.chromium.org/109993007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove use of GetDefaultProfileXXX in
- c/b/ui/ash/chrome_shell_delegate*
- c/b/ui/ash/keyboard_controller_proxy.cc
- c/b/ui/ash/screenshot_taker.cc
BUG=322682
Review URL: https://codereview.chromium.org/112153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable using those classes on the iOS build.
BUG=271392
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/105573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files were moved and the header was automatically updated to remove the
"(c)". However, this will make the presubmit scripts fail if a proto is updated.
BUG=271392
R=mnissler@chromium.org
Review URL: https://codereview.chromium.org/112893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/112943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moved chrome/browser/policy/proto/chromeos to
chrome/browser/chromeos/policy/proto, and chrome/browser/policy/proto/cloud to
components/policy/proto.
This enables the component code to use the cloud policy protobufs, so that iOS
can use cloud policy.
The old location is still kept temporarily until new git mirrors are set up
pointing to the new locations. A couple of PRESUBMIT scripts check that the
files are kept in sync.
BUG=271392, 327345
TBR=mnissler@chromium.org
Review URL: https://codereview.chromium.org/108563005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PolicyHeaderService now generates a json-style header to send up with web requests sent to DMServer containing information about the current policy state. This allows DMServer to return policy information via SAML assertions to authorized service providers.
BUG=326799
TBR=jochen
Review URL: https://codereview.chromium.org/99433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
10% of the time on trybots.
BUG=327520
TBR=pastarmovj@chromium.org
Review URL: https://codereview.chromium.org/111893009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There will no such thing as blacklisting just FCM in the future, so
first we will change these configurations to disable everything (so
they'll be like WinXP should be).
Fix up a number of tests that don't work when there is no GPU
process. It's not clear how these tests work on WinXP, so add a
temporary log statement in one of these tests so we can figure
out why they are passing on WinXP (they do not pass locally when
the GPU is blacklisted).
BUG=286038
Review URL: https://codereview.chromium.org/107093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables using that class on iOS without having to resort to DEPS
exceptions. An internal wrapper BCKS is used to forward BCKS-related calls to
the UserCloudPolicyManager on builds that use BCKS.
BUG=271392
Review URL: https://codereview.chromium.org/106173004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed a proto message and fields that were using during TT phase and
aren't used anymore.
BUG=None
Review URL: https://codereview.chromium.org/111503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this cannot happen in practice. Fix the comment.
The implementation of Base64Encode() attempts to check for the return value
MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
value. Remove the check.
Remove unneeded integer cast.
Change the return type to void.
BUG=323357
TEST=base_unittests, compile all
TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
Review URL: https://codereview.chromium.org/86913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code moved to component/policy can be included on iOS, but can't depend
on chrome/. This move includes an exception for the policy protobufs:
- the generic cloud policy protobufs will be moved into a new repository,
due to a dependency from a ChromeOS package
- the user cloud policy protobuf and its decoding will move into a new component
for user policy
BUG=271392
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/109743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL wires up the UserAvatarImage cloud policy so that UserManager
honors it by fetching and applying a policy-set image. The UI is also
made aware of the policy, closing the image picker shown after first
login when the policy is set and preventing the user from changing the
image via chrome://settings
BUG=152957,152959
TEST=Full browser test coverage
Review URL: https://codereview.chromium.org/99373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a empty MutableProfileOAuth2TokenService class. Future CLs
will move desktop specific logic that allow the users of PO2TS to update
the refresh tokens from OAuth2TokenService and ProfileOAUth2TokenService
to MutableProfileOAuth2TokenService.
TEST=NONE (no user visible change)
BUG=320625
Review URL: https://codereview.chromium.org/102313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
More policy componentization...
BUG=271392
Review URL: https://codereview.chromium.org/108333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the Chrome-specific LaunchContainer enum out of
extensions/common/constants.h and into
chrome/common/extensions/extension_constants.h (it can't
live under chrome/browser/extensions since it's used by
AppLaunchInfo). For consistency, also move the LaunchType
enum to extension_constants.h.
Rename LaunchContainer's values from LAUNCH_* to
LAUNCH_CONTAINER_*, and also rename the LAUNCH_TYPE_* values
in AppContextMenu to USE_LAUNCH_TYPE_* to avoid confusion
with the LaunchType enum.
BUG=180083
TBR=sky@chromium.org,jar@chromium.org
Review URL: https://codereview.chromium.org/106713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flag will be flipped back once the server is ready. For now it'll be
disabled on cloud policy. Note that policy for extensions is still loaded from
the platform policy providers.
BUG=108992
Review URL: https://codereview.chromium.org/107063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the ownership model of infobars so that InfoBars are long-lived and
own their InfoBarDelegates directly. The InfoBarService pseudo-owns the
InfoBars (instead of deleting them directly, it tells them when they're unowned
and expects them to delete themselves).
This fixes leaks when infobars are closed while not visible (e.g. in a
background tab) and in general makes the system clearer and easier to reason
about.
BUG=62154
TEST=none
TBR=sky
Review URL: https://codereview.chromium.org/103993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Facilitates policy componentization. Also add DEPS exceptions for ui
and grit includes.
BUG=271392
TBR=sky
Review URL: https://codereview.chromium.org/103263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL speeds up the PolicyPrefIndicatorTest test by an order of
magnitude by executing the test cases in chunks of 50 each.
It would be possible to execute all test cases in one go. However, this
takes 17 seconds on a fast Linux machine. On some of the slower bots, it
may exceed the 30 second timeout. Breaking the test cases into chunks
reduces the maximum run time per chunk to 11 seconds on said Linux
machine. If the tests still end up flaking, the chunk size can easily be
adjusted.
With the chosen chunk size, the change in wall clock time needed by the
tests is:
Release: 7:54 minutes -> 14 seconds
Debug: 13:11 minutes -> 42 seconds
BUG=325205
TEST=Updated browser test
Review URL: https://codereview.chromium.org/102333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of https://codereview.chromium.org/78603003/
BUG=271392
R=joaodasilva,jochen
Review URL: https://codereview.chromium.org/104373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add NetworkStateInformer and ErrorScreenActor to
AppLaunchSplashScreenHandler;
- AppLaunchSplashScreenHandler sends network state
to its delegate (AppLaunchController) during network
check;
- AppLaunchController decides when to show network
configure UI and call AppLaunchSplashScreenActor
to show it (via ErrorScreenActor);
- Show network config UI for enterprise kiosk;
- Add a 'Reboot' button for kiosk network error;
- Add a PromptForNetworkWhenOffline boolean field to
DeviceLocalAccountsProto to control whether to show
network config UI for enterprise managed kiosk;
BUG=314710
TEST=KioskTest.LaunchAppNetworkDown/Portal
Review URL: https://codereview.chromium.org/79113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves DevicePathToDriveLetterPath, NormalizeToNativeFilePath, IsLink, and GetFileInfo.
This also removes some explicit "base::" usage in base files I touched.
TBR=jam
Review URL: https://codereview.chromium.org/105293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://codereview.chromium.org/92263002/
BUG=271392
Review URL: https://codereview.chromium.org/92133003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL speeds up the PolicyToPrefsMapping test by an order of magnitude
by executing all test cases in one go, instead of instantiating one test
per pref. The resulting single test is still fast enough that it should
happily pass even on slow bots.
On my Linux machine, the change in wall clock time needed by the tests is:
Release: 7:34 minutes -> 3 seconds
Debug: 11:02 minutes -> 7 seconds
BUG=325205
TEST=Updated browser test
Review URL: https://codereview.chromium.org/101983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
BUG=271392
Review URL: https://codereview.chromium.org/92263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base namespace.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/100573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of https://codereview.chromium.org/92153002/.
BUG=271392
Review URL: https://codereview.chromium.org/101163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crashes on android
BUG=325216
> Infobar system refactor.
>
> This changes the ownership model of infobars so that InfoBars are long-lived and
> own their InfoBarDelegates directly. The InfoBarService pseudo-owns the
> InfoBars (instead of deleting them directly, it tells them when they're unowned
> and expects them to delete themselves).
>
> This fixes leaks when infobars are closed while not visible (e.g. in a
> background tab) and in general makes the system clearer and easier to reason
> about.
>
> BUG=62154
> TEST=none
> R=erg@chromium.org, sail@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/22694006
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/102163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ComponentCloudPolicyService is created whenever a user signs in, but isn't
cleared when the user signs out; signing out and back in leads to this crash:
[2774:2774:1126/144024:FATAL:cloud_policy_manager.cc(111)] Check failed: !component_policy_service_.
[0x7f9aa98bba3c] policy::CloudPolicyManager::CreateComponentCloudPolicyService()
[0x7f9aa9518eaf] policy::UserCloudPolicyManager::Connect()
[0x7f9aa951a321] policy::UserPolicySigninService::InitializeUserCloudPolicyManager()
[0x7f9aa951a2af] policy::UserPolicySigninService::OnRefreshTokenAvailable()
[0x7f9aaab639d9] OAuth2TokenService::FireRefreshTokenAvailable()
[0x7f9aa91dbfc9] ProfileOAuth2TokenService::UpdateCredentials()
[0x7f9aa8c9647b] SigninManager::CompletePendingSignin()
[0x7f9aaa2d4b5f] OneClickSigninSyncStarter::ConfirmAndSignin()
BUG=None
Review URL: https://codereview.chromium.org/98433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the ownership model of infobars so that InfoBars are long-lived and
own their InfoBarDelegates directly. The InfoBarService pseudo-owns the
InfoBars (instead of deleting them directly, it tells them when they're unowned
and expects them to delete themselves).
This fixes leaks when infobars are closed while not visible (e.g. in a
background tab) and in general makes the system clearer and easier to reason
about.
BUG=62154
TEST=none
R=erg@chromium.org, sail@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/22694006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The values in about:policy are converted to a format that jstemplate can
display correctly; in particular, DictionaryValues are serialized to strings.
This change applies that conversion to every value displayed, instead of only
to values of Chrome policies.
BUG=108992
Review URL: https://codereview.chromium.org/94403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238164 0039d316-1c4b-4281-b951-d872f2087c98
|