| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
CID=1483
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This caused the possible url dialog in the options menu to never load favicons, and instead DCHECK (crashing debug builds).
Review URL: http://codereview.chromium.org/179034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original issue: http://codereview.chromium.org/115212/show
The favicons service is the entry point to getting favicons.
Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages
are never added to the history.
BUG=5840
TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in
this window. Then close the window and open the NTP. The recently closed
windows/tabs should show the favicons for the hsitroy and downloads page.
Review URL: http://codereview.chromium.org/178001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This caused an easily reproducible crash:
1. Start with a fresh profile
2. Navigate to google.com
3. Restart
4. Navigate to google.com
5. crash
The change from pass-by-value to pass-by-ref in
fav_icon_helper.* seems to be to blame, but I can't see it
right off.
TBR=phajdan.jr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=11507
TEST=open options, click "add" to startup url list, select row from list in add url dialog, click add. Also, try sorting columns, and make sure correct url gets added when selecting an url after sorting.
Review URL: http://codereview.chromium.org/145009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19072 0039d316-1c4b-4281-b951-d872f2087c98
|