summaryrefslogtreecommitdiffstats
path: root/chrome/browser/pref_member.h
Commit message (Collapse)AuthorAgeFilesLines
* Move implementation from header to source.erg@chromium.org2010-07-151-10/+10
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* allow editing of hompage preferences on Windows, that are not locked by policiesmnissler@chromium.org2010-07-151-0/+7
| | | | | | | | | | | | | | Only disable those homepage-related gui controls, that are explicitly overridden by policies. This is a different solution than the expected behavior described in the bug below. The main point is that it avoids the ambiguous state, when the user has HomepageIsNewTabPage=true selected, and the policies only specify the HomepageLocation URL. BUG=46486 TEST=manual Review URL: http://codereview.chromium.org/2843022 Patch from Gabor Feher <gfeher@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52477 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-291-3/+3
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Update UI, sync and importer to properly handle managed homepage prefsmnissler@chromium.org2010-05-271-0/+10
| | | | | | | | | | | The change in Preferences.xib binds the homepage options container's enabled state to the new property PreferencesWindowController.IsHomepageManaged BUG=43423 TEST=Manual, especially homepage options on general page of options dialog Review URL: http://codereview.chromium.org/2059001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48371 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce FilePathPrefMember so we can get rid of some FromWString conversions.tony@chromium.org2010-04-231-3/+17
| | | | | | | | | | | BUG=24672 TEST=download a file and verify that works as before. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1646015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45399 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-0/+176
to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98