summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prefs/pref_value_store.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move DeviceManagementPolicyProvider into the profile.mnissler@chromium.org2010-11-191-4/+9
| | | | | | | | | | | Previously, we used only one provider, which would break in situations where there are two profiles (which ChromeOS already does), because it would apply the policy to both profiles and not only the logged in one. For this to work properly, we also need to pass the relevant TokenService instance the DeviceTokenFetcher, so the fetcher can decide whether the token is relevant to it by checking whether the TokenService that sent it is the one associated with the right profile. BUG=63608 TEST=existing unit tests succeed Review URL: http://codereview.chromium.org/5174006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66755 0039d316-1c4b-4281-b951-d872f2087c98
* Create additional PrefStore for Device Management policy.markusheintz@chromium.org2010-11-171-51/+118
| | | | | | | | | | | BUG=62478 TEST=PrefValueStore*:PrefService* Committing for danno@chromium.org Review URL: http://codereview.chromium.org/4876002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66426 0039d316-1c4b-4281-b951-d872f2087c98
* When a proxy command line switches are specified, policy admin warning ↵danno@chromium.org2010-10-151-5/+68
| | | | | | | | | | | | | shouldn't be shown Removed the logic from the ConfigurationPolicyPrefStore that sets managed preferences, it's now completely handled by CommandLinePrefStore. Moved the detection of conflicting proxy settings between the managed and other stores into the PrefValueStore. Implemented a sentinel value that can be used by stores to signal that they are returning the default value. Changed managed store to use this sentinel to hide non-managed proxy settings proxy settings when proxy policy is specified. BUG=54792 TEST=manual Review URL: http://codereview.chromium.org/3367021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62716 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part21:tfarina@chromium.org2010-10-121-1/+1
| | | | | | | | | | | - Include browser_thread.h instead of chrome_thread.h in more 100 files. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3691006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62286 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part13:tfarina@chromium.org2010-10-101-8/+8
| | | | | | | | | | | | | - Rename entries under appcache, automation, chromeos, cocoa, file_system, metrics, policy, prefs, remoting, search_engines and tab_contents. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3660002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62120 0039d316-1c4b-4281-b951-d872f2087c98
* A subtle bug was exposed when the following was added to ↵stevenjb@google.com2010-10-011-17/+27
| | | | | | | | | | | | | | | | | | | | Preferences::RegisterUserPrefs: prefs->RegisterIntegerPref(prefs::kLabsTalkEnabled, 0); Because prefs::kLabsTalkEnabled = "extensions.settings.ggnioahjipcehijkhpdjekioddnjoben.state", "extensions.settings" in the DEFAULT pref store is forced to a DictionaryValue instead of an empty value so that data can be stored in it. This invalidaded a test in PrefService::GetMutableDictionary, causing GetMutableDictionary to return a pointer to a DictionaryValue in the default pref store instead of creating a dictionary in the user pref store. BUG=http://code.google.com/p/chromium-os/issues/detail?id=7066 TEST=See bug; should no longer repro. Also, test preferences in general. Review URL: http://codereview.chromium.org/3533008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61209 0039d316-1c4b-4281-b951-d872f2087c98
* Make pref service more robust against prefs that change their types without ↵pam@chromium.org2010-09-171-8/+49
| | | | | | | | | | | | | | | | | | | | updating user pref values. The outdated value will be ignored, but can be overwritten by a value of the correct type. Developers who change types of prefs should provide migration functionality if needed. Changing the pref's path (i.e., its name) is also advisable, but watch out that you don't leave an orphaned pref value in the user pref file forever. This change also moves tracking of preference types out of PrefService::Preference and into the PrefValueStore, because the latter now needs to know the registered pref types. This is an implementation change, only "externally" visible to unit tests. BUG=55552 TEST=covered by unit tests; also, Chrome launched with a pre-June 2010 profile containing kWebkitInspectorSettings shouldn't crash Review URL: http://codereview.chromium.org/3411011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59773 0039d316-1c4b-4281-b951-d872f2087c98
* Create a DefaultPrefStore to hold registered application-default preference ↵pam@chromium.org2010-09-141-60/+63
| | | | | | | | | | | | | | | values. Also rework preference notifications so they're not sent when a pref store rewrites the same value it already had, to avoid infinite recursion in places that set a pref in response to a notification that that pref has changed. This allows notifications to be sent properly when another PrefStore takes control from a default value. BUG=52719, 54950 TEST=covered by unit tests (PrefValueStoreTest.*, PrefNotifierTest.*, and ExtensionPrefStoreTest.*) Review URL: http://codereview.chromium.org/3323022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59345 0039d316-1c4b-4281-b951-d872f2087c98
* Move policy-related stuff to its own namespace.mnissler@chromium.org2010-09-101-0/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3360019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58920 - Create a DefaultPrefStore to hold registered ↵pam@chromium.org2010-09-091-38/+19
| | | | | | | | | | | | | | | | | application-default preference values. This allows notifications to be sent properly when another PrefStore takes control from a default value. BUG=52719 TEST=covered by PrefValueStoreTest.* unit tests Review URL: http://codereview.chromium.org/3331016 TBR=pam@chromium.org [Reverting because it causes PrefsControllerTest.ValidateCustomHomePagesTable to crash on Mac.] Review URL: http://codereview.chromium.org/3353019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58925 0039d316-1c4b-4281-b951-d872f2087c98
* Create a DefaultPrefStore to hold registered application-default preference ↵pam@chromium.org2010-09-091-19/+38
| | | | | | | | | | | | values. This allows notifications to be sent properly when another PrefStore takes control from a default value. BUG=52719 TEST=covered by PrefValueStoreTest.* unit tests Review URL: http://codereview.chromium.org/3331016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58920 0039d316-1c4b-4281-b951-d872f2087c98
* Gracefully handle the case of empty preference file names in PrefValueStore.mnissler@chromium.org2010-09-031-5/+3
| | | | | | | | | BUG=53917 TEST=Instead of crashing, chrome should display a message if it cannot determine the local state file. Review URL: http://codereview.chromium.org/3322005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58471 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-0/+299
Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-01 11:34:02 +0000