| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Forgot to delete the Preference object in PrefService::UnregisterPreference.
TBR=bauerb@chromium.org
BUG=none
TEST=no leaks from MigratePreferences
Review URL: http://codereview.chromium.org/9034018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
intl.global.charset_default
webkit.webprefs.global.standard_font_family
webkit.webprefs.global.fixed_font_family
webkit.webprefs.global.serif_font_family
webkit.webprefs.global.sansserif_font_family
webkit.webprefs.global.cursive_font_family
webkit.webprefs.global.fantasy_font_family
webkit.webprefs.global.default_font_size
webkit.webprefs.global.default_fixed_font_size
webkit.webprefs.global.minimum_font_size
webkit.webprefs.global.minimum_logical_font_size
webkit.webprefs.global.javascript_can_open_windows_automatically
webkit.webprefs.global.loads_images_automatically
webkit.webprefs.global.plugins_enabled
BUG=105537
TEST=PrefsTabHelperTest*,PrefsTabHelperBrowserTest*
For files that has only prefs names changes and require OWNERS approval:
TBR=erikwright@chromium.org,gene@chromium.org,csilv@chromium.org,atwilson@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/8879016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
refactors:
IsChromeFirstRun()
CreateSentinel()
RemoveSentinel()
GetFirstRunSentinelFilePath()
It also fixed an issue that chromeos first run won't create sentinel file, and the following runs always think it is a first run.
BUG=108137
TEST=None
Review URL: http://codereview.chromium.org/8989043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SavePersistentPrefs calls to CommitPendingWrites.
TBR=ncarter@chromium.org
BUG=99306
TEST=none
Review URL: http://codereview.chromium.org/8198007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23063
TEST=Use the auto-enrollment flags set to 0, set the machine serial number to "0", point DMSERVER to a testserver, and sign-in after OOBE. The enrollment screen show be enforced after sign-in.
Review URL: http://codereview.chromium.org/8961009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows to swap the internal buffers for two pref_value_maps.
BUG=chromium-os:19960
TEST=unit_tests:PrefValueMapTest.SwapTwoMaps
Review URL: http://codereview.chromium.org/9016010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is for Windows only.
BUG=95971
TEST=This requires a special branded build to test (and master_preferences set to have auto_launch_chrome: true or specify mini_installer param --auto-launch-chrome), but after installing it you should see an item under the Wrench \ Options \ Basics that lets you configure Chrome to not auto-launch. If you instead, log out and log in again, Chrome should start with an infobar saying that it was auto-launched. The infobar should stay for a max of 5 launches and then not appear again. Pressing "Cut it out!" on the infobar should turn off this feature. If you just want to test the infobar, launch chrome with --auto-launch-at-startup. Also, uninstall and make sure Chrome is not auto-launched (a Windows error about Chrome not being found should not be shown).
Review URL: http://codereview.chromium.org/8729009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, this CL moves chrome/browser/ui/webui/sync_promo_* to
chrome/browser/ui/webui/sync_promo/sync_promo_*.
BUG=107223
R=stevet@chromium.org,rogerta@chromium.org,sail@chromium.org
TEST=The sync promo responds to brand code and records results of the field
trial correctly.
Review URL: http://codereview.chromium.org/8933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:22035
TEST=Manual.
Review URL: http://codereview.chromium.org/8920003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=43281
TEST=Setting pref has same effect as running with --enable-memory-info.
Review URL: http://codereview.chromium.org/8896018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107098, 106592
TEST=unit_tests:PrefValueStoreTest.*
Review URL: http://codereview.chromium.org/8896023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8873032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into them.
BUG=105872
TEST=no change
Review URL: http://codereview.chromium.org/8865004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:22035
TEST=
Review URL: http://codereview.chromium.org/8702009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105872
TEST=no change
Review URL: http://codereview.chromium.org/8775064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TabContents. Also rename it to tab_contents_unittests.cc. I've moved the one part that depended on PrefService to the pref service test.
BUG=98716
Review URL: http://codereview.chromium.org/8802024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The preference is controlled by the command line and enterprise policy.
R=mattm@chromium.org,mnissler@chromium.org
BUG=106077
TEST=Existing policy unit tests are updated.
Review URL: http://codereview.chromium.org/8772014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Read from the bottom to the top:
* Add new unit tests to cover what was removed before.
* Rename SignedSettingsTempStorage to SignedSettingsCache.
* Revitalize existing tests for SignedSettings[Helper].
* Add the needed infrastucture to support enrollment as well.
* Remove the second cache in OwnershipService it is obsolete.
* Remove the prop ops completely.
* Remove direct prop op from the proxy stuff.
* Serialize policy changes correctly and map side effects of policies.
Mainly make sure we never serialize dirty policy.
Don't reload if policy is serialized fine.
Clear local state registration.
* Clean up redundand SS ops and make proper callbacks for the helper
Move the temp storage finalization to where it belongs.
* Make the temp storage be the cache and use policy ops.
* Make DeviceSettingsProvider work with the protobuf blob directly.
* Merged DeviceSettingsProvider and UserCrosSettingsTrust.
* Rename UserCrosSettingsProvider to DeviceSettingsProvider.
* Extract the SignedSettingsMigrationHelper in its own file.
BUG=chromium-os:14054
TEST=unit_tests:SignedSettings*,*CrosSettings*,suite_Smoke:login_OwnershipApi
Review URL: http://codereview.chromium.org/8727037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
header files via io_thread.h or browser_thread.h
TBR=owners (previously approved on codereview 8477004)
BUG=98716
Review URL: http://codereview.chromium.org/8746023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL we update the user's GAIA info:
- immediately after they sign into sync
- every 24 hours since the last GAIA info update
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8709002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105537
TEST=TabContentsWrapperTest.PerTabJavaScriptEnabled
Review URL: http://codereview.chromium.org/8716004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
merged when it is synced.
This prevents local content settings patterns (exceptions) from being overwritten when sync is turned on and a previously synced version of the preferences is fetched.
BUG=105695
TEST=syncing content settings works
Review URL: http://codereview.chromium.org/8718016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables overriding user preferences on a per-tab rather
than per-profile basis.
Based on this CL: http://codereview.chromium.org/7838030/
BUG=none
TEST=unit_tests pass
Review URL: http://codereview.chromium.org/8568019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8614003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Admins can specify the URL, name, and icon to be used for the enterprise
web store. The app itself is implemented as a component extension, with
some of the manifest values being specified by policy.
BUG=88464
TEST=New ComponentLoaderTest class added to unit_tests. Additional
manual testing: set "EnterpriseWebStoreURL" policy to a valid URL and
start up Chrome. Verify that there is an app on the new tab page that
links to the specified URL. If possible, try installing an extension from
somewhere on that URL, and ensure that no warning is shown before
showing the permission dialog.
Review URL: http://codereview.chromium.org/8477005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two new policies added:
DiskCacheSize (general cache size)
MediaCacheSize (cache size for media files)
BUG=100549
TEST=unit_tests *Policy*
Review URL: http://codereview.chromium.org/8572006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.
The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h.
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.
Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
subdirectories.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8539006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
search provider. Add some defensive measures to prevent deletion of the default search engine or unnecessarily uniquifying keywords.
TEST=Ensure that the default search provider syncs when the Preferences sync data type is enabled. Ensure that the normal search engine syncing changes (add, update, delete) all work.
BUG=15548
Review URL: http://codereview.chromium.org/8334030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for "local" and "global" user preferences where
a "local" preference set in the overlay shadows the "global" preference.
BUG=none
TEST=OverlayUserPrefStoreTest*
Review URL: http://codereview.chromium.org/8515002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on cros
* original plan was to revise proxy ui on cros for all proxy sources and
network types, refer to bug rpt 21219 for ui details
* redesign and reimplement PrefProxyConfigTracker and PrefProxyConfigService
by switching the inter-dependencies between the two and renaming the latter
- PrefProxyConfigService used to observe PrefProxyConfigTracker and retrieve
new prefs proxy from the latter whenever the former gets notification of
proxy change from prefs or delegate service to determine effective proxy
config. Now, PrefProxyConfigTracker pushes new prefs proxy to the renamed
ChromeProxyConfigService on the IO thread; the latter then uses it and proxy
from delegate service to determine effective proxy config.
- remove all thread-switching in PrefProxyConfigTracker which now lives and
runs on UI thread, except for when it pushes proxy config to
ChromeProxyConfigService on IO thread
- enhances and moves ConfigState definition to namespace ProxyPrefs to
indicate source of proxy config (policy, extension, other-precede, system,
fallback) so that PrefProxyConfigTracker, ChromeProxyConfigService and
chromeos::ProxyConfigServiceImpl can acccess it
- extract code for deciding effective proxy config from PrefProxyConfigService
into static PrefProxyConfigTracker method to be shared by all classes
* re-design and re-implement chromeos::ProxyConfigServiceImpl
- this now extends PrefProxyConfigTracker to act as a special of "prefs",
handles all proxy changes from network and prefs notifications and
uses PrefProxyConfigTracker to push effective proxy to
ChromeProxyConfigService and hence to network stack
- remove wrapper chromeos::ProxyConfigService
- this is the authority on cros, and ChromeProxyConfigService does not have
a delegat service.
- provide proxy config to ui for all proxy sources: policy, extension,
network or recommended (in order of precedence), also indicates if proxy is
user-modifiable
- handle user profile changes to use correct PrefProxyConfigTracker
* modify CoreOptionsHandler and CoreChromeosOptionsHandler to implement dynamic
monitoring of prefs::kProxy and on-the-fly ui changes of affected
use-shared-proxies user pref
* modify ui native code, html, css and javascript for internet options and
proxy pages to show yellow banner with different messages (same banner as
options page when there's policy), en/dis-able ui fields, set current user
profile in backend
* modify network dropdown menu to always show proxy settings menu item as long
as there's a network
* modify automation tests, PrefProxyConfigTracker and ProxyConfigSerivceImpl
unittests to handle redesign, fix unittests that fail due to redesign
BUG=chromium-os:20679,chromium-os:21219
TEST=verify per bugs rpts
Review URL: http://codereview.chromium.org/8102019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=owners
BUG=98716
Review URL: http://codereview.chromium.org/8437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the preferences with the command-line options via the
CommandLinePrefStore. This allows us to control the preferences
via the PolicyPrefStores or any other pref store in the future.
Patch originally by wtc@chromium.org at http://codereview.chromium.org/7776002
R=wtc@chromium.org
BUG=102019
TEST=none
Review URL: http://codereview.chromium.org/8402019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.
A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.
Also moved BrowserProcessSubThread into content/ namespace. As part
of follow-up cleanup, chrome/ will stop using this class.
BUG=98716
TEST=existing
Review URL: http://codereview.chromium.org/8392042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving cookie-spesific logic from HostContentSettingsMap to CookieSettings.
Making it explicit that the "is cookie session only" decision only depends on the
primary url.
Also removes the migration code for the obsolete kCookieBehavior preference.
BUG=93335
TEST=CookieSettings.*
Review URL: http://codereview.chromium.org/8383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=99547
TEST=Install chrome and stop it as quickly as possible when the window opens.
Or create a new profile and close all windows as soon as the new profile's
window opens. Do that as often as you like. Make sure that eventually,
after leaving the windows open, that all default apps are correctly installed.
Review URL: http://codereview.chromium.org/8245018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101109
TEST=chrome/browser/prefs/incognito_mode_prefs_unittest.cc
Review URL: http://codereview.chromium.org/8373019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99503
TEST=Dismiss NTP4 bubble and create a new profile. Confirm that the NTP4 bubble does not show up for the new profile.
Review URL: http://codereview.chromium.org/8244009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=96318
TEST=
Review URL: http://codereview.chromium.org/8275012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser.
BUG=98716
Review URL: http://codereview.chromium.org/8342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes.
BUG=98716
Review URL: http://codereview.chromium.org/8331001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We assumed that when a preference becomes unmanaged, it will be user
controlled as well. This isn't the case if it was a default value previously.
This gets handled properly in the association code though, so just remove the
DCHECK and make the comment clearer.
BUG=97611
TEST=unit_tests --gtest_filter="*ProfileSyncServicePreference*"
Review URL: http://codereview.chromium.org/8266001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8258003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There is a bit of hackery. Most of this will be superseded by bubble and webui work.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8231032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=sail@chromium.org
BUG=97820
TEST=Either change the macros, check the codeflow, or add breakpoints to see if
UMA_* macros and other things are working (and it should also compile).
Review URL: http://codereview.chromium.org/8116024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removed the kEnableBookmarkBar preference. This was only used from the policy
code, and duplicated what the kShowBookmarkBar preference already does.
Removed custom policy code that handle this.
- Fixed the pref UI for the kShowBookmarkBar preference, which wasn't working
when set to true by the associated policy. Removed custom UI code for this.
- Fire NOTIFICATION_BOOKMARK_BAR_VISIBILITY_CHANGED from a single place, and
every time that the preference changes.
- Made ChromeWebUI::force_bookmark_bar_visible a virtual method instead, so that
subclasses can recompute the state dynamically. The previous implementation
wouldn't react to pref changes on existing NTPs.
Current behavior of the bookmark bar:
- If kShowBookmarkBar is true, it is shown as part of the tab;
- If kShowBookmarkBar is false, it is shown inline IF the policy is not set, AND
- using the old NTP, OR
- using the new NTP without bookmark features.
The policy forces the bar to be always visible in all tabs, or to never appear
at all.
BUG=98918
TEST=The BookmarkBarEnabled policy does what it's supposed to do in the old NTP, new NTP, and new NTP with bookmarks. The show-bookmark-bar shortcut also does the right thing in all versions.
Review URL: http://codereview.chromium.org/8135001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefernces.
To allow us to compile individual features in/out of a chrome build, we need to
attack browser_prefs.cc, which is a giant static registration. This used to be
done through another big code path starting in ProfileImpl which call
browser::RegisterUserPrefs() which linked to other static methods. Now this is
done through overridding ProfileKeyedServiceFactory::RegisterUserPrefs(), and
there are no additional dependencies.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104412
Review URL: http://codereview.chromium.org/7901027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the only property we manage is whether or not a server supports SPDY, as indicated by NPN. Also introduce a chrome/ implementation of HttpServerPropertiesManager that persists the information to Prefererences.
When we get a SpdySession for a SPDY server, record that that server supports SPDY in HttpServerPropertiesManager. When preconnecting, if we know that the server supports SPDY, only preconnect 1 socket.
R=willchan
BUG=66472
TEST=browser ui and unit tests,network unit tests
Review URL: http://codereview.chromium.org/7827033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
BUG=92044
TEST=
Review URL: http://codereview.chromium.org/8165009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104527 0039d316-1c4b-4281-b951-d872f2087c98
|