| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
| |
browser's local state, since these settings correspond to command line switches.
This is a release blocker for NaCl, so we decided to push this through.
TEST=manual
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322
Review URL: http://codereview.chromium.org/6267009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72225 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user_preferences, in preparation for multi-profile.
devtools
kDevToolsSplitLocation
browser
kBrowserWindowPlacement
Also add a method to browser_prefs to delete obsolete preferences from local state, and fix all related tests.
BUG=66717
TEST=all browser, interactive, and ui tests work properly
Review URL: http://codereview.chromium.org/5915006
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6247017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72175 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for multi-profile.
devtools
kDevToolsSplitLocation
browser
kBrowserWindowPlacement
Also add a method to browser_prefs to delete obsolete preferences from local state, and fix all related tests.
BUG=66717
TEST=all browser, interactive, and ui tests work properly
Review URL: http://codereview.chromium.org/5915006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72153 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update chrome/browser/gtk references & copyright dates of touched files.
Re-alphabetize include lists as necessary from this change.
Manually merge r71828
svn pset svn:eol-style LF \
chrome/browser/automation/testing_automation_provider_gtk.cc \
chrome/browser/speech/speech_input_bubble_gtk.cc
BUG=69289
TEST=none
Review URL: http://codereview.chromium.org/6245006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71859 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=64877
TEST=Existing unittests; manual testing.
Review URL: http://codereview.chromium.org/6310012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71790 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
When the ALSA volume mixer is used (if PulseAudio is disabled), the current volume and mute settings will be stored in the browser prefs so they can be restored when starting a new session.
BUG=chrome-os:10470
TEST=Manual, volume and mute setting via keyboard should persist after rebooting.
Review URL: http://codereview.chromium.org/6118006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71734 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=mnissler
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71663 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=64877
TEST=Existing unittests; manual testing.
Review URL: http://codereview.chromium.org/6079012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71656 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Add support for 'deprecated' attribute in template generator
- Add support for both int- and string- based enums in the template generator
- Add logic to handle ProxyMode and fall back to ProxyServerMode
BUG=68134
TEST=ConfigurationPolicyPrefStore*, new policy template generator tests
Review URL: http://codereview.chromium.org/5958014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71315 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6122006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=64870 64922
TEST=none
Review URL: http://codereview.chromium.org/6174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71172 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update references to use headers in chrome/browser/ui/views.
Update copyright dates in affected files.
/chrome/browser/ui/views/constrained_html_delegate_win.cc
Add space before 'private' label (presubmit warning)
/chrome/browser/ui/views/toolbar_view.cc
Add space before 'cleanup' label (presubmit warning)
BUG=69082
TEST=Compiling...
Review URL: http://codereview.chromium.org/6204002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=create notifications, use the options menu
Review URL: http://codereview.chromium.org/6006007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70564 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nico did some treemapping of our build time on Mac, and (surprise!) gmock
unittests dominated. Gmock works with several large, heavy templates, and previous patches that out of line the ctors/dtors have significantly sped up compilation (e.g.GLMock) and have reduced thrashing.
Nico says I should plug this again: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6056008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70516 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6005010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70351 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
This removes the final bits of thread-switching madness from PrefValueStore and also makes sure only the PrefStores and PrefService instances that are actually affected by a policy change get reconfigured.
BUG=67715
TEST=unit tests in configuration_policy_provider_unittest.cc
Review URL: http://codereview.chromium.org/6074003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70050 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The new preference is kProxyServerMode, which supersedes kProxyAutoDetect and kNoProxyServer. The point of this change is to represent 'use system proxy settings' in a more robust way. The proxy extension API is also adjusted to the preference system.
This is a continuation of gfeher's patch from issue 5701003.
BUG=65732, 66023
TEST=ProxyPrefsTest.*, and also covered by ExtensionApiTest.Porxy*, PrefProxyConfigServiceTest.*
Review URL: http://codereview.chromium.org/6004003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70042 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build fix to browser_render_process_host.cc)
Added group policy for disabling all client-side 3D APIs in Chromium
(in particular, WebGL and Pepper 3D). This has been hooked up through
a new command-line argument (--disable-3d-apis) orthogonal to the
existing ones, so that further changes to those command line arguments
will not accidentally regress the group policy support.
Tested in the following ways:
- Verified that --disable-3d-apis disables WebGL and Pepper 3D
support on Mac OS X.
- Verified that specifying the Disable3DAPIs policy via a JSON file
disables WebGL on Linux.
- Ran unit_tests and verified that there were no failures introduced.
BUG=64806
TEST=ConfigurationPolicyPrefStoreBooleanTest
Review URL: http://codereview.chromium.org/6045003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69791 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium
(in particular, WebGL and Pepper 3D). This has been hooked up through
a new command-line argument (--disable-3d-apis) orthogonal to the
existing ones, so that further changes to those command line arguments
will not accidentally regress the group policy support.
Tested in the following ways:
- Verified that --disable-3d-apis disables WebGL and Pepper 3D
support on Mac OS X.
- Verified that specifying the Disable3DAPIs policy via a JSON file
disables WebGL on Linux.
- Ran unit_tests and verified that there were no failures introduced.
BUG=64806
TEST=ConfigurationPolicyPrefStoreBooleanTest
Review URL: http://codereview.chromium.org/5991003
TBR=kbr@chromium.org
Review URL: http://codereview.chromium.org/6027004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69759 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(in particular, WebGL and Pepper 3D). This has been hooked up through
a new command-line argument (--disable-3d-apis) orthogonal to the
existing ones, so that further changes to those command line arguments
will not accidentally regress the group policy support.
Tested in the following ways:
- Verified that --disable-3d-apis disables WebGL and Pepper 3D
support on Mac OS X.
- Verified that specifying the Disable3DAPIs policy via a JSON file
disables WebGL on Linux.
- Ran unit_tests and verified that there were no failures introduced.
BUG=64806
TEST=ConfigurationPolicyPrefStoreBooleanTest
Review URL: http://codereview.chromium.org/5991003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69753 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5928003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69576 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
preferences, in preparation for multi-profile.
BUG=66717
TEST=none.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69320
Review URL: http://codereview.chromium.org/5800004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69412 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
local_state to user preferences, in preparation for multi-profile.
BUG=66717
TEST=none.
Review URL: http://codereview.chromium.org/5800004
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/5921003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69327 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
preferences, in preparation for multi-profile.
BUG=66717
TEST=none.
Review URL: http://codereview.chromium.org/5800004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69320 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5794003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=64753
TEST=*ContentSettings*.*
Review URL: http://codereview.chromium.org/5528010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68834 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reworks the PrefStore interface, specifically:
- Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store
- Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations
- Remove special handling of default and user pref store from PrefValueStore and put it into PrefService
- Pref change notification handling now almost exclusively handled through PrefValueStore
- Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list)
BUG=64232
TEST=existing unit tests
Review URL: http://codereview.chromium.org/5646003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Mac code to the file thread.
BUG=59265
TEST=none
This patch also splits platform-specific LaunchOnStartup code to platform-specific files, eliminating #if blocks from the primary source file.
Review URL: http://codereview.chromium.org/5368002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68678 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that using system proxy settings is triggered when the
internal proxy prefs of Chrome are set to their default values.
Unfortunately it is possible that these prefs are set to their defaults but
they are not controlled by the default pref store. This CL fixes this by
checking for the default values and not only for the origin of prefs. A longer term solution is described in
http://crbug.com/65732
BUG=65736
TEST=manual
Review URL: http://codereview.chromium.org/5664001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68591 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically:
- Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore.
- Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore.
- Clean up related unit tests, removing redundant mocks and gmockify others.
BUG=64893
TEST=Compiles and passes tests
Review URL: http://codereview.chromium.org/5441002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a redesign for http://codereview.chromium.org/4852002/ following discussions.
The goal of this patch is to ensure that Chrome maintains the order in which extensions apply their preferences between restarts. This may be an issue if two extensions overwrite each others preferences. Furthermore, it ensures that preferences are persisted to disk between browser restarts. Therefore, previous settings are immediately available when the browser is restarted.
A description of the design has been published https://docs.google.com/a/google.com/document/d/1E_HX_cUpET1gH2gDunGIU1EOywMM6FEOuVU6TlpnSwo/edit?hl=en for review and comments. - Sorry, accessible Google internally only.
This CL requires http://codereview.chromium.org/5204006/
Contributed by battre@google.com
BUG=50726
TEST=none
Review URL: http://codereview.chromium.org/5213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68355 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
further contexts.
contributed by battre@google.com
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5204006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68350 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the pref_value_store.h header from the pref_service.h
include list and cleans up any users that were getting the MessageLoop
and BrowserThread definitions indirectly through pref_service.h
BUG=64893
TEST=compiles and passes tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67997
Review URL: http://codereview.chromium.org/5461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68157 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_path_watcher into subdir
profile* into profiles/ subdir
login* into ui/login
visitedlink* into subdir
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5606002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the pref_value_store.h header from the pref_service.h
include list and cleans up any users that were getting the MessageLoop
and BrowserThread definitions indirectly through pref_service.h
BUG=64893
TEST=compiles and passes tests
Review URL: http://codereview.chromium.org/5461001
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/5575001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67998 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the pref_value_store.h header from the pref_service.h
include list and cleans up any users that were getting the MessageLoop
and BrowserThread definitions indirectly through pref_service.h
BUG=64893
TEST=compiles and passes tests
Review URL: http://codereview.chromium.org/5461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67997 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=64660
TEST=build succeeds (no effective code change)
Review URL: http://codereview.chromium.org/5367006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67706 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added BackgroundPageTracker which tracks which extensions/apps contain
background pages.
Added code to wrench menu/toolbar to display a badge when there is a new
background page added to the system.
BUG=59980
TEST=BackgroundPageTrackerTest
Review URL: http://codereview.chromium.org/5207002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66997 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5212005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66930 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Previously, we used only one provider, which would break in situations where there are two profiles (which ChromeOS already does), because it would apply the policy to both profiles and not only the logged in one. For this to work properly, we also need to pass the relevant TokenService instance the DeviceTokenFetcher, so the fetcher can decide whether the token is relevant to it by checking whether the TokenService that sent it is the one associated with the right profile.
BUG=63608
TEST=existing unit tests succeed
Review URL: http://codereview.chromium.org/5174006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66755 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
BUG=62478
TEST=PrefValueStore*:PrefService*
Committing for danno@chromium.org
Review URL: http://codereview.chromium.org/4876002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66426 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
to match naming pattern of UserCrosSettingsProvider etc.
reshuffle some code in more consistent way.
No Functionality Change.
BUG=http://crosbug.com/8645
TEST=None
Review URL: http://codereview.chromium.org/5078001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66271 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5043001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66198 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This preference can be set either via command-line or via group policy.
BUG=53625
TEST=unittests: ConfigurationPolicyPrefStore*; net_unittests: HttpAuthHandlerNegotiateTest.*:HttpAuthGSSAPIPOSIXTest.*; manually: start Chrome with command-line switch --gssapi-library-name=XYZ and see if this results in the Chrome process loading /usr/lib/whatever/XYZ as soon as an authenticated HTTP site is encountered.
Review URL: http://codereview.chromium.org/4560001
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65939 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Group Policy support for HTTP authentication, already had LGTM from http://codereview.chromium.org/3517018.
BUG=53625
TEST=ConfigurationPolicyPrefStore*
Review URL: http://codereview.chromium.org/4733003
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65664 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=53625
TEST=ConfigurationPolicyPrefStore*
Review URL: http://codereview.chromium.org/3517018
Patch from Jakob Kummerow <jkummerow@google.com>.
TBR=danno@chromium.org
Review URL: http://codereview.chromium.org/4643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65537 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
BUG=53625
TEST=ConfigurationPolicyPrefStore*
Review URL: http://codereview.chromium.org/3517018
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65535 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wrote much of the cross-platform policy-providing mechanism for Chrome. Much of the policy code is cross platform, so I would like to apply for a Linux C++ readability review. However, my submitted CLs also contain Windows-specific code, so I'm unsure if Windows readability is more appropriate.
* Implementation of managed policy abstraction on top of a preference store. This is the CL that is the initial preparation for implementing platform-specific policy - http://codereview.chromium.org/1692011
* Implement core mechanism to honor Windows Group Policy on top of initial CL - http://codereview.chromium.org/2119005
* Dynamic refresh of policy without restarting Chrome including Windows-specific code - http://codereview.chromium.org/2858060
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3774003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64897 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=59030
TEST=trybots
Review URL: http://codereview.chromium.org/4143012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64537 0039d316-1c4b-4281-b951-d872f2087c98
|