| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
When the user has not explicitly set a preference in Chrome for session restore, the default behavior under Lion becomes sensitive to the System preference for window restore.
BUG=75814
TEST=SessionStartupPrefTest.*, and manual testing of WebUI: clean prefs, Launch Chrome, toggle "System Preferences > General > Restore windows..." and observe effect on Chrome preferences "Basics > On Startup".
Review URL: http://codereview.chromium.org/7522025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Sync] Refactor sync datatype error handling.
This introduces SyncError's, which are a convenient way of passing around an
error location, type, and message. All datatypes have been refactored to use
this, including in the AssociateModels code. A future change will use this
to add support for continuing sync even when a datatype fails to start.
In addition, eventually a future change will convert the UnrecoverableError
handler to use SyncError's as well as have the datatype controller's and
datatype manager surface SyncError's to the PSS.
Original Review URL: http://codereview.chromium.org/7453014
TBR=akalin@chromium.org
BUG=87645
TEST=
Review URL: http://codereview.chromium.org/7461098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces SyncError's, which are a convenient way of passing around an
error location, type, and message. All datatypes have been refactored to use
this, including in the AssociateModels code. A future change will use this
to add support for continuing sync even when a datatype fails to start.
In addition, eventually a future change will convert the UnrecoverableError
handler to use SyncError's as well as have the datatype controller's and
datatype manager surface SyncError's to the PSS.
BUG=87645
TEST=
Review URL: http://codereview.chromium.org/7453014
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/7497014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces SyncError's, which are a convenient way of passing around an
error location, type, and message. All datatypes have been refactored to use
this, including in the AssociateModels code. A future change will use this
to add support for continuing sync even when a datatype fails to start.
In addition, eventually a future change will convert the UnrecoverableError
handler to use SyncError's as well as have the datatype controller's and
datatype manager surface SyncError's to the PSS.
BUG=87645
TEST=
Review URL: http://codereview.chromium.org/7453014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear local cache on exit
BUG=69580
TEST=configuration_policy_pref_store_unittest.cc
Review URL: http://codereview.chromium.org/7399021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add button to infobar allowing user to disable feature completely
- add checkbox to password section of personal settings allowing user to toggle
whether auto-login is enabled
- some word changes to the infobar
- remove the about:flags option since we now have control in options
BUG=87151
TEST=Make sure that checkbox in options page controls feature correctly
Review URL: http://codereview.chromium.org/7485007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=battre
BUG=58831
TEST=unit_tests --gtest_filter=CommandLinePrefStoreTest.DisableSSLCipherSuites:SSLConfigServiceManagerPrefTest.*
Review URL: http://codereview.chromium.org/7462008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Don't use g_browser_process, use BrowserThread::PostTask to send to the IO thread
- Explicitly register LocalState preferences at the appropriate time, rather than deferring registration until the first time the SSLConfigServicePref is used
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7489004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from devtools_manager.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7429006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incognito window
This CL renames the OverlayPrefStore to an IncognitoPrefStore. This IncognitoPrefStore stores write operations in memory and prevents persisting them to the user prefs file. The CL also blacklists two preferences from being stored in the in-memory IncognitoPrefStore to fix the regressions mentioned in the bugs.
BUG=87191,84472
TEST=see bug descriptions
Review URL: http://codereview.chromium.org/7342043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the gyp flag configuration_policy=0, use ifdefs in the places where
policy classes are referred to, rather than providing stubs that
implement parts of the policy classes. This is somewhat simpler and less
fragile. This reverts part of r87468 (where this flag was introduced)
but keeps other parts which are still valuable.
BUG=85534
Review URL: http://codereview.chromium.org/7343008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to make the bookmark editor remember what folders were expanded last
time the editor was shown.
BUG=6648
TEST=covered by unit tests
TBR=tim@chromium.org,maf@chromium.org,erg@chromium.org
Review URL: http://codereview.chromium.org/7343016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with a minor change to that code since libcros also uses base/values.h.
BUG=88666
TEST=none
Review URL: http://codereview.chromium.org/7259019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Introduce a gyp variable "safe_browsing" which can be set to 0 to remove
safe browsing code at compile time.
Review URL: http://codereview.chromium.org/7227013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_notification_types.h.
This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END
which defines the end of the enum used by content to define notification types. The notificaton_type.h file
in content\common has been renamed to content_notification_types.h
BUG=76698
Review URL: http://codereview.chromium.org/7327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL basically does the following things:
* Remove final dependencies of ProfilePolicyConnector on Profile
* Take ProfilePolicyConnector away from Profile and put it into BrowserPolicyConnector.
* Make BrowserPolicyConnector instance persistant and allow to
exchange the CloudPolicySubsystem backend instead.
* Introduce a new CloudPolicyProvider which combines two
(or more) CloudPolicyCacheBase backends and applies their policies in a well defined order.
That is the order in which the CloudPolicyCacheBases appear in
the List of CloudPolicyProvider determines the precedence,
early Providers get applied first and block the applied policies
for later Caches.
* Handles ProxyPolicies in CloudPolicyProvider making
the old infrastructure around MergingPolicyConnector obsolete.
* Consequently this means that user cloud policy can now serve local_state.
Continuation of http://codereview.chromium.org/6979011/
Patch from sfeuz@chromium.org with additional work from gfeher@chromium.org
BUG=none
TEST=Unittests CloudPolicyProvider.*
Review URL: http://codereview.chromium.org/7147015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other references are modified only to point to the new
location. Follow-up changes will move build rules for the debugger
into content.
This adds a somewhat permissive DEPS file to
content/browser/debugger. Follow-up work will whittle that down to
zero dependencies on chrome/.
BUG=84078
TEST=existing
Review URL: http://codereview.chromium.org/7274031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a preference to store avatar icons.
For this change I extended the idea of kProfileAvatarIconMap pref into a full blown class. The class is responsible for mantaining a list of sorted profiles that can be displayed without having to load profiles from disk.
Once this is chcked in there are several TODOs:
- remove the ProfileManager::GetNumberOfProfiles(), etc... functions that I added earlier
- add UI to customize the avatar icon
- create a single instance of the new ProfileInfoCache object some where. Maybe from ProfileManager?
BUG=
TEST=
Review URL: http://codereview.chromium.org/7155015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7262013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID = 14804, 16939, 16937, 16904, 16793, 16308, 14956, 15404, 11823
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7211019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now always update the pref user store with the sync data. Once a preference
stops being policy controlled, it will automatically pick up either the most
recent sync data or the previous user value.
BUG=86487
TEST=unit_tests --gtest_filter="*ProfileSyncServicePreference*"
Review URL: http://codereview.chromium.org/7205010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add to SyncChangeProcessor and SyncableService.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7189004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary because it affects conflict resolution, and helps with debugging.
BUG=86078
TEST=about:sync, sync node browser, preferences have names
Review URL: http://codereview.chromium.org/7144017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=If it compiles, it works.
Review URL: http://codereview.chromium.org/7187028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=16108
Review URL: http://codereview.chromium.org/7129061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7148006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to go through the newly made ProfileKeyedServiceFactory subclass.
In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test.
BUG=77155
TEST=unit tests
R=mirandac
Review URL: http://codereview.chromium.org/7056056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
refresh rate.
This is an effort towards removing dependencies of the ProfilePolicyConnector on Profile.
BUG=none
TEST=Verify that user- and device-refresh rate are set correctly when specified by policy.
Review URL: http://codereview.chromium.org/7014036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
specific to Chrome (i.e. interstitial, dialogs) stays behind. This change just moves code, and so adds a bunch of files to DEPS. I'll add proper interfaces in a follow up cl, but keeping the move simple at first.
BUG=76697
Review URL: http://codereview.chromium.org/7111013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Existing
Review URL: http://codereview.chromium.org/7096013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
apply to non-linux Unix also. Non-linux Unices tested are the BSDs and Solaris.
Review URL: http://codereview.chromium.org/3556009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Views-specific part is taken away from the WizardController and was put into ViewsOobeDisplay class. WizardScreenDelegate was renamed to ViewScreenDelegate, and moved to the ViewScreen class. Also WizardScreen interface was slighly changed to not depend on concrete implementation.
Also WizardController was moved to chromeos:: namespace.
BUG=chromium-os:11632
TEST=browser_tests
Review URL: http://codereview.chromium.org/7069013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6992081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=no change
Review URL: http://codereview.chromium.org/7065038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:15631
TEST=Manual.
Review URL: http://codereview.chromium.org/7019039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76232
TEST=Everything sync.
Review URL: http://codereview.chromium.org/6995008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from it.
I've moved watching changes to the default zoom level to the Profile class. The other value being watched was for the per-hostname level, which is only needed if it's being synced. However this pref stopped being synced in r51849, so the removal is roughly a revert of 44056.
Review URL: http://codereview.chromium.org/7058003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/logging.h is needed because of DCHECK's.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7051012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like they got moved accidentally in http://codereview.chromium.org/6714032
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7048007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bug description for more info.
BUG=chromium-os:14289
TEST=JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/6894020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following are the primary changes:
1. Whenever a profile preference is registered, it must specify whether that
preference should be synced or not. Local state preferences do not require this.
However, we DCHECK that local state preferences are in fact registered to the
local state.
2. We've created a new sync model associator interface, which all datatypes
will eventually implement. This new model associator is designed to be
decoupled from much of the sync internals, and to be owned by the chrome service
being synced. It also implements most of the functionality previous handled by
the change processor.
3. The PrefService now owns its sync model associator
(pref_model_associator), which partially implements the new model associator
functionality. Further work will be done to remove the use of sync
transactions from the model associator, as well as to migrate other datatypes.
BUG=76232
TEST=
Review URL: http://codereview.chromium.org/6905044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6883291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80755
TEST=Install extensions with background pages, make sure View Background Pages wrench menu item has the correct count.
Review URL: http://codereview.chromium.org/6929001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fetched or is invalid.
The optional blocking is currently only exposed to the Proxy Settings API, not to command-line parameters or policies.
BUG=79344
TEST=Install the sample proxy extension and enter a non-existing url and a URL that does not point to a valid JavaScript file. In either case, the request should fail.
Review URL: http://codereview.chromium.org/6871019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80818
TEST=Enable the AlwaysAuthorizePlugins policy, and plugins that require authorization are always allowed. Otherwise, the user is asked for authorization.
Review URL: http://codereview.chromium.org/6893092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And add myself to an ntp watchlist.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6905067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we would read the plug-in blacklist from user prefs at startup, but watch for changes (only!) in local state, which just seems wrong.
BUG=80025,45856
TEST=none
Review URL: http://codereview.chromium.org/6898050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13019
TEST=existing browser tests
Review URL: http://codereview.chromium.org/6893052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83304 0039d316-1c4b-4281-b951-d872f2087c98
|