summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prerender
Commit message (Collapse)AuthorAgeFilesLines
* Disabled flaky PrerenderOmniboxBrowserTest.PrerenderOmniboxAbandon.phoglund@chromium.org2014-06-111-1/+3
| | | | | | | | | | BUG=368721 TBR=davidben@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/332433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276408 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Remove context_menus and guest_view_internal extension APIs.thestig@chromium.org2014-06-111-1/+7
| | | | | | | | BUG=305852 Review URL: https://codereview.chromium.org/320703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276263 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize MetricsService.blundell@chromium.org2014-06-111-1/+1
| | | | | | | | | | | | | | | MetricsService, along with prefs that it uses, is moved into the Metrics component. A later CL will move MetricsService (and all other code in the metrics component) into the metrics namespace. BUG=374198 TBR=jochen Review URL: https://codereview.chromium.org/320553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276229 0039d316-1c4b-4281-b951-d872f2087c98
* Move about://-related constants from //content to //urlblundell@chromium.org2014-06-102-13/+16
| | | | | | | | | | | kAboutScheme and kAboutBlankURL are used in code shared by iOS, and are general enough to live in //url instead of //content. TBR=yoz,benm Review URL: https://codereview.chromium.org/325443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275988 0039d316-1c4b-4281-b951-d872f2087c98
* Make URLRequestFilter use URLRequestInterceptors.mmenke@chromium.org2014-06-061-45/+41
| | | | | | | | | | | It was using ProtocolHandlers, but it makes more sense for it to use the new URLRequestInterceptor class. BUG=146600 Review URL: https://codereview.chromium.org/300693005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some RenderProcessHost::IsGuest call sitesfsamuel@chromium.org2014-05-261-3/+6
| | | | | | | | | | | This CL removes some of the callsites to RenderProcessHost::IsGuest. BUG=364141, 330264 TBR=benm@chromium.org for trivial android_webview change. Review URL: https://codereview.chromium.org/291403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272830 0039d316-1c4b-4281-b951-d872f2087c98
* Add a field trial to disable deferred committing of cookie changestburkard@chromium.org2014-05-265-14/+35
| | | | | | | | | | | by prerender. This can be used to emergency disable the feature, or to do comparisons of other metrics. R=davidben@chromium.org Review URL: https://codereview.chromium.org/293123010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272824 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, mostly replacing uses of SplitStringUsingSubstr() with SplitString(),pkasting@chromium.org2014-05-231-39/+20
| | | | | | | | | | | also some other misc. changes to shorten code, remove a using directive, etc. BUG=none TEST=none Review URL: https://codereview.chromium.org/291653007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272624 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill ↵jam@chromium.org2014-05-163-7/+4
| | | | | | | | | | their child processes. R=avi@chromium.org Review URL: https://codereview.chromium.org/292443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271096 0039d316-1c4b-4281-b951-d872f2087c98
* Abort prerenders on app-intercepted navigations.davidben@chromium.org2014-05-152-0/+2
| | | | | | | | | | | Instead of skipping the interception, abort the prerender so that the prerender doesn't cause the actual navigation to bypass the interception. BUG=370519 Review URL: https://codereview.chromium.org/265293011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270789 0039d316-1c4b-4281-b951-d872f2087c98
* * Rename Prerender.NetworkBytes.* histograms to Prerender.NetworkBytes*jkarlin@chromium.org2014-05-155-20/+29
| | | | | | | | | | | | | | * Deprecate the old histogram names in histograms.xml * Add origin prefixes to Prerender.NetworkBytes histograms. * Stop recording prerenders of size 0. BUG= Review URL: https://codereview.chromium.org/283703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270735 0039d316-1c4b-4281-b951-d872f2087c98
* Check BrowsingInstance before swapping prerenders.davidben@chromium.org2014-05-154-6/+35
| | | | | | | | | | | | Even if a WebContents does not have an opener, if there is another WebContents in the BrowsingInstance, swapping processes can break pages which expect script access. BUG=118294 Review URL: https://codereview.chromium.org/257083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270581 0039d316-1c4b-4281-b951-d872f2087c98
* Hook prerender into non-CURRENT_TAB dispositions.davidben@chromium.org2014-05-141-3/+3
| | | | | | | | | | | | SwapInternal checks if CoreTabHelper::delegate is NULL now, and a non-CURRENT_TAB disposition would require the asynchronous codepath anyway, so it's fine that the WebContents is still to be attached. BUG=345474 Review URL: https://codereview.chromium.org/261623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270278 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup CanDownload WebContentsDelegate APIfsamuel@chromium.org2014-05-131-1/+1
| | | | | | | | | | | | | | It seems we were passing an opaque request ID in WebContentsDelegate::CanDownload that wasn't used anywhere. Instead, for <webview>, we would simply like the URL that generated the download request. This CL simplifies the API and reduces cruft and code complexity BUG=364141, 330264 TBR=sgurun@chromium.org Review URL: https://codereview.chromium.org/286543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270242 0039d316-1c4b-4281-b951-d872f2087c98
* Only commit cookie changes in prerenders after a prerender is showntburkard@chromium.org2014-05-1314-12/+832
| | | | | | | | | | | | | | Will create a PrerenderCookieStore for each prerender, retaining all cookie operations of a prerender until the prerender is shown to the user. Forces prerenders to be in a new render process by themselves for this to work. This is a resubmission of https://codereview.chromium.org/233353003, which had to be reverted due to build breaks. See LGTM's there. BUG=371003 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/280403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270049 0039d316-1c4b-4281-b951-d872f2087c98
* Add to the prerender history when no PrerenderContents is created.mmenke@chromium.org2014-05-122-10/+16
| | | | | | | | | | | Without this, the net-internals prerendering tests fail when a cancel that creates a PrerenderContents is replaced with one that does not. BUG=372471 Review URL: https://codereview.chromium.org/286433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269900 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 269855 "Only commit cookie changes in prerenders after a ..."piman@chromium.org2014-05-1214-825/+12
| | | | | | | | | | | | | | | | | | | | | This broke again - http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=23472 > Only commit cookie changes in prerenders after a prerender is shown > Will create a PrerenderCookieStore for each prerender, retaining all cookie > operations of a prerender until the prerender is shown to the user. > Forces prerenders to be in a new render process by themselves for this to work. > BUG=371003 > > This is a resubmission of https://codereview.chromium.org/233353003, which had > to be reverted due to build breaks. See LGTM's there. > > Review URL: https://codereview.chromium.org/278403003 TBR=tburkard@chromium.org Review URL: https://codereview.chromium.org/280383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269879 0039d316-1c4b-4281-b951-d872f2087c98
* Only commit cookie changes in prerenders after a prerender is showntburkard@chromium.org2014-05-1214-12/+825
| | | | | | | | | | | | | | Will create a PrerenderCookieStore for each prerender, retaining all cookie operations of a prerender until the prerender is shown to the user. Forces prerenders to be in a new render process by themselves for this to work. BUG=371003 This is a resubmission of https://codereview.chromium.org/233353003, which had to be reverted due to build breaks. See LGTM's there. Review URL: https://codereview.chromium.org/278403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269855 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 269798 "Only commit cookie changes in prerenders after a ..."mmenke@chromium.org2014-05-1214-815/+12
| | | | | | | | | | | | | | | | | | | | This broke prerender omnibox tests (Failing on tree, also failed on trybot runs for the CL). > Only commit cookie changes in prerenders after a prerender is shown > Will create a PrerenderCookieStore for each prerender, retaining all cookie > operations of a prerender until the prerender is shown to the user. > Forces prerenders to be in a new render process by themselves for this to work. > BUG=371003 > R=creis@chromium.org, davidben@chromium.org, erikwright@chromium.org, jam@chromium.org, jochen@chromium.org > > Review URL: https://codereview.chromium.org/233353003 TBR=tburkard@chromium.org Review URL: https://codereview.chromium.org/279173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269812 0039d316-1c4b-4281-b951-d872f2087c98
* Only commit cookie changes in prerenders after a prerender is showntburkard@chromium.org2014-05-1214-12/+815
| | | | | | | | | | | | Will create a PrerenderCookieStore for each prerender, retaining all cookie operations of a prerender until the prerender is shown to the user. Forces prerenders to be in a new render process by themselves for this to work. BUG=371003 R=creis@chromium.org, davidben@chromium.org, erikwright@chromium.org, jam@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/233353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269798 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore title parameter for navigator.registerProtocolHandlermeacer@chromium.org2014-05-101-1/+0
| | | | | | | | BUG=347720 Review URL: https://codereview.chromium.org/267103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269630 0039d316-1c4b-4281-b951-d872f2087c98
* We have a problem in the process on destroying WebContentsImpl becausezverre@yandex-team.ru2014-05-092-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | each WebContentsObserver first NULLs its web_contents_ pointer and performs cleanup code after that. This could work if we guaranteed that every WebContentsObserver doesn't directly or indirectly affect any other WebContentsObserver. But actually WebContentsObservers can do anything and also affect each other. And if one WebContentsObserver already NULLed its web_contents_ pointer (e.g. ZoomController) other WebContentsObserver (e.g. InterstitialPageImpl) calls it (indirectly in this case) we have problems and result depends on ordering of WebContentsObservers in the list of observers. The solution splits that process into two phases. First we let each WebContentsObserver to perform their cleanup code and at that point they can freely call each other, we completely don't care about the ordering. We can call this phase as untrusted phase because we deal with some cleanup code that can do anything. After that we make second pass and NULL each web_contents_ pointer and this phase is trusted because we call only private implementation of WebContentsObserver that we definitely can trust. BUG=363564 Review URL: https://codereview.chromium.org/257153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269264 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug in PrerenderLocalPredictortburkard@chromium.org2014-05-051-1/+1
| | | | | | | | | | Only access sb_manager if it was actually created and is not NULL. BUG=369494 R=cbentzel@chromium.org Review URL: https://codereview.chromium.org/265273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268180 0039d316-1c4b-4281-b951-d872f2087c98
* Hide WebContentsView from Chrome. This also removes WebContentsViewPort.jam@chromium.org2014-05-033-6/+2
| | | | | | | | | | | TestWebContentsView goes away since it's not needed anymore BUG=304341 R=avi@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/262823006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268072 0039d316-1c4b-4281-b951-d872f2087c98
* Move mime_types_handler.{cc,h} into manifest_handlerszork@chromium.org2014-05-011-1/+1
| | | | | | | | | BUG=None TBR=jam@chromium.org Review URL: https://codereview.chromium.org/261723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267644 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed namespaces in src/chrome.vitalybuka@chromium.org2014-04-302-18/+14
| | | | | | | | | | | | url_util -> url url_parse -> url url_canon -> url BUG=364747 Review URL: https://codereview.chromium.org/260623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267303 0039d316-1c4b-4281-b951-d872f2087c98
* Abort prerenders that call window.close()davidben@chromium.org2014-04-303-1/+12
| | | | | | | | BUG=366734 Review URL: https://codereview.chromium.org/256583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267259 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for BrowsingDataRemover to complete in prerender tests.davidben@chromium.org2014-04-301-9/+6
| | | | | | | | | | | BrowsingDataRemover causes shutdown problems if interrupted. Avoid test flakiness by letting it run to completion. BUG=316225, 340855 Review URL: https://codereview.chromium.org/250663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267106 0039d316-1c4b-4281-b951-d872f2087c98
* Disable load event check on PrerenderPrint.davidben@chromium.org2014-04-281-0/+1
| | | | | | | | | | Causing problems with a pending change in Blink. BUG=367271 Review URL: https://codereview.chromium.org/250953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266621 0039d316-1c4b-4281-b951-d872f2087c98
* Abandon and cancel omnibox prerenders as appropriate.davidben@chromium.org2014-04-243-0/+96
| | | | | | | | | | | | If a match is selected, abandon the prerender for a lower timeout. If the omnibox is dismissed, abort the prerender. This fixes the bug for desktop and Android Chrome. BUG=356894 Review URL: https://codereview.chromium.org/235943017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265988 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-enable PrerenderClickNew* tests.davidben@chromium.org2014-04-231-12/+17
| | | | | | | | | | | | | We don't even interpose on those navigations, so it's only so useful, but it'll let us assert that the swap doesn't happen one way or another. Can change that if it ever becomes useful to do this. (Might not be for BrowsingInstance reasons.) BUG=345474 Review URL: https://codereview.chromium.org/246053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265751 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable PrerenderWindowSize on TOOLKIT_VIEWS.davidben@chromium.org2014-04-231-5/+0
| | | | | | | | | | Seems to be running fine now. BUG=82363 Review URL: https://codereview.chromium.org/245973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265677 0039d316-1c4b-4281-b951-d872f2087c98
* Add prerender test for closing incognito windows.davidben@chromium.org2014-04-211-0/+11
| | | | | | | | | | | We don't actually have test coverage for aborting prerenders when the last incognito window is closed. BUG=none Review URL: https://codereview.chromium.org/243543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265095 0039d316-1c4b-4281-b951-d872f2087c98
* Convert prerender TabsApi test to RunExtensionTest.davidben@chromium.org2014-04-211-12/+2
| | | | | | | | | | | | | RunExtensionSubtest is flaky on Windows and there's no particular reason for this to be one. Also remove an unnecessary kAllowLegacyExtensionManifests. BUG=177163 Review URL: https://codereview.chromium.org/239173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265082 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable PrerenderBrowserTest.PrerenderWebAudioTest.davidben@chromium.org2014-04-141-3/+3
| | | | | | | | | | | Also use unprefixed AudioContext. This test works on Mac try bots now. BUG=261489 Review URL: https://codereview.chromium.org/233713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263679 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262697 "Revert 262680 "Put all in components/password_man..."vabr@chromium.org2014-04-092-7/+10
| | | | | | | | | | | | | | | | | | | | | > Revert 262680 "Put all in components/password_manager in passwor..." > > > Put all in components/password_manager in password_manager namespace. > > > > BUG=348523 > > TBR=jochen@chromium.org > > > > Review URL: https://codereview.chromium.org/225093012 > > TBR=vabr@chromium.org > > Review URL: https://codereview.chromium.org/231113002 TBR=dmazzoni@google.com Review URL: https://codereview.chromium.org/231153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262699 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262680 "Put all in components/password_manager in passwor..."dmazzoni@google.com2014-04-092-10/+7
| | | | | | | | | | | | | | | > Put all in components/password_manager in password_manager namespace. > > BUG=348523 > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/225093012 TBR=vabr@chromium.org Review URL: https://codereview.chromium.org/231113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262697 0039d316-1c4b-4281-b951-d872f2087c98
* Put all in components/password_manager in password_manager namespace.vabr@chromium.org2014-04-092-7/+10
| | | | | | | | | BUG=348523 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/225093012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262680 0039d316-1c4b-4281-b951-d872f2087c98
* Move DispatchBeforeUnload from RenderFrameHost to WebContents. This is after ↵jam@chromium.org2014-04-081-1/+1
| | | | | | | | | | | discussions to move as much stuff as possible to WebContents. BUG=304341 R=creis@chromium.org Review URL: https://codereview.chromium.org/228653007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262535 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to WebContentsView::SizeContents from chrome/ and app/erikchen@chromium.org2014-04-081-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebContentsView::SizeContents was initially introduced as a hack to allow the content module to resize a WebContentsView. This is odd because the embedder should be in full control of the layout of the WebContentsView. Unfortunately, SizeContents started being used as a platform-agnostic way for the embedder to change the size of a WebContentsView. The mac implementation of SizeContents has never been correct. The implementation would work correctly when SizeContents was used by the embedder, but it did not work when used by the content module. See https://code.google.com/p/chromium/issues/detail?id=264207 for details. I changed the mac implementation of SizeContents to be a no-op, which fixed the use of SizeContents from the content module, and broke its usage from the embedder. This CL introduces a new platform agnostic utility method to resize a WebContents. I've replaced all calls to SizeContents from chrome/ and app/ with a call to the new utility method. There is no expected behavioral change on aura, gtk, or android. This should fix the problems that have arisen from my change to the mac implementation of SizeContents. Ideally, the utility method would take a gfx::NativeView as its parameter. Unfortunately, I was unable perform the resizing on a ui::AndroidView*, and I was forced to pass in the whole WebContents to mimic the behavior of WebContentsViewAndroid::SizeContents. BUG=354769 TEST=Follow steps listed in bug. Review URL: https://codereview.chromium.org/209023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262276 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable prerender HTML5 audio and video tests.davidben@chromium.org2014-04-071-12/+6
| | | | | | | | | | | They've been disabled for a long time and the code and test framework have changed since then. Re-enable them and see if further flakes pop up. BUG=108402,145263 Review URL: https://codereview.chromium.org/224723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262144 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding user gesture fix for external protocol handlers after revert.meacer@chromium.org2014-04-031-1/+2
| | | | | | | | | | | The original CL that broke the build: https://codereview.chromium.org/131783012/ BUG=173557 TBR=pkasting@chromium.org,joi@chromium.org,kalman@chromium.org,jochen@chromium.org,mmenke@chromium.org,boliu@chromium.org Review URL: https://codereview.chromium.org/214603010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261316 0039d316-1c4b-4281-b951-d872f2087c98
* On Android, also prerender only if we may create a new render process.tburkard@chromium.org2014-04-021-4/+3
| | | | | | | | R=ppi@chromium.org Review URL: https://codereview.chromium.org/221933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261125 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Fix the handling of user gestures for external protocol handler ↵rlarocque@chromium.org2014-04-021-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dialogs. (https://codereview.chromium.org/131783012/) Reason for revert: Looks like this caused a failure on the build bots. http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/57837 FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/apps/shell/browser/app_shell_lib.shell_extensions_browser_client.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_MOJO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DGL_GLEXT_PROTOTYPES -DGTEST_HAS_POSIX_RE=0 -DLIBPEERCONNECTION_LIB=1 -DU_USING_ICU_NAMESPACE=0 -DV8_SHARED -DUSING_V8_SHARED -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DSK_SUPPORT_LEGACY_LAYERRASTERIZER_API=1 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_GETCLIPTYPE -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen -I../../third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -Igen/policy -Igen/protoc_out -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-deprecated-register -Wno-absolute-value -Xclang -load -Xclang /b/build/slave/Linux_Clang__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -march=x86-64 -O0 -g -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../apps/shell/browser/shell_extensions_browser_client.cc -o obj/apps/shell/browser/app_shell_lib.shell_extensions_browser_client.o In file included from ../../apps/shell/browser/shell_extensions_browser_client.cc:5: ../../apps/shell/browser/shell_extensions_browser_client.h:54:16:error: 'PermitExternalProtocolHandler' marked 'override' but does not override any member functions virtual void PermitExternalProtocolHandler() OVERRIDE; Original issue's description: > Fix the handling of user gestures for external protocol handler dialogs. > > - Remove browser state from external protocol handler. > - Use gesture with a timeout. > > BUG=173557 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261014 TBR=jyasskin@chromium.org,kalman@chromium.org,mmenke@chromium.org,joi@chromium.org,pkasting@chromium.org,jochen@chromium.org,boliu@chromium.org,meacer@chromium.org NOTREECHECKS=true NOTRY=true BUG=173557 Review URL: https://codereview.chromium.org/221283006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the handling of user gestures for external protocol handler dialogs.meacer@chromium.org2014-04-021-1/+2
| | | | | | | | | | | - Remove browser state from external protocol handler. - Use gesture with a timeout. BUG=173557 Review URL: https://codereview.chromium.org/131783012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261014 0039d316-1c4b-4281-b951-d872f2087c98
* Gather Prerender.AbandonTimeUntilUsed.davidben@chromium.org2014-03-274-10/+40
| | | | | | | | | | | The time between use and abandon, to determine if we can cut down that length a bit. BUG=356290 Review URL: https://codereview.chromium.org/211213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259889 0039d316-1c4b-4281-b951-d872f2087c98
* Add more stats about the use of cookies in prerenders.tburkard@chromium.org2014-03-196-5/+89
| | | | | | | | | | | For prerender cookie stats, also record whether cookie requests were for third party cookies, and whether those were for blocking resources. BUG=353678 R=asvitkine@chromium.org, davidben@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/203783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257969 0039d316-1c4b-4281-b951-d872f2087c98
* Disable one more failing test after the browser test harness improvements in ↵jam@chromium.org2014-03-181-0/+4
| | | | | | | | | | | r257597 until it's fixed. BUG=350550 TBR=sky Review URL: https://codereview.chromium.org/197493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257633 0039d316-1c4b-4281-b951-d872f2087c98
* Move CommandLine to base namespace.brettw@chromium.org2014-03-171-2/+5
| | | | | | | | | | | | Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Review URL: https://codereview.chromium.org/196413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
* Move clients of BrowserContextKeyedService to use KeyedService (#4)blundell@chromium.org2014-03-148-17/+16
| | | | | | | | | | | | | This change covers: - //components - Roughly half of the remaining clients in //chrome BUG=351704 TBR=jochen Review URL: https://codereview.chromium.org/198193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257067 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 05:50:33 +0000