| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
IPC message and are called by one or two places. Have the callers send the message instead. Also remove functions which dispatch an IPC only to call TabContents. Dispatch in TabContents instead.
Review URL: http://codereview.chromium.org/7037041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7051005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=83066
TEST=none
Review URL: http://codereview.chromium.org/7048001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
credentials.
Used this method in the browser. This will be used by the new login scheme for Cloud Print.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6969055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79524
TEST=Open a page with an embedded PDF, right click and print.
Review URL: http://codereview.chromium.org/6969031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
detailed information about the cloud print proxy. This is a first step towards the new login mechanism for Cloud Print.
BUG=None
TEST=Unit-tests, enabling disabling cloud print proxy
Review URL: http://codereview.chromium.org/7001012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
original tab.
BUG=none
TEST=Preview a webpage. Click 'Print' button. Observe the focus on the original tab.
Review URL: http://codereview.chromium.org/7004004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closed during rendering.
The error text contains a link to the original page so that the user can easily reload the page.
BUG=NONE
TEST=Open a large doc in print preview and close the initial tab before the preview is generated. Click on the displayed link.
Review URL: http://codereview.chromium.org/6976003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following are the primary changes:
1. Whenever a profile preference is registered, it must specify whether that
preference should be synced or not. Local state preferences do not require this.
However, we DCHECK that local state preferences are in fact registered to the
local state.
2. We've created a new sync model associator interface, which all datatypes
will eventually implement. This new model associator is designed to be
decoupled from much of the sync internals, and to be owned by the chrome service
being synced. It also implements most of the functionality previous handled by
the change processor.
3. The PrefService now owns its sync model associator
(pref_model_associator), which partially implements the new model associator
functionality. Further work will be done to remove the use of sync
transactions from the model associator, as well as to migrate other datatypes.
BUG=76232
TEST=
Review URL: http://codereview.chromium.org/6905044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79531
TEST=Print preview tab closes print button is pressed. Printing succeeds.
Review URL: http://codereview.chromium.org/6930034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than printer queue ids.
BUG=81488
TEST=Please refer to the test case specified in the issue.
Review URL: http://codereview.chromium.org/6935011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/6883278
BUG=none
TEST=included
TBR=kmadhusu
Review URL: http://codereview.chromium.org/6932061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/6883278
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/6930056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/6883278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since r83705, Value::GetAsDouble() can return an integer value as double. We no longer need to call Value::GetAsInteger() explicitly.
BUG=None
TEST=ran try
Review URL: http://codereview.chromium.org/6901084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
across platfroms.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6932021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81485
TEST=See bug description
Review URL: http://codereview.chromium.org/6925003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug description for more details.
BUG=79524
TEST=Navigate to a pdf. hit ctrl+p, the layout options should be disabled.
Review URL: http://codereview.chromium.org/6898055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6893124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable print preview flag. Preview a webpage. Select "Manage Printers..." in destination drop down list. Printer configuration dialog is displayed.
Review URL: http://codereview.chromium.org/6880283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
content\browser. I moved clipboard_dispatcher.* and content_restriction.h which should have moved originally.
Review URL: http://codereview.chromium.org/6893122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6904082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
message.
Review URL: http://codereview.chromium.org/6901104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6903098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dialog.
BUG=none
TEST=Enable print preview flag. Preview a webpage. Select the "Manage Printers..." option in the destination list. Native printer management dialog is displayed.
Review URL: http://codereview.chromium.org/6903083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80288
TEST=Bring up cloud print signing dialog, right click. No crash.
Review URL: http://codereview.chromium.org/6883203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80025
TEST=none
Review URL: http://codereview.chromium.org/6896055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79931
TEST=Enable print preview in linux. Preview a webpage. Set the color and duplex settings and print the data. Observe the output.
Review URL: http://codereview.chromium.org/6905007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the user selected pages.
BUG=none
TEST=Only a 3 page PDF, select page 3, print.
Review URL: http://codereview.chromium.org/6895015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72363
TEST=none
Review URL: http://codereview.chromium.org/6879125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new switch to Chrome that will delete the printed file once the print dialog finishes.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6882092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79523
TEST=Enable print preview flag. Preview a webpage. Close the initiator tab. Observe the disabled controls in preview tab.
Review URL: http://codereview.chromium.org/6881096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Counter-intuitively, in gtk_dialog_init(), they use g_signal_connect() to attach
a delete-event handler which calls gtk_dialog_respond with DELETE_EVENT, but
then they return FALSE to fall through to the default handler, which calls destroy. The
widget_hide_on_delete handler that we're using here is inserted after the dialog
delete-event handler, but before the default handler, thus overriding the destroy.
BUG=79764
TEST=manual
Review URL: http://codereview.chromium.org/6880078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
display error in the print preview tab on failure.
BUG=79945
TEST=UpdateSettings failures don't trigger DCHECKs.
Review URL: http://codereview.chromium.org/6878063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the printer.
BUG=79945
TEST=See bug.
Review URL: http://codereview.chromium.org/6878064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76124
TEST=Printed boarding pass using this code + print preview.
Review URL: http://codereview.chromium.org/6835008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes the crash bug which happens when right-clicking the keyboard
overlay or the print dialog.
BUG=chromium-os:14147
TEST=manually on the chrome notebook
Review URL: http://codereview.chromium.org/6879006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and path.
The suggested name is the title of the initiator tab. Also, the first time, the select file dialog opens on the "Documents" folder (or the equivalent for the current platform). In subsequent "Print To Pdf" sessions the last used folder is remembered.
BUG=NONE
TEST=In the print preview tab select "Print to PDF". The select file dialog box should be pre-populated. Also the second time you save to pdf, the suggested folder should be the one used right before.
Review URL: http://codereview.chromium.org/6759044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=76795
Review URL: http://codereview.chromium.org/6872003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserMain. This allows the print dialog to work even if chrome is already running.
BUG=
TEST=Run Chrome.exe normally then run a second copy with
--cloud-print-file="<some valid file>" Also, run chrome.exe with --cloud-print-file with no other chrome.exe running.
In both cases, the print dialog should display.
Review URL: http://codereview.chromium.org/6833012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6731022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6824086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
active_index. I plan on renaming more, but wanted to start with this
one.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6823064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Remove the NativeMetafileFactory since we can't just use preview flag.
+ Update each Metafile constructor site to use PreviewMetafile or NativeMetafileImpl.
+ Fix misc. problems blocking pdf generation on Windows.
+ Rename the metafile interface.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6826027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Printing on Linux still works.
Review URL: http://codereview.chromium.org/6811016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1/1.
(Note: This was a TODO for beng).
Also remove browser_window.h stub file as all the includes to it were already updated.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6820015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6805012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6689029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76795
TEST=none
Review URL: http://codereview.chromium.org/6780020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80050 0039d316-1c4b-4281-b951-d872f2087c98
|