summaryrefslogtreecommitdiffstats
path: root/chrome/browser/renderer_host
Commit message (Collapse)AuthorAgeFilesLines
* Fix test for valid UTF-16 input.evan@chromium.org2010-08-021-1/+1
| | | | | | | | | | | I got this wrong initially; Ningxin wrote a patch to fix it, which agl then also got wrong. So I am relanding Ningxin's original patch. Patch by Ningxin Hu <ningxin.hu@intel.com>. Review URL: http://codereview.chromium.org/3029048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54551 0039d316-1c4b-4281-b951-d872f2087c98
* Replace obsolete kProfile switch with kLoginProfilecmasone@google.com2010-08-021-2/+2
| | | | | | | | | BUG=50866 TEST=it compiles Review URL: http://codereview.chromium.org/3013050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54539 0039d316-1c4b-4281-b951-d872f2087c98
* Make prefetching default to disabledgavinp@google.com2010-08-011-1/+1
| | | | | | | | | | | | | | | | My earlier CL jumped the gun a bit; prefetching isn't ready to be the default, so this CL reverses that. Now you have to explicitly turn prefetching on to have it. Note that prefetching was never enabled in trunk: because I haven't yet flipped the build default for webkit to include prefetching, the command line flag had no effect on trunk chrome. BUG=none TEST=chrome --enable-prefetch http://gemal.dk/browserspy/prefetch.php Review URL: http://codereview.chromium.org/2847093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54485 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, Use the right variable to determine if linux is using breakpadnsylvain@chromium.org2010-07-311-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3074020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54477 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CrossSiteAfterCrash for official builds.nsylvain@chromium.org2010-07-311-3/+1
| | | | | | | | | We need to set expected_crashes_ when breakpad is set, because it does generate a crash dump, even on Linux. Review URL: http://codereview.chromium.org/3034042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54465 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-313-6/+6
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Implement prefetching in chromegavinp@google.com2010-07-311-1/+10
| | | | | | | | | | | | | | | | | | With this CL (see also issue 2910009), chrome will support basic prefetching. You can optionally deactivate prefetching with the command line argument --disable-prefetch. A new RequestPriority was created as well, IDLE, which is lower than LOWEST. Unfortunately, SPDY has only two bits for priority, so as a temporary measure (pending SPDY v3 which will have three), we have a mapping in SPDY that folds net::LOWEST and net::IDLE together. BUG=13505 TEST=http://gemal.dk/browserspy/prefetch.php Review URL: http://codereview.chromium.org/3050016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54421 0039d316-1c4b-4281-b951-d872f2087c98
* Asynchronously open the temp file used for Pepper StreamToFile, and delete thedarin@chromium.org2010-07-302-17/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | temp file once we are done with it. We observe ResourceHandle::OnRequestClosed as a signal of when we should delete the temp file. This corresponds to the WebURLLoader being closed (or canceled). This patch also includes some helpers: base/scoped_callback_factory.h This class makes it easy to allocate Callbacks that hold a weak reference back to the owning class. It works just like ScopedRunnableMethodFactory but for Callbacks instead of RunnableMethods. base/platform_file.h Added a PassPlatformFile class that is useful for cases where a callback may decide not to take ownership of a PlatformFile (as can happen when using ScopedCallbackFactory). chrome/file_system_proxy.{h,cc} This class provides static methods for executing file system commands on the FILE thread. It routes callbacks back to the originating thread to deliver results (file handles, etc.). Note: this file declares a few functions that are not yet used. I anticipate that we'll make use of these and add more functions here to support the Pepper and OWP FileSystem APIs. chrome/chrome_thread_relay.{h,cc} This class is a helper class for proxying calls over to a background ChromeThread and then returning results to the originating ChromeThread. R=brettw BUG=49789 TEST=(more to be added in third_party/ppapi/tests) Review URL: http://codereview.chromium.org/2878062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54402 0039d316-1c4b-4281-b951-d872f2087c98
* Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1satish@chromium.org2010-07-301-0/+1
| | | | | | | | | | | | | | | | | | Flip the compile-time enable switch for speech input to on and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side and in WebKit via WebRuntimeFeatures. This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146 BUG=none TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.* Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54235, but reverted due to tests failure. Review URL: http://codereview.chromium.org/3064017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54389 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of easy AppendSwitchWithValue to *ASCII.evan@chromium.org2010-07-301-6/+6
| | | | | | | | | For this patch, I skipped over any instance where it wasn't a nearly trivial change. Review URL: http://codereview.chromium.org/3069014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1"evan@chromium.org2010-07-301-1/+0
| | | | | | This reverts commit r54235. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54249 0039d316-1c4b-4281-b951-d872f2087c98
* Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1satish@chromium.org2010-07-301-0/+1
| | | | | | | | | | | | | | | | Flip the compile-time enable switch for speech input to on and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side and in WebKit via WebRuntimeFeatures. This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146 BUG=none TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.* Review URL: http://codereview.chromium.org/3064017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54235 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: add a CopySwitchesFrom() and AppendSwitchPath()evan@chromium.org2010-07-291-14/+6
| | | | | | | | | | | These are two common patterns in Chrome code: copying a subset of switches from one CommandLine to another, and appending a FilePath to a CommandLine. This sets me up to do a lot more deprecation in a follow-up change. Review URL: http://codereview.chromium.org/3012021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54218 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-293-18/+28
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-293-5/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Display a right-aligned generic CC icon in the suggestions popup forjhawkins@chromium.org2010-07-282-0/+8
| | | | | | | | | | | billing suggestions. BUG=50080 TEST=none Review URL: http://codereview.chromium.org/3071003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54052 0039d316-1c4b-4281-b951-d872f2087c98
* Support both preconnection, and pre-resolution for subresourcesjar@chromium.org2010-07-281-2/+5
| | | | | | | | | | | | | | | With this change, both preconnection and preresolution are enabled when the --enable-preconnection flag is turned on. I'm expecting to enable this feature by default soon, so as to better tune the parameters. BUG=42694 r=mbelshe Review URL: http://codereview.chromium.org/3032014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54044 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Fix some presubmit errors.tfarina@chromium.org2010-07-281-3/+3
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3026031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54020 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Move click-to-play behind the --enable-click-to-play switch.bauerb@chromium.org2010-07-281-0/+1
| | | | | | | | | BUG=50086 TEST=none Review URL: http://codereview.chromium.org/3074005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53924 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stream to file implementation.darin@chromium.org2010-07-284-0/+265
| | | | | | | | | | | | | This patch excludes one important detail. This code does not cleanup temp files yet. That will be added in a subsequent CL. R=brettw BUG=49789 TEST=third_party/ppapi/tests/test_url_loader.cc:TestStreamToFile Review URL: http://codereview.chromium.org/2806079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53923 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit tests for the ResourceDispatcherHost.darin@chromium.org2010-07-271-1/+2
| | | | | | | | | | | | | | | A field of the ViewHostMsg_Resource_Request structure was uninitialized. Also, includes a fix for an ASSERT_EQ that listed the expected value second instead of first. R=oshima BUG=50002 TEST=none Review URL: http://codereview.chromium.org/3052014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53820 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup:phajdan.jr@chromium.org2010-07-272-9/+9
| | | | | | | | | | | | | | - make the code more object-oriented, make the object expose less accessors - make some parts of code look more obvious, use existing helpers - make the public interfaces slightly better (less ctor parameters) - make some names slightly better TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3029025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53808 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame cookie requests would incorrectly get routed to the first host ↵ananta@chromium.org2010-07-272-113/+142
| | | | | | | | | | | | | | browser connected to the renderer. This basically meant that if the browser process exited then other popups could not query cookies from the host. Part of the fix for http://b/issue?id=2277519 Bug=2277519 Review URL: http://codereview.chromium.org/3066004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53757 0039d316-1c4b-4281-b951-d872f2087c98
* Fix acquisition of thumbnail images on Linux.scherkus@chromium.org2010-07-271-2/+2
| | | | | | | | | | Patch by jwillcox@litl.com: http://codereview.chromium.org/2904010/show BUG=48066 TEST=Load a page from new tab page, then ensure the thumbnail is updated by viewing the new tab page again git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53721 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2656-0/+56
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Use FRIEND_TEST_ALL_PREFIXES some more.phajdan.jr@chromium.org2010-07-261-2/+2
| | | | | | | | | TEST=compile BUG=44549 Review URL: http://codereview.chromium.org/3032025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors.ziadh@chromium.org2010-07-242-1/+43
| | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar Review URL: http://codereview.chromium.org/2856051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity issues 11559, 9326, 9325, 9317: Uninitialized members in ↵finnur@chromium.org2010-07-233-5/+14
| | | | | | | | | | | browser/render_host/* BUG=None (Coverity issue id listed above) TEST=None Review URL: http://codereview.chromium.org/2811067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53541 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-232-13/+8
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix a collection of uninitialized member variables, mostly in ↵finnur@chromium.org2010-07-231-1/+2
| | | | | | | | | | | | | | | | | | | | | extensions code, but some random ones outside extensions code as well. dhollowa : issue 11558: render_view_host.cc rafaelw : issue 11055: extension_browser_event_router.cc mirandac : issue 9443: profile_import_thread.cc estade : issue 9321: info_bubble_gtk.cc phajdan.jr: issue 8308: extensions_service_unittest.cc phajdan.jr: issue 8309: extensions_service_unittest.cc asargent : issue 8307: extension_browsertest.cc asargent : issue 7610: extension_browser_actions_api.h rafaelw : issue 2289: extension_function.cc BUG=None (Coverity issue id listed above) TEST=None Review URL: http://codereview.chromium.org/2832070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53451 0039d316-1c4b-4281-b951-d872f2087c98
* Continual header pruningerg@google.com2010-07-221-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3029019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53391 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53342 - Switch back to disabling Core Animation for Flash (for branch ↵stuartmorgan@chromium.org2010-07-221-1/+1
| | | | | | | | | | | | | | | | merge). This goes back to the M5 logic for managing Flash model negotiation on the Mac. BUG=49169 TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show. Review URL: http://codereview.chromium.org/3044015 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/2832074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53351 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back to disabling Core Animation for Flash (for branch merge).stuartmorgan@chromium.org2010-07-221-1/+1
| | | | | | | | | | | This goes back to the M5 logic for managing Flash model negotiation on the Mac. BUG=49169 TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show. Review URL: http://codereview.chromium.org/3044015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53342 0039d316-1c4b-4281-b951-d872f2087c98
* Add --enable-device-orientation switch and set ENABLE_DEVICE_ORIENTATION=1hans@chromium.org2010-07-221-0/+1
| | | | | | | | | | | | | | | Flip the compile-time enable switch for device orientation to on, and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side, and in WebKit via WebRuntimeFeatures. BUG=44654 TEST=browser_tests --gtest_filter=DeviceOrientationEnableSwitchTest.* Review URL: http://codereview.chromium.org/3042009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53317 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled zoom controls in the browser when displaying PDF using the internal ↵sanjeevr@chromium.org2010-07-223-0/+11
| | | | | | | | | | | | PDF plugin. We want to persist zoom state for PDF separately from the zoom state for other content. As a stopgap measure, disabled all browser zoom controls in that scenario. BUG=None TEST=Test zooming when displaying a PDF using the Chrome PDF plugin. Then load or switch to another page (non-PDF) and check that zoom works. Review URL: http://codereview.chromium.org/3007009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53294 0039d316-1c4b-4281-b951-d872f2087c98
* Start trimming headers included in the slowest to compile files.erg@google.com2010-07-214-10/+22
| | | | | | | | | | | Big chunk in the automation code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53246 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SSLClientAuthHandler and certificate selectiondavidben@chromium.org2010-07-213-0/+73
| | | | | | | | | | | | | | | | | | | | | | | | | This cleans up much of the code involved in displaying a certificate selection dialog to the user. - Adds a new inner class to RenderViewHostDelegate (later to be populated with more SSL things). - Adds a helper class for TabContents' implementation. - Moves the certificate dialogs themselves to have a common entry point. - Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the TabContents implementation displaying the dialogs. - Picks the correct parent window for the dialog on all platforms, instead of relying on BrowserList::GetLastActive - Makes the OS X implementation use an asynchronous sheet, now that we know the parent. - Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity. R=agl,brettw,mark BUG=148 TEST=selecting client certificates still works Review URL: http://codereview.chromium.org/2823038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53231 0039d316-1c4b-4281-b951-d872f2087c98
* Changed type CookieList to being a vector CanonicalCookies.rdsmith@google.com2010-07-211-5/+1
| | | | | | | | | | | Originally, it was a vector of pair<domain_string, CanonicalCookie>. TEST=Refactor; all relevant unit tests should still pass. BUG=8850 Review URL: http://codereview.chromium.org/2799057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53184 0039d316-1c4b-4281-b951-d872f2087c98
* Make ResourceDispatcherHostRequestInfo own SSLClientAuthHandler and ↵davidben@chromium.org2010-07-202-14/+17
| | | | | | | | | | | | | | | | | | LoginHandler references This avoids problems where the objects disappear while the ResourceDispatcherHostRequestInfo still holds pointers. In particular, SSLClientAuthHandler handler adds and removes a reference to itself when the user dismisses the dialog. ResourceDispatcherHost, however, still holds a pointer and may attempt to notify it of a cancelled request. This stray write may NULL out a useful field and crash. BUG=49352 TEST=steps in bug report Review URL: http://codereview.chromium.org/3043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash observed in ChromeFrame reliability test runs. The crash ↵ananta@chromium.org2010-07-201-4/+10
| | | | | | | | | | | | | | | | | occurs while processing the ViewHostMsg_UpdateRect message and occurs due to dereferencing a NULL view_ pointer. It looks that the view_ pointer got destroyed and effectively NULL'ed out in the context of the call to the MovePluginWindows function. Fix is to add a NULL check for the same. Fixes bug http://code.google.com/p/chromium/issues/detail?id=39356 Bug=39356 Review URL: http://codereview.chromium.org/3043009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53078 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Implement ViewID support. (third approach)suzhe@chromium.org2010-07-201-0/+5
| | | | | | | | | | | | | | | | This CL adds several extension methods to NSView class for ViewID support, and uses a map to store ViewIDs of views. Each view requiring ViewID support can set its ViewID upon initialization and unset it before destruction. When looking up a view with a specific ViewID, just search all sub views recursively from the root view of a window. BUG=44692 need ViewIds on mac TEST=none Review URL: http://codereview.chromium.org/2878037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53067 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Several functional fixes:jhawkins@chromium.org2010-07-201-3/+17
| | | | | | | | | | | | | * Don't fill CC data on non-HTTPS pages. * Don't display non-unique suggestions in the popup. * Fix displaying the 'AutoFill Options' suggestion (was a regression). BUG=48499 TEST=none Review URL: http://codereview.chromium.org/3040004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52980 0039d316-1c4b-4281-b951-d872f2087c98
* Let PaintAtAck send an int tag instead of the TransportDIB handle.thakis@chromium.org2010-07-194-18/+17
| | | | | | | | | | | TransportDIB handles are file descriptors on mac, which are duped when sent over IPC. Hence, they change their value, and the handle that comes back over IPC is not the same that was originally sent -- so they can't be used as map keys. BUG=none TEST=none Review URL: http://codereview.chromium.org/3037006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52925 0039d316-1c4b-4281-b951-d872f2087c98
* Remove incorrect usages of USE_SYSTEM_SQLITE.tfarina@chromium.org2010-07-191-6/+1
| | | | | | | | | | | | | Currently we don't provide any support to the system sqlite. BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3049001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52879 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit r52848 - Option-click to download should not display "Save As" UI.jeremy@chromium.org2010-07-184-2/+9
| | | | | | Review URL: http://codereview.chromium.org/2825056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52850 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r52848 - Linux x64 compile failure.jeremy@chromium.org2010-07-184-9/+2
| | | | | | Review URL: http://codereview.chromium.org/3012008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52849 0039d316-1c4b-4281-b951-d872f2087c98
* Option-click to download should not display "Save As" UI.jeremy@chromium.org2010-07-184-2/+9
| | | | | | | | | | | | | | | | | | | | | The download manager has a concept of a request originating from the "Save As..." contextual menu v.s. a direct download request from the renderer, however this was't hooked up. The Download Manager uses boolean variables named "save_as" in various locations to track whether a download originated via a contextual menu selection (in which case the save panel should be displayed) or via a renderer request (in which case no UI should be displayed). This CL contains 3 distinct changes: 1. DownloadFileManager::OnDownloadURL() is where downloads originating from the contextual menu are dispatched, set save_as to true if the download starts here. 2. ResourceMessageFilter::OnDownloadURL() is where downloads originating from the renderer are dispatched (e.g. option-click), don't display UI for these. 3. The "save_as" variable in the DownloadCreateInfo structure doesn't really reflect the origin of the request but whether the Save panel should be displayed. This can happen for example on a name collision or if the default download location isn't writeable regardless of the action that initiated the download. Renamed the variable and added documentation to this effect. BUG=36775 TEST=Option-click an image, the image should be saved without prompting the user for a download locate. Save an image via the "Save As..." context menu, you should be prompted for the save location. Review URL: http://codereview.chromium.org/2927006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52848 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IsSearchProviderInstalled and a test for it.levin@chromium.org2010-07-174-0/+24
| | | | | | | | | | | | | It is currently off by default and one must pass in a flag (--enable-search-provider-api-v2) to use it. Api details are in the bug. BUG=38475 TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled Review URL: http://codereview.chromium.org/2823042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52778 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 20:05:59 +0000