chromium_src.git - central chromium sources

	Commit message (Collapse)	Author	Age	Files	Lines
*	Delete obviously unneeded forward declarations in chrome/browser/*.h.	viettrungluu@chromium.org	2010-08-05	1	-1/+0
\| \| \| \| \| \| \| \| \|	BUG=none TEST=builds Review URL: http://codereview.chromium.org/3080031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55037 0039d316-1c4b-4281-b951-d872f2087c98
*	`#pragma once` for app, base, chrome, gfx, ipc, net, skia, views	thakis@chromium.org	2010-07-26	1	-0/+1
\| \| \| \| \| \| \| \| \|	BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
*	Ensure proper teardown of repost form warning objects.	bauerb@chromium.org	2010-04-14	1	-4/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make sure a repost form warning is closed properly even when the constrained window is closed from underneath us. To do this, its controller now calls \|Cancel\| in its destructor. We now have a potential cycle of methods calling each other: * \|RepostFormWarningController::CloseDialog\| closes the \|ConstrainedWindow\|. * This eventually calls \|RepostFormWarningWin::DeleteDelegate\|, which destroys \|RepostFormWarningWin\| and \|RepostFormWarningController\|. * In its destructor, \|RepostFormWarningController\| calls \|Cancel\|, which calls \|CloseDialog\|. Therefore, there are some checks in place to make sure we do everything during the teardown exactly once: * After calling \|NavigationController::CancelPendingReload\|, we set \|tab_contents\| to null to make sure we don't call it again. * During destruction, we set \|window_\| to null to make sure we don't call \|CloseConstrainedWindow\| again. BUG=41367 TEST=RepostFormWarningTest.* Review URL: http://codereview.chromium.org/1530032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44481 0039d316-1c4b-4281-b951-d872f2087c98
*	Refactor common, platform-independent code for the repost form warning ↵	bauerb@chromium.org	2010-04-09	1	-0/+53
	dialog on all platforms into a delegate. The platform-dependent ConstrainedWindow{Gtk,Mac,Win} classes each have their own platform-dependent \|ConstrainedWindowDelegate\| to inherit from, so instead of a common superclass they now have a RepostFormWarningDelegate. Also, change the RELOADING notification to REPOST_WARNING_SHOWN to avoid trying to close the dialog while it's already in the process of being closed. BUG=none TEST=RepostFormWarningTest.* Review URL: http://codereview.chromium.org/1520023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44074 0039d316-1c4b-4281-b951-d872f2087c98