summaryrefslogtreecommitdiffstats
path: root/chrome/browser/resource_dispatcher_host.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix for 1498134, possible crash when cancelling a url request. Thesky@google.com2008-11-251-2/+21
| | | | | | | | | | | | | | crash happened because OnReadCompleted would invoke CompleteRead which might invoke CancelRequest and delete the request. If this happened when control returned back to OnReadCompleted the request was deleted, yet ResourceDispatcherHost assumed it wasn't. BUG=1498134 TEST=none Review URL: http://codereview.chromium.org/12602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5989 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r5252 temporarily to see if it is related to thewtc@google.com2008-11-221-10/+1
| | | | | | | | | | crash in ResourceDispatcherHost::OnReadCompleted. R=eroman BUG=b/1498134 Review URL: http://codereview.chromium.org/11584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5881 0039d316-1c4b-4281-b951-d872f2087c98
* Fix erase method usage on STL containers in Chrome. Invoking erase on the ↵ananta@chromium.org2008-11-151-1/+1
| | | | | | | | | | iterator renders it invalid. We were continuing to use this iterator. R=darin Review URL: http://codereview.chromium.org/10925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5531 0039d316-1c4b-4281-b951-d872f2087c98
* Add Terminate() to the Process object, have RenderProcessHost use this to ↵brettw@google.com2008-11-141-5/+7
| | | | | | | | | | avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Review URL: http://codereview.chromium.org/10895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
* Update the user delay histogram for the SafeBrowsing.paulg@google.com2008-11-141-3/+3
| | | | | | Review URL: http://codereview.chromium.org/10916 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5434 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure ResourceDispatcherHost properly cleans up a cancelledsky@google.com2008-11-121-1/+10
| | | | | | | | | | | | | | | | | | | request that is not in a pending state. When we cancel a URLRequest with no pending IO, nothing happens. This means ResourceDispatcherHost doesn't clean up its maps and delete the URLRequest. Another possibility for fixing this is to invoke OnResponseCompleted, but as the request isn't really completed that may cause other bad things. Let me know if you think this should be fixed in another way. BUG=4302 TEST=see bug Review URL: http://codereview.chromium.org/10814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5252 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-0/+4
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem where "text/xml" responses get buffered past 512 bytes, causing ↵ericroman@google.com2008-10-171-0/+1
| | | | | | | | | | the response to be truncated. BUG=3521 Review URL: http://codereview.chromium.org/7610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3567 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-171-16/+198
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-101-0/+1
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Save Page code to the browser/download/ directory.paulg@google.com2008-09-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-131-2/+2
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid starting the pause timer if it is already started.darin@chromium.org2008-09-111-2/+3
| | | | | | | | R=sky Review URL: http://codereview.chromium.org/2443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2083 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CHECK in a memcpy that it is not trivial to understand.cpu@google.com2008-09-091-3/+3
| | | | | | Review URL: http://codereview.chromium.org/1630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1883 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify OneShotTimer and RepeatingTimer. Fix up all consumers.darin@google.com2008-08-281-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | Major changes: OneShotTimer and RepeatingTimer become template classes that no longer require a Task or a Timer object. They just use PostDelayedTask. Under the hood that still uses a Timer object. The API is much simpler for consumers as they now no longer need to worry about allocating a Task or managing the lifetime of the object pointer held by the Task. I added some new unit tests to timer_unittest.cc to cover the API. I preserved the old TimerManager / Timer API for now, but I plan to soon kill it. R=brettw BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1502 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the profiling system. This wasn't being used and complicated some ↵brettw@google.com2008-08-251-4/+0
| | | | | | parts of the code (I'm trying to clean up WebContents). We can ressurect this if we have a better plan for doing profiling that needs to live in the browser. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1341 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* A bunch of cleanups to beforeunload/unload handling.ojan@google.com2008-08-021-4/+2
| | | | | | | | 1. Remove all the is_closing_browser plumbing. WebContents/TabContents/RenderViewHost/etc really shouldn't (and don't!) need to know anything about whether we're closing the browser or not. 2. Refactor the handling of beforeunload/unload state in browser.cc. I think this makes it considerably easier to reason about the correctness of it. 3. Added a couple TODOs for future cleanups that would have made this change a bit too large. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the infinite read loop that can occasionally allowpaulg@google.com2008-08-011-8/+20
| | | | | | | | | | | | | | | | | | | | a large, fast network request to monopolize the IO thread. This particular bug was tickled by an FTP download where pause tasks posted to the IO thread from the UI thread were blocked from running until the FTP transfer was completed, leading to user noticeable jankiness. I added histograms to the previous read loop and noticed that during regular browsing and downloading sessions, the number of times the loop was traversed was 1 for something like 99.5% of the time. This leads me to believe that eliminating the read loop in favor of asynchronous tasks will not impact performance. BUG=1270179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212 0039d316-1c4b-4281-b951-d872f2087c98
* Move more net classes into the net namespace. Also remove the net_util ↵darin@google.com2008-07-311-1/+1
| | | | | | | | namespace in favor of the net namespace. This is a purely mechanical change. There should be no logic changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more classes from net/base into the net:: namespace.darin@google.com2008-07-301-6/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+2324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 21:06:07 +0000