| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=42072
TEST=manual tetsting, existing automated tests
Review URL: http://codereview.chromium.org/1631029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42075
TEST=manual testing
Review URL: http://codereview.chromium.org/1627029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1045003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes a bug where we could end up with two sets of buttons after a reload.
BUG=37804
TEST=Go into edit mode and select and deselect a bunch of entries. The disabled state of the remove button should be in sync.
Review URL: http://codereview.chromium.org/815001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35338
TEST=none
Review URL: http://codereview.chromium.org/660283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The history page renders each set of history results incrementally. It adds any
results it gets back to the views "currentPages_" array. On any following
search query result it will go through and render the entire currentPages_
array. This sets an isRendered flag on any pages that have already been
rendered.
This method is already used in the regular history service response.
BUG=35933
TEST=In a profile with a few months of history, search for something unique that
only would show up once.
Review URL: http://codereview.chromium.org/668007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of wiping out the page multiple times.
Code review 501044
BUG=30020
TEST=Navigate through history to make sure it still works. On windows, have a spares history with multiple days, and click one of the first entries while the rest are still loading and make sure the click is not lost.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Landing for eisinger.
BUG= 21459
TEST= On history page, font for delete day msg is correct, and you can tab to it.
Review URL: http://codereview.chromium.org/473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Committing for feldstein.
BUG= 21459
TEST= History tab on mac should show correct font in "delete day" message.
Review URL: http://codereview.chromium.org/460148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Search downloads" pages.
BUG= http://crbug.com/17892
TEST= Open history / downloads page. Search for "<h1>HI</h1>". Note that the HTML is not interpreted, but displayed as text.
Review URL: http://codereview.chromium.org/201129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9591
TEST=Go to the history page and make sure that "Delete history for this day"
still works and that it does not allow opening the "link" in a new window.
Review URL: http://codereview.chromium.org/155892
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimized for the way we do internationalization with JST before
and is about 4 times faster (average 4.8ms vs 22.8ms) for the history
page.
The syntax for this is very similar to JsTemplates. It uses the
attributes i18n-values and i18n-content which worls like jsvalues and
jscontent except that it does not allow arbitrary expressions.
BUG=None
TEST=All UI pages should work as before
Review URL: http://codereview.chromium.org/149420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Make sure that localized text on NTP, History and Downloads still
look the same.
Review URL: http://codereview.chromium.org/125076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entry titles or by making the window narrow enough to truncate the
text.
BUG=9712
TEST=Bookmark a page and go to the history page. Resize the window so
that it is narrow enough to truncate the entry title of the page you
just bookmarked. You still be able to see the star icon.
Review URL: http://codereview.chromium.org/113434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
keeping the value from the previous rule. The default value for
background-position-y is center if not specified.
http://crbug.com/11549
Review URL: http://codereview.chromium.org/113059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
strings to using the url_constant (shipshipship).
Users (such as those on Beta and Dev using session restore) attempting to load the old pages will see a blank white screen.
BUG=11272
TEST=Verify that the inspector, debugger, history, downloads and newtab pages load with chrome:// URLS. Verify that replacing the chrome:// with chrome-ui:// does not work.
Review URL: http://codereview.chromium.org/101026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use HTML5 placeholder instead of js code for the text input place holders.
Use HTML5 doctype in all html files.
Skip optional type in script and style tags.
Some small optimizations in LocalStrings.
Review URL: http://codereview.chromium.org/88072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
escape spaces, so we have to do some manual fiddling to make searches that have come from the New Tab Page work (see GetHistoryURLWithSearchText).
BUG=9940
TEST=Verify that searches from the new tab page and from the history page result in the same search query appearing in the history results page.
Review URL: http://codereview.chromium.org/67249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
history.
It also adds code to inline the resources for <link rel="icon"> elements
BUG=9805
Review URL: http://codereview.chromium.org/66041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI.
For some Indian languages (Malayalam, Bengali and Telugu), we have to
use a bigger size and a font family for that script on Windows.
This is because Windows' stock fonts for those scripts are smaller
than fonts for other scripts at a given size.
I removed 'WEB' style in chrome_font.h because it's not used anywhere any more
after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is
recycled to localize the font family (or the list of font families) for html UI.
I also back-ported the support for setting 'style.fooBar' property to our copy
of Jstemplate (JstProcessor.prototype.jstValues_).
BUG=7319
Review URL: http://codereview.chromium.org/57025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
middle of nowhere.
- Fix history text-wrapping issues.
BUG=8147
Review URL: http://codereview.chromium.org/56001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8334
Review URL: http://codereview.chromium.org/42544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would happen for an URLs that contained parens. These need to be
escaped when using in CSS.
BUG=none
TEST=Go to a page that has parens in it (such as
http://en.wikipedia.org/wiki/The_Wire_(season_5) ). Then open up
history and make sure you get a favicon for the site.
Review URL: http://codereview.chromium.org/48043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Issue was that EscapeQueryParamValue is equivalent to encodeURIComponent(), not escape()
BUG=8346
Review URL: http://codereview.chromium.org/42215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current day we would never show any results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Stop losing first-searches on history page due to
BUG=8438,8456
Review URL: http://codereview.chromium.org/43054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
called multiple times. We need to add UI to make what's happening clearer to the user, but this gets us over the hump for now. Also change the history page to queue deletions.Allow history search from the new tab page.Make history title inclusion safer (createTextNode changes).Show starred status on history page.BUG=8214,8163,8271,8284
Review URL: http://codereview.chromium.org/28308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
NewTabUI is only included on OS(WIN) because DOMUI doesn't appear to have been ported.
Review URL: http://codereview.chromium.org/28104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Speed up history viewing by swapping the search depth to day rather than month - it's now orders of magnitude faster for people who visit more than 30 pages a day, and very slightly slower for people who visit less than 10 pages a day.
Review URL: http://codereview.chromium.org/21182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Review URL: http://codereview.chromium.org/13183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
|