| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=136924
TEST=
Review URL: https://chromiumcodereview.appspot.com/10693159
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10802076
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@147901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=137690
TEST=
Review URL: https://chromiumcodereview.appspot.com/10778041
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10796094
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@147898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=136924
TEST=
Review URL: https://chromiumcodereview.appspot.com/10693159
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10806059
TBR=abodenha@google.com
Review URL: https://chromiumcodereview.appspot.com/10808085
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@147896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=136924
TEST=
Review URL: https://chromiumcodereview.appspot.com/10693159
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10806059
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@147764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=134242
TEST=
Review URL: https://chromiumcodereview.appspot.com/10661008
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10689049
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@144981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=133514
TEST=
Review URL: https://chromiumcodereview.appspot.com/10663007
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10689045
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@144920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=133514
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10657010
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10698050
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@144918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=133514
TEST=
Review URL: https://chromiumcodereview.appspot.com/10560040
TBR=rltoscano@google.com
Review URL: https://chromiumcodereview.appspot.com/10579047
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@143207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10560039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Escape key is used to be handled by JS-side in each dialog implementation. This CL removes JS code and change to handle Escape key by C++-side in constrained window implementation globally.
This CL is based with based on http://crrev.com/127012 (reverted).
BUG=119684
TEST=manual, trybots pass on win and linux_chromeos
Review URL: https://chromiumcodereview.appspot.com/10446076
TBR=yoshiki@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10558030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Escape key is used to be handled by JS-side in each dialog implementation. This CL removes JS code and change to handle Escape key by C++-side in constrained window implementation globally.
This CL is based with based on http://crrev.com/127012 (reverted).
BUG=119684
TEST=manual, trybots pass on win and linux_chromeos
Review URL: https://chromiumcodereview.appspot.com/10446076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10559022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10562024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10555014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10565011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10532163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10532165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132899
TEST=Make sure the "Print with Google Cloud Print" link appears when a cloud printer is selected. This link should be permanently visible on ChromeOS.
Review URL: https://chromiumcodereview.appspot.com/10543169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
preview race condition.
BUG=132824
TEST=
Review URL: https://chromiumcodereview.appspot.com/10535183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131337
TEST=
Review URL: https://chromiumcodereview.appspot.com/10559006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10543167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=131327
TEST=
Review URL: https://chromiumcodereview.appspot.com/10545181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10495009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=125688
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10533133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Makes icon in the print_preview.DestinationSettings widget small (32px -> 24px).
* Fixes vertical align of destination name when no location shown
* Adds throbber that is shown while first destination is loading
* Fixes title of destination search widget
* Fixes cropping issue on animated settings
BUG=131848
TEST=
Review URL: https://chromiumcodereview.appspot.com/10542141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10535122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10540112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cloud print destinations can be offline or dormant. This CL implements some UI treatment of those printers in the search widget.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10491003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=128275
TEST=
Review URL: https://chromiumcodereview.appspot.com/10480002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10458067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=114206
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10456063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
drop-down element.
BUG=114206
NOTRY=true
TEST=Use the print preview dialog to switch printers before printing. Also sign-in with a Google Account to gain access to Google Cloud Print Printers.
Review URL: https://chromiumcodereview.appspot.com/10450022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103688
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10444043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder. Some of the classes in the "data" folder are event targets that dispatch events when their state changes. UI widgets listen to these state changes and update their UI accordingly. The two most important "data" classes are PrintTicketStore and DestinationStore. These two manage the state of the print ticket (aka print settings) and the list of all of the print destinations respectively.
The UI widgets are divided into top-level components, settings components, and previewarea components.
Top-level components just include the outer most container widget (called PrintPreview) which handles global events and PrintHeader which renders the print and cancel buttons and some statistics on the document. If you were to start reviewing, PrintPreview is where I would start.
Settings components include all of the UI widgets that can be used to change the state of the PrintTicketStore. They live in the "settings" folder and include "CopiesSettings" and "PageSettings".
Preview area components include all of the UI widgets involved on the main part of the preview UI. PreviewArea and CustomMargins are the two main widgets in the "previewarea" folder.
It's important to note that almost all of the UI widgets have a dependency on PrintTicketStore. Crucially, this allows all UI widgets to be independent from each other and just depend on a common object.
Previously, the state of the print ticket (aka print settings) were distributed in the various UI controls. For example, custom margins were stored both in the preview area and in the margin settings and when it came time to print, these UI components had to be queried for that information, or the question on whether to show the header-footer setting depended on the state of the preview area. Now the state is consolidated into PrintTicketStore. This allows modification of each of the UI widgets without the worry of breaking other widgets.
BUG=114206
TEST=
Review URL: https://chromiumcodereview.appspot.com/10108001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
copied relevant style rules to print_preview.css
BUG=103688
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10408074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85132
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10083060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This page was visible when you manually navigated to chrome://print. I don't
think that we should care about that use case. Visiting chrome://foo for
arbitrary foo is undefined: it may show an error page, or a malformed page. For
example, chrome://extensions-frame/strings.js will show a snippet of JavaScript,
while chrome://crash will show a sad tab and chrome://foobar just shows an
error. With this change, chrome://print will show an error unless print preview
has already been validly opened, in which case it will show a broken print
preview page. It would be nice to fix the latter point, but chrome data sources
are too limited. (The code before which controlled when to show the dummy
page was flawed because dummy data sources could replace non-dummy sources while
a valid print preview was still showing, and vice versa. The dummy page also had
some visual glitches as a result of not being kept up-to-date, which indicates
that few people knew or cared about it.)
I think that in the past showing a somewhat broken page would have been more of
a problem because of session restore or manual attempts to copy-paste the URL.
Now that print preview is shown in a constrained dialog, there is no URL bar,
no way to restore a print preview tab, and no temptation to type
"chrome://print" in the omnibox.
BUG=none
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10386133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:29684
TEST=
Review URL: http://codereview.chromium.org/10178010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:29684
TEST=Manual test.
Review URL: http://codereview.chromium.org/10155030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122878
TEST=Verify 122878
Review URL: http://codereview.chromium.org/10048009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rules in widget.css.
BUG=122505
TEST=Text in margin boxes should be white.
Review URL: https://chromiumcodereview.appspot.com/10031010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122018
TEST=No presubmit errors
Review URL: http://codereview.chromium.org/9980021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=120369
TEST=Stuff still works, chrome/browser/resources/PRESUBMIT.py is happy.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/9958101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This CL does not convert gray #hex colors to rgb() as this is optional.
BUG=120369
TEST=Nothing breaks, chrome/browser/resources/PRESUBMIT.py is happy.
Review URL: https://chromiumcodereview.appspot.com/9923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
touch-optimized is the only attribute still being used. For shared css, I changed the mechanism so that pages will transparently get the correct CSS rather than needing to make a js call. For individual pages (i.e. the options page), I left the js call because a page author who includes special CSS can reasonably be expected to realize this call is necessary.
I deleted some touch CSS that looked stale and/or unused.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/9836095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=118298
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9794016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119771
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9845028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119170
TEST=See bug description.
Review URL: https://chromiumcodereview.appspot.com/9811018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104080
TEST= Please refer to bug report.
Review URL: http://codereview.chromium.org/9699040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116275
TEST=see bug.
Review URL: http://codereview.chromium.org/9663037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126217 0039d316-1c4b-4281-b951-d872f2087c98
|