| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
to access a download that no longer exists.
Review URL: http://codereview.chromium.org/2844040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes: Add another view with IndexedDB details to CookieDetailsView.xib.
BUG=56248
TEST=CookiesTreeModelTest.*:CookiesDetailsTest.*:CookiesViewTest.*:
Review URL: http://codereview.chromium.org/3429020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
same page was uninstalled.
BUG=56454
TEST=Install one app, then another. Uninstall the first one.
Second one's install animation should not replay.
Review URL: http://codereview.chromium.org/3396021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an issue where the text would be unreadable with certain themes
installed.
BUG=45971
TEST=see bug for repro steps
Review URL: http://codereview.chromium.org/3497002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and apps data. This improves performance and avoids
flickeryness.
BUG=56278
TEST=Install some apps and refresh the ntp over and over.
Should not see flickering as mv section, then apps load.
Review URL: http://codereview.chromium.org/3474006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sections if both sections were shown under the old version
of the ntp.
Also clean up some old cruft.
BUG=55610
TEST=Upgrade Chrome from an older version to a version with
this change with at least one app installed. Should see only
apps section. Do it with no apps installed, should see only
MV section.
Review URL: http://codereview.chromium.org/3393013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And bump up CppVariant::ToStringVector limit from 100 to 60000 so that we can pass more arguments through chrome.send.
BUG=chromium-os:6827
TEST=Verify proxy setting values entered are sent to CrosSettingsProviderProxy.
Review URL: http://codereview.chromium.org/3386009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
numeric values to strings.
Also adds the OS version from the user-agent string to the top of the log dump.
TEST=manual
BUG=53474
BUG=54302
Review URL: http://codereview.chromium.org/3416015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56153
TEST=Verify that the dom-ui settings tab displays the proper favicon.
Review URL: http://codereview.chromium.org/3444012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56278
Review URL: http://codereview.chromium.org/3393015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
setting.
BUG=56429
TEST=unit_tests --gtest_filter=ExtensionsServiceTest.*
Review URL: http://codereview.chromium.org/3120029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Install the test.talkgadget chat manager. Chats should appear in panels. Hovering over contact should not show profile card.
BUG=none
Review URL: http://codereview.chromium.org/3391017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that import data overlay displays with valid HTML.
Review URL: http://codereview.chromium.org/3480001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify there is not javascript error when loading options page.
Review URL: http://codereview.chromium.org/3450019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
server.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3418020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
earlier in the load process, so they can cache the values for subsequent
use by Google chat code to prevent on-page moles from appearing on ChromeOS
BUG=chromium-os:3312
TEST=Open chat through chat manager and then launch iGoogle.
Review URL: http://codereview.chromium.org/3416014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=validate import dialog behavior in tabbed-options window
Review URL: http://codereview.chromium.org/3402008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tables.Extends TablePrinter to output HTML in addition to plain text tables, to avoid duplicating code to populate the tables.BUG=39756TEST=manual
Review URL: http://codereview.chromium.org/3451001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://net-internals/#requests. Both buttons delete all captured events that appear in subsequent log dumps and on the requests page.
The delete selected button on the requests page now deletes items from subsequent log dumps as well.
BUG=54744
TEST=manual
Review URL: http://codereview.chromium.org/3450013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Skip registration screen when manifest is not defined or url is invalid.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6708, http://code.google.com/p/chromium-os/issues/detail?id=6749
TEST=Manual. Register screen is not shown when OEM customization is not specified. Additional system info is passed to register page.
Review URL: http://codereview.chromium.org/3459009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: When there is no items in the profile list, click on the checkbox to
disable the autofill feature. Notice that all buttons become disable (that is ok).
Now click again to enable the feature, notice that all buttons become enabled
(that is NOT ok, because there aren't any items in the profile list).
Fix: Properly enable/disable the Edit and Remove buttons based on the profile
list size and the current state of the preference.
BUG=None
TEST=see Bug description above.
Review URL: http://codereview.chromium.org/3390016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6737,chromium-os:6739,chromium-os:6547,chromium-os:6108
TEST=test the bugs above
Review URL: http://codereview.chromium.org/3417008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=56075
TEST=Open NTP. Make window small enough to scroll. Open a different
section, then reopen the original section. Scroll should have returned
to top.
Review URL: http://codereview.chromium.org/3415016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54275
TEST=Open NTP. Change font size (preferences > under the hood
> change font and language settings). All fonts on page
should change size proportionally.
Review URL: http://codereview.chromium.org/3458007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55911
TEST=Verify that the new tab page colors are grey and the shadow is removed.
Review URL: http://codereview.chromium.org/3423011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
UI has been approved for M7.This allows me to more easily change the way the appmodal dialog system works.
http://crbug.com/55121
TEST=existing tests
Review URL: http://codereview.chromium.org/3299020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The click event of add-language-overlay-language-list is handled by
handleAddLanguageListClick_ in chromeos_language_options.js.
So the temporarily commented out code is not needed in the first place.
BUG=chromium-os:6713
TEST=manually on the net book
Review URL: http://codereview.chromium.org/3452005
Patch from Yasuhiro Matsuda <mazda@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:968
TEST=Verify users settings are persisted per machine correctly and only owner is allowed to make changes.
Review URL: http://codereview.chromium.org/3403007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not add support for displaying the keyboard. That will be provided (along with a more useful keyboard) in follow-up changes.
BUG=none
TEST=added new override test
Review URL: http://codereview.chromium.org/3362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
noticeable when end events missing from log.
BUG=54879
TEST=manual
Review URL: http://codereview.chromium.org/3450009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=55798
TEST=Go to bookmark manager
Right click the list
Mouse over and mousedown on a separator. It should not change color.
Review URL: http://codereview.chromium.org/3381007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=52291
TEST=Go to bookmark manager.
Right click a bookmark.
Right click another bookmark. This should open a new context menu
Right click "Edit...". This should start editing the item.
Review URL: http://codereview.chromium.org/3395006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=55732
TEST=Create a ntp that is small enough that the theme
attribution or chrome/chromium icon does not show up. Refresh
the page. The attribution or icon should still not be
visible.
Review URL: http://codereview.chromium.org/3437004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no longer has an error in the javascript console
Review URL: http://codereview.chromium.org/3435008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=tim
BUG=chromiumos:6363
TEST=manual
Review URL: http://codereview.chromium.org/3447003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixed so that import window is setup correctly when invoked directly from a command.
- Correctly enable/disable checkboxes based on what services are supported by a profile.
- Changes to avoid relying on the exact order of checkboxes in the DOM.
- Changes to use ExternalProcessImporterHost instead of ImporterHost (MacOS X).
- Put ok/cancel buttons in a button strip.
BUG=none
TEST=verify Import dialog works properly via dom-ui (--enable-tabbed-options)
Review URL: http://codereview.chromium.org/3363012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
credentials as well.
BUG=55211
TEST=manual
Review URL: http://codereview.chromium.org/3402002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mock: https://docs.google.com/leaf?id=0B_nT9N2oDUPyNzg4MGFlYTEtYzc2MS00OThjLTk4OTMtOGFkMDlmM2U2ODBi&authkey=CJuQlvQN&hl=en
Entry changes:
- Show the domain (green) for the page and favicon.
- Page title has underline only on hover, and is blue even if visited.
- Page title is truncated to 80 characters.
- A tooltip is shown for truncated titles.
- Fluid bidirectional layout with max-width and text wrapping.
Semantic HTML for accessibility (for screen-readers).
- Headings used for day labels.
- Ordered lists used for day groups or search results.
- Removed table DOM structure used in search results.
Speeding up DOM generation
- Using document fragments for generating day groups
Consistent browse and search entries:
- Same JavaScript method is used to construct both types of entries.
- Shared HTML structure and CSS for both types of entries.
Fixed minor issues with RTL languages (Hebrew and Arabic):
- Wrapping issues for search results.
- Inconsistent bidi layout
Code changes:
- Added domain property to Page class.
- Added getDomainFromURL_ method to Page class.
- Added truncateString_ method to Page class.
- Unified getSearchResultDom and getBrowseResultDom methods.
- Updated getTitleDOM_ method to truncate title and add optional tooltip.
- Updated displayResults_ method to use documentFragment and group into days.
BUG=52697
TEST=none
Review URL: http://codereview.chromium.org/3202002
Patch from Keekim Heng <keekim@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
overlay. Matches current mocks.
BUG=none
TEST=Verify font settings page appears correct via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3390005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that cancel buttons only appear to left on Windows.
Review URL: http://codereview.chromium.org/3393001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53222
TEST=Manualy installed extensions, hosted apps,a nd packaged apps.
Review URL: http://codereview.chromium.org/3425001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:6363
TEST=manual
Review URL: http://codereview.chromium.org/3335017
TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/3405003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:6363
TEST=manual
Review URL: http://codereview.chromium.org/3335017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that 'stop sync' and 'remove all password' alerts display correctly.
Review URL: http://codereview.chromium.org/3409001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the clear browser data buttons into a button strip div.
- Improve how labels are associated with checkboxes, previous method had layout issues.
- Removed an extraneous div.
BUG=none
TEST=Verify that clear browsing data dialog right justifies buttons.
Review URL: http://codereview.chromium.org/3363015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that button strip buttons are not too close to upper dialog items.
Review URL: http://codereview.chromium.org/3407001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54903
TEST=block cookies, go to almost any site, click little cookie in omnibox, manage cookies
Review URL: http://codereview.chromium.org/3323021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Turn off logo/attribution completely when it overlaps
with the content.
2) Replace the single-item dropdown menu in the most visited
section with a text link to restore blacklisted URLs. The
link should only be visible if there are any blacklisted
URLs.
BUG=55196,55208
TEST=unit_tests --gtest-filter=TopSitesTest.*
Review URL: http://codereview.chromium.org/3361015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and display them on a new net-internals tab. On other OSes, the new tab is always hidden.
BUG=53474
TEST=manual
Review URL: http://codereview.chromium.org/3329016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3308030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59303 0039d316-1c4b-4281-b951-d872f2087c98
|