| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally the mapping from input method ID to keyboard overlay ID was written
in ibus_input_methods.txt.
I moved this to gen_keyboard_overlay_data.py and made the deta be generated in
keyboard_overlay_data.js.
I also modified gen_keyboard_overlay_data.py to generate a list of input method
IDs that shouldn't remap the right alt key in xkeyboard.cc instead of a list of
keyboard overlay IDs.
These changes make the two functions related to keyboard overlay ID in
input_method_util.{h,cc} unnecessary.
I also deleted keyboard overlay data for en_fr_hybrid_CA, ar_fr, id and fil, which was unused.
BUG=chromium-os:17592
TEST=Ran unit_tests and manually tested on the chromebook
Review URL: http://codereview.chromium.org/7370001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added C++ code send property name in OnNetworkDeviceChanged to make sure that we got results of scan instead of some other property change.
BUG=chrome-os-partner:4918,chromium-os:14422
TEST=manual
Review URL: http://codereview.chromium.org/7342041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87295,chromium-os:16138
TEST=launch downloads page (ctrl-j). Right click should bring up a context menu on the body and non-control links. For control links (Show in Finder, Remove From List, Pause, Resume, etc), right click should not bring up a context menu. Right click + Open in New Tab should work correctly on all platforms for files with unicode characters as well as uri special chars +/\@~!'"()#$&,:;=?%
Review URL: http://codereview.chromium.org/7308002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1 - fix horizontal scroll for pagers in rtl
2 - fix page shower hidden logic (don't flash them during page startup)
3 - fix nav dots so you can click the whole vertical space to select them (use a spacer div instead of margin because margins can't be clicked)
4 - fix font color for nav dots (linux doesn't like transparency and we don't need it anyway)
5 - fix z-order of recently closed menu (show on top of footer)
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7373015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initial state.
Also, changed button css width property from width to min-width.
Multiline button text for longer strings we have in some languages (e.g. Croatian) looks just weird :)
TEST=*Make sure that in Croatian button on fail page (start burn and click
cancel button) is in a single line
*Start burning, when download starts, click cancel, remove and attach removable device to machine and verified that UI does not change.
BUG=NONE
Review URL: http://codereview.chromium.org/7380002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7277010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this is a class that was going to be used for showing bookmarks in Apps pages, but since we decided to synthesize apps instead we don't need it any more.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7361005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Show first screen header.
BUG=chromium-os:17485
TEST=Manual. Changed language, observed that all elements change.
Review URL: http://codereview.chromium.org/7369006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hidden behind the gyp flag webui_certificate_viewer, this dialog will replace the GTK certificate viewer as part of the nogtk effort. This CL only adds the new certificate viewer but does not use it unless compiled with webui_certificate_viewer=1.
This is the first stage, which adds the viewer and only shows the "General" certificate details (As shown in the General tab in the GTK viewer). The next steps are to show the detailed information, resolve some minor display and functionality issues on desktop builds and then make this the standard certificate viewer.
BUG=None
TEST=Manually viewed certificate details for several secure sites.
Review URL: http://codereview.chromium.org/7331016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89015
TEST=manual
Review URL: http://codereview.chromium.org/7346033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7331043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7346031
Patch from Fady Samuel <fsamuel@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89237
TEST=When there is no plugin, dummy plugin is removed from the preview page and an error message is displayed.
Review URL: http://codereview.chromium.org/7361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins
BUG=73666
TEST=
Review URL: http://codereview.chromium.org/7104121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7354026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
head in chrome://history.
Review URL: http://codereview.chromium.org/7310009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. don't show press effects on thumbnail when user is clicking the [x]
2. don't show the [x] on thumbnail focus (the [x] itself is not focusable so it's really a mouse-only control)
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7355024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tile grid fixes
BUG=none
TEST=manual (dragging tiles around)
Review URL: http://codereview.chromium.org/7355030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88807, 89106
TEST=NONE
Review URL: http://codereview.chromium.org/7313035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7284016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make EULA columns a bit wider.
BUG=chromium-os:17331
TEST=Manual. Created manifest with OEM EULA defined.
Review URL: http://codereview.chromium.org/7345009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=84397
TEST=None
Review URL: http://codereview.chromium.org/7084024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Show/hide column by clicking the context menu of the table header.
BUG=chromium-os:13885
TEST=manual on chromeos-chrome in Linux
Review URL: http://codereview.chromium.org/7326044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change was reverted in r90547 due to unrelated test failures.
BUG=None
TEST=Unit-tests.
Review URL: http://codereview.chromium.org/7348001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To enable in Windows/Mac/Linux pass "--enable-cloud-print --enable-print-preview" on the command line.
To enable in ChromeOS open about:flags and enable print preview.
This first pass extends the print preview UI to retrieve a printer list from cloud print and to allow printing to a cloud print printer.
Limitations/known issues:
Sign in opens a new tab and requires the print preview page to be refreshed after sign in.
Only pulls the first 10 GCP printers.
Job settings are very limited. Only sets color and only for a limited set of printers.
BUG=80004
TEST=
When running with default flags the only visible change should be that "Manage Printers" is now "Manage Local Printers"
With flags set as above there should be new entries in the printer selection dropdown allowing the use of cloud printers. It should be possible to sign in to cloud print, open the management page, and be able to print documents to cloud printers.
Review URL: http://codereview.chromium.org/7038028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove duplicate code between most_visited_handler.cc and top_sites.cc
- remove dead code in most_visited_handler.cc
- remove duplicate favicon resources
- update favicon resources by adding 32x32s resource for NTP stock most visited pages
- uniformly refer to PRODUCT_NAME rather than sometimes using "google chrome" in chromium builds on the NTP
- consolidate some resources (IDR_CHROME_STORE_PAGE_FAVICON and IDR_WESBTORE_ICON_16 for example)
- remove unused thumbnail for webstore (which is slightly distinct from the themes gallery because there's no &category=theme in the URL)
as a precursor, I had to add an icon to chrome/app/theme/google_chrome (internal repository)
as a cleanup after, I will have to remove an icon from the same
BUG=none
TEST=trybots; manual
Review URL: http://codereview.chromium.org/7342001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
match new mocks: remove edit bar, don't allow drag-reorder, move close button into thumbnail, add hover/active effects to thumbnail
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7342017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a work-in-progress refactoring. I was hoping to have it done by now, but just discovered today that Chrome already has support for some of the ByteReader functionality, including the only reliable way to deal with signed/unsigned numbers.
This isn't working yet, and so it may change a bit more before landing, but please feel free to suggest changes now.
BUG=chromium-os:17498
TEST=manual testing on chromeos-chrome on linux
Review URL: http://codereview.chromium.org/7322001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix bug with 2 similar buttons on EULA screen.
Learn more help dialog that is triggered on EULA screen has issue with focusing but I'll address that later.
BUG=chromium-os:17337
TEST=Manual. Opened proxy dialog, "learn more" help dialog.
Review URL: http://codereview.chromium.org/7329022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7285046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81648
TEST=see bug
Review URL: http://codereview.chromium.org/7285043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also making the previewed doc to fit to height always instead of fitting to
width for landscape layout.
BUG=88805
TEST=See bug description.
Review URL: http://codereview.chromium.org/7324055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88732
TEST=manual on chromeos-chrome in linux
Review URL: http://codereview.chromium.org/7324044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7313034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=87320
TEST=manual
Review URL: http://codereview.chromium.org/7215037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a BaseLoginUIHandler interface for WebUILoginDisplay to call into
webui login handler;
- Generate error text in WebUILoginDisplay and pass them into webui login
handlers;
- Dummy implemenation to just reset input UI when there is an error;
BUG=chromium-os:17410
TEST=Verify that authentication failure should reset sign-in UI.
Review URL: http://codereview.chromium.org/7331024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
acts like a normal app, but you can't uninstall it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7227028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Task manager should bundle same-process tasks to make select
them easier.
As this CL, the same-process resources are grouped and WebUI task manager treats tasks not as resource-by-resource but as group-by-group. Converting between index of resource and index of group is in task_manager_handler.cc.
BUG=chromium-os:13885
TEST=manual on chromeos-chrome in Linux
Review URL: http://codereview.chromium.org/7329014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving all page selection related stuff within PagesSettings class.
BUG=88098
TEST=NONE
Review URL: http://codereview.chromium.org/7302006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
card slider and page switchers are fixed.
there are more rtl issues I didn't even attempt yet (e.g. tiles are currently ordered backwards for RTL)
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7330005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And add a placeholder signin screen;
BUG=chromium-os:17341
TEST=Sign-in in oobe should work. Usually flow should work as well except that account picker is not visible and shows oobe background. Also authentication failure is not handled.
Review URL: http://codereview.chromium.org/7312030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Persist app page names in the preferencs file after a user makes an edit.
Also remove pageName from tile pages, its obsolete.
TODO: Perform necessary steps to get this data synced with the 'apps' sync type.
(The previous CL was reverted due to a bug that caused test failures. This has been fixed.)
Review URL: http://codereview.chromium.org/7277090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82912
TEST=Manually set the policy and observe the button gets disabled.
Review URL: http://codereview.chromium.org/7322014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
starting with dot.
BUG=chromium-os:15620
TEST=Save a file, rename a file or folder, create a new folder. Try to start the name with dot.
Review URL: http://codereview.chromium.org/7236034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
user-modifiable.
BUG=88341
Review URL: http://codereview.chromium.org/7310003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also a couple of minor fixes:
- Menu width changed: 150 -> 250
- Setup font size and direction when updating the content.
- Refresh network control position, when updating the content.
BUG=chromium-os:17338
TEST=manual
Review URL: http://codereview.chromium.org/7329018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Save a file with characters @!'() #$&,;=. Click on it in the downloads panel and it should launch correctly.
Review URL: http://codereview.chromium.org/7324012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...instead of the the "These settings may only be modified by the
owner:<blank>" as it was until now. Also correctly wired the managed state
of the local_state cache of SignedSettings prefs to be set to true when
the device is enrolled.
BUG=chromium-os:16058
TEST=Enroll the device and go to user settings. The yellow banner should be there.
Review URL: http://codereview.chromium.org/7171018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=87831
TESTS=none
Review URL: http://codereview.chromium.org/7237036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1 - z-order: make it show on top of the footer
2 - disable uninstall when appropriate
3 - fix appearance of disabled items on linux/gtk (applies to all places menu.js is used)
BUG=none
TEST=see above
Review URL: http://codereview.chromium.org/7227025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91740 0039d316-1c4b-4281-b951-d872f2087c98
|