| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=47180
Review URL: http://codereview.chromium.org/2809034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for the bookmark manager to work after upgrading
in the background on Linux.
BUG=42770
TEST=Bookmark manager still works
Review URL: http://codereview.chromium.org/2814009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45137
TEST=See bug
Review URL: http://codereview.chromium.org/2849017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
error messages to the user when a song/video is unplayable.
BUG=chromium-os:3836,chromium-os:3563
TEST=none
Review URL: http://codereview.chromium.org/2829013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3837
TEST=none
Review URL: http://codereview.chromium.org/2858019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
loading.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the "Show full history" from the "Recently closed" bar since we can now get to the history using the link in the footer.
BUG=None
TEST=There should be three links at the bottom of the NTP now.
Review URL: http://codereview.chromium.org/2712004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the new app section.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2862023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
through the list of files. Have not wired this into the filebrowser yet either.
BUG=chromium-os:3837
TEST=none
Review URL: http://codereview.chromium.org/2801004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
BUG=45445
TEST=Open about:memory in a Google Chrome build and check the mouseover help dialogs --they should refer to "Google Chrome" rather than "Chromium".
Review URL: http://codereview.chromium.org/2675006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://history2/.
BUG=2093
TEST=launch browser, navigate to chrome://history2/
Review URL: http://codereview.chromium.org/2852015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactors the cr.ui.List to be backed by a data model. The data model is like an array, but it dispatches events when it changes. When the data model changes the view is updated. The view is smart enough to only draw what is in the viewport which allows large data sets to be displayed.
There are a lot of TODOs after this to make the list more reusable but this is already getting big so I'd rather get this in before moving on.
TODOs:
1. Create a *real* data model for the bookmark list.
2. Move the edit behavior from bmm.BookmarkListItem to cr.ui.ListItem and make it work better with scrolling.
3. Refactor the drag and drop code so that it can be reused.
4. Refactor the selectionModel so that it does not handle the user input events.
BUG=39528
TEST=The bookmarks manager should still work.
Review URL: http://codereview.chromium.org/2842001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44915
TEST=Start chrome with --enable-apps (and optionally --enable-accelerated-compositing). Install some apps. Now hover over the app icon and click the wrench icon.
Review URL: http://codereview.chromium.org/2832014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Group app-related keys under a new "app" key, and change
the implementation of IsApp() to just check that.
2) Rename IsApp() and IsTheme() -> is_app(), is_theme() to
match style guide.
3) Remove web_content.enabled. That was a stupid idea.
4) Make some kind of launch URL required for apps.
BUG=46632
Review URL: http://codereview.chromium.org/2836012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also re-order the Data tab to appear before the others.
Review URL: http://codereview.chromium.org/2822011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Was incorrectly clearing a valid central roster jid.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2869007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the initial implementation of System page in ChromeOS options.
BUG=chromium-os:
TEST=none yet, work in progress
Review URL: http://codereview.chromium.org/2781005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The debug options were forcefully causing apps to launch as tabs.
BUG=46502
TEST=try launching a panel or window based app, it shouldn't launch as a tab
Review URL: http://codereview.chromium.org/2844008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
available.
BUG=chromium-os:3834
TEST=none
Review URL: http://codereview.chromium.org/2858001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2860002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace name link with name+error message in content browser;
- Show an error message ChromeOS's openItem;
- Update SimpleErrorBox so that it runs in a Chrome window;
- Put back "Show in folder" in download page and make it work with content
browser;
BUG=chromium-os:1637
TEST=Verify fix for chromium-os:1637 and verify error message pops up for unknown type file in downloads ui.
Review URL: http://codereview.chromium.org/2748007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We don't use this yet, but the plan is to move everything in the resources directory into here.
BUG=42770
Review URL: http://codereview.chromium.org/2667001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a pref observer for prefs::kNTPShownSections and calls a js function when these changes. This is so that instances of the NTP do not get out of sync with each other.
BUG=None
TEST=Open two or more NTPs. Hide and show different sections and the sections should be hidden and removed on all instances.
Review URL: http://codereview.chromium.org/2792004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4014
TEST=none
Review URL: http://codereview.chromium.org/2746008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2558
TEST=none
Review URL: http://codereview.chromium.org/2723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a sound mute icon and swap between sound high and mute icon based on
volume change;
- Change sound button click to toggle volume mute;
- Show volume control when mouse over sound button and hide it when mouse
leaves;
- Call volumeChange after we setupPlaybackControls so that volume slider's
value syncs with media element's volume;
- Removed "controlbutton" class from "volume" element because it is really
a control button and "controlbutton" style sets its hight to 30px;
BUG=chromium-os:3148
TEST=Verify click on sound button mute/unmute audio and volume slider shows up when mouse over sound button.
Review URL: http://codereview.chromium.org/2722006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3462
TEST=none
Review URL: http://codereview.chromium.org/2758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2737001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we remove an item.
Change the code to do the add and removal to the cache in the addAt and remove methods to the tree and the tree items.
BUG=42239
TEST=See bug
Review URL: http://codereview.chromium.org/2696001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Start chrome with a new blank profile. No bottom promos should show up.
Review URL: http://codereview.chromium.org/2637004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tbarzic@chromium.org:
Implemented functionality for viewing chromeOS system status
BUG=chromium-os:3807
TEST=type in about:system in the browser and system status page should appear
Review URL: http://codereview.chromium.org/2698003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:plugins and show update link for out-of-date ones.
Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2686001
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2686001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
too many are not h.264.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2622002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40924
TEST=Go to a bookmark folder in the bookmarks manager where the list has a vertical scrollbar. Middle clicking on a bookmark should open the bookmark in a background tab.
Review URL: http://codereview.chromium.org/2658004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When deleting multiple folders we get callback after each remove and this can trigger a selection change which in turn triggers a call to getSubtree for a folder that was just removed. When this happens we finish the Promise with the value undefined.
BUG=None
TEST=Create two folders and select both. Hit Delete and check that we do not get a script error. (We still get an error from the extension API that the id no longer exists but at least we do not keel over.
Review URL: http://codereview.chromium.org/2647001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=something
Review URL: http://codereview.chromium.org/2507001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39250
TEST=Select a folder with no items. The sort command should be disabled.
Review URL: http://codereview.chromium.org/2467007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
enqueueing an item is available from the menu.
Review URL: http://codereview.chromium.org/2436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We used to assume that all bookmark imports were adding a folder to "Other bookmarks". This is not always the case so now we reload the tree and the list instead.
BUG=39893
TEST=Start with an empty profile. Click "Import bookmarks" on the bookmarks toolbar. The imported bookmarks and bookmarks folders should show up.
Review URL: http://codereview.chromium.org/2485002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41005
TEST=as described in the bug
Review URL: http://codereview.chromium.org/2322005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(This way don't need to give separate instructions on bug reports depending on what version of chrome they are using, can still just say "copy dump from about:net-internals")
Review URL: http://codereview.chromium.org/2365002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should help reduce confusion when reading logs that have a mixture of passive and actively captured events (since there may have been some loss of information along the boundaries).
Review URL: http://codereview.chromium.org/2094020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by seh@chromium.org:
http://codereview.chromium.org/2249001/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2252004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2248001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the CSS that follows roma's button design.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2159004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new work will take a very different approach (using a component extension,
similar to the bookmark manager).
This basically reverts the following commits:
- http://src.chromium.org/viewvc/chrome?view=rev&revision=20595
(http://codereview.chromium.org/155067)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19918
(http://codereview.chromium.org/155051)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19906
(http://codereview.chromium.org/150207)
BUG=173
TEST=everything still builds
Review URL: http://codereview.chromium.org/2156003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=seh
Review URL: http://codereview.chromium.org/2074026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48118 0039d316-1c4b-4281-b951-d872f2087c98
|