summaryrefslogtreecommitdiffstats
path: root/chrome/browser/resources
Commit message (Collapse)AuthorAgeFilesLines
* Replace <meta> tag with header for content-security-policy on chrome:// pages.tsepez@chromium.org2011-10-0530-51/+0
| | | | | | | | | By default, all chrome:// pages will get CSP with a whitelist of the exceptions. BUG=98877 Review URL: http://codereview.chromium.org/8124010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104134 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show "enable" link for plug-ins that are disabled by policy.bauerb@chromium.org2011-10-051-18/+0
| | | | | | | | | | | | | Also, remove some superfluous messages in chrome://plugins UI. BUG=98912 TEST=see bug Review URL: http://codereview.chromium.org/8142025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104116 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Login screen: add Caps Lock hint to password input.ivankr@chromium.org2011-10-055-6/+43
| | | | | | | | | | | | | *) Caps Lock turned off when login screen is first shown. *) Caps Lock icon shown over password input field. *) 'Caps Lock is on' warning added to signin and unlock failure messages. BUG=chromium-os:19749 TEST=Manual: password field on login screen should display an icon when Caps Lock is pressed. Review URL: http://codereview.chromium.org/8116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104115 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Use full login html when device is not owned.xiyuan@chromium.org2011-10-052-0/+3
| | | | | | | | | | | | So that enterprise enrollment is still possible after oobe_completed flag is set. BUG=chromium-os:20821 TEST=Verify fix for chromium-os:20821 Review URL: http://codereview.chromium.org/8038034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104114 0039d316-1c4b-4281-b951-d872f2087c98
* Call prepareSort befor any sorting in array_data_model.dgozman@chromium.org2011-10-052-1/+15
| | | | | | | | | BUG=chromium-os:19834,chromium-os:19082 TEST=See bug 19082. Review URL: http://codereview.chromium.org/8065009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104087 0039d316-1c4b-4281-b951-d872f2087c98
* Improved ChromeOS Gallerykaznacheev@chromium.org2011-10-0534-1351/+2143
| | | | | | | | | | | The patch implements most of the desired appearance and behavior for Gallery v1. BUG=chromium-os:19534 TEST= Review URL: http://codereview.chromium.org/8113033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104085 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI TaskManager: Support on Mac & Linux yoshiki@chromium.org2011-10-053-10/+23
| | | | | | | | | | | | | WebUI TaskManager is enabled when "--enable-task-manager" command-line option is set or when chrome is built with WEBUI_TASK_MANAGER. The title and close button are shown only when task manager is a dialog and chrome runs on ChromeOS. BUG=69222 TEST=manual Review URL: http://codereview.chromium.org/8115005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104075 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102834 - Revert 102806 - [Sync Setup UI] String changes. "Sync" -> ↵binji@chromium.org2011-10-051-2/+2
| | | | | | | | | | | | | | | | | | | | | "Sign In" and others. I was asked to revert this by a sheriff on a failing mac test, but I've successfully retried, so I think it was flake. BUG=93176, 97523 TEST=manual Review URL: http://codereview.chromium.org/7977029 TBR=binji@chromium.org Review URL: http://codereview.chromium.org/8028049 TBR=binji@chromium.org Review URL: http://codereview.chromium.org/8143010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104047 0039d316-1c4b-4281-b951-d872f2087c98
* Add learn more information to sync promosail@chromium.org2011-10-043-2/+37
| | | | | | | | | | | | | | | | This change adds a learn more link to the sync promo. Clicking on the link replaces the sync info graphic with text information about sync. Users can then click "hide" to go back to the info graphic. Screenshots: http://www.dropmocks.com/mac22 BUG=89276 TEST= Review URL: http://codereview.chromium.org/8101010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104030 0039d316-1c4b-4281-b951-d872f2087c98
* Add OS and ANGLE info in the about:gpu page.zmo@google.com2011-10-041-0/+8
| | | | | | | | BUG=96603,94157 TEST=watch about:gpu page for the added info Review URL: http://codereview.chromium.org/8085014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104024 0039d316-1c4b-4281-b951-d872f2087c98
* Hiding any error messages from prior login attempts after successful loginchrelad@gmail.com2011-10-041-0/+1
| | | | | | | | | | BUG=98536 TEST=Login with incorrect creds, then correct ones; error should go away Review URL: http://codereview.chromium.org/8072027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103987 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Use the TOOLKIT_VIEWS define to determine the value of isViews.jhawkins@chromium.org2011-10-041-3/+9
| | | | | | | | | | | | | This sets isViews correctly for non-Windows, non-CrOS Views builds. Fixes test failures from the previous commit which was reverted. BUG=none TEST=none Review URL: http://codereview.chromium.org/8114027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103966 0039d316-1c4b-4281-b951-d872f2087c98
* Remove box-shadow styling.bryeung@chromium.org2011-10-041-0/+6
| | | | | | | | | | | | The performance of box-shadow styling is not good enough for use on the keyboard at this time. TEST=manually BUG=none Review URL: http://codereview.chromium.org/8136001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103956 0039d316-1c4b-4281-b951-d872f2087c98
* Triggers sign in dialog immediately when displaying the preview page if the ↵abodenha@chromium.org2011-10-041-0/+1
| | | | | | | | | | | | | | user isn't signed in. Changes the dialog flow to not refresh the preview page if the signin dialog is canceled. Removed a unit test. It should be re-added when we address bug 98747 BUG=98731 TEST= Review URL: http://codereview.chromium.org/8100012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103940 0039d316-1c4b-4281-b951-d872f2087c98
* Separate Virtual Keyboard related conditionals from TouchUIhashimoto@chromium.org2011-10-043-4/+4
| | | | | | | | | | | | | | Add a gyp variable use_virtual_keyboard Add a cpp define USE_VIRTUAL_KEYBOARD Add a grit define use_virtual_keyboard BUG=chromium-os:10620 TEST=chrome and browser_tests compile successfully with GYP_DEFINES="touchui=1" and GYP_DEFINES="use_virtual_keyboard=1 use_only_pure_views=1". they run with a virtual keyboard with command-line option --views-desktop Review URL: http://codereview.chromium.org/8051010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103926 0039d316-1c4b-4281-b951-d872f2087c98
* ntp4: fix bookmark bar dragging regressionestade@chromium.org2011-10-041-1/+1
| | | | | | | | | | BUG=98894 TEST=drag from bookmark bar to apps section, it works instead of throwing an error Review URL: http://codereview.chromium.org/8054038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103916 0039d316-1c4b-4281-b951-d872f2087c98
* ntp4: fix app title directionalityestade@chromium.org2011-10-041-6/+6
| | | | | | | | | BUG=93339 TEST=manual Review URL: http://codereview.chromium.org/7779024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103904 0039d316-1c4b-4281-b951-d872f2087c98
* Adding file type column.serya@chromium.org2011-10-043-69/+177
| | | | | | | | | | BUG=chromium-os:20582 TEST=None Review URL: http://codereview.chromium.org/8119001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103892 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Add fake domain for login to test extension manifestcmasone@chromium.org2011-10-041-1/+6
| | | | | | | | | | | | | We're having SSL issues faking out www.google.com, so we're going to start testing against the made-up domain 'insecure.com' BUG=chromium-os:20323 TEST=suite_Smoke Review URL: http://codereview.chromium.org/8114010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103888 0039d316-1c4b-4281-b951-d872f2087c98
* [ntp4] Move bookmarks pane behind an experimental flag.csilv@chromium.org2011-10-041-5/+12
| | | | | | | | BUG=none TEST=Verify that NTP4 bookmarks pane only appears when flag is enabled. Review URL: http://codereview.chromium.org/8081003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103841 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 103795 (may have turned windows bots red) - WebUI: Use the ↵willchan@chromium.org2011-10-031-9/+3
| | | | | | | | | | | | | | | | | | TOOLKIT_VIEWS define to determine the value of isViews. This sets isViews correctly for non-Windows, non-CrOS Views builds. BUG=none TEST=none R=arv@chromium.org Review URL: http://codereview.chromium.org/7968001 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/8114018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103817 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to file manager's pyautoAPI for getting disk size statsfrankf@google.com2011-10-032-14/+50
| | | | | | | | | | | BUG=chromiumos:19851 TEST=Ran pyauto tests Change-Id: Iaa995cc1931e427117a70f4483cc89ef9fb26b9b Review URL: http://codereview.chromium.org/8068012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103812 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Use the TOOLKIT_VIEWS define to determine the value of isViews.jhawkins@chromium.org2011-10-031-3/+9
| | | | | | | | | | | | | This sets isViews correctly for non-Windows, non-CrOS Views builds. BUG=none TEST=none R=arv@chromium.org Review URL: http://codereview.chromium.org/7968001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103795 0039d316-1c4b-4281-b951-d872f2087c98
* Options: Use cr.isViews instead of the wrong check I had in place before.jhawkins@chromium.org2011-10-031-1/+6
| | | | | | | | | | | | | | Also includes a fix for overlays which do not have button strips (only happens on CrOS). BUG=97099 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8114012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103780 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Add border/background for Gaia box.xiyuan@chromium.org2011-10-031-0/+2
| | | | | | | | | | BUG=chromium-os:21038 TEST=Verify Gaia UI is in a box per chromium-os:21038. Review URL: http://codereview.chromium.org/8094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103771 0039d316-1c4b-4281-b951-d872f2087c98
* Language 'add' button still active if spell check is disabled. (Regression fix)groby@chromium.org2011-10-031-1/+0
| | | | | | | | | | BUG=98818 TEST=Go to language/spell checker settings, disable spell check. Add button should still be active Review URL: http://codereview.chromium.org/8118011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103770 0039d316-1c4b-4281-b951-d872f2087c98
* Preview now defualts to color for GCP printers with unknown color support.abodenha@chromium.org2011-10-031-2/+4
| | | | | | | | | | | | Since the print preview page currenly has very limited ability to parse capabilities for GCP printers we now give a color preview for a printer if we don't know the if it supports color. BUG= TEST=Bring up print preview on chrome OS. Select any printer. It should either display an option to select color or display the preview in color. Review URL: http://codereview.chromium.org/8093004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103752 0039d316-1c4b-4281-b951-d872f2087c98
* Add content-security-policy directive to chrome://hung-renderer. WebUI ↵tsepez@chromium.org2011-10-031-2/+3
| | | | | | | | pages should specify CSP as a second line of defense against XSS vulnerabilities. Review URL: http://codereview.chromium.org/8103008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103727 0039d316-1c4b-4281-b951-d872f2087c98
* [filebrowser] Bug fixes.dgozman@chromium.org2011-10-032-10/+81
| | | | | | | | | | | | - Allow to duplicate files, creating copy named 'file (1).txt'. - Fix Esc key handling. BUG=chromium-os:20337,chromium-os:20328 TEST=See bugs. Review URL: http://codereview.chromium.org/8054014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103701 0039d316-1c4b-4281-b951-d872f2087c98
* NotificationPromo.achuith@chromium.org2011-10-011-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Split out NotificationPromo helper class for PromoResourceService to handle promo notification. * Support for views/max_views. * NotificationPromo has data members for all the prefs fields (start, end, build, time_slice, max_group, max_views, group, views, text and closed). * Move notification parsing methods from PromoResourceService to NotificationPromo. * NotificationPromo can be initialized from json when the promo resource is parsed, or from prefs, when CanShowNotificationPromo is called. * NotificationPromo now only writes out prefs upon detecting a new notification. * NotificationPromo has a Delegate class, useful for testing. * Static helper methods introduced for extracting time from DictionaryValue, string and prefs. These may be easily unit-tested in the future. * Number of additional tests to more thoroughly test parsing, CanShow logic, and static helper functions like GetNextQuestionValue and NewGroup. * NewGroup now uses RandInt instead of rand(), so this CL passes lint with no complaints. * Some additional cleanup of PromoResourceService, esp GetChannel and IsBuildTargeted. BUG=96290 TEST=Unit tests pass. Use --promo-server-url='http://achuithz600.mtv.corp.google.com/www/files/promoresource2?hl=' to see the promo. If you exceed 5 views, you have to reset the views count (ntp.promo_views) in your Preferences. Review URL: http://codereview.chromium.org/8045012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103646 0039d316-1c4b-4281-b951-d872f2087c98
* Only show one placeholder row in 'Edit Autofill address' name list for ↵isherman@chromium.org2011-10-011-3/+2
| | | | | | | | | | | | profiles without name info. BUG=98280 TEST=none Review URL: http://codereview.chromium.org/8068014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103597 0039d316-1c4b-4281-b951-d872f2087c98
* Apply content-security-policy directive to chrome://policy page. WebUI ↵tsepez@chromium.org2011-09-301-0/+1
| | | | | | | | pages should specify CSP as a second line of defense against XSS vulnerabilities. Review URL: http://codereview.chromium.org/8102003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103541 0039d316-1c4b-4281-b951-d872f2087c98
* NTP4: Adding a tiny bit of delay to transform class application in order for ↵dbeam@chromium.org2011-09-301-1/+10
| | | | | | | | | | | | | transitions to work properly (solves app dropped on other pane bug). BUG=97792 R=csilv@chromium.org TEST=Drop an app on a non-app page and make sure 1) it wormholes, 2) it re-appears on the apps page. Review URL: http://codereview.chromium.org/8072024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103516 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] OOBE TPM overlay focus issues.ivankr@chromium.org2011-09-301-0/+7
| | | | | | | | | | | | *) Focus is restricted to the TPM overlay. *) The 'OK' button is initially focused. BUG=chromium-os:18753,chromium-os:18754 TEST=Manual: in OOBE EULA screen, click the Security Setting link; focus should be initially over the Ok button and should never leave the overlay. Review URL: http://codereview.chromium.org/8086019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103495 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Login screen: added hint to password input.ivankr@chromium.org2011-09-303-1/+60
| | | | | | | | | BUG=chromium-os:20182 TEST=Manual: when password field is empty and focused, semi-transparent label 'Enter password' should be seen. Review URL: http://codereview.chromium.org/8082025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103489 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] OOBE: fix regression with taking user images from camera.ivankr@chromium.org2011-09-302-11/+7
| | | | | | | | | | | | | *) Image from camera is correctly displayed in the images list. *) Fixed double-open of Take Photo dialog. *) Fixed some test paths that crashed. BUG=chromium-os:21043 TEST=Manual: in OOBE, after image is taken from camera, it should appear in the images list and be selectable. Review URL: http://codereview.chromium.org/8085025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103486 0039d316-1c4b-4281-b951-d872f2087c98
* Stub in support for bluetooth settings in Chrome OS.kevers@chromium.org2011-09-303-8/+44
| | | | | | | | | | BUG=Partial fix for chromium-os:20991. TEST=Launch chromeOS with the command-line argument --enable_bluetooth, and switch to the System setttings page. A section for bluetooth devices appears below the touchpad section. Launching without the command-line argument suppresses the bluetooth section. Review URL: http://codereview.chromium.org/8084003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103476 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up WebUI task manager CSS and disable selection.derat@chromium.org2011-09-301-19/+22
| | | | | | | | | | | | | | | | | | This disables user selections and uses the default cursor in the task manager dialog; previously, the title and the headings were selectable (sadly, the possibly-useful-to-copy data being displayed in the dialog was already unselectable). I'm also sorting the CSS rules as instructed by the style guide. BUG=chromium-os:20738 TEST=manual Review URL: http://codereview.chromium.org/8089011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103465 0039d316-1c4b-4281-b951-d872f2087c98
* Policy update notifications are now sent even when the policies haven't changed.simo@google.com2011-09-301-2/+5
| | | | | | | | | | | | | This is so that about:policy can wait for the async policy fetch to finish and grey out the "fetch policies" button as well as display the correct "last policy fetch" time. BUG=97076 TEST= Review URL: http://codereview.chromium.org/7989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103456 0039d316-1c4b-4281-b951-d872f2087c98
* [cros,webui] Close the bubble when network becomes online.altimofeev@chromium.org2011-09-302-7/+37
| | | | | | | | | BUG=chromium-os:18791 TEST=manual Review URL: http://codereview.chromium.org/8070023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103455 0039d316-1c4b-4281-b951-d872f2087c98
* Add CSS style and JS code to lock content settings exceptions in the WebUI ↵markusheintz@chromium.org2011-09-302-7/+13
| | | | | | | | | | | | | | if they are managed by extensions. In the content settings exceptions settings UI, extension managed exceptions will be locked and marked with a yellow background and an extension icon. BUG=98258 TEST=Set a content settings exceptions using an extension (e.g. the sample extension for the content settings extension API). Open the settings for content settings exceptions and verify that the set exception is marked yellow and with a small extension icon. Review URL: http://codereview.chromium.org/7261020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103454 0039d316-1c4b-4281-b951-d872f2087c98
* Policy: about:policy now hides unsent policies in such a way that the page ↵simo@google.com2011-09-302-12/+5
| | | | | | | | | | | | isn't unnecessarily long. BUG=20989 TEST= Review URL: http://codereview.chromium.org/8072028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103448 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Defer Gaia frame loading when selecting user that has no OAuth token.ivankr@chromium.org2011-09-304-46/+92
| | | | | | | | | | | | *) When focus such user with keyboard, a 'Sign in' button appears. *) 'Remove user' button no longer focusable by keyboard. BUG=chromium-os:20046 TEST=Manual: add a user, change password, log out and select this new user with keyboard; instead of instantly opening a Gaia frame, Signin button should appear that opens Gaia frame when clicked. Review URL: http://codereview.chromium.org/8060051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103436 0039d316-1c4b-4281-b951-d872f2087c98
* Add sync promo textsail@chromium.org2011-09-295-201/+314
| | | | | | | | | | | | | | This adds some explanatory text to the side of the sync promo. Note, this doesn't change the look of the sync sign-in dialog in Settings. I'll do that as a separate CL. BUG=89276 TEST= Review URL: http://codereview.chromium.org/8021014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103356 0039d316-1c4b-4281-b951-d872f2087c98
* Options/Autofill: Disable the separator select option.jhawkins@chromium.org2011-09-291-1/+3
| | | | | | | | | | | BUG=97096 TEST=none R=isherman@chromium.org Review URL: http://codereview.chromium.org/8082007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103355 0039d316-1c4b-4281-b951-d872f2087c98
* Move sync promo to standalone pagesail@chromium.org2011-09-295-258/+102
| | | | | | | | | | BUG=89276 TEST= Review URL: http://codereview.chromium.org/7966028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103321 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused qcms library.phajdan.jr@chromium.org2011-09-291-119/+0
| | | | | | | BUG=98460 Review URL: http://codereview.chromium.org/8079005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103316 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced images for USB/SD device.zelidrag@chromium.org2011-09-292-0/+0
| | | | | | | | BUG=chromium-os:20980 TEST=make sure device representation in chrome://files looks nice now Review URL: http://codereview.chromium.org/8060048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103296 0039d316-1c4b-4281-b951-d872f2087c98
* Adding hover visuals for checkbox and radio buttons on settings page.tbarzic@chromium.org2011-09-281-0/+17
| | | | | | | | | TEST=confirmed the visuals on Cr48. BUG=chromium-os:17733 Review URL: http://codereview.chromium.org/7848008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103207 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored code to move cloudprint specific code into print_preview_cloud.js.abodenha@google.com2011-09-283-167/+120
| | | | | | | | | | | | | | | | | Removed "Local" and "Cloud" labels from dropdown The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome. The system print dialog link is replaced with a similar link referencing cloud print in chrome os. Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog. Fixed broken tests. BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119 TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103010 Review URL: http://codereview.chromium.org/7976017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103173 0039d316-1c4b-4281-b951-d872f2087c98