| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This is a changelist for http://codereview.chromium.org/75031 by Kent Tamura (tkent@google.com)
Review URL: http://codereview.chromium.org/100111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Reset HWND size when HWNDHtmlView changes size. The two should always be in sync.
* Race: We might already have frames when RenderWidget receives a new background, need to set these to transparent too.
* Race: Toolstrip background not always available by the time ExtensionToolstrip is constucted
* Make images line up correctly for toolstrip buttons.
Review URL: http://codereview.chromium.org/99042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
property for the placeholder attribute.
BUG=10940
TEST=Make sure that the search boxes (not Search your history) on the new tab
page has place holder text.
Review URL: http://codereview.chromium.org/92107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Please refer to this URL to have your mind blown:
http://aaronboodman.com/z_dropbox/whoa/
Review URL: http://codereview.chromium.org/92119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is used to make the background behind toolstrips 'shine
through' them. It isn't possible to make them really transparent
due to cleartype (cleartype must know the pixels behind the text
to work), so instead we paint the background we want behind the
transparent webview.
Review URL: http://codereview.chromium.org/88076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
icon and the text to show the number of closed windows.
BUG=9022
TEST=With more than one window open close a window. Go to the new tab
page and make sure you see an entry for the closed window. The entry
should have the chrome/chromium logo and instead of 'Window' it
should say the number of tabs in the window.
Review URL: http://codereview.chromium.org/92022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not trigger its deletion.
BUG=10527
TEST=Open the New Tab Page. Click the "Remove thumbnails" link to enter edit mode. Right-click on a thumbnail. The context menu should be displayed and the thumbnail should not be removed.
Review URL: http://codereview.chromium.org/92018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use HTML5 placeholder instead of js code for the text input place holders.
Use HTML5 doctype in all html files.
Skip optional type in script and style tags.
Some small optimizations in LocalStrings.
Review URL: http://codereview.chromium.org/88072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
escape spaces, so we have to do some manual fiddling to make searches that have come from the New Tab Page work (see GetHistoryURLWithSearchText).
BUG=9940
TEST=Verify that searches from the new tab page and from the history page result in the same search query appearing in the history results page.
Review URL: http://codereview.chromium.org/67249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.
Review URL: http://codereview.chromium.org/67162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 052b8f424d1550deebf3dc562d7c47dde72d7f76.
Review URL: http://codereview.chromium.org/78001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.
Review URL: http://codereview.chromium.org/67162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- some minor string changes
- there is now a Cancel button next to the Done button to restore the thumbnails removed during the current editing session
- link and favico are opacified as well in remove mode
- now using a dictionary instead of a list to store the URL blacklist for faster access
- now storing URL hashes instead of URLs (for privacy and also because the DictionaryValue breaks down keys on . characters)
BUG=None
TEST=Make sure removing thumbnails works as expected. Start removing thumbnails then click Cancel, verify that the thumbnails just removed are restored.
Review URL: http://codereview.chromium.org/69007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URL of removed thumbnails is added to a blacklist, which is a user pref.
I had to modify the VisitSegmentDatabase::QuerySegmentUsage not to return a
fixed number of items, as now we may filter the ones we get back.
Note: this adds between 20 and 30ms to the first NTP load on my machine (a
3 to 5% increase).
BUG=685
TEST=Open the NTP. Click the 'Edit thumbnails' link. Remove some thumbnails.
Press Done. Edit again, use the "Restore removed" link.
Review URL: http://codereview.chromium.org/67037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
history.
It also adds code to inline the resources for <link rel="icon"> elements
BUG=9805
Review URL: http://codereview.chromium.org/66041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a "Clear All" link to the downloads page.
Fixes jankiness of the blue bar in the download page as it loads.
Improve rendering time of the downloads page by chunking the number of
download items to do before scheduling the timeout.
BUG=9033
Review URL: http://codereview.chromium.org/62115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI.
For some Indian languages (Malayalam, Bengali and Telugu), we have to
use a bigger size and a font family for that script on Windows.
This is because Windows' stock fonts for those scripts are smaller
than fonts for other scripts at a given size.
I removed 'WEB' style in chrome_font.h because it's not used anywhere any more
after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is
recycled to localize the font family (or the list of font families) for html UI.
I also back-ported the support for setting 'style.fooBar' property to our copy
of Jstemplate (JstProcessor.prototype.jstValues_).
BUG=7319
Review URL: http://codereview.chromium.org/57025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
middle of nowhere.
- Fix history text-wrapping issues.
BUG=8147
Review URL: http://codereview.chromium.org/56001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8433
Review URL: http://codereview.chromium.org/55017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8433
Review URL: http://codereview.chromium.org/55002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issue 7252 --[New Tab] page, the underline of linked text should be under all text
http://crbug.com/7252
issue 7697 -- RTL: New Tab page - bad display of page titles with RTL text
http://crbug.com/7697
The bug is caused by WebKit not rendering text-overflow:ellipsis correctly for mixed bidi text with rtl directionality.
The workaround is to change text-overflow to 'clip' for text with 'rtl' directionality.
(The workaround we thought by changing 'text-overflow' to 'clip' in the style, such as in 'html[dir='rtl'] .thumbnail-title', does not work well. 'text-overflow:clip' caused pure English text overlap with the right-aligned favicon in RTL New Tab page).
Review URL: http://codereview.chromium.org/42636
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved this file.
See:
http://codereview.chromium.org/49011
http://codereview.chromium.org/42435
Review URL: http://codereview.chromium.org/42585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
need the message and can just put an actual URL in the page.
BUG=8961
Review URL: http://codereview.chromium.org/49014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the progress status text indicator code from the old history page.
Make 'cancel' visible when paused.
More RTL fixes.
BUG=8220,8334
Review URL: http://codereview.chromium.org/42550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8334
Review URL: http://codereview.chromium.org/42544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the css user script information to chrome-ui://extensions/
Review URL: http://codereview.chromium.org/49011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initializing values into Extension, outputting values to the extension_ui, and appropriate unit test changes
Review URL: http://codereview.chromium.org/42480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would happen for an URLs that contained parens. These need to be
escaped when using in CSS.
BUG=none
TEST=Go to a page that has parens in it (such as
http://en.wikipedia.org/wiki/The_Wire_(season_5) ). Then open up
history and make sure you get a favicon for the site.
Review URL: http://codereview.chromium.org/48043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Issue was that EscapeQueryParamValue is equivalent to encodeURIComponent(), not escape()
BUG=8346
Review URL: http://codereview.chromium.org/42215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current day we would never show any results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Stop losing first-searches on history page due to
BUG=8438,8456
Review URL: http://codereview.chromium.org/43054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ExtensionsService and ExtensionErrorReporter
Review URL: http://codereview.chromium.org/39026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
controls (Pause/Cancel).* Help deblock download UI creation (timeout in downloads.html, kMaxDownloads in downloads_ui.cc)* Allow resume for paused downloads
BUG=8271,8270,8130,8330
Review URL: http://codereview.chromium.org/40047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
called multiple times. We need to add UI to make what's happening clearer to the user, but this gets us over the hump for now. Also change the history page to queue deletions.Allow history search from the new tab page.Make history title inclusion safer (createTextNode changes).Show starred status on history page.BUG=8214,8163,8271,8284
Review URL: http://codereview.chromium.org/28308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
template page
Review URL: http://codereview.chromium.org/28172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In preparation for an internal launch, this adds a splash screen as
the startup URL for Linux which has a few FAQs.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
NewTabUI is only included on OS(WIN) because DOMUI doesn't appear to have been ported.
Review URL: http://codereview.chromium.org/28104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Speed up history viewing by swapping the search depth to day rather than month - it's now orders of magnitude faster for people who visit more than 30 pages a day, and very slightly slower for people who visit less than 10 pages a day.
Review URL: http://codereview.chromium.org/21182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
interface polish). But is enough for us to begin removing the native UI.ojan, please review downloads.htmlpaul, please review everything else
Review URL: http://codereview.chromium.org/20110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=5836
TEST=see bug
Review URL: http://codereview.chromium.org/21490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows. It was rather bogus that we were doing this before as there
is nothing for the window to link to.
BUG=5836
TEST=see bug
Review URL: http://codereview.chromium.org/21426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.
Create a chrome_resources.vcproj that holds grd files that hold
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/24011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9631.
TBR=deanm
Review URL: http://codereview.chromium.org/23023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/20247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser/about:memory/task manager/metrics code doesn't depend on PluginProcessHost pointers. In a future changelist I'll add one central child process registry in the browser process.
Review URL: http://codereview.chromium.org/20196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed the flatten_html visual studio rule and just rolled the
functionality directly into GRIT.
The sln change is to have browser depend on browser_resources (now needed for browser_resources.h).
Review URL: http://codereview.chromium.org/21148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
truncated from RightToLeft instead of LeftToRight.
(http://crbug.com/5926)
Basically, the issue is that in RTL locales, the thumbnail title etc. text will always be truncated from left, even if they are pure English. For example, "mail.yahoo.com" whose title is "Yahoo! the best web based email!" will be truncated to "best web-based email!".
We should be able to truncate the title as "Yahoo! the be...".
The fix is to set the direction style of each title in the [New Tab] html page for title to be displayed and truncated correctly.
The fix consists 2 part: new_tab_ui.cc in backend and new_tab.html in frontend.
1. new_tab_ui.cc
For thumbnail title, recent bookmark title, and recently closed tab titles, originally, we set "title" and "url" into the data we pass to JS in new_tab.html. The fix added the title's "direction" to the data. The direction is by default "ltr" and is set as "rtl" when there is character having strong directionality in the title.
2. new_tab.html
2.1 set text-alignment in thumbnail-title, bookmark container, and recently closed container to be "right" for RTL locales.
2.2 explicitly set title's directionality in the above 3 sections.
Test:
1. open Chrome in RTL locales.
2. open the following pages:
http://yahoo.com
http://gmail.com
http://mail.yahoo.com
http://wikipedia.com
http://msdn.microsoft.com/en-us/default.aspx
http://arabic.arabia.msn.com/default.aspx
http://he.wikipedia.org/
3. bookmark, close some of them.
4. open [New Tab]
Review URL: http://codereview.chromium.org/19738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9129 0039d316-1c4b-4281-b951-d872f2087c98
|