| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
keyboard shortcuts set on the command. This solves the issue of having platform specific activation keyboard shortcuts and move that to the command.
BUG=39715
TEST=Try double clicking on bookmarks and folders in the list. Also try selecting one or multiple items (including folders). If a single folder is selected we should navigate to the folder instead of opening the items in the folder.
Review URL: http://codereview.chromium.org/1569019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BMM can be really slow to render when there are hundreds of bookmarks in the
bookmark bar. This will hide the list while it's rendering the new elements
which increases performance by a lot since it doesn't have to do any
measurements while it's adding all the elements.
BUG=39865
TEST=Load BMM with over 500 bookmarks in the bookmark bar
Review URL: http://codereview.chromium.org/1540014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise parentheses, periods, etc. look wrong with RTL languages.
Note that for RTL languages, tables should still be layed out right-to-left (and
cells should be aligned to the right).
BUG=34306
TEST=Set your language to your favourite RTL language. Go to chrome://plugins/. Everything should look correct. Expand Details -- everything should look correct. Everything should still look correct in LTR languages as well.
Review URL: http://codereview.chromium.org/1593010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for proxy, dns, sockets, requests, and http cache subsections. The actual subviews are placeholders.
BUG=37421
Review URL: http://codereview.chromium.org/1593009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new API to the experimental.bookmarkManager namespace
getSubtree(id, foldersOnly, callback)
Which returns any subtree, and if foldersOnly is true, only returns the folders.
At this point, only the bookmark tree is using the new call.
BUG=39877
TEST=ExtensionBookmarksTest.*
Review URL: http://codereview.chromium.org/1611001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make sure we do not show the menu on right mouse botton.
BUG=40078
TEST=Open the bookmark manager and right click
Review URL: http://codereview.chromium.org/1518011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40138
Test=None
Review URL: http://codereview.chromium.org/1585012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39093
TEST=Drag the splitter. Reload the bookmark manager and the size of the tree should be persisted.
Review URL: http://codereview.chromium.org/1519016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40036
TEST=MIME type descriptions should mostly show up as before. On Linux (especially?), the descriptions for the MIME type of the Java plug-in should have proper "TM" characters instead of "™".
Review URL: http://codereview.chromium.org/1591008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39364
TEST=Select the "Bookmarks bar" tree item. Right click and do new folder. The text "New folder" should not be clipped.
Review URL: http://codereview.chromium.org/1534004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38591
TEST=Drag bookmarks inside the bookmark manager. The move cursor should be shown.
Rearrange thumbnails on the new tab page using DnD. The move icon should be used.
Review URL: http://codereview.chromium.org/1563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Do not limit search results to 50 items.
2. Middle clicking a bookmark should open it in a new tab
3. Clear lead/anchor item when clearing the selection.
BUG=39589, 39704, 39611
TEST=1. Search for http (or some other common term). The number of items in the result should not be limited to 50 items.
2. Middle click on a bookmark. It should open in a new tab.
3. See crbug.com/39611
Review URL: http://codereview.chromium.org/1508004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39557
TEST=Search for a, then search for b. The list should now show the results of b.
Review URL: http://codereview.chromium.org/1537001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
operator and it shouldn't be called as 0-arguments function.
BUG=29062
Review URL: http://codereview.chromium.org/1516003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1529001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the handle(e) function is called by a separate function instead of as an
event handler when pasting, it was trying to call preventDefault on a
non-existant event and throwing an exception.
Do we need to do something for paste to prevent the system beep? I'm not sure
how to cause the beep to test it out.
Review URL: http://codereview.chromium.org/1473001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It used to live in the experimental.bookmarkManager namespace.
BUG=35320
TEST=none
Review URL: http://codereview.chromium.org/1353004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Go to chrome://apps
Review URL: http://codereview.chromium.org/1353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1389002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Under "Inspect Active Views", any extension that has a browser or page action will show grayed text directing the developer to right click on the icon and select 'Inspect Popup'
BUG=24477
TEST=Install an extension with a page or browser action. Go to chrome://extensions, turn on developer mode. Verify that under "inspect active views", the new instructions appear.
Review URL: http://codereview.chromium.org/1198002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was recently fixed in Chrome.
BUG=31292
TEST=Dragging and dropping items in the NTP and bookmarks still works.
Review URL: http://codereview.chromium.org/1306001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1232001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1261001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1182001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do this by "remapping" about:plugins to chrome://plugins/. Also delete old
about:plugins page and associated strings.
BUG=736
TEST=Go to about:plugins; should get new plugins page (same as chrome://plugins/).
Review URL: http://codereview.chromium.org/1219005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=736
TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions.
Review URL: http://codereview.chromium.org/1085003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BMM was originally only checking for the control key on non-mac platforms.
BUG=39085
TEST=Select some non-contiguous bookmarks and copy and paste them, without the
elements in between
Review URL: http://codereview.chromium.org/1225001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Tested by loading on device and clicking fullscreen button. (needs most recent codebase)
Review URL: http://codereview.chromium.org/1034002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1088007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1141007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Drag a folder in the tree. You should not be able to drop it on itself. You should only be able to drop it when there is a drop marker.
Review URL: http://codereview.chromium.org/1161004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "Delete" menu item should be right after the "Paste" menu item.
As it's in the bookmarks bar and in the old bookmarks manager.
BUG=None
TEST=open the tabbed bookmarks manager and see if the "Delete" menu item is right after the "Paste".
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1159001
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36587
TEST=Open an incognito window and open the Downloads page for it. Now download something in the OTR window. The item should show up in the downloads page but it should be lighter and have a OTR icon background.
Review URL: http://codereview.chromium.org/1126005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1128005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32365
Review URL: http://codereview.chromium.org/1075005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally described here:
http://code.google.com/p/chromium/wiki/InfoBarExtensionAPI
The API is simple:
chrome.experimental.infoBar.show(
{"htmlPath": "infobar.html"}, function(window) {
// |window| is where the infobar was shown.
});
To close it, you can simply call window.close() from within the InfoBar (infoBar.hide is not provided).
The api is privileged (not available to content scripts directly).
The minimum height for the infobar is regular height for our infobars (32 pixels), maximum is twice that and the actual size is determined by the content (within these constraints mentioned).
See screenshot in bug. The icon on the far left is an extension icon with a dropdown menu showing the menu that shows when you right-click on the extension icon in the Omnibox/browser action container.
BUG=26463
TEST=None (for now).
Review URL: http://codereview.chromium.org/1049001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now it is bound to the temporary URL "chrome://net2", since the frontend is under construction.
(Loading this page right now just shows a dummy HTML page.)
This change is a first step to transitioning the about:net-internals / about:network pages from C++ to javascript.
Note that the network stuff needs to run on the IO thread, however the DOMUI infrastructure is all set up to run on the UI thread.
I work around this by proxying things back and forth through the IO thread. Hopefully in subsequent iterations this overhead can be removed, by exposing a sort of "IO thread DOMUI".
BUG=37421
Review URL: http://codereview.chromium.org/1036001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I hijacked the extension install/uninstall dialog, and added another type that
it can transmogrify into.
BUG=32365
Review URL: http://codereview.chromium.org/1041002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/969005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/845003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1045003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/898004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=feldstein@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an issue with reloading after a search.
BUG=4890
TEST=Enter some search terms. Hitting enter should select the search tree item and show the search results. Noew, hit F5 to reload. The search term should be filled in and the search tree item should be selected and the search results should be shown.
Review URL: http://codereview.chromium.org/837011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/894002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as downloads and history.
BUG=37371,4890
TEST=Open three tabs, History, Downloads and Bookmarks. Ctrl+tab between them and notice how the section icon, input and button all stay in the same position.
Review URL: http://codereview.chromium.org/837003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/850001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make IsIncognitoEnabled take an Extension* as an argument as well and use that where possible.
BUG=4890
TEST=Select one more bookmarks and right click/tools and select "Open in incognito". The bookmarks should open in an incognito window.
Review URL: http://codereview.chromium.org/750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
if the user selects a file via the filebrowser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/749001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41191 0039d316-1c4b-4281-b951-d872f2087c98
|