| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
causing old "Last Screenshot" images to show up.
Fixed it by a hack - unfortunately, cache-config:cache-off meta tags don't seem to be working in Chrome.
Review URL: http://codereview.chromium.org/3162050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3197023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SourceEntry's text.
Add "sort:X" to the search field in the Requests view, and log entries will be sorted depending on "X". Possible values are "id", "desc", "source", "duration", and "active". "Active" sorts active entries first, longest active at the top, and inactive entries below, most recently active at the top. "Source" sorts sourceless entries using the largest source ID seen up to that point. The rest should be self-explanatory.
"sort:-X" will reverse the order of the sort.
New entries are sorted as they are added.
"is:active" shows only the active events, and "is:-active" only shows the inactive ones.
Bug=50764
Test=manual
Review URL: http://codereview.chromium.org/3165024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed ExtensionStartupTest which was essentially counting the number of component extensions. Now it doesn't.
Original review here: http://codereview.chromium.org/3116040
This patch adds a component which does not appear on the NTP, but does enforce that gallery urls are isolated in their own process. This is in anticipation of exposing extension api bindings to the gallery so it can install/detect/uninstall extensions & apps.
Note that this patch works correctly with the --apps-gallery-url. If specified, the replacement url will be inserted into the component app's extent
BUG=27431
TBR=aa
Review URL: http://codereview.chromium.org/3104039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't do any behavior changes -- it just implements
the styling. So we still have multi expand, and the recently
closed section is still toggleable.
I also didn't make the changes to the placement or text of
the web store icon. I will make those separately.
Screen caps:
http://aaronboodman.com/z_dropbox/cr3156049/
BUG=53248
Review URL: http://codereview.chromium.org/3156049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a component which does not appear on the NTP, but does enforce that gallery urls are isolated in their own process. This is in anticipation of exposing extension api bindings to the gallery so it can install/detect/uninstall extensions & apps.
Note that this patch works correctly with the --apps-gallery-url. If specified, the replacement url will be inserted into the component app's extent
BUG=27431
Review URL: http://codereview.chromium.org/3116040
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/3180027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a component which does not appear on the NTP, but does enforce that gallery urls are isolated in their own process. This is in anticipation of exposing extension api bindings to the gallery so it can install/detect/uninstall extensions & apps.
Note that this patch works correctly with the --apps-gallery-url. If specified, the replacement url will be inserted into the component app's extent
BUG=27431
Review URL: http://codereview.chromium.org/3116040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
card overlays in response to user input.
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3199018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
general AlertOverlay class.
BUG=53241
TEST=Exercice the 'Reset to Defaults' button in the dom-ui options window.
Review URL: http://codereview.chromium.org/3140027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3161036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are checked.
BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.
Review URL: http://codereview.chromium.org/3143012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entry
TEST=Open about:system. Table containing available system information is shown.
Clicking on button Expand shows associated entry, and clicking on Collapse hides it. Initialy all entries are hidden.
Clicking on Expand all / Collapse all shows / hides all entries.
about:system/foo hides all entries but foo, and scrolls to it
BUG=4973
Review URL: http://codereview.chromium.org/3173038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify preference UI works properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3170042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3140026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
around nav bar items.
BUG=chromium-os:6059
TEST=none
Review URL: http://codereview.chromium.org/3157037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for easier use on CrOS.
BUG=none
TEST=Verify CrOS preferences working properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3174032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52765
TEST=Bookmark sites in a language different than the language Chrome is configured in (you should have few of them, with titles long enough, so there are more than 100 characters in that language). Go to the bookmark manager, no translate infobar should be shown.
Review URL: http://codereview.chromium.org/3130045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3153034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Differences over the reverted version (http://codereview.chromium.org/3080034/show - reverted http://codereview.chromium.org/3137022/show ):
* Jobs never log anything in their destructor, as the HostResolverImpl randomly outlives the NetLog, at least in some unit tests.
* Removed the extra log entries for when a DNS lookup starts/completes. Instead, the job's event is ended in OnLookupComplete().
* Slight modification of the CanceledAsynchronousLookup unit test, as the Job is now closed before posting any events to the Request. For actual lookups, this behavior means the Job's duration more accurately reflects the time the DNS lookup takes itself.
BUG=46844
TEST=Look at the net-internals screen.
Review URL: http://codereview.chromium.org/3119027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually on the netbook
BUG=chromium-os:5152
Review URL: http://codereview.chromium.org/3153022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Properly enable and disable the Edit and Remove buttons based on select
control state.
* Modify the title of the address/CC overlays when pressing the
'Add address/CC' buttons.
* Remove the ability to select multiple options.
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3125039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3184018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3174028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3119038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and USB key. Actual burning is not included in the change list.
BUG=chromium-os:5346
TEST=type in chrome://imagebuner in browser. UI lists all media that image can be burnt to. After selecting burning target by clicking an image right to the target name, image download should start, and download progress should be displayed. After download ends alert should pop up asking user to confirm that he wants to burn image to selected device. Clicking both ok or cancel shouldn't do anything, since actual burning isn't stil included in CL.
Image should be downloaded to chrome_image folder in users Downloads directory.
this folder is deleted during shutdown.
This is only visible in ChromeOS...
Review URL: http://codereview.chromium.org/2808100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
shadow and a border.
BUG=chromium-os:5956
TEST=none
Review URL: http://codereview.chromium.org/3146030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3122034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3061044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
managing proxies.
BUG=51376
TEST=Verify proxy settings UI matches proposal when proxy settings are managed by an extension.
Review URL: http://codereview.chromium.org/3132030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify 'Show Gears Settings' button works properly in ChromeWin via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3187010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
should use the same UI.
BUG=none
TEST=Verify that the 'Show Passwords' button displays the passwords panel in dom-ui.
Review URL: http://codereview.chromium.org/3149025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
multiple times.
Fix the problem when force closing the tab while importing.
BUG=49095
TEST=None
Review URL: http://codereview.chromium.org/3167028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the password exceptions list.
BUG=49093
TEST=None
Review URL: http://codereview.chromium.org/3177023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Second attempt to repair options regression.
Review URL: http://codereview.chromium.org/3130041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Should fix DOM options on non-chromeos platforms.
Review URL: http://codereview.chromium.org/3152037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Ensure that pulling up options on non-chrome os devices doesn't report
problems.
Review URL: http://codereview.chromium.org/3170022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3108032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3157027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such.
BUG=none
TEST=compile; manual testing
Review URL: http://codereview.chromium.org/3146019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------
Make the saved passwords tab work.
BUG=49093
TEST=None
------------
TBR=sargrass
Review URL: http://codereview.chromium.org/3108034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Broke compile.
TBR=rkc
Review URL: http://codereview.chromium.org/3199006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Backend: Various reports submitted from Chrome OS and Windows builds
sent to the feedback test server. For Chromium OS, sent reports
with current screenshot and saved screenshots; verified all reports
for data accuracy and completion.
Frontend: Tested the UI features by excersizing various options; tested
not selecting any issue, tested switching between screenshot types.
Review URL: http://codereview.chromium.org/3181027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactors common elements (favicon source, CSS styling) from the subpages and the main page into shared locations. Also fixes a few small existing mistakes in comments and function naming.
BUG=48713
TEST=DOMUI prefs should show favicons for startup pages.
Review URL: http://codereview.chromium.org/3112017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
too much text, and click+drag can take a while, for large amounts of text.
Bug=none
Test=Press the button
Review URL: http://codereview.chromium.org/3124029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=Open the dom ui dialog of the AutoFill options dialog, uncheck the checkbox,
see if the buttons become disable, do the reverse and see if the buttons becomes
enabled again and vice-versa.
Review URL: http://codereview.chromium.org/3156013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56681 0039d316-1c4b-4281-b951-d872f2087c98
|