| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace name link with name+error message in content browser;
- Show an error message ChromeOS's openItem;
- Update SimpleErrorBox so that it runs in a Chrome window;
- Put back "Show in folder" in download page and make it work with content
browser;
BUG=chromium-os:1637
TEST=Verify fix for chromium-os:1637 and verify error message pops up for unknown type file in downloads ui.
Review URL: http://codereview.chromium.org/2748007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We don't use this yet, but the plan is to move everything in the resources directory into here.
BUG=42770
Review URL: http://codereview.chromium.org/2667001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a pref observer for prefs::kNTPShownSections and calls a js function when these changes. This is so that instances of the NTP do not get out of sync with each other.
BUG=None
TEST=Open two or more NTPs. Hide and show different sections and the sections should be hidden and removed on all instances.
Review URL: http://codereview.chromium.org/2792004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4014
TEST=none
Review URL: http://codereview.chromium.org/2746008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2558
TEST=none
Review URL: http://codereview.chromium.org/2723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a sound mute icon and swap between sound high and mute icon based on
volume change;
- Change sound button click to toggle volume mute;
- Show volume control when mouse over sound button and hide it when mouse
leaves;
- Call volumeChange after we setupPlaybackControls so that volume slider's
value syncs with media element's volume;
- Removed "controlbutton" class from "volume" element because it is really
a control button and "controlbutton" style sets its hight to 30px;
BUG=chromium-os:3148
TEST=Verify click on sound button mute/unmute audio and volume slider shows up when mouse over sound button.
Review URL: http://codereview.chromium.org/2722006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3462
TEST=none
Review URL: http://codereview.chromium.org/2758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2737001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we remove an item.
Change the code to do the add and removal to the cache in the addAt and remove methods to the tree and the tree items.
BUG=42239
TEST=See bug
Review URL: http://codereview.chromium.org/2696001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Start chrome with a new blank profile. No bottom promos should show up.
Review URL: http://codereview.chromium.org/2637004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tbarzic@chromium.org:
Implemented functionality for viewing chromeOS system status
BUG=chromium-os:3807
TEST=type in about:system in the browser and system status page should appear
Review URL: http://codereview.chromium.org/2698003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:plugins and show update link for out-of-date ones.
Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2686001
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2686001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
too many are not h.264.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2622002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40924
TEST=Go to a bookmark folder in the bookmarks manager where the list has a vertical scrollbar. Middle clicking on a bookmark should open the bookmark in a background tab.
Review URL: http://codereview.chromium.org/2658004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When deleting multiple folders we get callback after each remove and this can trigger a selection change which in turn triggers a call to getSubtree for a folder that was just removed. When this happens we finish the Promise with the value undefined.
BUG=None
TEST=Create two folders and select both. Hit Delete and check that we do not get a script error. (We still get an error from the extension API that the id no longer exists but at least we do not keel over.
Review URL: http://codereview.chromium.org/2647001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=something
Review URL: http://codereview.chromium.org/2507001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39250
TEST=Select a folder with no items. The sort command should be disabled.
Review URL: http://codereview.chromium.org/2467007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
enqueueing an item is available from the menu.
Review URL: http://codereview.chromium.org/2436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We used to assume that all bookmark imports were adding a folder to "Other bookmarks". This is not always the case so now we reload the tree and the list instead.
BUG=39893
TEST=Start with an empty profile. Click "Import bookmarks" on the bookmarks toolbar. The imported bookmarks and bookmarks folders should show up.
Review URL: http://codereview.chromium.org/2485002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41005
TEST=as described in the bug
Review URL: http://codereview.chromium.org/2322005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(This way don't need to give separate instructions on bug reports depending on what version of chrome they are using, can still just say "copy dump from about:net-internals")
Review URL: http://codereview.chromium.org/2365002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should help reduce confusion when reading logs that have a mixture of passive and actively captured events (since there may have been some loss of information along the boundaries).
Review URL: http://codereview.chromium.org/2094020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by seh@chromium.org:
http://codereview.chromium.org/2249001/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2252004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2248001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the CSS that follows roma's button design.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2159004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new work will take a very different approach (using a component extension,
similar to the bookmark manager).
This basically reverts the following commits:
- http://src.chromium.org/viewvc/chrome?view=rev&revision=20595
(http://codereview.chromium.org/155067)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19918
(http://codereview.chromium.org/155051)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19906
(http://codereview.chromium.org/150207)
BUG=173
TEST=everything still builds
Review URL: http://codereview.chromium.org/2156003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=seh
Review URL: http://codereview.chromium.org/2074026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
command line.
BUG=none
TEST=Go to about:net-internals click on dump to text, check if version and command line are good.
Patch contributed by malavv
Review URL: http://codereview.chromium.org/2104012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/2063014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2773
TEST=none
Review URL: http://codereview.chromium.org/2079013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
uses rather than using images. This looks a lot sharper.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2078019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2104011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2097011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3357
TEST=none
Review URL: http://codereview.chromium.org/2129012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The typo led to access of undefined javascript variable on chrome://net-internals when the load flags were 0.
Review URL: http://codereview.chromium.org/2089015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The start/end events would get smashed together when the start event had extra parameters (the case where the end event had extra parameters was already being handled properly).
Review URL: http://codereview.chromium.org/2068008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here are some examples showing what it looks like now (the stuff in parenthesis is new):
--> load_flags = 8240 (DISABLE_CACHE | DISABLE_INTERCEPT | DO_NOT_SAVE_COOKIES)
--> net_error = -105 (NAME_NOT_RESOLVED)
BUG=37421
Review URL: http://codereview.chromium.org/2115007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31584
TEST=none
Review URL: http://codereview.chromium.org/2113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are save as (such as images)
BUG=chromium-os:1581
TEST=none
Review URL: http://codereview.chromium.org/2074009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses a popup window that is carefully positioned to be placed over the icon on the NTP. The popup fades out after a short delay.
BUG=None
TEST=Start with --enable-apps and launch an app. The icon should *stick* for a very short period and then fade out.
Review URL: http://codereview.chromium.org/2095008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "Reload" button was used to refresh the stats + cache listings.
With this change, I poll the statistics for updates, so the reload button is unecessary.
Note that the cache listing is too expensive to poll, so I replaced it with a link to a listings page.
Lastly, updated the text dump to include the http cache statistics.
BUG=37421
Review URL: http://codereview.chromium.org/2085005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(It was possible to get unmatched start/end before).
Also renamed the event to URL_REQUEST_START_JOB, since it is really a superset of URLRequest::Start().
Review URL: http://codereview.chromium.org/2091009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42116
TEST=None
Review URL: http://codereview.chromium.org/2102007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
timeticks.
Also use a prettier display for the DNS cache and "bad proxy" cache.
BUG=37421
Review URL: http://codereview.chromium.org/2120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prefixed with '+'.
TBR=willchan
Review URL: http://codereview.chromium.org/2098008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Display it on the about:net-internals page
- Collect it in the histogram Net.OSErrorsForGetAddrinfo.
Review URL: http://codereview.chromium.org/2134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and modified communication with chat engine for increased reliability.
Patch by seh@chromium.org:
http://codereview.chromium.org/2065004/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2094007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47332 0039d316-1c4b-4281-b951-d872f2087c98
|