| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
pages should specify CSP as a second line of defense against XSS vulnerabilities.
Review URL: http://codereview.chromium.org/8102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
transitions to work properly (solves app dropped on other pane bug).
BUG=97792
R=csilv@chromium.org
TEST=Drop an app on a non-app page and make sure 1) it wormholes, 2) it re-appears on the apps page.
Review URL: http://codereview.chromium.org/8072024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
*) Focus is restricted to the TPM overlay.
*) The 'OK' button is initially focused.
BUG=chromium-os:18753,chromium-os:18754
TEST=Manual: in OOBE EULA screen, click the Security Setting link; focus should be initially over the Ok button and should never leave the overlay.
Review URL: http://codereview.chromium.org/8086019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20182
TEST=Manual: when password field is empty and focused, semi-transparent label 'Enter password' should be seen.
Review URL: http://codereview.chromium.org/8082025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*) Image from camera is correctly displayed in the images list.
*) Fixed double-open of Take Photo dialog.
*) Fixed some test paths that crashed.
BUG=chromium-os:21043
TEST=Manual: in OOBE, after image is taken from camera, it should appear in the images list and be selectable.
Review URL: http://codereview.chromium.org/8085025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=Partial fix for chromium-os:20991.
TEST=Launch chromeOS with the command-line argument --enable_bluetooth, and switch to the System setttings page. A section for bluetooth devices appears below the touchpad section. Launching without the command-line argument suppresses the bluetooth section.
Review URL: http://codereview.chromium.org/8084003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This disables user selections and uses the default cursor in
the task manager dialog; previously, the title and the
headings were selectable (sadly, the possibly-useful-to-copy
data being displayed in the dialog was already
unselectable).
I'm also sorting the CSS rules as instructed by the style
guide.
BUG=chromium-os:20738
TEST=manual
Review URL: http://codereview.chromium.org/8089011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so that about:policy can wait for the async policy fetch to finish and grey out the "fetch policies" button as well as display
the correct "last policy fetch" time.
BUG=97076
TEST=
Review URL: http://codereview.chromium.org/7989006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18791
TEST=manual
Review URL: http://codereview.chromium.org/8070023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if they are managed by extensions.
In the content settings exceptions settings UI, extension managed exceptions will be locked and marked with a yellow background and an extension icon.
BUG=98258
TEST=Set a content settings exceptions using an extension (e.g. the sample extension for the content settings extension API). Open the settings for content settings exceptions and verify that the set exception is marked yellow and with a small extension icon.
Review URL: http://codereview.chromium.org/7261020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
isn't unnecessarily long.
BUG=20989
TEST=
Review URL: http://codereview.chromium.org/8072028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
*) When focus such user with keyboard, a 'Sign in' button appears.
*) 'Remove user' button no longer focusable by keyboard.
BUG=chromium-os:20046
TEST=Manual: add a user, change password, log out and select this new user with keyboard; instead of instantly opening a Gaia frame, Signin button should appear that opens Gaia frame when clicked.
Review URL: http://codereview.chromium.org/8060051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds some explanatory text to the side of the sync promo.
Note, this doesn't change the look of the sync sign-in dialog in Settings. I'll do that as a separate CL.
BUG=89276
TEST=
Review URL: http://codereview.chromium.org/8021014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=97096
TEST=none
R=isherman@chromium.org
Review URL: http://codereview.chromium.org/8082007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89276
TEST=
Review URL: http://codereview.chromium.org/7966028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98460
Review URL: http://codereview.chromium.org/8079005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20980
TEST=make sure device representation in chrome://files looks nice now
Review URL: http://codereview.chromium.org/8060048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=confirmed the visuals on Cr48.
BUG=chromium-os:17733
Review URL: http://codereview.chromium.org/7848008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103010
Review URL: http://codereview.chromium.org/7976017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18744,chromium-os:20469
TEST=manual
Review URL: http://codereview.chromium.org/7980010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20757
TEST=manual
Review URL: http://codereview.chromium.org/8065010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=87378
TEST=None, stylistic changes, shouldn't change how the page works.
Review URL: http://codereview.chromium.org/8008015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the build/installer output.
This change undoes the revert of 99878. This change was originally reverted
because it was decided to push this change to M16.
BUG=94920
TEST=Do an Official build in mac, linux and win. Ensure that after installing
the app, you can find the default apps under the install's directory
structure. For win, this is under a default_apps directory, for mac, this is
under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/8041033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
print_preview_cloud.js.
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Review URL: http://codereview.chromium.org/7976017
TBR=abodenha@google.com
Review URL: http://codereview.chromium.org/8055036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
section on the Personal Options page.
BUG=98225
TEST=none
Review URL: http://codereview.chromium.org/8055025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Auto reload auth extension when we hit frame error and we are online. Retry three times with 5s, 10s and 20s delays.
Also add more logs to find out whether the offline/portal message is being shown.
BUG=chromium-os:20323
TEST=Verify fix for chromium-os:20323.
Review URL: http://codereview.chromium.org/8037035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, hide the autofill options in guest mode as it does not
make sense for a guest user.
TEST=confirm that crash is fixed and the autofil options are hidden for the guest user on chrome os
BUG=chromium-os:20846
Review URL: http://codereview.chromium.org/8050026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ignore keydown event when pod row is disabled. Pod row is disabled when there is a login in progress.
BUG=chromium-os:20823
TEST=Verify crash in chromium-os:20823 no longer happens.
Review URL: http://codereview.chromium.org/8060014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
between them.
BUG=
TEST=NetworkActionPredictor*
Review URL: http://codereview.chromium.org/8036003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Review URL: http://codereview.chromium.org/7976017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=89092
TEST=Add a startup page with a very long URL, verify that startup items list is a reasonable size.
Review URL: http://codereview.chromium.org/8059026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8038041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8052008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed login screen to observe network changes directly, instead of 'navigator.onLine' usage.
This CL also fixed the problem captive portal wasn't being hide, when good connection had appeared.
BUG=chromium-os:18744
TEST=manual
Review URL: http://codereview.chromium.org/8043024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions as 'Sharing'.
Also, a little refactoring in file tasks execution.
BUG=chromium-os:19534
TEST=See bug.
Review URL: http://codereview.chromium.org/8036019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=89057
TEST=NetInternalsTest.NetInternalsHSTSView*
Review URL: http://codereview.chromium.org/8028002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds 'Start guest session' link to the captive portal part of the
offline screen without changing '.grd' files.
BUG=chromium-os:20755
TEST=manual
Review URL: http://codereview.chromium.org/8054010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18216
TEST=Login with new user and check if his image is his profile picture.
Review URL: http://codereview.chromium.org/7888007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address overlay.
* Consolidated the JavaScript classes ValuesListItem and ValuesAddRowListItem into a single class, for the sake of inheritance.
* Generalized the logic in ValuesListItem slightly to allow for straightforward subclassing.
* Added the NameValuesListItem and NameValuesList classes to represent the list of separated-out first/middle/last names.
BUG=71447
TEST=none
Review URL: http://codereview.chromium.org/8041006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=93176, 97523
TEST=manual
Review URL: http://codereview.chromium.org/7977029
TBR=binji@chromium.org
Review URL: http://codereview.chromium.org/8028049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're planning on enabling some WebUI dialogs by default on ChromeOS soon, so
expose in flags to make it easier for people to test.
Also tweak the certificate viewer UI a little to make it look and behave more
like the original:
- make it bigger (so it's generally big enough to fit the contents)
- automatically select the main certificate in the details pane
- scroll the details windows to the top
- add a border around the details windows (like the original)
- shrink hierarchy window a bit - it will rarely have more than 3 lines
- fix spacing and indendation on the main tab
BUG=98027
TEST=None
Review URL: http://codereview.chromium.org/8028024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=csilv
BUG=98070
TEST=manual
Review URL: http://codereview.chromium.org/8038035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=93176, 97523
TEST=manual
Review URL: http://codereview.chromium.org/7977029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
their DOM id strings, for use in tests.
TEST=manual, some tested by NetInternalsTest.*
BUG=89057
Review URL: http://codereview.chromium.org/8018004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20597
TEST=manual testing
Review URL: http://codereview.chromium.org/8028033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the 'Browse as Guest' text larger on TOUCH_UI and so easier to touch.
Disable the getting started guide for now on TOUCH_UI.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8046007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This column is hideen by default.
BUG=97571
TEST=manual, pass trybot
Review URL: http://codereview.chromium.org/7983059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
if you drag an app onto the page switchers and wait until it goes to the most visited page, it will start spamming asserts because MostVisited does not implement setDropEffect. I don't think anything harmful happens without this patch, but the assert is log spam.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the padding area from header bar into buttons so that the clickable area extends to the screen edges. Top/bottom padding are added to button via CSS. Left edge padding is handled by adding an extra div because background-position with offset from right (which is needed for RTL) is not yet supported.
BUG=chromium-os:20392
TEST=Verify fix for chromium-os:20392.
Review URL: http://codereview.chromium.org/8003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102601 0039d316-1c4b-4281-b951-d872f2087c98
|