summaryrefslogtreecommitdiffstats
path: root/chrome/browser/resources
Commit message (Collapse)AuthorAgeFilesLines
* Adding libevent to about:creditsian@chromium.org2010-02-041-0/+35
| | | | | | | | BUG=22301 TEST=Go to about:credits and verify that libevent is listed. Review URL: http://codereview.chromium.org/564053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38069 0039d316-1c4b-4281-b951-d872f2087c98
* Adding catches to states of the UI to only allow button pushes in certain ↵dhg@chromium.org2010-02-031-5/+30
| | | | | | | | | | | states. Basically adding error catching. BUG=none TEST=none Review URL: http://codereview.chromium.org/562005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37996 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmark managerarv@chromium.org2010-02-0335-0/+5783
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/560023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37980 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Make sure that hidden elements cannot be dragged.arv@chromium.org2010-02-021-1/+4
| | | | | | | | | BUG=34124 TEST=Hide thumbnails on NTP. Reload. Make sure you cannot drag the hidden thumbnails. Review URL: http://codereview.chromium.org/568006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37860 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Add work around for recent changes to HTML5 DnD behavior.arv@chromium.org2010-01-301-3/+12
| | | | | | | | | BUG=33657 TEST=Drag and drop thumbnails on the NTP to reorder them. Review URL: http://codereview.chromium.org/558055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37647 0039d316-1c4b-4281-b951-d872f2087c98
* Replace GtkFileChooser with file browser for ChromeOSxiyuan@chromium.org2010-01-291-16/+401
| | | | | | | | | | | | | - Remove dialogs_gtk.cc and add select_file_dialog.cc for chrome os build; - select_file_dialog.cc provides a SelectFileDialogImpl that serves file browse html via HTMLDialogUI; BUG=none TEST=none Review URL: http://codereview.chromium.org/543137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37547 0039d316-1c4b-4281-b951-d872f2087c98
* Add promo for extensions and bookmark sync back into the Mac NTP. Also, fix ↵mirandac@chromium.org2010-01-271-0/+1
| | | | | | | | | | | | | font size bug that snuck in with a recent webkit roll. BUG= 33291 TEST= run a Mac build with a new profile. See the extension / sync promo line and the puzzle piece on the NTP. Review URL: http://codereview.chromium.org/552193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37334 0039d316-1c4b-4281-b951-d872f2087c98
* Adding tab browsing for filebrowser.xiyuan@chromium.org2010-01-201-27/+300
| | | | | | | | | | | Committing this CL on dhg's behalf. Original Review: http://codereview.chromium.org/542083 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the fallback Mozilla code for parsing FTP LIST response.phajdan.jr@chromium.org2010-01-201-36/+0
| | | | | | | | | | | | | | | | | | The new parser seems to be compatible enough to do that. The Mozilla code was very helpful in the process of developing the new parser. Also add UI encouraging users to submit bug reports when we can't parse the listings, and an option to see the raw data sent by the server. This should allow us to fix remaining compatibility problems with very rare listing types or variations. When ?raw is found at the end of an FTP url and it is a directory listing, the parsing logic is bypassed and the data is displayed as-is with text/plain MIME type. TEST=none BUG=25520 Review URL: http://codereview.chromium.org/549053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36632 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/505031 for dhg:sky@chromium.org2010-01-111-2/+20
| | | | | | | | | | | Browser should pop up status when usb is inserted. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/547009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35967 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Increase the width for 'date-container' in download.html to 110px to make ↵jshin@chromium.org2010-01-111-5/+5
| | | | | | | | | | | | | | | room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly. 2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this). BUG=21699 TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line. Review URL: http://codereview.chromium.org/381009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35908 0039d316-1c4b-4281-b951-d872f2087c98
* Make about:plugin page get rendered properly in Hebrew and Arabic Chrome. ↵jshin@chromium.org2010-01-091-9/+19
| | | | | | | | | | | | | | Also make it use the same font as other 'domUI' pages. While doing so, get rid of some unnecessary string conversions in browser_about_handler.cc BUG=31782 TEST=Run Chrome with --lang=ar / --lang=he on Windows (or LANGUAGE=ar or LANGUAGE=he on Linux) and go to 'about:plugins' page. The page should be properly 'RTLized'. Review URL: http://codereview.chromium.org/523153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35851 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Make sure that we do not focus the thumbnails on mouse down.arv@chromium.org2010-01-061-0/+7
| | | | | | | | | | | | | We used to focus the thumbnail on mousedown which makes the thumbmail hover effect show up which confuses users. BUG=31361 TEST=Right click on a thumbnail and dismiss the context menu. The thumbnail should not be focused. Review URL: http://codereview.chromium.org/525045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35589 0039d316-1c4b-4281-b951-d872f2087c98
* Implement delaying resource requests until privacy blacklists are ready.phajdan.jr@chromium.org2010-01-051-1/+0
| | | | | | | | | | | | | | | | | | | Associate a BlacklistRequestInfo with each URLRequest started by ResourceDispatcherHost so that in various places we get access to the right BlacklistManager (each Profile has its own), and lazily cache a Blacklist::Match. BlacklistListener controls delaying requests until the privacy blacklist is ready for the request. BlacklistInterceptor handles substituting real response with a blocking page or blocking image. I've temporarily removed support for unblocking things. It was too hacky. This change also removes a large block of blacklist-related code from RDH to more focused classes. Should make it a little more readable. This should also make BlacklistManagerBrowserTest not flaky. TEST=Covered by browser_tests and unit_tests. BUG=21541, 29113 Review URL: http://codereview.chromium.org/501082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35538 0039d316-1c4b-4281-b951-d872f2087c98
* Make history page more responsive by rendering items incrementally instead ↵feldstein@chromium.org2009-12-181-5/+36
| | | | | | | | | | | of wiping out the page multiple times. Code review 501044 BUG=30020 TEST=Navigate through history to make sure it still works. On windows, have a spares history with multiple days, and click one of the first entries while the rest are still loading and make sure the click is not lost. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34908 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show "show in foloder" in chrome os.oshima@chromium.org2009-12-171-5/+15
| | | | | | | | | BUG=chromiun-os:916 TEST=None Review URL: http://codereview.chromium.org/506045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34837 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom Linux version strings (e.g. release channel, downstream ↵mmoss@google.com2009-12-151-1/+1
| | | | | | | | | | | vendor name, etc.). Also reformat the Mac/Win version strings as per comments in http://codereview.chromium.org/506007. Review URL: http://codereview.chromium.org/506016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34609 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "Bookmark sync" menu itemarv@chromium.org2009-12-152-14/+1
| | | | | | | | | | | | This also cleans up the states. BUG=28419 TEST=The menu item should be gone but we should still see errors from bookmark sync on the NTP Review URL: http://codereview.chromium.org/501029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34608 0039d316-1c4b-4281-b951-d872f2087c98
* Move channel (beta,dev,stable) determination code to a common location.jrg@chromium.org2009-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | Add channel info to about:version. Linux about box work not done. Linux channel determination code still a stub. BUG=30444 How to verify: - on both Mac and Win, with a branded build: - confirm the About Box and about:version have channel info after the version number. Channel for PC comes from the registry so it'll be the channel of your official install, not this build. Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined. Review URL: http://codereview.chromium.org/506007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34583 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Hide the notifier when restoring all removed thumbnails.arv@chromium.org2009-12-151-0/+4
| | | | | | | | | | BUG=29952 TEST=Blacklist a thumbanil. This shows the notifier. Then restore all remove thumbnails. The notifier should be hidden now. Review URL: http://codereview.chromium.org/494013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34576 0039d316-1c4b-4281-b951-d872f2087c98
* Creating new CL for uploading a picture from ChromiumOSdavemoore@chromium.org2009-12-111-26/+163
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/452016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix delete day so that font is correct and it can be reached through tab.mirandac@chromium.org2009-12-091-1/+2
| | | | | | | | | | Landing for eisinger. BUG= 21459 TEST= On history page, font for delete day msg is correct, and you can tab to it. Review URL: http://codereview.chromium.org/473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34168 0039d316-1c4b-4281-b951-d872f2087c98
* Make "delete history for day" message have the correct font on Mac.mirandac@chromium.org2009-12-091-1/+1
| | | | | | | | | | | Committing for feldstein. BUG= 21459 TEST= History tab on mac should show correct font in "delete day" message. Review URL: http://codereview.chromium.org/460148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34111 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-051-30/+33
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* Move incognito text box down.mirandac@chromium.org2009-12-041-0/+1
| | | | | | | | | Top line of incognito text box is now at the same point as the top line of the thumbnails in the regular NTP. This means that themed NTP backgrounds look the way the theme designers planned them to (for example, you can see the "Chrome comet" in Star Gazing, and the pattern swirl in OP), and the regular and incognito NTPs have a unified look. Review URL: http://codereview.chromium.org/463030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33856 0039d316-1c4b-4281-b951-d872f2087c98
* Notify user that Chrome is already synced if promo banner "sync me" link is ↵mirandac@chromium.org2009-12-031-0/+9
| | | | | | | | | | | clicked. BUG= 28795 TEST= sync bookmarks, then click "sync" link in promo again. see notification that you are already synced. Review URL: http://codereview.chromium.org/462011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33685 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-022-31/+22
| | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527 Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33527 - Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-022-22/+31
| | | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/460007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-022-31/+22
| | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Allow tips with a[target]arv@chromium.org2009-12-011-0/+7
| | | | | | | | | | | | | This does not reject links with targets but it does reset the target to the current page. BUG=29084 TEST=With tips turned on and the web inspector shown. You should no longer see any warnings about a[target] Review URL: http://codereview.chromium.org/452029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33470 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the RTL UI support in the extensions_ui (chrome://extensions). While ↵jshin@chromium.org2009-11-251-13/+86
| | | | | | | | | | | | | doing so, make it use the font-family and font-size (84% by default) set in locale_settings for the current UI language. The body font size used to be 87%. To make up for the difference between two, the font sizes given in percentage are adjusted (increased) accordingly in the rest of the file. BUG=28202 TEST=1. Run Chrome with '--lang=he' or '--lang=ar' on Windows (or 'LANGUAGE=he chrome' / 'LANGUAGE=ar chrome' on Linux) and go to 'chrome://extensions'. Strings are not yet translated, but the overall UI should be RTL. 2. Run Chrome in en-US (or your favorite LTR language) and go to 'chrome://extensions'. It should look the same as before. Review URL: http://codereview.chromium.org/434024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33108 0039d316-1c4b-4281-b951-d872f2087c98
* Remove theming from notifications and extension/bookmark sync promo.mirandac@chromium.org2009-11-241-1/+17
| | | | | | | | | | BUG= 28577 TEST= Trigger notification (remove a thumbnail) with themed browser, note that text and link in notification (and in extension/bookmark sync promo) are legible and retain original colors. Review URL: http://codereview.chromium.org/437045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32996 0039d316-1c4b-4281-b951-d872f2087c98
* More tweaks and fixes for extension and bookmark sync promo. mirandac@chromium.org2009-11-203-34/+84
| | | | | | | | | | | | Make bookmark sync link start up the sync process. Make the message more aesthetically pleasing. Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors. BUG= 27853, 28047 TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process. Review URL: http://codereview.chromium.org/402021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32619 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix issue where a thumbnail was stuck in hover mode after a delete.arv@chromium.org2009-11-201-0/+18
| | | | | | | | | | | | | | | | | | | The reason why the thumbnail was stuck is that it was focused due to the mousedown (the element was reused). Now we blur the element when we blacklist the thumbnail. This also adds support for Del (and Cmd+Backspace for mac) to blacklist the focused thumbnail. This also fixes the issue where the user could tab to a filler. BUG=28185 TEST=Remove a thumbnail and move the mouse out of the mostvisited thumbnails. None of them should be highlighted. Review URL: http://codereview.chromium.org/414011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32573 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-183-8/+10
| | | | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176 Review URL: http://codereview.chromium.org/385135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32413 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32176 - Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-182-10/+7
| | | | | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/399051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32237 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-172-7/+10
| | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32176 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Make sure the notifier does not get focused after it was hidden.arv@chromium.org2009-11-161-0/+5
| | | | | | | | | | | BUG=27833 TEST=See bug Review URL: http://codereview.chromium.org/387064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32103 0039d316-1c4b-4281-b951-d872f2087c98
* add chromeos creditsdavemoore@chromium.org2009-11-161-0/+7577
| | | | | | Review URL: http://codereview.chromium.org/399012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32096 0039d316-1c4b-4281-b951-d872f2087c98
* Minor text changes per Kathy's suggestions.aa@chromium.org2009-11-151-1/+1
| | | | | | TBR=kathyw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32034 0039d316-1c4b-4281-b951-d872f2087c98
* Add message and image to NTP to promote extensions and bookmark sync.mirandac@chromium.org2009-11-154-14/+84
| | | | | | | | | BUG= 27393, 26744 TEST= promotional messages should show up on NTP. Review URL: http://codereview.chromium.org/394005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
* Add new link to bottom right of extension management page.aa@chromium.org2009-11-131-6/+27
| | | | | | Review URL: http://codereview.chromium.org/394002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31893 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in file browser.sky@chromium.org2009-11-121-1/+1
| | | | | | | | TBR=dhg BUG=none Review URL: http://codereview.chromium.org/385081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31858 0039d316-1c4b-4281-b951-d872f2087c98
* Improve text on management UI. Still waiting for a treatmentaa@chromium.org2009-11-121-3/+18
| | | | | | | | | from the design team, but I wanted to at least get the words in before the string freeze. Review URL: http://codereview.chromium.org/385075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31842 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Hide "Make this my home page" after setting the home page.arv@chromium.org2009-11-123-8/+14
| | | | | | | | | | | | | | | | | | | | This also fixes an l10n issue where the string was hard coded in English. Instead of using the tips infrastructure, after setting the home page we send an ack to the NTP and show a notification. In this way the user will see the notification even if they have hidden the tips. Added a ui test that clicks on the link and checks the state of the UI afterwards. BUG=25101 TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click on the link "Make this my home page" at the bottom. You should see a banner at the top. Pressing Alt-Home should now go to the NTP. Review URL: http://codereview.chromium.org/392005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31823 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/386015 for dhg:sky@chromium.org2009-11-121-4/+3
| | | | | | | | | | | | | Changing the dom_ui so that it has a new call which allows the javascript of the page to open a new window. BUG=none TEST=none Review URL: http://codereview.chromium.org/385074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31816 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to the new extensions default icon.finnur@chromium.org2009-11-111-0/+0
| | | | | | | | | | | BUG=27399 TEST=Extensions without an icon now have a light-blue puzzle-piece icon when installing/uninstalling them and when listing them on chrome://extensions. Review URL: http://codereview.chromium.org/384055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31713 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/379007 for Dave:sky@chromium.org2009-11-111-67/+338
| | | | | | | | | | | | Fixes leak in BackingStore as shown by valgrind. XFree doesn't free the data of the image, where as XDestroyImage does. BUG=none TEST=none Review URL: http://codereview.chromium.org/391008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled extensions should be uninstallable. finnur@chromium.org2009-11-101-2/+3
| | | | | | | | | | | | | | | | | | | | | The code to display the dialog looks up an Extension by id but doesn't return disabled ones. So I added that option to the function. I also added a check so that we don't show the Options button enabled when the extension is disabled, since you need the extension to be enabled for the Options page to work. BUG=26910 TEST=Disable an extension that has an Option page, make sure Options is not enabled after disabling, then uninstall it. It should uninstall. Review URL: http://codereview.chromium.org/385014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo from r31351aa@chromium.org2009-11-071-1/+1
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31371 0039d316-1c4b-4281-b951-d872f2087c98