summaryrefslogtreecommitdiffstats
path: root/chrome/browser/safe_browsing/safe_browsing_service.h
Commit message (Collapse)AuthorAgeFilesLines
* Include high-fidelity metadata about a download in incident reports.grt2014-11-041-0/+7
| | | | | | | | | | | This is accomplished by the introduction of the DownloadMetadataManager, which maintains state about the most recent binary download. BUG=389123, 386915, 389643 Review URL: https://codereview.chromium.org/663023007 Cr-Commit-Position: refs/heads/master@{#302624}
* Standardize usage of virtual/override/final in chrome/browser/safe_browsing/dcheng2014-10-221-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=mattm@chromium.org Review URL: https://codereview.chromium.org/657373004 Cr-Commit-Position: refs/heads/master@{#300586}
* replace OVERRIDE and FINAL with override and final in chrome/browser/[r-z]*mostynb2014-10-071-1/+1
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/629603002 Cr-Commit-Position: refs/heads/master@{#298430}
* Moving all the incident reporting stuff to a common folderpmonette@google.com2014-08-151-1/+1
| | | | | | | | | BUG= Review URL: https://codereview.chromium.org/470213002 Cr-Commit-Position: refs/heads/master@{#289938} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289938 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new delayed analysis that verifies the signatures of Chrome's binariespmonette@google.com2014-08-141-0/+4
| | | | | | | | | BUG=402455 Review URL: https://codereview.chromium.org/444123002 Cr-Commit-Position: refs/heads/master@{#289703} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289703 0039d316-1c4b-4281-b951-d872f2087c98
* Support for process-wide incidents in the safe browsing incident reporting ↵grt@chromium.org2014-08-071-0/+7
| | | | | | | | | | | service. BUG=399428 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/441453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288028 0039d316-1c4b-4281-b951-d872f2087c98
* Safe browsing incident reporting service improvements.grt@chromium.org2014-06-191-2/+3
| | | | | | | | | | | | | Honour the safe browsing opt out and report on incidents that arrive before profile initialization is complete. BUG=383039,383365 R=mattm@chromium.org, noms@chromium.org TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/341563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278358 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Revert of [Safe browsing] Support FULL_SAFE_BROWSING mode in ↵mathp@chromium.org2014-06-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Android. (https://codereview.chromium.org/334273002/) Reason for revert: My mistake, I mistakenly thought it was breaking the build. Sorry to the author. Original issue's description: > Revert of [Safe browsing] Support FULL_SAFE_BROWSING mode in Android. (https://codereview.chromium.org/327083004/) > > Reason for revert: > if FULL_SAFE_BROWSING is not defined, SafeBrowsingService::IsEnabledByFieldTrial is not defined and compile fails. > > Original issue's description: > > [Safe browsing] Support FULL_SAFE_BROWSING mode in Android. > > > > A client can register customized SafeBrowsingResourceThrottleFactory > > in FULL_SAFE_BROWSING mode. > > > > BUG=381896 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277198 > > TBR=bengr@chromium.org,sgurun@chromium.org,davemoore@chromium.org,sky@chromium.org,shess@chromium.org,feng@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=381896 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277452 TBR=bengr@chromium.org,sgurun@chromium.org,davemoore@chromium.org,sky@chromium.org,shess@chromium.org,feng@chromium.org NOTREECHECKS=true NOTRY=true BUG=381896 Review URL: https://codereview.chromium.org/331213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277459 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [Safe browsing] Support FULL_SAFE_BROWSING mode in Android. ↵mathp@chromium.org2014-06-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/327083004/) Reason for revert: if FULL_SAFE_BROWSING is not defined, SafeBrowsingService::IsEnabledByFieldTrial is not defined and compile fails. Original issue's description: > [Safe browsing] Support FULL_SAFE_BROWSING mode in Android. > > A client can register customized SafeBrowsingResourceThrottleFactory > in FULL_SAFE_BROWSING mode. > > BUG=381896 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277198 TBR=bengr@chromium.org,sgurun@chromium.org,davemoore@chromium.org,sky@chromium.org,shess@chromium.org,feng@chromium.org NOTREECHECKS=true NOTRY=true BUG=381896 Review URL: https://codereview.chromium.org/334273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277452 0039d316-1c4b-4281-b951-d872f2087c98
* [Safe browsing] Support FULL_SAFE_BROWSING mode in Android.feng@chromium.org2014-06-141-1/+1
| | | | | | | | | | | A client can register customized SafeBrowsingResourceThrottleFactory in FULL_SAFE_BROWSING mode. BUG=381896 Review URL: https://codereview.chromium.org/327083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277198 0039d316-1c4b-4281-b951-d872f2087c98
* Safe Browsing Incident Reporting Service.grt@chromium.org2014-06-131-0/+10
| | | | | | Review URL: https://codereview.chromium.org/282363005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277110 0039d316-1c4b-4281-b951-d872f2087c98
* [Safe browsing] Initialize safe browsing preference properly.feng@chromium.org2014-06-051-0/+6
| | | | | | | | | | | | | In Finch trial, we'd like to enable safe browsing for users in the 'Enabled' group, but disalbe it for uses in controlled group and not in trial. BUG=379256 R=davemoore@chromium.org, mariakhomenko@chromium.org, shess@chromium.org Review URL: https://codereview.chromium.org/301353010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274993 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --safebrowsing-url-prefix flag.mattm@chromium.org2014-04-111-1/+1
| | | | | | | | | | | | | Makes SafeBrowsingService::GetProtocolConfig virtual so that tests can override that to change the url prefix and disable auto update. Also removes the use of --safebrowsing-disable-auto-update from these files. BUG=354747,354743 Review URL: https://codereview.chromium.org/233683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263377 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=267514oleg@chromium.org2013-12-171-0/+4
| | | | | | | | Design doc: https://docs.google.com/a/google.com/document/d/1oDS8nT2hj6tOAnhK-sZpK5sIhfc3RPaapzRw1Fb0sng Review URL: https://codereview.chromium.org/49253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241316 0039d316-1c4b-4281-b951-d872f2087c98
* Add some dchecks and comments about SafeBrowsingService member variable ↵mattm@chromium.org2013-10-101-6/+13
| | | | | | | | | | thread access. BUG=none Review URL: https://codereview.chromium.org/24302013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix accessing SafeBrowsingService::url_request_context_getter_ from multiple ↵mattm@chromium.org2013-10-091-1/+2
| | | | | | | | | | threads. BUG=262999 Review URL: https://codereview.chromium.org/24280010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227697 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198844 "Move sequenced_task_runner to base/task"dbeam@chromium.org2013-05-081-1/+1
| | | | | | | | | | | | | | | | | Reverting revisions that rely on r198820 so to unbreak the build. > Move sequenced_task_runner to base/task > > BUG= > R=akalin@chromium.org > > Review URL: https://codereview.chromium.org/14927008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14985007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198848 0039d316-1c4b-4281-b951-d872f2087c98
* Move sequenced_task_runner to base/taskbrettw@chromium.org2013-05-081-1/+1
| | | | | | | | | BUG= R=akalin@chromium.org Review URL: https://codereview.chromium.org/14927008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198844 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-241-1/+1
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'master' into file_path_browserbrettw@chromium.org2013-02-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version control markers Merge branch 'master' into file_path_browser remove version control Fix typo Merge branch 'master' into file_path_browser Conflicts: chrome/browser/intents/native_services_browsertest.cc chrome/browser/ui/intents/native_file_picker_service.cc Merge branch 'master' into file_path_browser Conflicts: chrome/browser/chromeos/drive/drive_file_system.cc chrome/browser/chromeos/drive/drive_file_system.h chrome/browser/chromeos/drive/drive_file_system_interface.h chrome/browser/chromeos/drive/drive_file_system_unittest.cc chrome/browser/chromeos/drive/file_system/drive_operations.cc chrome/browser/chromeos/login/wallpaper_manager.cc chrome/browser/chromeos/login/wallpaper_manager.h chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc chrome/browser/google_apis/gdata_wapi_operations.cc chrome/browser/google_apis/gdata_wapi_operations.h chrome/browser/google_apis/gdata_wapi_operations_unittest.cc chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/profiles/profile_impl_io_data.cc chrome/browser/profiles/profile_impl_io_data.h chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc chrome/browser/ui/webui/options/manage_profile_handler.cc Long lines long lines some long lines. long lines long lines Beginning of lines. Rename FilePath -> base::FilePath in chrome/browser git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the reverted patch from CL 11366042 by addressing lifetimes/access to ui ↵sgurun@chromium.org2012-11-271-409/+37
| | | | | | | | | | | and database managers. BUG=159136 Review URL: https://chromiumcodereview.appspot.com/11411105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169608 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefObserver usage, batch 9.joi@chromium.org2012-11-211-6/+0
| | | | | | | | | | TBR=abodenha@chromium.org,erikkay@chromium.org,erikwright@chromium.org,erg@chromium.org,ben@chromium.org,xiyuan@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11414083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169029 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 168658 - Refactor SafeBrowsingServicebenwells@chromium.org2012-11-201-36/+417
| | | | | | | | | | | | | | | Split UI and reporting implementation from SafeBrowsingService. BUG=159136 Reverting as it seems to have caused failures in sync_integration_tests. Review URL: https://chromiumcodereview.appspot.com/11366042 TBR=sgurun@chromium.org Review URL: https://codereview.chromium.org/11316092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168685 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SafeBrowsingServicesgurun@chromium.org2012-11-201-417/+36
| | | | | | | | | | | Split UI and reporting implementation from SafeBrowsingService. BUG=159136 Review URL: https://chromiumcodereview.appspot.com/11366042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168658 0039d316-1c4b-4281-b951-d872f2087c98
* Rename SafeBrowsingServiceTest in safe_browsing_test.cc to ↵jam@chromium.org2012-11-121-0/+1
| | | | | | | | | SafeBrowsingServerTest to avoid collision with SafeBrowsingServiceTest in safe_browsing_service_browsertest.cc. This is in prepartion to https://codereview.chromium.org/11366196/ landing (after master restarts) which moves safe_browsing_test.cc to browser_tests to avoid building another target just for this one test. BUG=148792 Review URL: https://codereview.chromium.org/11366204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167257 0039d316-1c4b-4281-b951-d872f2087c98
* Split safe browsing protocol manager. Currently the protocol manager has two ↵sgurun@chromium.org2012-11-081-0/+4
| | | | | | | | | | | jobs: it downloads safebrowsing information from Google servers, and it provides safebrowsing stats. These two are orthogonal so we split the functionality into separate entities. BUG=158532 Review URL: https://chromiumcodereview.appspot.com/11273106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166607 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 165883 - Revert 165865 - Add SafeBrowsingProtocolManagerDelegate class.cbentzel@chromium.org2012-11-051-16/+16
| | | | | | | | | | | | | | | | | | | <nacl_integration test failures continue to happen after the original CL was reverted, so adding back in> This removes any direct dependency of SafeBrowsingService on SafeBrowsingProtocolManager, and should make it easier to unit test SafeBrowsingProtocolManager. BUG=158246 Review URL: https://chromiumcodereview.appspot.com/11340020 TBR=cbentzel@chromium.org Review URL: https://codereview.chromium.org/11369068 TBR=cbentzel@chromium.org Review URL: https://codereview.chromium.org/11369072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165915 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 165865 - Add SafeBrowsingProtocolManagerDelegate class.cbentzel@chromium.org2012-11-041-16/+16
| | | | | | | | | | | | | | | | <I am doing this speculatively to see if it impacts nacl_integration test failures that started with this CL> This removes any direct dependency of SafeBrowsingService on SafeBrowsingProtocolManager, and should make it easier to unit test SafeBrowsingProtocolManager. BUG=158246 Review URL: https://chromiumcodereview.appspot.com/11340020 TBR=cbentzel@chromium.org Review URL: https://codereview.chromium.org/11369068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165883 0039d316-1c4b-4281-b951-d872f2087c98
* Add SafeBrowsingProtocolManagerDelegate class.cbentzel@chromium.org2012-11-041-16/+16
| | | | | | | | | | | This removes any direct dependency of SafeBrowsingService on SafeBrowsingProtocolManager, and should make it easier to unit test SafeBrowsingProtocolManager. BUG=158246 Review URL: https://chromiumcodereview.appspot.com/11340020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165865 0039d316-1c4b-4281-b951-d872f2087c98
* Remove content::NotificationObserver dependency from most Prefs code.joi@chromium.org2012-11-011-1/+7
| | | | | | | | | | | | | | | | | | | | | Instead of using content::NotificationObserver, introduce specific type-safe observer classes and update users to use them. In a very large number of cases this was the users' only reason for being a content::NotificationObserver and they would have a lot of boiler-plate code such as a DCHECK on the notification type and unpacking of the generic NotificationDetails types, so this change removes a bunch of boilerplate and introduces more type safety. This is part of enabling more of the Prefs code to live in base/prefs/. TBR=ben@chromium.org,brettw@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11345008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165414 0039d316-1c4b-4281-b951-d872f2087c98
* Move SafeBrowsingService::UrlCheckResult to SBThreatType.cbentzel@chromium.org2012-11-011-26/+12
| | | | | | | | | | | This is being done so SafeBrowsingProtocolManager does not need to depend on SafeBrowsingService, so it can be more easily unit tested. BUG=158246 Review URL: https://chromiumcodereview.appspot.com/11347013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165339 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SafeBrowsingService::IsUpdateInProgresscbentzel@chromium.org2012-10-301-2/+0
| | | | | | | | | This was not being used anywhere. Review URL: https://chromiumcodereview.appspot.com/11273067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164948 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Set the system network delegate on the SystemURLRequestContext.mattm@chromium.org2012-06-301-0/+6
| | | | | | | | | | | | Fixes SafeBrowsingURLRequestContext not sending cookies. (The SafeBrowsingURLRequestContext copies its base settings from the system request context.) BUG=134277 TEST=check net-internals event log for safebrowsing url_request events. Cookies should be sent. Review URL: https://chromiumcodereview.appspot.com/10657013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145044 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, delegate cleanuprsleevi@chromium.org2012-06-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | For Delegate/Observer-type classes that specify an interface but do not have any particular lifetime requirements, make their destructors protected. This is to allow their interfaces to be implemented safely by RefCounted types. With public destructors, it's possible to do "scoped_ptr<Delegate> foo", and then assign a RefCountedDelegateImpl, which would lead to a double free. As none of these Delegates actually need public destructors (ownership of the Delegate* is not transferred during a function call / class constructor), mark the destructors protected so that it becomes a compile warning to try to delete them via the Delegate*. BUG=123295 TEST=it compiles Review URL: https://chromiumcodereview.appspot.com/10383262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144086 0039d316-1c4b-4281-b951-d872f2087c98
* Remove message_loop_helpers.h and update the includes to point to the new ↵tfarina@chromium.org2012-06-201-1/+1
| | | | | | | | | | | | | | | | location. Note: This was a TODO for akalin@. This patch was generated by: $ find . -name '*.h' -o -name '*.cc' -o -name '*.mm' | xargs sed -i -e "s/base\/message_loop_helpers.h/base\/sequenced_task_runner_helpers.h/g" R=akalin@chromium.org TBR=willchan@chromium.org,ben@chromium.org,jam@chromium.org,tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/10578026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143174 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting URLRequestContext.willchan@chromium.org2012-05-111-1/+1
| | | | | | | | | | | | While doing so, fix a few issues with the code like ordering of URLRequestContext to ensure correct destruction order. Also fix const correctness in some places. BUG=58859 TEST=none TBR=willchan Review URL: https://chromiumcodereview.appspot.com/10299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136497 0039d316-1c4b-4281-b951-d872f2087c98
* Replace SafeBrowsing MAC with downloads over SSL.bryner@chromium.org2012-04-161-10/+1
| | | | | | | | | | BUG=119662 TEST=updated unittests, ran Chrome and verified SB functionality on new profile Review URL: http://codereview.chromium.org/10069031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132456 0039d316-1c4b-4281-b951-d872f2087c98
* Clear SafeBrowsing cookie store in BrowsingDataRemover.mattm@chromium.org2012-02-221-0/+2
| | | | | | | | | | BUG=114584 TEST=clear site data, sqlite .dump the Safe Browsing Cookies contents Review URL: http://codereview.chromium.org/9419027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123132 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the content notification for memory purging, which is a chrome ↵jam@chromium.org2012-02-211-0/+3
| | | | | | | | | feature. We also don't want chrome to be issuing notifications that are in content since that breaks the abstraction layer around the Content API (in effect it circumvents it). BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9355047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122882 0039d316-1c4b-4281-b951-d872f2087c98
* Add SafeBrowsingURLRequestContext which stores cookies.mattm@chromium.org2012-02-141-6/+23
| | | | | | | | | | | | Rename OnIOInitialize and OnIOShutdown methods to more accurately match their current use. BUG=103243 TEST=tcpdump it up, run chrome twice in a row (waiting for safebrowsing updates to occur), verify that cookies from both connections were the same. Review URL: http://codereview.chromium.org/9310020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121794 0039d316-1c4b-4281-b951-d872f2087c98
* simplify notification registrar - no need to store thread ID per recordjoth@chromium.org2012-01-261-1/+1
| | | | | | | | | | BUG=109000 TEST=Existing tests pass on try servers Review URL: http://codereview.chromium.org/9006007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119216 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using base::Callback for DisplayBlockingPage. It was already a bitdarin@chromium.org2012-01-131-7/+8
| | | | | | | | | | | | awkward that we were using the Client interface for two separate purposes. Also, using base::Callback will give more control over the lifetime of the callback subject. R=jam@chromium.org Review URL: http://codereview.chromium.org/9148075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117700 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DeleteTask and convert remaining users.dcheng@chromium.org2012-01-021-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9015021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116107 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a whitelist for code-signing certificates.bryner@chromium.org2011-12-021-0/+6
| | | | | | | | | | | | With this change, only downloads that match a whitelisted URL or certificate will be exempt from the download protection pingback. The certificate whitelist format allows matching on the certificate issuer along with the CN, O, or OU attributes of the certificate. BUG=102540 TEST=DownloadProtectionServiceTest Review URL: http://codereview.chromium.org/8762007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112604 0039d316-1c4b-4281-b951-d872f2087c98
* Some easy NewRunnableMethod conversions in safe_browsing.shess@chromium.org2011-11-151-5/+5
| | | | | | | | | | Also a harder one of a CancelableTask timeout task, which was replaced with a callback-owned flag. Review URL: http://codereview.chromium.org/8548003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110166 0039d316-1c4b-4281-b951-d872f2087c98
* This is a first CL which refactors the way we lookup the bad binarynoelutz@google.com2011-11-101-1/+2
| | | | | | | | | | | | | download URL and digest SafeBrowsing lists. This change adds these two lookups to the SafeBrowsing download protection service. I will send out a separate CL which refactors the download manager. BUG=102540 TEST=No visible change. Simply run DownloadProtectionServiceTest. Review URL: http://codereview.chromium.org/8467038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109458 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-3/+4
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Collect some histograms about signed binary downloads.bryner@chromium.org2011-10-281-3/+8
| | | | | | | | | | | | | | This hooks up the DownloadProtectionService to run after a download finishes. For now, this does not send a download pingback since the flag defaults to off. TEST=DownloadProtectionServiceTest BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107528 Review URL: http://codereview.chromium.org/8345033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107674 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-10 04:19:29 +0000