summaryrefslogtreecommitdiffstats
path: root/chrome/browser/safe_browsing
Commit message (Collapse)AuthorAgeFilesLines
* Clean up unnecessary #includes of base/{scoped_ptr.h,string16.h}.viettrungluu@chromium.org2010-08-194-1/+3
| | | | | | | | | | | | Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in base/ref_counted.h, not in base/scoped_ptr.h. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3132024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 6)thestig@chromium.org2010-08-193-1/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SafeBrowsingDatabase for transition to new file format.shess@chromium.org2010-08-189-223/+2112
| | | | | | | | | | | | | | | | | | | | | | | | Refactor old SafeBrowsingDatabase code to allow for transitioning from the old SQLite-based store to a new SQLite-based store, and from there to the final raw file-based store. The intended rollout is: - Rollout with SafeBrowsingDatabaseBloom (basically the old code). - Rollout SafeBrowsingDatabase+SafeBrowsingStoreSqlite. This changes much of the code, but not the file format, so revert is possible without resync'ing everyone's store (unless the stores have been corrupted or something). - Rollout SafeBrowsingDatabase+SafeBrowsingStoreFile. This changes the file format while the control code stays the same. Revert requires resync. - Rollout a big cleanup which removes dead code. BUG=28647 TEST=Safe browsing continues to work. Review URL: http://codereview.chromium.org/3141009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the urls reported as page_url and referer_url when a redirect is involved.panayiotis@google.com2010-08-182-4/+29
| | | | | | | | | Bug=None Test=Manually verified with sites redirecting to malware. Review URL: http://codereview.chromium.org/3151018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56583 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementally bring SafeBrowsingDatabaseTest into the modern age.shess@chromium.org2010-08-171-53/+41
| | | | | | | | | | | Use ScopedTempDir, and don't CHECK in tests. BUG=none TEST=waterfall. Review URL: http://codereview.chromium.org/3127007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56397 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring Get(As)String() methods from Value, etc.viettrungluu@chromium.org2010-08-161-48/+51
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
* Report malware redirectors as well.panayiotis@google.com2010-08-125-23/+37
| | | | | | | | BUG=none TEST=unit_tests Review URL: http://codereview.chromium.org/3028040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55966 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 5)thestig@chromium.org2010-08-071-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3041049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55349 0039d316-1c4b-4281-b951-d872f2087c98
* Minor header cleanup of chrome/browser/[st]*/*.h minus c/b/sync/*.h.viettrungluu@chromium.org2010-08-067-13/+4
| | | | | | | | | | | | - Remove unnecessary forward decls. - Remove unnecessary inclusions of <set>, <map>, <vector>, <list>. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3023043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-061-2/+3
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55138 - Full end to end test using safebrowsing test server suite.lzheng@chromium.org2010-08-051-394/+31
| | | | | | | | | Review URL: http://codereview.chromium.org/3032008 TBR=lzheng@google.com Review URL: http://codereview.chromium.org/3027044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55139 0039d316-1c4b-4281-b951-d872f2087c98
* Full end to end test using safebrowsing test server suite.lzheng@google.com2010-08-051-31/+394
| | | | | | Review URL: http://codereview.chromium.org/3032008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55138 0039d316-1c4b-4281-b951-d872f2087c98
* base: rename Environment::HasEnv to Environment::HasVar.tfarina@chromium.org2010-08-041-1/+1
| | | | | | | | | | | | This is the part 2 of this series. More two comming. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3035050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54996 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove GetSwitchValue() from chrome/* where easy."evan@chromium.org2010-08-041-3/+2
| | | | | | | | This reverts commit r54966. Meant to try it, not commit it, sorry everyone. :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-041-2/+3
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2010-08-041-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54863 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of GetSwitchValue for most of chrome/browser/.evan@chromium.org2010-08-041-12/+13
| | | | | | Review URL: http://codereview.chromium.org/3005053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54856 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Windows build.brettw@chromium.org2010-08-031-7/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54758 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename EnvVarGetter to Environment.tfarina@chromium.org2010-08-031-2/+2
| | | | | | | | | | | | | | | Now EnvVarGetter do much more than getting environment variables. Per suggestion from Pawel in http://codereview.chromium.org/3043018/. BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3052034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-311-2/+3
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 3ziadh@chromium.org2010-07-302-2/+2
| | | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2613-0/+13
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Break another common->app dependency.thestig@chromium.org2010-07-201-2/+2
| | | | | | | | BUG=46666 TEST=none Review URL: http://codereview.chromium.org/3007008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
* Remove <iostream> where possible.erg@google.com2010-07-201-1/+0
| | | | | | | | | | | | | <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Review URL: http://codereview.chromium.org/3014015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
* First change to add safebrowsing service test. lzheng@chromium.org2010-07-163-0/+198
| | | | | | | | | | | | | | Right now, the test only launch the browser and makes sure no auto update is scheduled. Later, the test suite server will be launched within the test and requests will be issued, BUG=47318 TEST=this is the test. Review URL: http://codereview.chromium.org/2845035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52719 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt four at landing the "histogram.h removed from message_loop.h" patch.erg@chromium.org2010-07-151-0/+1
| | | | | | | | | | | | | | Previously committed as r52349 and r52336. Related commits: r52367, r52364 and r52343. Rerunning trybots due to previous trybot breakage. TEST=none BUG=none Review URL: http://codereview.chromium.org/2965015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
* Moved InitNavigationParams to test_render_view_host so that other test can ↵oshima@chromium.org2010-07-141-21/+1
| | | | | | | | | | | | | | use it. Added PageTransitionType to argument to make it more general but I can revert this if you think this should not be changed. let me know. BUG=none TEST=none Review URL: http://codereview.chromium.org/2945015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52389 0039d316-1c4b-4281-b951-d872f2087c98
* Revert everything related to the relanding.erg@chromium.org2010-07-141-1/+0
| | | | | | Review URL: http://codereview.chromium.org/2982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52336.erg@chromium.org2010-07-141-0/+1
| | | | | | | | | | | | | | (I accidentally committed a previous version of the patch (the fixed version was in codereview since I had switched to my mac to address this exact compile failure.) BUG=none TEST=none TBR=evan Review URL: http://codereview.chromium.org/2937010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52336 - More header cleanup:erg@chromium.org2010-07-141-1/+0
| | | | | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52343 0039d316-1c4b-4281-b951-d872f2087c98
* More header cleanup:erg@chromium.org2010-07-141-0/+1
| | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52336 0039d316-1c4b-4281-b951-d872f2087c98
* Add switches and apis in safebrowsing protocol_manager that will allow ↵lzheng@chromium.org2010-06-295-83/+330
| | | | | | | | | | | end-to-end test later. BUG=6787,47318 TEST=protocol_manager_unittest.cc Review URL: http://codereview.chromium.org/2868030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51177 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-291-4/+4
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* AppendASCII returns a new object.thakis@chromium.org2010-06-233-3/+3
| | | | | | | | Found by clang. Review URL: http://codereview.chromium.org/2840017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50614 0039d316-1c4b-4281-b951-d872f2087c98
* Pref service strings should be std::string.estade@chromium.org2010-06-181-2/+2
| | | | | | | | | | | Part 1: Convert RegisterStringPref. BUG=none TEST=compile Review URL: http://codereview.chromium.org/2809022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50202 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a ResourceBundle::GetDataResource and convert people totony@chromium.org2010-06-151-3/+4
| | | | | | | | | | the StringPiece version. In most cases, I didn't bother trying to make the calling code more efficient since nothing seems to be in time sensitive code. Review URL: http://codereview.chromium.org/2827001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49766 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary header dependency and fix misleading comment.dpranke@chromium.org2010-06-151-0/+1
| | | | | | | | | | | | | | | PasswordFormManager() doesn't directly depend on the web_data_service, so I'm removing the #include; doing so exposed a missing dependency of the safe_browsing_service (which was failing to include chrome_thread.h directly). Also, the comment above the constructor was wrong. R=tim@chromium.org BUG=none TEST=things still compile Review URL: http://codereview.chromium.org/2770009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49755 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Fix SafeBrowsingDatabase unit tests for MacOS X by disabling logging of IOcsilv@chromium.org2010-06-111-23/+21
| | | | | | | | | | | stats since those are unsupported on MacOS X (and really just informative, not critical to the function of the test.) BUG=46040 TEST=SafeBrowsingDatabase.* Review URL: http://codereview.chromium.org/2723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49578 0039d316-1c4b-4281-b951-d872f2087c98
* Merging issue 2067023 for bryner@google.comian@chromium.org2010-06-102-18/+51
| | | | | | | | | BUG=none TEST=safe_browsing_blocking_page_unittest.cc Review URL: http://codereview.chromium.org/2737005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49437 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Re-enable four SafeBrowsingDatabase tests. Add a comment with bug link ↵jhawkins@chromium.org2010-06-081-17/+12
| | | | | | | | | | | | for the tests being disabled on Mac. TBR=stuartmorgan BUG=46040 TEST=SafeBrowsingDatabase.* Review URL: http://codereview.chromium.org/2676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49128 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap Sqlite utils functions into a sqlite_utils namespace.tfarina@chromium.org2010-06-033-6/+6
| | | | | | | | | | | Note: this was a TODO. BUG=None TEST=compiles Review URL: http://codereview.chromium.org/2410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48883 0039d316-1c4b-4281-b951-d872f2087c98
* Add ftp protocol to the safebrowsing checks. Fixed the crash with ↵inferno@chromium.org2010-06-023-2/+32
| | | | | | | | | | | canonicalization of non-standard urls in CanonicalizeUrl function. Add CanCheckUrl to a more central location. Added the null check in GeneratePathsToCheck. Remove redundant checks from resource dispatcher host. BUG=40605 TEST=SafeBrowsingUtilTest.CanonicalizeUrl Review URL: http://codereview.chromium.org/2471002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48720 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing AutoReset to be a template.gspencer@chromium.org2010-06-011-1/+1
| | | | | | | | | | | I've run into a couple of times this week when I needed one of these, for two different types besides bool. Time to fix the TODO. TEST=trybots FTW, and built locally. BUG=none Review URL: http://codereview.chromium.org/2394001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48644 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-013-10/+10
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using TimeTicks for profiling and histogramsjar@chromium.org2010-05-102-7/+7
| | | | | | | | | | | Avoid using wall clock time, which can be changed by the user, or impacted by Daylight Savings transitions etc. BUG=14193 r=eroman Review URL: http://codereview.chromium.org/1253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46821 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLFetcher and related classes to chrome/common/net.sanjeevr@chromium.org2010-05-073-3/+3
| | | | | | | | BUG=None TEST=Build and Unittests Review URL: http://codereview.chromium.org/1995008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring versions of GetFileInfo, GetFileSize, GetTempDir.evan@chromium.org2010-04-211-2/+2
| | | | | | | | | TEST=compiles BUG=24672 Review URL: http://codereview.chromium.org/1753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45246 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FileVersionInfo into an interface with platform implementations.tony@chromium.org2010-04-141-1/+2
| | | | | | | | | | | | | This allows us to move the chrome specific version informaton used by Linux into src/chrome. Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome. In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell. Review URL: http://codereview.chromium.org/1560027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98