| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=7713
TEST=SafeBrowsingUtilTest.CanonicalizeUrl
Review URL: http://codereview.chromium.org/1275002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the SafeBrowsingInterstitialPage.
The interstitial page logic makes sure its Proceed/DontProceed
are called only once, but the DontProceed could also be called
when navigating back. Since the SafeBrowsingService::Client
is deleted when the SafeBrowsingService is notified, that would
cause a crasher on the 2nd notification.
BUG=http://crbug.com/30079
TEST=See bug.
Review URL: http://codereview.chromium.org/697002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull handling of the database setup, teardown, and memory management
up into the test class. Push a bunch of global functions into the
test class. Use helper functions for dealing with hashes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/755001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/672007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This attempts to clean up ownership so that it's more clear who
creates and deletes the chunk data between parsing and storage in the
database. SBChunkList replaces std::deque<SBChunk>, mostly to add
correct cleanup in the destructor rather than requiring FreeChunks()
to be called manually. Additionally remove deletion of chunk info
from the database layer, now it processes const data.
Additionally remove the need for SafeBrowsingDatabase to have a
chunk-inserted callback by having the caller handle it directly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40605
Review URL: http://codereview.chromium.org/666001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the build. Sorry.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/666001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MD5 checksum verifies that the file read is the file that was written.
Also added sanity checks for the file header to prevent interpretting
random garbage as a valid count. Unit test corruption-detection.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element. This lays the groundwork for adding
checksumming.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39619
Review URL: http://codereview.chromium.org/650113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24672
Review URL: http://codereview.chromium.org/652225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
---------------
Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element. This lays the groundwork for adding
checksumming.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39619
Review URL: http://codereview.chromium.org/652073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element. This lays the groundwork for adding
checksumming.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/650113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingDatabaseBloom stores a integer prefix column and a blob
hash column, where the first four bytes of the hash are the prefix.
This isn't necessary, so getting rid of the duplication rather than
propagating it into the future.
[Previously this was left alone because it wasn't too harmful because
the code could always drop the duplication from the file format. A
future change for SafeBrowsingStoreFile will write an array of hashes,
making the duplication unavoidable.]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/651057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Existing code stores the |time_t| from |base::Time::ToTimeT()| using
|bind_int64()|. But |time_t| is an unsigned 32-bit value so this
didn't add anything.
Also changed |SafeBrowsingStoreSqlite| to have the singleton writers
use the array writers, rather than vice versa. The only tie-in is
that otherwise it wanted a helper writer taking an int32 for the time
component to share between |WriteAddHash()| and |WriteAddHashes()|.
[This CL is a prelude to bulk-writing arrays of |SBAddFullHash| to the
database, so making |SBAddFullHash.received| an explicitly simple type
is worthwhile.]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/646030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
towards redoing the Callback interfaces.
Added and removed includes as needed.
BUG=35223
TEST=trybots
Review URL: http://codereview.chromium.org/646061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/630012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=If it compiles it is perfect.
Review URL: http://codereview.chromium.org/585008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
95% of this is removing "const" from return types, but turning this
on found one bug! (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)
BUG=34160
Review URL: http://codereview.chromium.org/570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First bit of refactoring safe-browsing to use a flat file format.
SafeBrowsingStore implements just what is needed for
SafeBrowsingDatabase using straight-forward read/modify/write code.
There will be a follow-on change to layer in on-the-fly format
migration and integrate with SafeBrowsingDatabase. This CL only adds
new classes and tests for same.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36615
Review URL: http://codereview.chromium.org/545053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First bit of refactoring safebrowsing to use a flat file format.
SafeBrowsingStore implements just what is needed for
SafeBrowsingDatabase using straightforward read/modify/write code.
There will be a followon change to layer in onthefly format
migration and integrate with SafeBrowsingDatabase. This CL only adds
new classes and tests for same.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/545053
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/549105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First bit of refactoring safe-browsing to use a flat file format.
SafeBrowsingStore implements just what is needed for
SafeBrowsingDatabase using straight-forward read/modify/write code.
There will be a follow-on change to layer in on-the-fly format
migration and integrate with SafeBrowsingDatabase. This CL only adds
new classes and tests for same.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/545053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
replacement is in query part of the URL or not.
Removed duplicate EscapeQueryParamValue functions without |use_plus| argument.
BUG=24571
TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia.
Review URL: http://codereview.chromium.org/543077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
EmptyGURL(), since the code in question can just use the default constructor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet,
along with reformatting.
The macros were cleaned up to use common sub-macros rather than
repeating code as much.
Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros)
since this class was not getting used.
I introduced UMA_HISTOGRAM_ENUMERATION to support the common use
of LinearHistograms to count various enumerated values.
I added a Flags argument to all the FactoryGet routines to help avoid
needing to call SetFlags each time a new sample is Add()ed. This also
simplifies the code.
This will all help prepare for a "don't histogram at all" macro setting
so that I can test the impact of the histogram macro calls on
performance (since there are now so many active histograms).
BUG=31206
r=raman.tenneti
Review URL: http://codereview.chromium.org/515033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/505056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 20411
TEST= none
Review URL: http://codereview.chromium.org/463047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is CL patch 377028 by Raman Tenneti, with minor changes to
make the try-bots happier.
It is cleanup that better ensures lifetimes of histograms (making it harder
for users to abuse them).
bug=16495 (repairs leak induced by the first landing)
bug=18840 (should make leaks less possible)
tbr=raman.tenneti
Review URL: http://codereview.chromium.org/462027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
compiler optimizations.
BUG=28559
TEST=none
Review URL: http://codereview.chromium.org/455039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows. These names will be different for Google Chrome, Chromium and Chrome Frame. On Mac / Linux, leaving the name as "googlechrome" for all builds.
BUG=None
TEST=Verify that the safe browsing URLs are tagged with the correct product name for each product.
Review URL: http://codereview.chromium.org/455035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Shorten code where easy to do so
* Remove an unneeded line
* Better function parameter names for one function
* Be consistent about not using {} on one-line bodies (some places did, some didn't)
* Be consistent about using "a" and "!a" instead of "a != 0" and "a == 0" (some places did one, some did the other)
* No else after return/continue
* Reduce duplicated code by reordering lines
* Use for () instead of while () where doing so would shorten things
* More comments in a few places
* Use iterators in a few cases where doing so avoids more verbose or complex code
* Name a few constants
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/452043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
declaration order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/460008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update copyrights.
* Remove unnecessary headers.
* Remove useless functions.
* Make declaration and definition order match (in at least the _database_bloom.* files).
* Eliminate database_perftest.cc, since it seems to have been disabled entirely since before the public launch, and looks like it's perhaps irrelevant to the current code design.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/457019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is only read from the options dialog, the windows installer (a separate
process) and a spot in safe browsing. The only one that matters is
the safe browsing case.
BUG=28992
Review URL: http://codereview.chromium.org/456004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pawel
Review URL: http://codereview.chromium.org/453007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13572
TEST=none
Review URL: http://codereview.chromium.org/399068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Functions that take a printf-style format get a new annotation, which
produces a bunch of compiler warnings when you use printf impoperly.
This change adds the annotations and fixes the warnings.
We now must use PRId64 for 64-bit numbers and the PRIsz for size_t.
Review URL: http://codereview.chromium.org/339059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
28k of pak file size, but will make the binary a tad bit larger.
BUG=28174
Review URL: http://codereview.chromium.org/407007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23400
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the check finally ran it passed the prefix check (the common case). This was made more noticeable by r31950 since before that things wouldn't be queued unless we were resetting the database (rare) or caught a narrow timing window where |database_| was true but |database_loaded_| was false; after that, we could get this on startup, and with r32136, after closing the database as well.
This also removes some unnecessary bits now that we don't queue during a reset.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/402004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32212 0039d316-1c4b-4281-b951-d872f2087c98
|