summaryrefslogtreecommitdiffstats
path: root/chrome/browser/safe_browsing
Commit message (Collapse)AuthorAgeFilesLines
* Update the SafeBrowsing protocol version to 2.2, which handlespaulg@google.com2008-11-071-3/+3
| | | | | | | | | | | - Zero sized chunks - Redirect URL format changes http://crbug.com/3418 Review URL: http://codereview.chromium.org/10222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial patch: add whitespace to some SQL statements to turn "INSERT INTO ↵pkasting@chromium.org2008-10-292-7/+5
| | | | | | | | | foo(bar,baz)VALUES(?,?)" into "INSERT INTO foo (bar, baz) VALUES (?,?)" (which is the way we have it in most of our code). This was annoying me while I tried to track down cases where we omitted the appropriate fieldnames from our SQL statements. Review URL: http://codereview.chromium.org/8855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4145 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor memory leak.paulg@google.com2008-10-294-8/+6
| | | | | | | | | BUG=1340229 Review URL: http://codereview.chromium.org/8690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4117 0039d316-1c4b-4281-b951-d872f2087c98
* Give the new implementation a unique name for the databasepaulg@google.com2008-10-281-1/+1
| | | | | | | | and filter storage so that it can run side by side with the old implementation without data loss. Review URL: http://codereview.chromium.org/8844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4087 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the referrer throughout the OpenURL APIs.ericroman@google.com2008-10-271-3/+3
| | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3224 Caveats: * Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer. * Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.) * Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version. Review URL: http://codereview.chromium.org/8186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the chunk processing pipeline. We are no longerpaulg@google.com2008-10-272-326/+216
| | | | | | | | | asynchronous, so we can greatly simplify the code. Refactor BuildBloomFilter() to smaller worker functions. Review URL: http://codereview.chromium.org/8605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4032 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-2713-17/+37
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a long running test.paulg@google.com2008-10-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3972 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to allow running the new SafeBrowsing storage system,contained in ↵paulg@google.com2008-10-2413-162/+606
| | | | | | | | SafeBrowsingDatabaseBloom, via a command line flag(--new-safe-browsing). Review URL: http://codereview.chromium.org/6807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3959 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more parts of browser/evanm@google.com2008-10-234-63/+104
| | | | | | | | | | | | This first needs http://codereview.chromium.org/6492 (porting base/process_util). BUG=2333 Review URL: http://codereview.chromium.org/6268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3858 0039d316-1c4b-4281-b951-d872f2087c98
* Change the detection of the list name from parsing a URLpaulg@google.com2008-10-223-13/+3
| | | | | | | | to storing it from the update in order to avoid breaking due to changes in the format. Review URL: http://codereview.chromium.org/7851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3717 0039d316-1c4b-4281-b951-d872f2087c98
* Return without doing anything instead of dereferencing junk in unexpected cases.mark@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3470 0039d316-1c4b-4281-b951-d872f2087c98
* As agreed on by the SafeBrowsing server team:paulg@google.com2008-10-152-15/+14
| | | | | | | | | | | 1. Back off when we encounter a parse error. 2. Ignore commands we don't understand instead of returning an error. 3. Make redirect URL parsing in an update response more robust to changes in format. Review URL: http://codereview.chromium.org/7329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3425 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at refactoring the interstitial page.jcampan@chromium.org2008-10-134-236/+126
| | | | | | | | | | | | | | | | | The SSL and malware blocking pages were doing similar things in 2 different classes. There is now a base class called InterstitialPage that contains the common logic. As part of that refactoring, the safe browsing was changed so that the SafeBrowsingBlockingPage is only used from the UI thread. This CL also adds transient entries to the navigation controller: that type of entry gets deleted as soon as a navigation occurs. It is used by interstitial that need to create such a temporary entry while they show. BUG=3013 TEST=Run the unit tests and ui tests. Review URL: http://codereview.chromium.org/6311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3324 0039d316-1c4b-4281-b951-d872f2087c98
* Minor code clean up.paulg@google.com2008-10-132-4/+9
| | | | | | Review URL: http://codereview.chromium.org/7271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3314 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of UMRs in the unit tests.paulg@google.com2008-10-102-0/+3
| | | | | | Review URL: http://codereview.chromium.org/7047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3165 0039d316-1c4b-4281-b951-d872f2087c98
* Provide an option to turn on the new SafeBrowsing storage systempaulg@google.com2008-10-091-0/+4
| | | | | | | | | | via a command line flag ("--new-safe-browsing"). This is to ease testing and is not yet ready for production use. Review URL: http://codereview.chromium.org/6390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3148 0039d316-1c4b-4281-b951-d872f2087c98
* Support zero size chunks in the current implementation.paulg@google.com2008-10-095-39/+282
| | | | | | | | | | | | | | | | | | | | | | | | | | This allows the SafeBrowsing servers to send us Add and Sub chunks with no content so that when we report our update status, the request size is decreased. Our update status request contains a list of all chunks that we have received from the service, and this can get fragmented over time. For example, the part of the request containing our phishing chunks might look like this: goog-phish-shavar:a:1,3,5,7,9,11,13,15,17 By sending zero size chunks for the chunk numbers missing from the above example, the report will now look like: goog-phish-shavar:a:1-17 Given the large number of chunks and the rate of chunk expiry, this change will reduce the client request size. BUG= http://code.google.com/p/chromium/issues/detail?id=3262 Review URL: http://codereview.chromium.org/6369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3131 0039d316-1c4b-4281-b951-d872f2087c98
* One more link that needs drag and drop disabled in the malware blocking page.jcampan@chromium.org2008-10-091-1/+1
| | | | | | | BUG=3235 Review URL: http://codereview.chromium.org/6360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3099 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to the experimental bloom filter storage code.paulg@google.com2008-10-083-46/+69
| | | | | | | | | | | Update the unittest to handle the bloom filter storage implementation and fix a test scenario. This change does not affect the current working implementation. Review URL: http://codereview.chromium.org/6513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3031 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking the diagnostic link on the malware page would triggers a DCHECK.jcampan@chromium.org2008-10-081-2/+2
| | | | | | | | | | The diagnostic URL was not formatted properly and we would load an empty URL. BUG=2957 TEST=Navigate to www.ianfette.us, the malware interstitial shows. Click the diagnostic link, you should see the diagnostic google page. Review URL: http://codereview.chromium.org/6081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3012 0039d316-1c4b-4281-b951-d872f2087c98
* Make chunk ranges searchable.paulg@google.com2008-10-083-0/+47
| | | | | | Review URL: http://codereview.chromium.org/5645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2990 0039d316-1c4b-4281-b951-d872f2087c98
* A partially working implementation of a faster safe browsing implementation.erikkay@google.com2008-10-028-2/+1334
| | | | | | Review URL: http://codereview.chromium.org/5643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2814 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more of chrome/ to Linux.deanm@google.com2008-10-021-7/+2
| | | | | | | | Original review: http://codereview.chromium.org/4247 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2793 0039d316-1c4b-4281-b951-d872f2087c98
* Change the SafeBrowsing client version to use the properpaulg@google.com2008-10-012-11/+17
| | | | | | | Google Chrome version number. Review URL: http://codereview.chromium.org/6022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2742 0039d316-1c4b-4281-b951-d872f2087c98
* Use RandUInt64 instead of going from signed to unsigned.deanm@chromium.org2008-09-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2714 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring for portability:mark@chromium.org2008-09-292-9/+11
| | | | | | | | | | | | | - Move chrome/common/env_util to base/sys_info - Move chrome/common/rand_util to base/rand_util (new), simplify its public interface, and fix its implementation Patch by Paweł Hajdan, Jr. <phajdan.jr@gmail.com> http://codereview.chromium.org/4079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2697 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup EOL and include guards, including fixing one guard that was not the ↵deanm@chromium.org2008-09-2017-38/+27
| | | | | | | | correct path. Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC. Review URL: http://codereview.chromium.org/4007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2437 0039d316-1c4b-4281-b951-d872f2087c98
* Create a SafeBrowsing database interface to more easilypaulg@google.com2008-09-209-1713/+1885
| | | | | | | | | | | facilitate alternate implementations. The current SafeBrowsingDatabase code is moved to *_impl files. Adding a new implementation can be done via command line flags in the SafeBrowsingDatabase::Create factory method. Review URL: http://codereview.chromium.org/3162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2434 0039d316-1c4b-4281-b951-d872f2087c98
* Enable safe browsing tests exercising VerifyMAC. Reorder libraries to match ↵deanm@chromium.org2008-09-182-12/+0
| | | | | | | | | the dependency order required on Posix. Patch from Pawel Hajdan Jr. Review URL: http://codereview.chromium.org/3143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2361 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome SConscript.unit_tests in Linux build.tc@google.com2008-09-173-52/+42
| | | | | | | | | | | | BUG=2335 Original patch by phajdan.jr@gmail.com in http://codereview.chromium.org/2891 R=mark,sgk Review URL: http://codereview.chromium.org/2939 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2319 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome/browser/SConscript in Linux build.tc@google.com2008-09-175-9/+22
| | | | | | | | | | | | | | | In dns_host_info.cc there was probably a bug (hardcoded 1 instead of length. BUG=2333 R=mark,sgk Original patch by phajdan.jr@gmail.com at: http://codereview.chromium.org/2890 Review URL: http://codereview.chromium.org/3108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2317 0039d316-1c4b-4281-b951-d872f2087c98
* This is almost a complete rewrite of DidNavigate and the associated ↵brettw@google.com2008-09-141-16/+6
| | | | | | | | | | NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on. I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it. Review URL: http://codereview.chromium.org/479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2201 0039d316-1c4b-4281-b951-d872f2087c98
* If you click a link to a malware page or if a page redirects to malware, the ↵jcampan@chromium.org2008-09-101-3/+2
| | | | | | | | | | | | malware blocking page is shown but it says that the malware page is a resource of the originating page. This is because the blocking page was using the page URL to determine if we are dealing with the main frame, and in these cases the URL was not set yet. BUG=1335251 TEST=Navigate to a page that has a link to malware. Click on the link. The malware blocking page should be displayed and should indicate that the page is malware (and not that the originating page contains malware). Review URL: http://codereview.chromium.org/1881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1998 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all instances of <hash_map> with a "base/hash_tabe.h",erg@google.com2008-09-084-12/+8
| | | | | | | | | | | which does the right thing based on whatever platform we're compiling for, along with changing the hardcoded "stdext::", which is a MSVC++ism to use base::hash_{map,set}. B=1869 Review URL: http://codereview.chromium.org/1629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
* Use FRIEND_TEST() instead of guessing the test class name (!)maruel@google.com2008-09-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/1626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1857 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flakey test.deanm@google.com2008-09-081-2/+2
| | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=1880 Review URL: http://codereview.chromium.org/1816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1852 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak introduced in the SafeBrowsing prefix cache test.paulg@google.com2008-09-061-1/+5
| | | | | | | BUG=1484 Review URL: http://codereview.chromium.org/481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1817 0039d316-1c4b-4281-b951-d872f2087c98
* Cache empty responses from the SafeBrowsing servers for GetHashpaulg@google.com2008-09-056-11/+67
| | | | | | | | | | | requests so that we don't keep asking for full hashes that don't exist. We flush this cache with each update, which is a little aggressive, but on the safe side. BUG=1358225 Review URL: http://codereview.chromium.org/454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue where a sub chunk coming in before an add chunk, both containg ↵jam@chromium.org2008-09-043-3/+42
| | | | | | | | | the same prefixes, will lead to the whole hostname looking like it's blocked. BUG=1358531 Review URL: http://codereview.chromium.org/439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1729 0039d316-1c4b-4281-b951-d872f2087c98
* HMAC-SHA1 implementation for Mac based on CommonCrypto;mmentovai@google.com2008-09-041-3/+3
| | | | | | | allow Windows HMAC-SHA1 to use keys longer than 16 bytes. Review URL: http://codereview.chromium.org/218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1724 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup to OneShotTimer and RepeatingTimer: moves more of the member ↵darin@google.com2008-09-032-29/+5
| | | | | | | | | | | variables into the Task subclass. Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer. R=beng BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1684 0039d316-1c4b-4281-b951-d872f2087c98
* Take out uneeded comment (and test public Rietveld instance!).jam@chromium.org2008-09-021-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1657 0039d316-1c4b-4281-b951-d872f2087c98
* Change SafeBrowsing client name for Chromium.BUG=1296800rahulk@google.com2008-08-312-4/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1601 0039d316-1c4b-4281-b951-d872f2087c98
* On line 138 of protocol_manager.cc we were converting a std::stringifette@google.com2008-08-291-1/+1
| | | | | | | | | | to a char*. The string could contain null bytes, which led to data loss and failures in safebrowsing. R=wtc BUG=1352561 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1565 0039d316-1c4b-4281-b951-d872f2087c98
* Make a step on refactoring navigation. The eventual plan is to have the ↵brettw@google.com2008-08-281-1/+4
| | | | | | | | | | | | | NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable). This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed. Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway. BUG=1343593,1343146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1506 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of safebrowsing database removing an add for a hostname when it ↵jabdelmalek@google.com2008-08-282-2/+31
| | | | | | | | got a sub for some prefixes. BUG=1315628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1481 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup navigation_entry.h. I made the accessors consistent and in Google ↵brettw@google.com2008-08-271-4/+4
| | | | | | style, and organized and commented all the entries. Hopefully it will be much easier to find things and deal with this class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1449 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-263-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-2423-654/+92
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98