| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds support to TestRenderViewHost for changing the MIME type that
it reports in the ViewHostMsg_FrameNavigate_Params.
BUG=none
TEST=ClientSideDetectionHostTest.ShouldClassifyUrl
Review URL: http://codereview.chromium.org/6691036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add ability to swap out the TestTabContents in RenderViewHostTestHarness/TabContentsWrapperTestHarness.
BUG=71097
TEST=no visible change
Review URL: http://codereview.chromium.org/6720050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
like foo.com/bar in which case we should whitelist foo.com/bar?boo
as well as foo.com/bar/boo.
BUG=
TEST=SafeBrowsingDatabaseTest
Review URL: http://codereview.chromium.org/6771060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a bug where the PrefixSet doesn't seem to work in a small
fraction of cases. One possibility is that memory is being corrupted
during construction. Though this seems very unlikely, this should
make sure...
BUG=71832
TEST=Monitor histograms
Review URL: http://codereview.chromium.org/6706032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79931
Review URL: http://codereview.chromium.org/6708059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
jingle.
BUG=None
TEST=Build.
Review URL: http://codereview.chromium.org/6778025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=3333
TEST=NONE
Review URL: http://codereview.chromium.org/6756001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsing enabled."
This reverts commit e41059f0bef15b2f5298c225dfab6f6929be6ddc.
The change broke all of browser tests on ChromiumOS dbg bot:
Example: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/5925/steps/browser_tests/logs/SwitchLanguage
[20793:20793:0330/233023:13949359567:FATAL:pref_service.cc(304)] Check failed: false. Trying to read an unregistered pref: user_experience_metrics.reporting_enabled
Backtrace:
base::debug::StackTrace::StackTrace() [0x130bc1d]
logging::LogMessage::~LogMessage() [0x131e20d]
PrefService::GetBoolean() [0xa72628]
SafeBrowsingService::Start() [0xae78a2]
SafeBrowsingService::Initialize() [0xae7efe]
ResourceDispatcherHost::Initialize() [0x2fb4ca7]
BrowserProcessImpl::CreateResourceDispatcherHost() [0xd98d0b]
BrowserProcessImpl::resource_dispatcher_host() [0xd98dd1]
ExtensionService::Init() [0x9085e6]
ProfileImpl::InitExtensions() [0xf646ed]
ProfileManager::AddProfile() [0xa9151a]
ProfileManager::GetProfile() [0xa916c1]
ProfileManager::GetDefaultProfile() [0xa91d26]
(anonymous namespace)::CreateProfile() [0x11a37d9]
BrowserMain() [0x11a69e5]
InProcessBrowserTest::SetUp() [0x129565f]
testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x146634b]
testing::internal::HandleExceptionsInMethodIfSupported<>() [0x146daf8]
testing::Test::Run() [0x1460af9]
testing::TestInfo::Run() [0x14644c0]
testing::TestCase::Run() [0x1464613]
testing::internal::UnitTestImpl::RunAllTests() [0x1465168]
testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x1466841]
testing::internal::HandleExceptionsInMethodIfSupported<>() [0x146d952]
testing::UnitTest::Run() [0x145de1b]
base::TestSuite::Run() [0x13922b2]
main [0x71f869]
0x2b6ae16a91
TBR=bryner
BUG=chromium-os:13699
TEST=ran safe_browsing_tests
Review URL: http://codereview.chromium.org/6737023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=77634
TEST=None
R=avi@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/6778026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6708059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Info about where the unsortedness happens.
BUG=71832
TEST=I will monitor resulting histograms.
Review URL: http://codereview.chromium.org/6765035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
back_inserter.
BUG=71134
TEST=Compile cleanly under VS2010
Review URL: http://codereview.chromium.org/6745016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=14390,14587,14798,14825,14990,15376,15500,15654,15731,15777,15857
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6696052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=SafeBrowsingServiceTest
Review URL: http://codereview.chromium.org/6733016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also do a bunch of cleanup:
-move safe browsing messages together
-get rid of webkit_param_traits and common_param_trait since they're no longer needed
-remove the multiple include of IPC files from places that don't need it
TBR=tsepez
Review URL: http://codereview.chromium.org/6713084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enum histogram.
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6725036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tsepez
Review URL: http://codereview.chromium.org/6721021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6705007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=68350
TEST=TabContentsTest.CrossSiteNavigationBackPreempted
TEST=NavigationControllerTest.RestoreNavigate
Review URL: http://codereview.chromium.org/6709056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the CHECK.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6719017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection code.
BUG=
TEST=ClientSideDetectionHostTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78635
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78818
Review URL: http://codereview.chromium.org/6670053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection code.
BUG=
TEST=ClientSideDetectionHostTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78635
Review URL: http://codereview.chromium.org/6670053
TBR=noelutz@google.com
Review URL: http://codereview.chromium.org/6708048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection code.
BUG=
TEST=ClientSideDetectionHostTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78635
Review URL: http://codereview.chromium.org/6670053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check whether PrefixSet::GetPrefixes() returns results that are
unsorted or contain duplicates, and indicate how many items are unique
to the restored vector (or aren't in the restored vector).
BUG=71832
TEST=histograms
Review URL: http://codereview.chromium.org/6711054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some implementations of std::set<> make an allocation per element,
with the allocations stitched into a list. This allows iterators to
remain valid while other elements in the set are added or removed.
Unfortunately, for small elements like SBPrefix in large sets like
safe-browsing, this temporarily uses an unexpectedly large amount of
memory. [Apologies if I got that wrong!]
This refactors things to allow the std::vector<> version to be used.
BUG=71832
TEST=none
Review URL: http://codereview.chromium.org/6711044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was sleeping to get past the one-second file lastmod resolution.
Instead just bump the lastmod back manually before running each test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6711042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure SBPrefix is a fixed size.
PrefixSet tests for single-element set, set with large deltas, and
int32 space edge cases.
PrefixSet::GetPrefixes() can be const.
Consolidate the SafeBrowsingDatabase GetPrefixes() checking code.
Check whether deltas fit by directly checking whether the delta fit.
Add a histogram for checking if SBPrefix really was crazy.
BUG=71832
TEST=none
Review URL: http://codereview.chromium.org/6711021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection code.
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6670053
TBR=noelutz@google.com
Review URL: http://codereview.chromium.org/6713023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection code.
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6670053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resetting the database (on corruption) caused a nested lock to be
acquired.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6674046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Ran ClientSideDetectionHostTest with heapchecking enabled.
Review URL: http://codereview.chromium.org/6677032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=safe_browsing_util_unittest
BUG=76013
Review URL: http://codereview.chromium.org/6679046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also makes it so that a positive cache hit will immediately show
a warning page without running classification.
BUG=
TEST=Ran ClientSideDetectionServiceTest and ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6652013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=14063,14197,14317,14659,14898,14958,14983,15408,15410,15411
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6677010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Safe browsing doesn't need to be on for prefetch requests, since they go directly to cache.
BUG=56582
TEST=SafeBrowsingServiceTest.Prefetch
Review URL: http://codereview.chromium.org/6334131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to use the full list name to figure out if a hash response if for a given list.
TEST=safe_browsing_test stays green.
BUG=none
Review URL: http://codereview.chromium.org/6650008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection. This whitelist will only contain full-length hashes
and should be small (fewer than 1K entries). The whitelist is loaded in
memory and is looked up on every page load before we start the client-side
phishing detection. If the loaded URL is on the csd whitelist we won't start
client-side phishing detection for that URL.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6592056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Third part of the remaining files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6650020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just the ability to read/write the data structure to a file. File
format is a simple header, the contents of the vectors, and a
checksum.
BUG=71832
TEST=none
Review URL: http://codereview.chromium.org/6625002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable switch.
Since currently on download url is checked, this only enables download url checks.
Because the safe browsing server used by safe_browsing_test.cc does not understand the new list for safebrowsing download, we have to disable the download protect in that test.
TEST=safe browsing related tests stay green.
BUG=60822
Review URL: http://codereview.chromium.org/6611006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consistent since we pass in string in checkdownloadhash.
Also DCHECK empty hashes and handle it nicely when it happens.
TEST=safebrowsing related tests stays green.
BUG=none
Review URL: http://codereview.chromium.org/6627017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PrefixSet-vs-BloomFilter histograms showed a minor discrepency,
with a very small number of PREFIX_SET_EVENT_BLOOM_MISS_PREFIX_HIT
reports. This CL adds code to regenerate the prefix list and
manually double-check.
Additionally, reduce memory use by requiring the input prefix vector
to be pre-sorted.
BUG=71832
TEST=none
Review URL: http://codereview.chromium.org/6591087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address.
Since we can't discern the remote IP address if the page was loaded via a proxy, also disable phishing detection in that case.
The pre-classification checks are moved to ClientSideDetectionHost, since it is already set up as a TabContentsObserver and receives the ViewHostMsg_FrameNavigate_Params for each navigation.
BUG=none
TEST=ClientSideDetectionHostTest.ShouldClassifyUrl
Review URL: http://codereview.chromium.org/6594006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=69467
Review URL: http://codereview.chromium.org/6588131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This handles only download related operations. We could move the browse timeout here too.
At the same time, I did some small scale refector to group similar codes into helper functions.
TEST=safe_browsing_service_browsertest.cc
BUG=60822
Review URL: http://codereview.chromium.org/6597026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6596084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6598086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6594084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6591066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76390 0039d316-1c4b-4281-b951-d872f2087c98
|