summaryrefslogtreecommitdiffstats
path: root/chrome/browser/search_engines
Commit message (Collapse)AuthorAgeFilesLines
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-112-2/+2
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on i18n/icu_string_conversions from base/string_util.h.brettw@chromium.org2009-10-101-6/+8
| | | | | | | | | | | | Fix up all files requireing this header to include it directly. Split out the ICU-dependent string util unit tests into a new file base/i18n/icu_string_util_unittest.cc TEST=none BUG=none Review URL: http://codereview.chromium.org/269034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28674 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check file_util::ReadFileToString return.mattm@chromium.org2009-10-081-1/+1
| | | | | | | | | | CID=6217 TEST=none BUG=none Review URL: http://codereview.chromium.org/257039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28476 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-2/+2
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Convert history to use new sql wrappers. Enhance wrappers in several ways tobrettw@chromium.org2009-10-021-0/+2
| | | | | | | | | | support the needs of history. BUG=none TEST=covered by unit tests Review URL: http://codereview.chromium.org/246053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27832 0039d316-1c4b-4281-b951-d872f2087c98
* posix: fix a bug estade found in the review but I misunderstood his commentevan@chromium.org2009-09-251-1/+1
| | | | | | We still need the "break;" to happen on all platforms. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27234 0039d316-1c4b-4281-b951-d872f2087c98
* linux: unittest fixevan@chromium.org2009-09-251-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27164 0039d316-1c4b-4281-b951-d872f2087c98
* linux: drop temp_scaffolding_stubsevan@chromium.org2009-09-252-1/+12
| | | | | | | | | It was mostly unneeded, but I had to excise the last bits of RLZ and move some NOTIMPLEMENTED bits to where they belong. Review URL: http://codereview.chromium.org/219042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27161 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Polish the search engine managerrsesek@chromium.org2009-09-192-0/+12
| | | | | | | | | | | | | | | * Make the edit search engine window a sheet. * Only allow one instance of the search engine manager to be opened at once. * The search engine manager now remembers its position. * Create NSWindow(LocalStateAdditions) category to assist with storing window position in Chromium's local state. BUG=21761,21762,21883,21996 TEST=Editing/adding a search engine happens in a sheet. Press [Manage] multiple times and only 1 window should open. Press [Manage] and the window should be at its last position. Review URL: http://codereview.chromium.org/207027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26646 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetCurrentCountryID() for Linux.suzhe@chromium.org2009-09-181-1/+28
| | | | | | | | | | | This CL implements GetCurrentCountryID() function for Linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/203079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26544 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow updating tabs to javascript URLs without hostaa@chromium.org2009-09-111-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | permissions to that tab. Cleaned up a few things along the way: - added a GetExtension() method to ExtensionFunctionDispatcher and ExtensionFunction since it was used in more than one place. - Removed first param from chrome.test.failCallback() since it wasn't used anywhere. - Added a convenience CanAccessHost() method to Extension, since it seems likely to be commonly used. - Refactored setup of mock host resolver in browsertest, since the way it was, you could only customize it at the testsuite level, not the test level. Review URL: http://codereview.chromium.org/199074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25971 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath version of PathService::Get.thestig@chromium.org2009-09-091-13/+13
| | | | | | | | | | | BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/193047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-6/+6
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-283-14/+8
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-283-8/+14
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-1/+2
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Changes Live Search to Bing for en_US only. A full worldwide review is in ↵pkasting@chromium.org2009-08-171-13/+13
| | | | | | | | | | | | progress and we'll pick up the other countries eventually. Added some temporary comments on the Bing entry since the way it's coexisting with the Live entries right now makes for a few slightly unusual bits. BUG=13065 TEST=Search providers should show Bing and not Live Search, setting Bing to default should result in working Suggest and search functionality. Review URL: http://codereview.chromium.org/171065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23571 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-061-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some character literals to use the right escape string.pkasting@chromium.org2009-07-311-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22222 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in creating search terms where we weren't unescapingsky@chromium.org2009-07-312-1/+6
| | | | | | | | | | | correctly. BUG=17697 TEST=covered by unit tests Review URL: http://codereview.chromium.org/159707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22167 0039d316-1c4b-4281-b951-d872f2087c98
* Fix search engine manager allowing you to remove the current default search ↵mattm@chromium.org2009-07-302-3/+3
| | | | | | | | | | | | | engine. If a search engine entry is already in the main group, MakeDefaultTemplateURL should return the current index(so that button states will be updated) rather than -1(which should mean nothing was done.) BUG=17566 TEST=Select search engine that is already in the main group but not the default, and click "make default". The "make default" and "remove" buttons should no longer be clickable. Review URL: http://codereview.chromium.org/159557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22088 0039d316-1c4b-4281-b951-d872f2087c98
* Refactorings surrounding HostResolver:ericroman@google.com2009-07-151-4/+4
| | | | | | | | | | | | | | | | | | | | | | (1) Extract HostResolver to an interface. The existing concrete implementation is now named HostResolverImpl. This makes it possible to create mocks with more complex behavior (i.e. choose via rules if response will be sync vs async). (2) Transform HostMapper into HostResolverProc. Conceptually HostResolverProc maps a hostname to a socket address, whereas HostMapper mapped a hostname to another hostname (so you were still at the mercy of the system's host resolver). With HostResolverProc you can specify the exact AddressList, making it possible to run tests requiring IPv6 socketaddrs on systems (like WinXP) that don't actually support it. (3) Add a MockHostResolver implementation of HostResolver. This replaces the [ScopedHostMapper + RuleBasedHostMapper + HostResolver] combo. It is less clunky and a bit more expressive. BUG=http://crbug.com/16452 R=willchan TEST=existing Review URL: http://codereview.chromium.org/149511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20795 0039d316-1c4b-4281-b951-d872f2087c98
* Moved typedef of RedirectList from HistoryService class to history namespace.meelapshah@chromium.org2009-07-012-2/+2
| | | | | | Review URL: http://codereview.chromium.org/151168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19766 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Certain redirections remove sites from the historyyuzo@chromium.org2009-07-012-2/+3
| | | | | | | | | | | | | | | | | | | Currently, PageTransition::CHAIN_END flag is removed from a History database entry for a redirect source, even when the redirect is user initiated. This change prevents the flag removal for user-initiated redirects. TEST=Open http://www.google.com/ig and click on tabs multiple times. Without this change, only the last tab clicked appears in the History page (CTRL+H). With this change, all the tabs should appear. TESTED=gcl try, manually BUG=11355 Review URL: http://codereview.chromium.org/147145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19708 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the win KeywordEditorView for cross platform friendliness.mattm@chromium.org2009-06-265-0/+797
| | | | | | | | | | | The TableModel is moved to search_engines/template_url_table_model.* The shared logic, and ownership of the url_model_ and table_model_, is moved to search_engines/keyword_editor_controller.* BUG=13326 Review URL: http://codereview.chromium.org/146138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19421 0039d316-1c4b-4281-b951-d872f2087c98
* Replace std:;wstring with std::string and string16 in locale-name related APIs.jshin@chromium.org2009-06-242-2/+3
| | | | | | | | | | | | | | | 1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly. 2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring. This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. BUG=8647 (http://crbug.com/8647) TEST=Pass l10n_util_unittest and other unit tests Review URL: http://codereview.chromium.org/126223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
* Rejiggers the keyword editor so that the UI is independent of the model ↵ben@chromium.org2009-06-235-163/+174
| | | | | | | | | | | rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword. BUG=none TEST=none Review URL: http://codereview.chromium.org/140054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt to land this. This time it compiles on windows, too.ben@chromium.org2009-06-191-0/+2
| | | | | | | | | | | Resuscitate the TOOLKIT_VIEWS build by disabling stuff we don't build yet. TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/141012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18878 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 18865.ben@chromium.org2009-06-191-2/+0
| | | | | | Review URL: http://codereview.chromium.org/140020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18869 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for TOOLKIT_VIEWS build. Disable stuff that we know isn't working so far.ben@chromium.org2009-06-191-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/140014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18865 0039d316-1c4b-4281-b951-d872f2087c98
* Add gtk EditKeywordController.mattm@chromium.org2009-06-182-15/+13
| | | | | | | | BUG=13326 Review URL: http://codereview.chromium.org/126305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18727 0039d316-1c4b-4281-b951-d872f2087c98
* Pass a gfk::NativeWindow instead of gfx::NativeView for TemplateURLFetcher.mattm@chromium.org2009-06-172-4/+4
| | | | | | | | | | Use cross-platform method to get the NativeWindow. BUG=13326 Review URL: http://codereview.chromium.org/126302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18666 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor platform-independent stuff out of EditKeywordController.mattm@chromium.org2009-06-172-0/+221
| | | | | | | | | | | Preparation for adding GTK implementation. BUG=13326 TEST=Edit existing search engine, add new search engine, add engine by clicking on OpenSearch description file. Review URL: http://codereview.chromium.org/125161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18636 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where keyword editor would end up prefixing all keyword urlssky@chromium.org2009-06-156-37/+38
| | | | | | | | | | | | | | | | with "http://" if they didn't have one. This proves problematic as for the google search url we don't have http:// and don't want it. The fix is to only add http:// if the url field is editable. If the url field isn't editable, we know the user hasn't editted it and don't need to try and fix it up. BUG=13282 TEST=see bug, but also make sure you don't run into any other problems with the keyword editor. Review URL: http://codereview.chromium.org/126052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18410 0039d316-1c4b-4281-b951-d872f2087c98
* Completely miscellaneous minor cleanup. Remove some unneeded class ↵pkasting@chromium.org2009-06-051-0/+2
| | | | | | | | declarations, modify or add a couple comments, change a function name in hopes of greater accuracy. Review URL: http://codereview.chromium.org/119264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17798 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-212-16/+9
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16649 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-061-1/+1
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-052-2/+2
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-053-3/+3
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate wstring version of PathService::Get() in unit tests.thestig@chromium.org2009-05-042-12/+10
| | | | | | Review URL: http://codereview.chromium.org/100292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "output=chrome" as the Suggest team has deprecated it server-side.pkasting@chromium.org2009-05-041-3/+2
| | | | | | | BUG=1660988 Review URL: http://codereview.chromium.org/102024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15212 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* ImportantFileWriterphajdan.jr@chromium.org2009-04-281-1/+1
| | | | | | | | | | | | | | Introducing a class for writing important files, preventing their corruption during writing. Switched PrefService to use it. Other classes will be switched in future changesets. TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences. http://crbug.com/10618 Review URL: http://codereview.chromium.org/83001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98
* Searching by keyword now generates a visit against the site with asky@chromium.org2009-04-273-7/+110
| | | | | | | | | | | | | | | | transition type of TAB_TO_SEARCH. This visit increments the typed count and ensures if you use TAB_TO_SEARCH you still get autocompleted to the site. I'll add some tests for this, but want to make sure we're ok with it before I do that. BUG=3633 TEST=will be covered by unit tests. Review URL: http://codereview.chromium.org/93087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 2674 - search engine name containing parenthesis is not ↵xji@chromium.org2009-04-212-0/+10
| | | | | | | | | | | | | | displayed correctly in Omnibox NavSuggest drop-down list. The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI. BUG=2674 Review URL: http://codereview.chromium.org/79005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14119 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the omnibox show past searches and suggestions for keywords.sky@chromium.org2009-04-142-0/+9
| | | | | | | | | | | | | | | We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Review URL: http://codereview.chromium.org/66073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13668 0039d316-1c4b-4281-b951-d872f2087c98
* Scrape search definitions from forms that have onsubmit handlers. The ↵ben@chromium.org2009-04-101-0/+90
| | | | | | | | | | | | | | | | scraping is done after submit events are handled by the page DOM so doing this is safe. Adds test infrastructure for determining that scraping occurs on submit: - allow testserver to be configured to serve pages from / on the server - provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission Eric, please review the test server changes. Scott, please look over everything else. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444 Review URL: http://codereview.chromium.org/62145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13491 0039d316-1c4b-4281-b951-d872f2087c98
* revert until I can figure out why the tests are hangingben@chromium.org2009-04-091-88/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13448 0039d316-1c4b-4281-b951-d872f2087c98
* Scrape search definitions from forms that have onsubmit handlers. The ↵ben@chromium.org2009-04-091-0/+88
| | | | | | | | | | | | | | scraping is done after submit events are handled by the page DOM so doing this is safe. Adds test infrastructure for determining that scraping occurs on submit: - allow testserver to be configured to serve pages from / on the server - provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission Eric, please review the test server changes. Scott, please look over everything else. Review URL: http://codereview.chromium.org/62145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13444 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 06:08:28 +0000