summaryrefslogtreecommitdiffstats
path: root/chrome/browser/search_engines
Commit message (Collapse)AuthorAgeFilesLines
* rid of more OS_LINUX defines, to help the BSD port (work by sprewell & I)pvalchev@google.com2010-08-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2089010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55289 0039d316-1c4b-4281-b951-d872f2087c98
* Allow search engine dialog to have only two choices (Vietnam and Iran have ↵mirandac@chromium.org2010-08-061-1/+1
| | | | | | | | | | | | | only two listed in template_url_prepopulate_data). Fix invalid search URL in in.gr search engine. BUG= 51295 TEST= Vietnam and Iran search engine dialogs work fine, searching with in.gr (from Greek default search engine choices) works. Review URL: http://codereview.chromium.org/3007032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55164 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-042-2/+2
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of GetSwitchValue for most of chrome/browser/.evan@chromium.org2010-08-041-4/+4
| | | | | | Review URL: http://codereview.chromium.org/3005053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54856 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-312-10/+17
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 3ziadh@chromium.org2010-07-302-0/+6
| | | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-302-4/+6
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Add new search engine logos to template url data. This CL also reorganizes ↵mirandac@google.com2010-07-284-45/+400
| | | | | | | | | | | the way logos and search engine type data are stored. Because the search engine dialog is no longer an experiment running on few locales, move the data and logos into the template_url_prepopulate_data for each search engine. BUG=42612 TEST=search engine dialog works as expected. Review URL: http://codereview.chromium.org/3040022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53870 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-269-0/+9
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors.ziadh@chromium.org2010-07-241-2/+4
| | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar Review URL: http://codereview.chromium.org/2856051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in unit testcpu@chromium.org2010-07-171-4/+4
| | | | | | | | | | | | | Test is TemplateURLPrepopulateDataTest_ProvidersFromPrefs TBR=oshima BUG=49086 TEST=none Review URL: http://codereview.chromium.org/2843056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52773 0039d316-1c4b-4281-b951-d872f2087c98
* Add a PrefStore for loading prefs from command-line switches.pam@chromium.org2010-07-161-5/+2
| | | | | | | | | | The first users are proxies and locale, for policies. BUG=49162 TEST=covered by unit tests Review URL: http://codereview.chromium.org/3025001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52650 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the default search providers to be specified by the preferences files,cpu@chromium.org2010-07-134-32/+157
| | | | | | | | | | | | | overriding the built-in set. - Per locale providers not allowed. BUG=47440 TEST=unittest included, for manual testing see bug. Review URL: http://codereview.chromium.org/2974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52228 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for omnibox.onInputStarted and onInputCancelled.mpcomplete@chromium.org2010-07-021-4/+8
| | | | | | | | | | | | Also fix a bug where we'd keep an extension's old keyword even if it changed on upgrade/reload. BUG=46475 BUG=48091 Review URL: http://codereview.chromium.org/2807033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51540 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-2917-325/+323
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA logging of search engine selection position when the search engine ↵mirandac@google.com2010-06-281-0/+12
| | | | | | | | | | | logo positions have been randomized. BUG=46604 TEST=none Review URL: http://codereview.chromium.org/2846038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51061 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: First run bubble.thakis@chromium.org2010-06-262-0/+43
| | | | | | | | | | | | | | | Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it. Move some l10n stuff to l10n_util and use that, too. Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone()) BUG=27489,36366 TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work. Review URL: http://codereview.chromium.org/2822026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98
* Replace wstring with string16 in history. The only time wstring is used now ↵brettw@chromium.org2010-06-231-1/+2
| | | | | | | | | | | | in history is for bookmark-related stuff (the bookmarks system is still wstring-based). The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code). TEST=none BUG=none Review URL: http://codereview.chromium.org/2808017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
* Pref service strings should be std::string.estade@chromium.org2010-06-181-5/+5
| | | | | | | | | | | Part 1: Convert RegisterStringPref. BUG=none TEST=compile Review URL: http://codereview.chromium.org/2809022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50202 0039d316-1c4b-4281-b951-d872f2087c98
* Link with RLZ library from open source repo.rogerta@google.com2010-06-103-6/+5
| | | | | | | | | | | | | In order to pass the check dependency step in the build, I added rlz to the include_rules in DEPS. However, I am not sure this is the best solution. TEST=Make sure that the RLZ pings from chrome are the sameas they were with the old RLZ dll BUG=none Review URL: http://codereview.chromium.org/2755002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49399 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-066-10/+10
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-012-14/+16
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at experimental omnibox API. There are plenty of rough edges and ↵mpcomplete@chromium.org2010-05-285-12/+116
| | | | | | | | | | | | | | | features to work on, but it's in a usable state. When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later. I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout the omnibox code. BUG=38884 Review URL: http://codereview.chromium.org/2078021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
* Allow for non-HTTP schemes in URLs to OSDD entries.jochen@chromium.org2010-05-271-2/+7
| | | | | | | | | BUG=45203 TEST=as described in the bug Review URL: http://codereview.chromium.org/2265003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48392 0039d316-1c4b-4281-b951-d872f2087c98
* Always ask the user when adding a search engine from JS.jochen@chromium.org2010-05-251-6/+10
| | | | | | | | | | | When adding a search provider from JS, and the autogenerated keyword clashes with an existing search engine, ask the user. BUG=15060 TEST=as described in the bug Review URL: http://codereview.chromium.org/2155001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48143 0039d316-1c4b-4281-b951-d872f2087c98
* Only attempt once to autogenerate a keyword for search engines.jochen@chromium.org2010-05-142-3/+12
| | | | | | | | | BUG=none TEST=Add a search engine provider for which no keyword can be generated Review URL: http://codereview.chromium.org/2008017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47249 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix compilation error with gcc 4.5.craig.schlenter@chromium.org2010-05-113-18/+15
| | | | | | | | | | | | | | | Avoid a gcc 4.5 warning/error for values that aren't part of NPNVariable. Also drop some unnecessary static_casts by swapping from an int to a size_t in TemplateURLRef's Replacement struct and use platform specific NULL or 0 constants in a couple of places. BUG=43341 TEST=chrome target compiles with gcc 4.5. Review URL: http://codereview.chromium.org/2019002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46889 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLFetcher and related classes to chrome/common/net.sanjeevr@chromium.org2010-05-071-1/+1
| | | | | | | | BUG=None TEST=Build and Unittests Review URL: http://codereview.chromium.org/1995008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
* Remove/update a bunch of references to the Google-internal bug tracker.evan@chromium.org2010-05-071-1/+1
| | | | | | | | | | Many of our references turn out to just be context for a given workaround, e.g. "Set the foobar here because the destructor dereferences it, see http://private-bug-url". Review URL: http://codereview.chromium.org/2004004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46645 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetDisplayStringInLTRDirectionality() in more places to simplify code.pkasting@chromium.org2010-05-051-8/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1928004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various uses of release() that did not check its valueestade@chromium.org2010-05-041-7/+7
| | | | | | | | | BUG=42904 TEST=compile, unit tests Review URL: http://codereview.chromium.org/1730024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46376 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Add more search engine types.mirandac@chromium.org2010-04-203-6/+26
| | | | | | | | | | | | | 2. Change "GetSearchEngineType" function to use the short name to get the search engine type if we can't choose by prepopulate_id. 3. Disable the close button. (Next CL will remove it, if possible, but this requires adding a method to window_delegate.h). 4. Close the search engine view immediately if the user launches the keyword editor view. Pass the SearchEngineViewObserver object (the FirstRunView) to the keyword editor, who will call back to the waiting observer when closed. BUG= none TEST= none Review URL: http://codereview.chromium.org/1539044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45092 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA calls to record search engine choice during first run.mirandac@chromium.org2010-04-162-0/+48
| | | | | | | | BUG= 37565 TEST= UMA calls should be recorded correctly. Review URL: http://codereview.chromium.org/1528037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44816 0039d316-1c4b-4281-b951-d872f2087c98
* Change prepopulated search engines to reflect new data.mirandac@chromium.org2010-04-151-25/+65
| | | | | | | | | BUG= 41532 TEST= Chrome install for countries in question should offer the new set of search engines. Review URL: http://codereview.chromium.org/1530039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44583 0039d316-1c4b-4281-b951-d872f2087c98
* UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.evan@chromium.org2010-03-232-4/+8
| | | | | | | | | | | | That way it is easier to keep track of those constants in reporting tools. TEST=Covered with standard ui tests Patch by Frank Mantek <fmantek@google.com>. Review URL: http://codereview.chromium.org/811005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-202-6/+8
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-181-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* Change so that the extension favicon is read on the UI thread since ↵arv@chromium.org2010-03-171-1/+1
| | | | | | | | | | | | | extension objects should only be accessed on the UI thread. This also fixes erg's todo to make favicons use RefCountedMemory instead of RefCountedBytes in all places. BUG=None TEST=None Review URL: http://codereview.chromium.org/1028001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41869 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-172-2/+2
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: Another chunk of chrome/ ifdef changespvalchev@google.com2010-03-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/652186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40974 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 6: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-085-8/+15
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40964 0039d316-1c4b-4281-b951-d872f2087c98
* The search terms escaping respect forward slash: it is not escaped if the ↵brettw@chromium.org2010-03-022-30/+40
| | | | | | | | | | | | replacement preceeds ? sign. BUG=19718 Patch by glotov@chromium.org Original review http://codereview.chromium.org/601004 TEST=Verify that slash is escaped as stated in description; example: create search engine en.wikipedia.org/%s and search it with parameters wiki/hi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40364 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-193-3/+3
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-192-0/+2
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* A few miscellaneous changes in the Template URL Prepopulate area:pkasting@chromium.org2010-02-012-47/+54
| | | | | | | | | | | | * Make sure that when migrating away from the old pref the old pref gets erased. * Make sure the unittest is testing all the countries in the data file. * Make sure we explicitly handle or don't handle all the countries the unittest tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/565003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37763 0039d316-1c4b-4281-b951-d872f2087c98
* Removed restriction for {} so that javascript blocks can be used in the url.avayvod@chromium.org2010-01-213-15/+104
| | | | | | | | | | | Added unittests for TemplateURLRef::ParseParameter and TemplateURLRef::ParseURL methods. BUG=2238 TEST=Try adding urls with different combinations of {}, they all should work. Review URL: http://codereview.chromium.org/555012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36743 0039d316-1c4b-4281-b951-d872f2087c98
* The search terms are escaped using + or %20 for space depending on whether ↵avayvod@google.com2010-01-152-13/+42
| | | | | | | | | | | | replacement is in query part of the URL or not. Removed duplicate EscapeQueryParamValue functions without |use_plus| argument. BUG=24571 TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia. Review URL: http://codereview.chromium.org/543077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36398 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/545058 for Dmitry:sky@chromium.org2010-01-151-5/+16
| | | | | | | | | | | Preserve short_name for search engine from OSDD file and generate keyword from URL in OSDD for JS added search engines. BUG=7851 TEST=Try adding search engine via JS and autodetected search engines. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36384 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 03:21:33 +0000