summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sessions
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Remove chrome/browser/browser_navigator.* and references.jhawkins@chromium.org2010-11-121-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4840001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65881 0039d316-1c4b-4281-b951-d872f2087c98
* Stop loading when network state becomes CONNECTINGoshima@chromium.org2010-11-101-4/+2
| | | | | | | | | | | I had wrong assumption that connected->connecting won't happen. BUG=chromium-os:8285 TEST=none Review URL: http://codereview.chromium.org/4678004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65728 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-1/+1
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Session sync integration tests. Left out many client for now, since evenzea@chromium.org2010-11-044-3/+4
| | | | | | | | | | | without doing anything in the test it was timing out. BUG=30519 TEST=self Review URL: http://codereview.chromium.org/4158009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65051 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-022-10/+9
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-2/+2
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-1/+1
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed test expectations, also made network observer a separate objectdavemoore@chromium.org2010-10-281-4/+0
| | | | | | | | | | | TBR:nkostylev@chromium.org 3rd attempt to land http://codereview.chromium.org/4003006 BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4141009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64325 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of missing bug references to FLAKY testsstuartmorgan@chromium.org2010-10-271-0/+1
| | | | | | | | | BUG=None TEST=N/A Review URL: http://codereview.chromium.org/4135007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64114 - Second attempt to land http://codereview.chromium.org/4003006davemoore@chromium.org2010-10-271-0/+4
| | | | | | | | | | | | | | Added mock implementation of prewarm method TBR: nkostylev@chromium.org BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4133002 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/4186005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64140 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt to land http://codereview.chromium.org/4003006davemoore@chromium.org2010-10-271-4/+0
| | | | | | | | | | | Added mock implementation of prewarm method TBR: nkostylev@chromium.org BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64114 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64104 - Prewarm google auth urldavemoore@chromium.org2010-10-271-0/+4
| | | | | | | | | | | | | | | | As cros has no system level dns cache, every login needs to access google.com for the first time. This change causes us to preconnect to the login url while the login panel is being shown. BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4003006 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/4197003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64108 0039d316-1c4b-4281-b951-d872f2087c98
* Prewarm google auth urldavemoore@chromium.org2010-10-271-4/+0
| | | | | | | | | | | | | As cros has no system level dns cache, every login needs to access google.com for the first time. This change causes us to preconnect to the login url while the login panel is being shown. BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4003006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64104 0039d316-1c4b-4281-b951-d872f2087c98
* Output login times as timelinedavemoore@chromium.org2010-10-211-0/+9
| | | | | | | | | BUG=chromium-os:7971 TEST=Log in, examine /tmp/login-times-sent or chrome:system/login-times Review URL: http://codereview.chromium.org/3971001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63437 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syncing of sessions. Numerous changes have been made. Currently, the ↵zea@chromium.org2010-10-202-3/+2
| | | | | | | | | | | | | model associator does not have a local model to associate with, but instead contains a buffer of protobuf specifics for foreign sessions which gets completely overwritten everytime an update occurs. This buffer is then used to create a vector of foreign sessions for each foreign session handler. As a result, The model associator is slightly different from other datatypes. The creation of a persistent unique machine tag needs to be resolved still. Something understandable by the user would be good (home, work, etc.), but for now we use the directory kernel's cache_guid. Unfortunately, this gets reset each time sync is enabled/disabled, resulting in stale client session info that remains visible. BUG=30519 TEST=unit_test Review URL: http://codereview.chromium.org/3825005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63266 0039d316-1c4b-4281-b951-d872f2087c98
* SessionRestoreUITest.ShareProcessesOnRestore as flaky on windows too.eroman@chromium.org2010-10-191-7/+2
| | | | | | | BUG=52022 Review URL: http://codereview.chromium.org/3883001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63100 0039d316-1c4b-4281-b951-d872f2087c98
* Makes session restore work correctly with instant.sky@chromium.org2010-10-152-0/+8
| | | | | | | | | BUG=58956 TEST=see bug Review URL: http://codereview.chromium.org/3783005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62738 0039d316-1c4b-4281-b951-d872f2087c98
* In the TabRestoreService, do not create Window entries that only have 1 Tab.rsesek@chromium.org2010-10-143-12/+42
| | | | | | | | | BUG=56744 TEST=Open a window and navigate 1 tab. Close window. Both NTP and the Mac History menu show the tab, without being in a window. Review URL: http://codereview.chromium.org/3397032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62537 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-142-2/+2
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* chromium-os:7243: Fix so that extensions create popup windows of TYPE_APP_POPUP.stevenjb@google.com2010-10-061-2/+1
| | | | | | | | | | | | Refactor Browser::BuildPopupWindow as Browser::CreatePopupWindow and call it from ExtensionHost::ShowCreatedWindow. BUG=http://code.google.com/p/chromium-os/issues/detail?id=7243 TEST=Test popup windows in general. See issue for specific test case. Review URL: http://codereview.chromium.org/3532011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61657 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Browser::AddTabWithURL(...) with:ben@chromium.org2010-10-052-11/+10
| | | | | | | | | | | | | | - Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition) -> A good many callsites just wanted a way to open a tab somewhere and select it. - Browser::AddTabWithURL(AddTabWithURLParams* params) -> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/3599006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
* ifdef out tests that don't apply to the Macstuartmorgan@chromium.org2010-09-231-36/+33
| | | | | | | | | | | The reason these tests were failing on the Mac is that they test something that the Mac explicitly doesn't support: opening a new window in the existing browser process by re-running from the command line. This ifdefs out the tests that don't apply to the Mac, and the helper method that they are built on so that new tests using it won't accidentally be run on the Mac. BUG=45108 TEST=N/A Review URL: http://codereview.chromium.org/3394018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60354 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-164-0/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionStoragejorlow@chromium.org2010-09-143-5/+15
| | | | | | | | | | | | | | | Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks. To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage. Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely. BUG=52393 TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug. Review URL: http://codereview.chromium.org/3325012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this:jcivelli@chromium.org2010-09-071-5/+5
| | | | | | | | | | | | | | | Don't create pending entries when a navigation is initiated by the page. If the page reloads while such a navigation happens, we could end up with the wrong pending entry. Also make sure TestTabContents::NavigateAndCommit() does commit on the right RVH. BUG=51680 TEST=See bug for steps. TBR=creis Review URL: http://codereview.chromium.org/3257002 Review URL: http://codereview.chromium.org/3346005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58701 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Reaplly the TabRestoreService::Observer into its own file commit.erg@google.com2010-09-027-42/+108
| | | | | | | | | | | | | This means browser.h no longer includes a large chunk of the tab restore system. Now with fixes to chromeos. BUG=none TEST=compiles First Review URL: http://codereview.chromium.org/3296003 Review URL: http://codereview.chromium.org/3358005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58382 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Don't create pending entries when a navigation is initiated by the ↵phajdan.jr@chromium.org2010-09-021-5/+5
| | | | | | | | | | page." TBR=jcivelli Review URL: http://codereview.chromium.org/3360003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58289 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "FBTF: Move the TabRestoreService::Observer into its own file."erg@google.com2010-09-017-108/+42
| | | | | | | | | | | This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to chromeos compile fail. TBR=akalin Review URL: http://codereview.chromium.org/3340007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58271 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create pending entries when a navigation is initiated by the page.jcivelli@chromium.org2010-09-011-5/+5
| | | | | | | | | | | | If the page reloads while such a navigation happens, we could end up with the wrong pending entry. Also make sure TestTabContents::NavigateAndCommit() does commit on the right RVH. BUG=51680 TEST=See bug for steps. Review URL: http://codereview.chromium.org/3257002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58261 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move the TabRestoreService::Observer into its own file.erg@google.com2010-09-017-42/+108
| | | | | | | | | | | | This means browser.h no longer includes a large chunk of the tab restore system. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3296003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58256 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Minor cleanup to testing headers.erg@google.com2010-08-252-0/+2
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3136014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57345 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: move tests that use WebKit from unit_tests to browser_testsphajdan.jr@chromium.org2010-08-241-0/+0
| | | | | | | | | | | | to avoid crashes. TBR=dhollowa, sky, erikkay TEST=unit_tests, browser_tests BUG=52731, 52643 Review URL: http://codereview.chromium.org/3150034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57236 0039d316-1c4b-4281-b951-d872f2087c98
* sync: take two for:tim@chromium.org2010-08-185-6/+70
| | | | | | | | | | | | | Added classes to enable session sync functionality. TEST=ProfileSyncServiceSessionTest BUG=30519 Original patch by : jerrica@chromium.org Original review http://codereview.chromium.org/3168009 Review URL: http://codereview.chromium.org/3133022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56462 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56423 - Added classes to enable session sync functionality.tim@chromium.org2010-08-175-70/+6
| | | | | | | | | | | | | | | TEST=ProfileSyncServiceSessionTest BUG=30519 Original patch by jerrica@chromium.org Original review: http://codereview.chromium.org/3168009 Review URL: http://codereview.chromium.org/3184004 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/3127017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56426 0039d316-1c4b-4281-b951-d872f2087c98
* Added classes to enable session sync functionality.tim@chromium.org2010-08-175-6/+70
| | | | | | | | | | | | TEST=ProfileSyncServiceSessionTest BUG=30519 Original patch by jerrica@chromium.org Original review: http://codereview.chromium.org/3168009 Review URL: http://codereview.chromium.org/3184004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56423 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-5/+5
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SessionRestoreUITest.ShareProcessesOnRestore as flaky on Linux and Mac.viettrungluu@chromium.org2010-08-131-1/+7
| | | | | | | | | BUG=52022 TEST=greener tree Review URL: http://codereview.chromium.org/3156007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56001 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-122-3/+8
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression the resulted in not showing window after doing a tabsky@chromium.org2010-08-061-0/+1
| | | | | | | | | | | | | restore in some situations. BUG=51255 TEST=create a new window with one tab, press control-w to close the window, restore the window by way of control-shift-t and make sure you can see the window. Review URL: http://codereview.chromium.org/3091012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55261 0039d316-1c4b-4281-b951-d872f2087c98
* Minor header cleanup of chrome/browser/[st]*/*.h minus c/b/sync/*.h.viettrungluu@chromium.org2010-08-063-6/+2
| | | | | | | | | | | | - Remove unnecessary forward decls. - Remove unnecessary inclusions of <set>, <map>, <vector>, <list>. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3023043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55222 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-311-3/+3
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine API.evan@chromium.org2010-07-301-2/+1
| | | | | | | | | Cleaned up the final few callers, punting the remaining harder ones to TODOs. Review URL: http://codereview.chromium.org/3043033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 3ziadh@chromium.org2010-07-301-0/+3
| | | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-7/+7
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Drop usage of IntToWString in switch values; we can use ASCII now.evan@chromium.org2010-07-301-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3037034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54286 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-2/+3
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-269-0/+9
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-231-2/+1
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-25 00:31:19 +0000