summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sessions
Commit message (Collapse)AuthorAgeFilesLines
* Wrap InternalSessionRequest in a scoped_refptr.albertb@google.com2010-03-021-1/+1
| | | | | | | | | BUG=37138 TEST=Valgrind reports no errors Review URL: http://codereview.chromium.org/660322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40396 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new method to SessionService that returns a snapshot of the currentalbertb@google.com2010-03-018-21/+143
| | | | | | | | | | | | session. The snapshot is computed directly from memory or, if there are pending closed windows, by reading the session commands from disk. BUG=35040 TEST=unit tests Review URL: http://codereview.chromium.org/661055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40284 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Synchronous session restore work with the login managercmasone@google.com2010-02-221-0/+3
| | | | | | Review URL: http://codereview.chromium.org/650160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39632 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-195-1/+5
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Rename ambiguous "exceptions_page_gtk.cc" before making the content ↵erg@chromium.org2010-02-121-1/+2
| | | | | | | | | | | exceptions page. BUG=none TEST=none Review URL: http://codereview.chromium.org/597051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38953 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to restore application extensions. I'm also enabling tabsky@chromium.org2010-02-1012-18/+266
| | | | | | | | | | | | pinning on views again as everything in place, except a couple of bugs. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/598027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-2/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* Step 1 in Implementing/Prototyping App Panels.rafaelw@chromium.org2010-02-042-1/+6
| | | | | | | | | | | | | | | | | | | | In this first step we 1) Create a new Browser::Type::TYPE_APP_PANEL which is observed in various places 2) Create an AppPanelBrowserFrame which is created in BrowserFrameWin when the TYPE_APP_PANEL is observed. AppPanelBrowserFrame draws itself per glen's mocks and will ultimately behave substantially different from regular browser windows. 3) Create a temporary command switch called --app-launch-as-panel which can be used until we implement actual app launching. Note that there is still work to be done "bit-twiddling" to match glen's mocks and to implement the "inactive" look for these windows. Steps 2 through N may include: different sizing behavior (based either on the content size or an api call), different min/maximize behavior, docking to the os taskbar, auto order & placement of app panels. A screen capture of the current implementation is attached to the bug. BUG=32361 Review URL: http://codereview.chromium.org/553143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38107 0039d316-1c4b-4281-b951-d872f2087c98
* Disables pinned tabs until I land apps. I've #ifdef parts that aresky@chromium.org2010-01-284-23/+11
| | | | | | | | | | | going to stay around, but need to be disabled for now. BUG=32845 TEST=make sure pinned tabs are disabled for now. Review URL: http://codereview.chromium.org/557026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37421 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes flakiness in session restore test. I'm adding two things:sky@chromium.org2010-01-261-8/+16
| | | | | | | | | | | | | | | | . Make the newly created popup navigate to a url. Without this session restore won't restore the tab. . Before exiting manually shutdown the session service. Without this the windows are closed, which, depending upon timing, is treated as though the user closed the window so that session restore won't restore the window. BUG=32716 TEST=this is only a test fix Review URL: http://codereview.chromium.org/552134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37148 0039d316-1c4b-4281-b951-d872f2087c98
* Changes synchronous session restore to create windows after nestedsky@chromium.org2010-01-081-3/+19
| | | | | | | | | | | | | | | message loop returns. The problem with the old approach was we created a bunch of windows than exited the nested message loop. But because exit isn't processed immediately it meant someone could also ask for the nested loop to be exited and then you're hosed (one nested message loop still running). BUG=22878 TEST=none Review URL: http://codereview.chromium.org/519090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35850 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid reloading the Inspector window.apavlov@chromium.org2009-12-252-2/+6
| | | | | | | | | | | This CL disables reloading from the system menu, tab popup menu, and page context menu. BUG=27254,6902 TEST=none Review URL: http://codereview.chromium.org/391036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35275 0039d316-1c4b-4281-b951-d872f2087c98
* Putting back tests that are excluded in bug 28808oshima@chromium.org2009-12-221-3/+0
| | | | | | | | | BUG=28808 TEST=Run ui_tests Review URL: http://codereview.chromium.org/502071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35180 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: sky@chromium.orgoshima@chromium.org2009-12-111-6/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34353 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-022-8/+16
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ↵willchan@chromium.org2009-12-011-1/+1
| | | | | | | | | | SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching as flaky. BUG=29110 Review URL: http://codereview.chromium.org/450044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33502 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky tests on linux/view/64bit builds.oshima@chromium.org2009-11-251-0/+6
| | | | | | | | | | | Also updated browser_tests to use #define instead of #if/else, like other tests. BUG=28808 TEST=None Review URL: http://codereview.chromium.org/442012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33137 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the refcount on InternalGetCommandRequest stays non-zero through ↵jamesr@chromium.org2009-11-181-1/+1
| | | | | | | | | | | | | | | a PostTask The problem was that BaseSessionService::ScheduleGetLastSessionCommands() was posting a task with a InternalGetCommandsRequest* request parameter by calling NewRunnableMethod(.., &SessionBackend::ReadLastSessionCommands, request). SessnionBackend::ReadLastSessionCommands takes one parameter of type scoped_refptr<InternalGetCommandsRequest>. However, NewRunnableMethod was matching the template because an InternalGetCommandsRequest* is implicitly convertable to a scoped_refptr<InternalGetCommandsRequest> but it was not actually creating the scoped_refptr<> (and thus bumping the refcount) until the task was dispatched. By this time the refcount on the InternalGetCommandsRequest had already dropped to zero, leading to memory corruption. This fixes the problem by passing a scoped_refptr<...> in to NewRunnableMethod() to ensure that it is copied and that the refcount stays up. TEST=covered by TabRestoreUITest.RestoreIntoSameWindow - caused very intermittend failures locally BUG=none Review URL: http://codereview.chromium.org/404012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32240 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-132-4/+4
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* A little cleanup in SessionRestoreUITest.phajdan.jr@chromium.org2009-11-121-15/+3
| | | | | | | | | | | | | - don't reload tabs to ensure that a page loaded (it's handled in waiting for completion of IDC_NEW_TAB) - simplify the code, making it shorter and issuing less automation calls TEST=none BUG=none Review URL: http://codereview.chromium.org/385066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31800 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-075-7/+17
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-3/+3
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: don't restore explicitly closed windows.viettrungluu@chromium.org2009-11-052-2/+15
| | | | | | | | | | | | | With "On startup"/"Restore the pages that were open last" set (in Preferences), a window which was explicitly closed (using the red button, Cmd-Shift-W, the menu item -- but not due to quit) should not be restored on startup. This is the behaviour of Firefox and Camino (Safari doesn't appear to implement this feature). Note about this patch: Depending on how we decide things will work for App mode, much more code could be disabled on Mac. BUG=13341 TEST=Set the browser to restore pages on start (see above). Navigate somewhere interesting; close window; quit; restart; should open a browser with default window (NTP or homepage or whatever). Navigate somewhere; quit; restart; should open previously opened stuff. Make sure that session restore (also crash recovery) still work as expected. Review URL: http://codereview.chromium.org/362016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31164 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking on restore window button on ntp now nukes ntp. We always didsky@chromium.org2009-11-051-0/+6
| | | | | | | | | | | this for tabs, just not windows. BUG=21316 TEST=see bug Review URL: http://codereview.chromium.org/360060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31146 0039d316-1c4b-4281-b951-d872f2087c98
* Make SessionService use its own enum for storing window type in the session ↵ben@chromium.org2009-11-052-5/+55
| | | | | | | | | | | database. This allows us to modify Browser::Type without invalidating databases from older versions. http://crbug.com/26500 TEST=see bug Review URL: http://codereview.chromium.org/361016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31069 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore to use a normal load rather than preferringsky@chromium.org2009-11-033-7/+22
| | | | | | | | | | | | the cache. We need to do this else we don't honor page expiration and end up showing stale data for some sites. BUG=21195 TEST=make sure session restore works. Review URL: http://codereview.chromium.org/341043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window restore behaviour on Mac.erg@chromium.org2009-10-291-1/+12
| | | | | | | | | | | | | | | | On the mac, there can be no windows, but the application is sitll open. This confused "Restore the pages that were open last" so that it would restore when opening a new window. BUG=13341 TEST=Open chromium. Set On Startup to "Restore the pages that were open last". Open a few tabs. Close the window (but not chromium). Click the dock icon. The tabs shouldn't be restored. But if you quit chrome and start again, things should reopen. Review URL: http://codereview.chromium.org/340023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30463 0039d316-1c4b-4281-b951-d872f2087c98
* Changes ui proxy classes to use Browser::Types rather than copyingsky@chromium.org2009-10-281-7/+7
| | | | | | | | | | them. BUG=none TEST=none Review URL: http://codereview.chromium.org/343018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30355 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at this. The only change between this and the first is to add the ↵sky@chromium.org2009-10-274-23/+130
| | | | | | | | | | | | | | | GetType message to the end of the list and to keep the old message for creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored. Makes session restore on Chrome OS restore popups. BUG=18862 TEST=none Review URL: http://codereview.chromium.org/329040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30194 - Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-274-130/+23
| | | | | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/335047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30204 0039d316-1c4b-4281-b951-d872f2087c98
* Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-274-23/+130
| | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30194 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-141-2/+2
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: memset the window command data structure. |timestamp| is aligned ↵jhawkins@chromium.org2009-09-161-2/+8
| | | | | | | | | | on a 16 byte boundary leaving 4 bytes of uninitialized data in the middle of the struct. We write this data to disk, which is a possible security risk. BUG=22031 TEST=TabRestoreUITest.RestoreToDifferentWindow Review URL: http://codereview.chromium.org/196144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two tests that leak temporary files.thestig@chromium.org2009-09-021-12/+4
| | | | | | | | BUG=none TEST=Run ExtensionsServiceTest and SessionBackendTest, make sure they don't leave extra temp files behind. Review URL: http://codereview.chromium.org/180068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25149 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-4/+1
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-1/+4
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Split short-circuited assertions in session_restore_uitest.cc to make morephajdan.jr@chromium.org2009-08-141-19/+20
| | | | | | | | | | | | | meaningful errors appear in the logs. This will help fight the test flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/164564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23482 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23357 since it doesn't seem to be the cause of unit testtony@chromium.org2009-08-132-4/+4
| | | | | | | | | | | | | | | | | failure: Renames the NavigationEntry::display_url() to virtual_url(). BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23374 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Renames the NavigationEntry::display_url() to virtual_url()."tony@chromium.org2009-08-132-4/+4
| | | | | | | | | This reverts commit r23357. Review URL: http://codereview.chromium.org/164517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23367 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the NavigationEntry::display_url() to virtual_url().tony@chromium.org2009-08-132-4/+4
| | | | | | | | | | | | | BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23357 0039d316-1c4b-4281-b951-d872f2087c98
* Changes SessionService to make sure a Pickle is deleted before thesky@chromium.org2009-08-101-5/+10
| | | | | | | | | | | | | | memory the pickle was created from is deleted. I don't think the current code actually causes a problem as Pickle's destructor won't attempt to delete the memory in this case, but I'm adding this to make it clear the Pickle should be deleted and prevent any future problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/165241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22921 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Thiago Farina's CL.jcampan@chromium.org2009-07-291-1/+1
| | | | | | | | | | | | | See http://codereview.chromium.org/159186 Renaming GetNormalBounds to GetRestoredBounds from browser_window.h. BUG=None TEST=None TBR=tfarina Review URL: http://codereview.chromium.org/160337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21983 0039d316-1c4b-4281-b951-d872f2087c98
* Adds timestamp to session restore for tabs and windows.arv@google.com2009-07-203-23/+173
| | | | | | | | | | BUG=13134 TEST=None Review URL: http://codereview.chromium.org/155609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21095 0039d316-1c4b-4281-b951-d872f2087c98
* Makes --pinned-tab-count work if session restore is enabled, but wesky@chromium.org2009-07-171-3/+26
| | | | | | | | | | | don't restore anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/155667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20935 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up restoring pinned tabs for session and tab restoresky@chromium.org2009-07-148-22/+245
| | | | | | | | | | | services. And turns on pinned tabs by default on linux. BUG=16634 TEST=Currently this linux only. Try tab pinning and make sure it works. Review URL: http://codereview.chromium.org/149621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20650 0039d316-1c4b-4281-b951-d872f2087c98
* Sprinkle some defensiveness into the UI tests so that they don't explode if ↵stuartmorgan@chromium.org2009-07-071-4/+9
| | | | | | | | | | the proxy doesn't respond (e.g., due to a timeout). BUG=none TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking). Review URL: http://codereview.chromium.org/149281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-061-1/+1
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-193-67/+52
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-132-0/+2
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-032-0/+2
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 23:09:42 +0000