summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sidebar
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: More dtor deinlining. (Can almost see the end!)erg@google.com2010-10-222-12/+12
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test SidebarTest.SidebarNavigate as it times out on windows.satish@chromium.org2010-10-051-1/+7
| | | | | | | | BUG=57964 TEST=none TBR=brettw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61505 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionStoragejorlow@chromium.org2010-09-141-1/+1
| | | | | | | | | | | | | | | Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks. To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage. Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely. BUG=52393 TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug. Review URL: http://codereview.chromium.org/3325012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
* Unify sidebar identification in the chrome.experimental.sidebar extension ↵aa@chromium.org2010-08-313-12/+4
| | | | | | | | | | | | API implementation. BUG=51084 TEST=Run interactive_ui_tests and browser_tests. Review URL: http://codereview.chromium.org/3212005 Patch from Aleksey Shlyapnikov <alekseys@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57965 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding a previous CL (I fixed the ChromeOS build):jcivelli@chromium.org2010-08-231-0/+1
| | | | | | | | | | | | | | | Making window.focus()/blur() work only when there is a user gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). TBR=darin,sky BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3174030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57094 - Making window.focus()/blur() work only when there is a user ↵jcivelli@chromium.org2010-08-231-1/+0
| | | | | | | | | | | | | | | | | gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3201008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
* Making window.focus()/blur() work only when there is a user gesture.jcivelli@chromium.org2010-08-231-0/+1
| | | | | | | | | | | | Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98
* FBTB: Remove unneeded #includes of base/ref_counted.h and base/string16.h in ↵viettrungluu@chromium.org2010-08-201-1/+0
| | | | | | | | | | | src/chrome. BUG=23581 TEST=builds Review URL: http://codereview.chromium.org/3181028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56874 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of chrome.experimental.sidebar extension API. brettw@chromium.org2010-08-195-0/+870
BUG=51084 TEST=Run interactive_ui_tests and browser_tests. New: - sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en); - Sidebar panel in Chrome browser view; Original review=http://codereview.chromium.org/2836040/show Patch by alekseys@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56716 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:19:08 +0000