| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8687031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8729013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
make the enums match the Content API naming convention.
BUG=98716
Review URL: http://codereview.chromium.org/8664006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=maruel@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8716001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ChromeOS bubble setup code to window.cc.
This code is also in the original bubble code.
msw: Update name to CreateViewsBubbleAboveLockScreen.
BUG=98322
TEST=None
Review URL: http://codereview.chromium.org/8650001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8614003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8566052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I chose to use the local ContentView class to implement BubbleDelegateView.
SpeechInputBubbleImpl didn't fit well as a BubbleDelegateView, because:
-Instances are expected to outlive Widget closure or hide (not implemented).
-SpeechInputBubbleBase::Show would cause a naming conflict.
-SpeechInputBubbleController interactions made that approach difficult.
BUG=98323
TEST=SpeechInputBubbles function as before.
Review URL: http://codereview.chromium.org/8565003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8566028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=97388
TEST=existing apitests + status icon unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109285
Review URL: http://codereview.chromium.org/8386074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trybot, stuffing up the CQ.
Add a tray notification UI for speech input recording in the extension API.
BUG=97388
TEST=existing apitests + status icon unittests
Review URL: http://codereview.chromium.org/8386074
TBR=leandrogracia@chromium.org
Review URL: http://codereview.chromium.org/8508051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97388
TEST=existing apitests + status icon unittests
Review URL: http://codereview.chromium.org/8386074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently when showing the avatar bubble the tip of the bubble points to the middle of the anchor control.
This can look weird so I'm changing it to be aligned with the edge of the anchor control.
BUG=98884
TEST=
Review URL: http://codereview.chromium.org/8439064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=owners
BUG=98716
Review URL: http://codereview.chromium.org/8437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.
A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.
Also moved BrowserProcessSubThread into content/ namespace. As part
of follow-up cleanup, chrome/ will stop using this class.
BUG=98716
TEST=existing
Review URL: http://codereview.chromium.org/8392042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68267
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8346013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes.
BUG=98716
Review URL: http://codereview.chromium.org/8331001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97388
TEST=none
Review URL: http://codereview.chromium.org/8274011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61677
TEST=none
Review URL: http://codereview.chromium.org/8289007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for my upcoming changelist.
BUG=97665
TEST=None (effectively a no-op), all bubbles should work as before.
Review URL: http://codereview.chromium.org/8136034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch replaces all occurrences of 'censor results' with 'filter profanities', which is a much accurate description of what it does and avoids unfortunate confusions.
BUG=79991
TEST=none
Review URL: http://codereview.chromium.org/8199010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This includes extended error management by handling the status response code and the DidStartReceivingSpeech/DidStopReceivingSpeech events.
BUG=97388
TEST=none
Review URL: http://codereview.chromium.org/8137005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Redo for CR=8113031, it failed on linux_chromeos_clang.
Following files are missed in CR=8113031
1 chrome/browser/chromeos/drop_shadow_label.cc
2 chrome/browser/chromeos/drop_shadow_label.h
3 chrome/browser/ui/views/cookie_info_view.cc
4 chrome/browser/ui/views/database_info_view.cc
5 chrome/browser/ui/views/hung_renderer_view.cccc
6 chrome/browser/ui/views/importer/import_lock_dialog_view.cc
7 chrome/browser/ui/views/task_manager_view.cc
8 ui/aura_shell/examples/bubble.cc
9 views/examples/bubble_example.cc
10 views/examples/link_example.cc
11 views/examples/native_theme_button_example.cc
12 views/examples/text_example.cc
13 views/examples/textfield_example.cc
BUG=68267
TEST=no user visible changes
Review URL: http://codereview.chromium.org/8162013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change wst::string to string16 for view::Label and views::Link
BUG=68267
TEST=no user visible changes
Review URL: http://codereview.chromium.org/8113031
TBR=yosin@chromium.org
Review URL: http://codereview.chromium.org/8142026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change wst::string to string16 for view::Label and views::Link
BUG=68267
TEST=no user visible changes
Review URL: http://codereview.chromium.org/8113031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetBrowserViewForBrowser. There is one place still using
GetBrowserViewForNativeWindow and that's the tab dragging code which
needs to use it.
BUG=none
TEST=none
R=asargent, pinkerton, erg, pkasting, ben
Review URL: http://codereview.chromium.org/8068020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now gets the request context and censor preference in BrowserRenderProcessHost and passes them through to the SpeechInputDispatcherHost. Each time a speech request is made, the SpeechInputDispatcherHost passes through these values to the SpeechInputManager. Also each time the censor preference changes, RenderViewContextMenu updates the current profile's SpeechInputPreferences.
BUG=92366
TEST=Speech recognition works.
Review URL: http://codereview.chromium.org/7989001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of content and also move a couple of functions to content that should've
been moved earlier.
BUG=90442
TBR=jam@chromium.org,allanwoj@chromium.org
TEST=
Review URL: http://codereview.chromium.org/7969028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved requests_ (and related code) to SpeechInputManager. Added some pure virtual methods in SpeechInputManager that are implemented by ChromeSpeechInputManager.
BUG=95792
TEST=None
Review URL: http://codereview.chromium.org/7838028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=23
CID=100941,100986,100987,101015,101016,101017,101227,101229,101230,101332,101333,101334,101335,101336,101337,101355,101356,101359,101362,101363,101381,101389,101417
BUG=none
TEST=none
R=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7780013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove kGdkGreen (only used in one place) and kGdkGray (used in 3 places
for a disabled text field).
- Inline the definition of kGdkBlack and kGdkWhite to avoid copy being run
as a static initializer.
BUG=94925
Review URL: http://codereview.chromium.org/7838014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now with fixes for builds that trybots don't cover by default.
(This yak needs shaving because chunks of gtk using code in chrome/ are being
moved to content/ to build the content_shell, but we can't depend on code in
chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig
constants, widget factory functions, etc instead of just moving the file.)
BUG=93804
TEST=none; code move
First Review URL: http://codereview.chromium.org/7737001
Review URL: http://codereview.chromium.org/7748026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
consistency with other platforms.
BUG=80730
TEST=none
Review URL: http://codereview.chromium.org/7741043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts r98287.
BUG=93804
Review URL: http://codereview.chromium.org/7749017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This yak needs shaving because chunks of gtk using code in chrome/ are being
moved to content/ to build the content_shell, but we can't depend on code in
chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig
constants, widget factory functions, etc instead of just moving the file.
BUG=93804
TEST=none; code move
Review URL: http://codereview.chromium.org/7737001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7744028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SpeechInputManager through the embedder interface.
I've renamed Chrome's SpeechInputManagerImpl to ChromeSpeechInputManager, to match what we've been doing for other chrome implementations of content classes.
BUG=76697
Review URL: http://codereview.chromium.org/7729001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a redo of http://codereview.chromium.org/7629009/
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7720011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 59e1c15b1ee0e29742a2479527de09715a2e5525.
TBR=saintlou@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7720010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7719001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was r97750, which was reverted at r97756. This patch, in addition to all
the other things it did, marks OwnedWidgetGtk for export and moves it to the
ui:: namespace.
Original list of things this patch does:
- OwnedWidgetGtk now goes in ui/base/gtk/
- TruncateString moved from l10n_util:: to ui::
- GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper).
- gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk.
BUG=93804
TEST=existing unit tests
Original Review URL: http://codereview.chromium.org/7669040
Review URL: http://codereview.chromium.org/7708021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=saintlou@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7685057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7629009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/
This also moves some other files:
- OwnedWidgetGtk now goes in ui/base/gtk/
- TruncateString moved from l10n_util:: to ui::
- GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper).
- gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk.
BUG=93804
TEST=existing unit tests
Review URL: http://codereview.chromium.org/7669040
TBR=erg@google.com
Review URL: http://codereview.chromium.org/7708017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also moves some other files:
- OwnedWidgetGtk now goes in ui/base/gtk/
- TruncateString moved from l10n_util:: to ui::
- GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper).
- gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk.
BUG=93804
TEST=existing unit tests
Review URL: http://codereview.chromium.org/7669040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7601014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7544021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
|