summaryrefslogtreecommitdiffstats
path: root/chrome/browser/spellcheck_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-021-1/+27
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the spellchecker and associated messages and functions to use string16brettw@chromium.org2009-10-191-65/+71
| | | | | | | | | | | | for words instead of wstring. I also changed some places where it converted the word to a string to do that conversion at the last possible second before giving it to Hunspell (since this conversion isn't needed for Mac). TEST=Covered by unit tests BUG=none Review URL: http://codereview.chromium.org/274077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-131-276/+276
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Spellchecker:estade@chromium.org2009-10-091-2/+1
| | | | | | | | | | | | | Move file accesses during initialization to file thread. Also fix a rare (and harmless) memory leak. Also introduce a rare (and harmless) memory leak. TEST=added dchecks, ran spellcheck unit tests, clicked around, changed dictionaries, added words BUG=22984 BUG=21924 BUG=1123096 Review URL: http://codereview.chromium.org/269020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28512 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the os x spelling panel to chromium. Users canpinkerton@chromium.org2009-09-091-10/+89
| | | | | | | | | | | now access it from the main menu and context menu and use it to perform spelling tasks. For more detail, see http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc Patch from pwicks86@gmail.com (Paul Wicks). BUG=None TEST=The spelling panel should work in os x. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
* Update hunspell DEPS to 1.2.8mhm@chromium.org2009-09-011-3/+3
| | | | | | | | | BUG=14756 TEST=Ran valgrind and unit_tests for SpellCheckTest and all passed successfully. Review URL: http://codereview.chromium.org/176046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24998 0039d316-1c4b-4281-b951-d872f2087c98
* Pull the entire hunspell tree and place it in depsBUG=14756TEST=Compiled ↵mhm@chromium.org2009-08-211-1/+0
| | | | | | | | Chromium, ran tests Review URL: http://codereview.chromium.org/174127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23957 0039d316-1c4b-4281-b951-d872f2087c98
* Another fix for my new unit-test "SpellCheckTest.SpellCheckTest".hbono@chromium.org2009-08-141-5/+16
| | | | | | | | | | | Sorry I forgot removing a fprint() call used for debug. TBR=brettw BUG=18184 TEST=run unit_test on Mac Review URL: http://codereview.chromium.org/164554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23432 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for a unit-test break on Mac.hbono@chromium.org2009-08-141-7/+14
| | | | | | | | | | | | | | | | | | This change fixes my new unit-test "SpellCheckTest.SpellCheckTest" breaks on Mac. The system dictionaries of Mac spellchecker don't have the following words included in hunspell: * en-AU (Australia): "organize" (which is a typo of "organise"); * en-GB (United Kingdom): "organize" (which is a typo of "organise"); * pt-BT (Brazil): "Google"; * pt-PT (Portugal): "Google". This change removed "Google" from a couple of texts and fixed a couple of typos. Also, this change adds a language for Spanish (Spain), which I forgot adding. TBR=brettw BUG=18184 TEST=run unit_tests on Mac Review URL: http://codereview.chromium.org/164553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23431 0039d316-1c4b-4281-b951-d872f2087c98
* Added a unit test "SpellCheckTest.SpellCheckText".hbono@chromium.org2009-08-141-0/+239
| | | | | | | | | | This change adds a new unit test "SpllCheckTest.SpellCheckText" for testing our spellchecker with all available dictionaries. BUG=18184 "Add more spellcheck tests with languages other than en-US" TEST=run unit_test.exe Review URL: http://codereview.chromium.org/159906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23430 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting hunspell upgrade 22263,22257,22252,22243. Causing many valgrind ↵mhm@chromium.org2009-08-031-3/+3
| | | | | | | | | warnings. TBR: brettw, dank, jshin Review URL: http://codereview.chromium.org/159797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22287 0039d316-1c4b-4281-b951-d872f2087c98
* Update Hunspell to the latest stable version to use the latest bdict format.mhm@chromium.org2009-08-011-3/+3
| | | | | | | | | | Updated Hunspell to version 1.2.8 which properly deals with UTF8 and fixes many bugs. This CL will use the BDict format and remove the usage of FileMgr. Removed the unwanted "key" parameter constructors from hunspell since we are managing them through bdict. Removed all line numbers from the errors since we don't support that. BUG= 14756 (http://crbug.com/14756) TEST= Compiled Hunspell, Compiled Chromium, Ran Chromium, Fixed some of my spelling mistakes. Ran unit tests for SpellCheckTest.* Review URL: http://codereview.chromium.org/155841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22243 0039d316-1c4b-4281-b951-d872f2087c98
* Enable support for the Mac OS X spellchecking service in chromium.pinkerton@chromium.org2009-06-301-1/+298
| | | | | | | | | | | | | | | | | | | | spellchecker_platform_engine.h provides a basic interface for platform specific spellcheckers to follow. spellchecker_mac.mm implements these functions for the OS X spellchecking service. spellchecker_win.cc and spellchecker_linux.cc provide a space for future developments on these platforms. spellchecker_common.h contains a few shared variables and typedefs that are useful across all spellchecking code. spellchecker.cc has been modified to call the SpellCheckerPlatform::SpellCheckerAvailable() and use either hunspell or the platform spellchecker based on that call. Many new test cases have been added to one of the unit tests as well. chrome.gyp has been edited to reflect the added files. patch from pwicks86@gmail.com (paul wicks) BUG=13206 TEST=spellchecking works in web pages git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19585 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 13432.hbono@chromium.org2009-06-291-0/+5
| | | | | | | | | | | This is caused by my bonehead mistake that I forgot filtering out U_STRING_NOT_TERMINATED_WARNING while checking the return value in SpellCheckWordIterator::Normalize() in my change r10087. I have added code that checks if the result value is U_STRING_NOT_TERMINATED_WARNING and added a couple of test cases which verify this issue. BUG=13432 "Any word of 13 or 14 characters is not spellcheck" TEST=run unit_test.exe. Review URL: http://codereview.chromium.org/146074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19482 0039d316-1c4b-4281-b951-d872f2087c98
* UI Support for Auto Spell Correct. Currently, it is still under the command ↵sidchat@google.com2009-06-031-0/+1
| | | | | | | | line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box. Review URL: http://codereview.chromium.org/119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17528 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Changes to stop tests breaking.sidchat@google.com2009-05-301-1/+0
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/112077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17270 0039d316-1c4b-4281-b951-d872f2087c98
* Do not autocorrect words in capital letters, or having capital letters in ↵sidchat@google.com2009-05-291-0/+1
| | | | | | | | | | between, as they may refer to acronyms or terms not in the dictionary. BUG = www.crbug.com/12921 TEST = Type CLD (a library), should not change back to LCD Review URL: http://codereview.chromium.org/118008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17259 0039d316-1c4b-4281-b951-d872f2087c98
* Add Automatic spell correction support in Chrome.sidchat@google.com2009-05-121-0/+33
| | | | | | | Issue=7624 Review URL: http://codereview.chromium.org/42608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15888 0039d316-1c4b-4281-b951-d872f2087c98
* Change SpellChecker::Language to be an ASCII string.estade@chromium.org2009-03-111-5/+5
| | | | | | Review URL: http://codereview.chromium.org/41028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11407 0039d316-1c4b-4281-b951-d872f2087c98
* Changes spellcheck_unittest to read dictionaries directly from the src tree. ↵shess@chromium.org2009-03-051-12/+20
| | | | | | | | | Removes the build rules to copy test dictionaries to Dictionaries/. Review URL: http://codereview.chromium.org/40082 Patch from rohitrao. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10951 0039d316-1c4b-4281-b951-d872f2087c98
* Enable spellcheck_unittest.cc.mark@chromium.org2009-03-031-5/+4
| | | | | | Review URL: http://codereview.chromium.org/28335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10754 0039d316-1c4b-4281-b951-d872f2087c98
* Ports SpellChecker to use FilePaths instead of wstring.estade@chromium.org2009-02-251-17/+20
| | | | | | | | | by Rohit Rao (rohitrao@google.com) issue: http://codereview.chromium.org/28013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10374 0039d316-1c4b-4281-b951-d872f2087c98
* Port the spell checker to posix.estade@chromium.org2008-12-161-6/+6
| | | | | | | | It all builds but does not link yet. Review URL: http://codereview.chromium.org/14408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7109 0039d316-1c4b-4281-b951-d872f2087c98
* Missed this file in my previous cleanup patch.pkasting@chromium.org2008-12-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/13729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6766 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellcheck unittest into browser next to the filetc@google.com2008-10-261-0/+487
it tests. Review URL: http://codereview.chromium.org/8176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3989 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-05 02:49:33 +0000