summaryrefslogtreecommitdiffstats
path: root/chrome/browser/spellchecker.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remember change in Spell Check language by putting it in the list of accept ↵sidchat@google.com2009-02-031-0/+13
| | | | | | | | | | | languages when the user changes the language from languages options menu. It also includes a fix (required for this change to work) when existing users are updated to use language only code for spellcheck languages instead of languages+region. Issue=5829 Review URL: http://codereview.chromium.org/19520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9106 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary region code from spellcheck language/locale codes. ↵sidchat@google.com2009-01-281-42/+65
| | | | | | | | | Fix of Linux by using ARRAYSIZE_UNSAFE instead of arraysize. Issue=Issue=6329 Review URL: http://codereview.chromium.org/18567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8816 0039d316-1c4b-4281-b951-d872f2087c98
* Roll forward 8722,8721jeremy@chromium.org2009-01-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/19028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8734 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8722,8721.maruel@chromium.org2009-01-271-3/+0
| | | | | | Review URL: http://codereview.chromium.org/19024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8723 0039d316-1c4b-4281-b951-d872f2087c98
* First step of porting VisitedLinkMaster to POSIX:jeremy@chromium.org2009-01-271-0/+3
| | | | | | | | | | | | * Use POSIX file access APIs rather than HANDLEs. * Add stubs so that VisitedLinkMaster compiles on POSIX. Still to be done: * Bring up Surrounding infrastructure to turn on unit tests. Review URL: http://codereview.chromium.org/18530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8721 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8565.brettw@chromium.org2009-01-231-54/+32
| | | | | | Review URL: http://codereview.chromium.org/18718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8566 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary region code from spellcheck language/locale codessidchat@google.com2009-01-231-32/+54
| | | | | | | Issue=6329 Review URL: http://codereview.chromium.org/18694 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8565 0039d316-1c4b-4281-b951-d872f2087c98
* Change spell check dictionary download URL to now include edgedlsidchat@google.com2009-01-221-1/+1
| | | | | | | BUG=1592281 Review URL: http://codereview.chromium.org/18631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8487 0039d316-1c4b-4281-b951-d872f2087c98
* Move url_* to net subdirben@chromium.org2009-01-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8224 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of 'Add common words for each language, and remove forbidden words'sidchat@google.com2009-01-121-7/+14
| | | | | | | | | Update spellchecker to use version 1.2 dictionaries for 19 languages. Issue=2837 Review URL: http://codereview.chromium.org/17337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7873 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug.xji@chromium.org2008-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Related bug: http://code.google.com/p/chromium/issues/detail?id=2779 Related Webkit fix: http://trac.webkit.org/changeset/36874 Test: Steps to repro: 1) open chrome, Hebrew UI 2) make sure the spell checker is on, and is set to Hebrew 3) type some Hebrew text in a RTL box (like RTL plain text finto), and use a Hebrew word that the speller does not know. 4) type some more Without the underlying Webkit fix: the highlight marker is in a wrong location, and keeps moving while typing more words after the unrecognized one. With the underlying Webkit fix: the highlight marker is in a correct and fixed location. Review URL: http://codereview.chromium.org/16606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7496 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildestade@chromium.org2008-12-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7112 0039d316-1c4b-4281-b951-d872f2087c98
* Port the spell checker to posix.estade@chromium.org2008-12-161-24/+22
| | | | | | | | It all builds but does not link yet. Review URL: http://codereview.chromium.org/14408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7109 0039d316-1c4b-4281-b951-d872f2087c98
* revert r6938estade@chromium.org2008-12-121-1/+1
| | | | | | | (i.e. reapply 6935, with fix) Review URL: http://codereview.chromium.org/14087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6953 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6935.ojan@google.com2008-12-121-1/+1
| | | | | | | Broke compile Review URL: http://codereview.chromium.org/14083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6938 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the memory mapped file class for posix.estade@chromium.org2008-12-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/14073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6935 0039d316-1c4b-4281-b951-d872f2087c98
* Add a MemoryMappedFile class to file_util.estade@chromium.org2008-12-121-50/+6
| | | | | | | | Factor out windowisms from the spell checker. Review URL: http://codereview.chromium.org/14041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6919 0039d316-1c4b-4281-b951-d872f2087c98
* Try and make some spellcheck code more obvious by using typedefs.pkasting@chromium.org2008-12-111-30/+27
| | | | | | | I am not convinced this patch is a net win. Please share your thoughts on if using a Language/Languages set of types is better or worse than what we're doing now. Review URL: http://codereview.chromium.org/13367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6807 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 6.pkasting@chromium.org2008-12-101-74/+58
| | | | | | | | | | | | | | | | | | | | | Lots of small things (mostly in spellcheck code), e.g.: * L"" -> std::wstring() * type *var; -> type* var; * Fix parameter line-wrapping to comply with style guide * Remove unnecessary classname scoping inside class delcaration * Remove empty declaration * Add/remove blank lines in hopes of increasing readability * Add block ("{", "}") around local use of a temporary that is later redefined * Fold temps into other statements where obvious * Use std::find() instead of hand-rolling the same functionality * Combine distinct cases in switch statements when they all do the same thing * Range-check to avoid some algorithmic work when it's not needed * at() -> [] ...and various others. Pretty much every change stands on its own. Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground. (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). ) Review URL: http://codereview.chromium.org/13688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6745 0039d316-1c4b-4281-b951-d872f2087c98
* Make the spellcheck-context-menu generation code more robust/future-proof ↵jungshik@google.com2008-12-091-10/+17
| | | | | | | | | | | | | | | | | | (fil and fil-PH will match each other). Currently, en-AU, de-CH, fr-CA do not match any spellcheck language. With this change, they will match en-US, de-DE, fr-FR, respectively unless there's an exact (more specific) match. Matching en-{AU,NZ,ZA} with en-US is not ideal. BUG=5251 TEST=Add 'fr-CA' (but NOT fr or fr-FR) to the accept-language list and see if 'fr-FR' comes up in the list of spell-check languages in the context menu of a textarea. Add 'de' (but not de-DE) to a-l list and see if 'de-DE' comes up in the list of spell-check languages in the context menu. Review URL: http://codereview.chromium.org/13262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6562 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new submenu in the context menu for a text box. This submenu displays ↵sidchat@google.com2008-12-011-0/+118
| | | | | | | | some spell check languages that Chrome supports, derived from the accept languages list and the current spell check language. The spell check language which is currently set is shown to be selected. The user can click on some other spell check language, and it will become effective immediately (this part of the code was addressed in a previous CL, and has been checked in). Review URL: http://codereview.chromium.org/12614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6162 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to disable/enable Spell Check. In addition, remove additional ↵sidchat@google.com2008-10-291-6/+0
| | | | | | | | | | code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter. Issue = 120 Review URL: http://codereview.chromium.org/7935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4140 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-0/+2
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crasher in SpellChecker Add to dictionary feature.sidchat@google.com2008-10-171-1/+2
| | | | | | | Issue=3039 Review URL: http://codereview.chromium.org/7484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3546 0039d316-1c4b-4281-b951-d872f2087c98
* Update SpellChecker to download the latest version of the bdic dictionary files.sidchat@google.com2008-10-161-3/+41
| | | | | | Review URL: http://codereview.chromium.org/6474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3468 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform wrappers for fopen, _wfopen_s, etc.mark@chromium.org2008-10-011-3/+2
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>. http://codereview.chromium.org/6005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2760 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for "Add to dictionary" in the context menu.sidchat@google.com2008-09-171-3/+81
| | | | | | Review URL: http://codereview.chromium.org/2446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2322 0039d316-1c4b-4281-b951-d872f2087c98
* Update URL for dictionary download.sidchat@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2071 0039d316-1c4b-4281-b951-d872f2087c98
* Invoke a flag setting for 'dictionary download over' in the IO loop through ↵sidchat@google.com2008-09-041-33/+33
| | | | | | | | a proxy in the UI loop. Review URL: http://codereview.chromium.org/438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1726 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-261-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup spell check file to stop using reference counted pointers without need.jar@google.com2008-08-141-10/+5
| | | | | | | | | | | | | | | | | I don't really believe this will solve anything (in terms of the bug), but it did remove some needless complexity above the crash site in the stack. There is a tiny chance that there is a shutdown race, where the destruction of the containing object raced ahead of the execution (and resulting destruction) of a task. I think the destruction of the task by the containing object would probably be bad anyway, and I doubt that it even happens... so this is all about being cleaner. bug=1318039 r=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@850 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 15:11:47 +0000