summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ssl
Commit message (Collapse)AuthorAgeFilesLines
* Cite bug 61528 about the IsWindow(hwnd_) DCHECK failures,wtc@chromium.org2010-11-021-2/+2
| | | | | | | | | | | which may be why these unit tests started to time out. R=nirnimesh BUG=61528 TEST=none Review URL: http://codereview.chromium.org/4278001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64763 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-021-12/+14
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestHTTPSExpiredCertAndGoBackViaMenu on win.nirnimesh@chromium.org2010-11-011-0/+5
| | | | | | | | | | | | It's been failing consistently. BUG=43575 TEST= TBR=wtc Review URL: http://codereview.chromium.org/4251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64675 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestHTTPSExpiredCertAndGoBackViaButton on winnirnimesh@chromium.org2010-11-011-0/+5
| | | | | | | | | | | | | | | | Times out: SSLUITest.TestHTTPSExpiredCertAndGoBackViaButton: Did not complete. BUG=43575 TEST= TBR=wtc Review URL: http://codereview.chromium.org/4244001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64670 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-011-3/+4
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-011-4/+3
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-012-6/+6
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to test_server.py to restrict the SSL/TLS bulk encryption ↵rsleevi@chromium.org2010-10-281-4/+7
| | | | | | | | | | | algorithms via the command-line argument --ssl-alg. BUG=58831 TEST=Run test_server.py as an HTTPS server with --ssl-alg=rc4. Connect via openssl s_client -connect 127.0.0.1:1337 -cipher DEFAULT:\!RC4. Observe a connection failure. Connect with openssl s_client -connect 127.0.0.1:1337, observe that a ciphersuite that uses RC4 is negotiated. Review URL: http://codereview.chromium.org/3812007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64233 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test that times out.thakis@chromium.org2010-10-251-1/+1
| | | | | | | | BUG=43437 TEST=None TBR=jcivelli git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63768 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: More dtor deinlining. (Can almost see the end!)erg@google.com2010-10-222-10/+26
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SSLUITest.TestUnauthentidatedFrameNavigation as disabled for ↵nkostylev@chromium.org2010-10-221-1/+1
| | | | | | | | | | | | | | linux_chromeos. It crashes browser_tests in 20% of the times. TBR=jcivelli@chromium.org BUG=43437 TEST=none Review URL: http://codereview.chromium.org/3985003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63505 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - misc. chrome/browser/*/*.pkasting@chromium.org2010-10-212-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4009001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63420 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-1/+1
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Final Part:tfarina@chromium.org2010-10-121-1/+1
| | | | | | | | | | | | | | - Rename chrome_thread.cc to browser_thread.cc - Rename chrome_thread_unittest.cc to browser_thread_unittest.cc - Include browser_thread.h instead of chrome_thread.h where needed. - Fix gyp files according. BUG=56926 TEST=trybots and compiled locally Review URL: http://codereview.chromium.org/3643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62356 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part22:tfarina@chromium.org2010-10-125-5/+5
| | | | | | | | | | | | | | | | - Include browser_thread instead of chrome_thread in more 97 files. Now the remaining files that are including chrome_thread.h are: chrome_thread.cc and browser_thread.h. They will be fixed next. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3717004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 58162: Mixed Content False Positive for intranet hostname certificatesfinnur@chromium.org2010-10-112-17/+20
| | | | | | | | | | | Previously, we lumped the intranet host warning in with mixed content warning. This calls it out as a separate warning. BUG=58162 TEST=None Review URL: http://codereview.chromium.org/3536019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62178 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Small nits; moving virtual methods to implementation.erg@google.com2010-10-087-6/+25
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3627002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61976 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part6:tfarina@chromium.org2010-10-085-26/+26
| | | | | | | | | | | - Rename entries under renderer_host and ssl. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3595017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61913 0039d316-1c4b-4281-b951-d872f2087c98
* SSLUITest.TestRunsInsecuredContentRandomizeHash fails on Vista Tests (and ↵dhollowa@chromium.org2010-10-071-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | others) http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/23216/steps/browser_tests/logs/stdio Note: Google Test filter = SSLUITest.TestRunsInsecuredContentRandomizeHash [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SSLUITest [ RUN ] SSLUITest.TestRunsInsecuredContentRandomizeHash [6072:5256:1006/165819:224673187:INFO:install_util.cc(72)] No existing Chrome install found. [6072:5980:1006/165821:224674390:INFO:chrome_plugin_lib.cc(201)] ChromePluginLib::CP_Initialize(c:\b\slave\chromium-rel-vista-tests\build\src\build\Release\gears.dll): initialized=0 [6072:5980:1006/165821:224674421:INFO:chrome_plugin_lib.cc(222)] ChromePluginLib::CP_Initialize(c:\b\slave\chromium-rel-vista-tests\build\src\build\Release\gears.dll): initialized=1): result=0 [6072:5980:1006/165821:224674500:INFO:ssl_client_socket_nss.cc(1224)] The server 127.0.0.1 does not support the TLS renegotiation_info extension. Backtrace: (No symbol) [0x011F8B37] BUG=58230 TEST=SSLUITest.TestRunsInsecuredContentRandomizeHash TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/3539018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61746 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Browser::AddTabWithURL(...) with:ben@chromium.org2010-10-051-14/+12
| | | | | | | | | | | | | | - Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition) -> A good many callsites just wanted a way to open a tab somewhere and select it. - Browser::AddTabWithURL(AddTabWithURLParams* params) -> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/3599006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring ui_test_utils codeisherman@chromium.org2010-09-281-9/+6
| | | | | | | | | BUG=none TEST=all tests that used to pass should continue to pass Review URL: http://codereview.chromium.org/3402030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60858 0039d316-1c4b-4281-b951-d872f2087c98
* The original intent of the test was to test badd HTTPS sub-resources inside ↵jcivelli@chromium.org2010-09-271-1/+1
| | | | | | | | | | | | | | a good HTTPS page. Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found. I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that. BUG=40932 TEST=Run the test Review URL: http://codereview.chromium.org/3452026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60722 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Remove the flaky mark from ↵phajdan.jr@chromium.org2010-09-231-10/+1
| | | | | | | | | | | | | | | SSLUITest.TestDisplaysInsecureContentLoadedFromJS The last test failure occurred on September 14th. TBR=jcivelli BUG=52557 TEST=browser_tests Review URL: http://codereview.chromium.org/3395013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60289 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-161-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 8)thestig@chromium.org2010-09-081-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58794 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup the SSLPolicyBackend class.tfarina@chromium.org2010-09-044-188/+3
| | | | | | | | | | | This removes some code that now are obsolete. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3337005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58577 0039d316-1c4b-4281-b951-d872f2087c98
* Do not say the connection is not encrypted if security_bitswtc@chromium.org2010-09-021-3/+4
| | | | | | | | | | | | | | | | | is -1 (unknown). Say nothing in that case. If the description for the connection section is empty, omit the connection section in the dialog. R=finnur,jcivelli BUG=53366,13049 TEST=Visit https://alioth.debian.org/. Bring up the Security info dialog while Chrome is displaying the SSL certificate error page. The security info dialog should not say "Your connection to alioth.debian.org is not encrypted." Review URL: http://codereview.chromium.org/3243008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58302 0039d316-1c4b-4281-b951-d872f2087c98
* Address a TODO in SSLPolicyBackend class.tfarina@chromium.org2010-08-312-56/+45
| | | | | | | | | | | | | | Fix the conversions from wide to string16 in this class and get rid of the base/utf_string_conversions.h. (Note: this was a TODO for evanm). BUG=None TEST=compiles locally and trybots Review URL: http://codereview.chromium.org/3284003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57987 0039d316-1c4b-4281-b951-d872f2087c98
* https: add support for DNS exclusion and switch to TXT records.agl@chromium.org2010-08-283-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (This code has no effect unless --enable-dnssec-certs is given.) The existing DNSSEC code will process embeded chains in certificates and validate CERT records there in. The format of the CERT record was just something made up as a proof of concept. This change switches that code to using TXT records which are at least used by some other code. Additionally, when --enable-dnssec-certs is given. TXT record lookups are triggered for each HTTPS connection. If DNSSEC secure, these lookups can validate a HTTPS certificate. Even without DNSSEC, they can by used for exclusion: if TLS fingerprints are given, but the certificate doesn't match any of them, then the certificate is rejected. The next step in this series will be to perform the TXT lookup for some percentage of dev channel users in order to measure the latency impact. For this experiment, all behavioural changes will be disabled. BUG=none TEST=net_unittests http://codereview.chromium.org/3148037/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57787 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-264-5/+5
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up unnecessary #includes of base/{scoped_ptr.h,string16.h}.viettrungluu@chromium.org2010-08-191-1/+0
| | | | | | | | | | | | Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in base/ref_counted.h, not in base/scoped_ptr.h. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3132024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SSLUITest.TestDisplaysInsecureContentLoadedFromJS as flaky on Win32.thestig@chromium.org2010-08-181-1/+10
| | | | | | | | BUG=52557 TEST=none Review URL: http://codereview.chromium.org/3125021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56497 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-219/+130
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* Remove remaining deprecated wstring methods from base/values.{cc,h}.viettrungluu@chromium.org2010-08-171-19/+22
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3109025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
* Convert infobar APIs to UTF-16.evan@chromium.org2010-08-131-7/+12
| | | | | | | | | | | | | | | | | The critical change is the base class in infobar_delegate.h. The remainder is just adapting all users to that change. I grepped for all instances of the three base functions whose types I changed to be more sure that I found all classes that tried to overload these functions. I sure wish C++ had an @Override annotation. :~( TEST=compiles BUG=23581 Review URL: http://codereview.chromium.org/3127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56066 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-121-3/+7
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 5)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3041049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55349 0039d316-1c4b-4281-b951-d872f2087c98
* Minor header cleanup of chrome/browser/[st]*/*.h minus c/b/sync/*.h.viettrungluu@chromium.org2010-08-061-2/+0
| | | | | | | | | | | | - Remove unnecessary forward decls. - Remove unnecessary inclusions of <set>, <map>, <vector>, <list>. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3023043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55222 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar after enrolling a client certificatedavidben@chromium.org2010-08-022-38/+56
| | | | | | | | | | | | This gives the user some feedback that we added a certificate. R=wtc,brettw TEST=none BUG=50782 Review URL: http://codereview.chromium.org/2815023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54602 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 3ziadh@chromium.org2010-07-301-0/+3
| | | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-3/+3
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-65/+67
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-291-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2611-0/+11
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-231-1/+1
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SSLClientAuthHandler and certificate selectiondavidben@chromium.org2010-07-215-478/+37
| | | | | | | | | | | | | | | | | | | | | | | | | This cleans up much of the code involved in displaying a certificate selection dialog to the user. - Adds a new inner class to RenderViewHostDelegate (later to be populated with more SSL things). - Adds a helper class for TabContents' implementation. - Moves the certificate dialogs themselves to have a common entry point. - Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the TabContents implementation displaying the dialogs. - Picks the correct parent window for the dialog on all platforms, instead of relying on BrowserList::GetLastActive - Makes the OS X implementation use an asynchronous sheet, now that we know the parent. - Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity. R=agl,brettw,mark BUG=148 TEST=selecting client certificates still works Review URL: http://codereview.chromium.org/2823038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53231 0039d316-1c4b-4281-b951-d872f2087c98
* Minor clean-up tasks that were TODO(snej)rsleevi@chromium.org2010-07-176-19/+19
| | | | | | | | | | | | | | Rename Principal->CertPrincipal, Policy->CertPolicy, both of which are merely syntatic fluff. Rename Fingerprint->SHA1Fingerprint, which is more important since those using the fingerprint, such as the unit tests, were truly hardcoded against SHA-1 fingerprints, and if the fingerprint ever changed, wouldn't cause errors until run time. R=wtc BUG=None TEST=Compilers stay green Review URL: http://codereview.chromium.org/2815048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52789 0039d316-1c4b-4281-b951-d872f2087c98
* Display the error code when certificates fail to adddavidben@chromium.org2010-07-151-2/+9
| | | | | | | | | | | We really want to make error strings, but this is a start. BUG=43906 TEST=none Review URL: http://codereview.chromium.org/2859026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52499 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb SSL connection information into the PageInfo model.agl@chromium.org2010-07-122-7/+16
| | | | | | | | | | | | | | | | | This plumbs two bits of information into the PageInfo model (the dialog which results from clicking on the padlock icon): whether or not we performed SSLv3 fallback and whether or not the server supported the renegotiation extension. It doesn't actually do anything with this information yet (except to add histograms of them), pending future CLs. BUG=none TEST=none http://codereview.chromium.org/2943001/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52079 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor certificate viewer code behind ShowCertificateViewerdavidben@chromium.org2010-07-071-3/+2
| | | | | | | | | | | | | This abstracts away the platform-specific certificate viewer behind a common function call. R=wtc,mattm BUG=none TEST=Viewing the certificate information on an SSL session continues to work Review URL: http://codereview.chromium.org/2815024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51793 0039d316-1c4b-4281-b951-d872f2087c98