summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ssl
Commit message (Collapse)AuthorAgeFilesLines
* Reverting r9823 (http://codereview.chromium.org/16207) because dkegel@google.com2009-02-141-4/+10
| | | | | | | | | | | | | | | | | | | | | 1) the Interactive Tests (dbg) buildbot needs the SSL cert installed 2) the same buildbot showed a refcounting problem, e.g. FATAL:ref_counted.cc(22)] Check failed: in_dtor_. RefCounted object deleted without calling Release() c:\b\slave\chromium-dbg-builder\build\src\chrome\browser\views\find_bar_win_interactive_uitest.cc(57): error: Value of: NULL != server.get() Actual: false Expected: true [ FAILED ] FindInPageTest.CrashEscHandlers (2109 ms) 3) the Webkit Linux buildbot failed four tests redirect302-frames.html cross-frame-access-protocol-explicit-domain.html cross-frame-access-protocol.html origin-header-for-https.html I'm leaving the tcp_pinger files in for the moment, they shouldn't hurt anything. Review URL: http://codereview.chromium.org/23028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9827 0039d316-1c4b-4281-b951-d872f2087c98
* ssl_client_socket_unittest.cc: launch local server with TestServerLauncher dkegel@google.com2009-02-141-10/+4
| | | | | | | | | | | | | | | | | | | | | | rather than use bugs.webkit.org, fixes TODO(darin) Add tests with bad server certs ssl_client_socket_nss.cc: fix bugs revealed by new tests tcp_pinger.cc: helper class to do synchronous connect from tests. Has to work inside ui tests where one can't use TestCompletionCallback. ssl_test_util: renamed class TestServerLauncher, added Start/Stop methods. Make part of net.lib to work around link error in test_shell_tests. url_request_unittest.h: use TestServerLauncher to manage server. SSL client tests disabled for now on Mac. BUG=7114 Review URL: http://codereview.chromium.org/16207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9823 0039d316-1c4b-4281-b951-d872f2087c98
* Remember that we've white listed a certificate when we switch to a new tab.abarth@chromium.org2009-02-134-49/+150
| | | | | | | | R=wtc BUG=6456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9749 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 9747abarth@chromium.org2009-02-134-150/+49
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9748 0039d316-1c4b-4281-b951-d872f2087c98
* Remember that we've white listed a certificate when we switch to a new tab.abarth@chromium.org2009-02-134-49/+150
| | | | | | | | | R=wtc BUG=6456 Review URL: http://codereview.chromium.org/20296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9747 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply of Tony's r9656 (Add chrome/browser/ssl/ssl_manager.cc to the build.)estade@chromium.org2009-02-124-21/+44
| | | | | | | | | | | Also port 2 more files in browser/ssl to posix * ssl_policy * ssl_blocking_page Review URL: http://codereview.chromium.org/21297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9703 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add chrome/browser/ssl/ssl_manager.cc to the build."tc@google.com2009-02-121-18/+11
| | | | | | | | | This reverts commit 9656. Review URL: http://codereview.chromium.org/20308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9672 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of landing chrome_resources project. Changes from last time:tc@google.com2009-02-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | - fix scons dependencies by adding a target for grit/theme_resources.h - fix mac build by adding grit to unittest include path - fix check deps by adding rules for /grit dir. Create a chrome_resources.vcproj that holds grd files that hold non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/24011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/browser/ssl/ssl_manager.cc to the build.tc@google.com2009-02-121-11/+18
| | | | | | | Review URL: http://codereview.chromium.org/21275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9656 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Create a chrome_resources.vcproj that holds grd files that hold"tc@google.com2009-02-121-1/+1
| | | | | | | | | | This reverts commit r9631. TBR=deanm Review URL: http://codereview.chromium.org/23023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
* Create a chrome_resources.vcproj that holds grd files that holdtc@google.com2009-02-121-1/+1
| | | | | | | | | | | | | | | | | | | | | non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/20247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser_resources.rc into a a grd file. While I'm at it,tc@google.com2009-02-092-2/+5
| | | | | | | | | | | | I removed the flatten_html visual studio rule and just rolled the functionality directly into GRIT. The sln change is to have browser depend on browser_resources (now needed for browser_resources.h). Review URL: http://codereview.chromium.org/21148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9418 0039d316-1c4b-4281-b951-d872f2087c98
* Move resource_message_filter and resource_request_details to the renderer_host.brettw@chromium.org2009-02-051-1/+1
| | | | | | | | | | Make the repost form warning portable by abstracting the show function from the view. Rename the Windows repost form warning and move it to browser/views. This also fixes a comment in browser_process.h Review URL: http://codereview.chromium.org/20066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9242 0039d316-1c4b-4281-b951-d872f2087c98
* Finish taking out render_messages.h includes from headers.jam@chromium.org2009-02-051-1/+0
| | | | | | Review URL: http://codereview.chromium.org/20072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9209 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting the changes from my previous cl that are specific to not including ↵jam@chromium.org2009-02-041-0/+1
| | | | | | | | | | render_messages.h/plugin_message.h unless necessary. TBR=mpcomplete Review URL: http://codereview.chromium.org/20059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9189 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my change to get the tree green. Not sure why the tests became ↵jam@chromium.org2009-02-041-1/+0
| | | | | | | | | | flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Review URL: http://codereview.chromium.org/21039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easier/less work/less error-prone to create new IPC channel types ↵jam@chromium.org2009-02-041-0/+1
| | | | | | | | (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-015-19/+23
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the option for HTTPServer to be created with a specificsky@google.com2009-01-291-1/+1
| | | | | | | | | | | | | | | MessageLoop. I'm going to need this when running ui tests in process. In this case I'll pass in the IO thread. I'll change all callers to use the new method, but before doing that wanted to make sure you're ok with it. BUG=none TEST=none Review URL: http://codereview.chromium.org/19039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
* This prevents an occasional DCHECK seen during the SSL UI test that happenedcreis@google.com2009-01-281-6/+3
| | | | | | | | | | | | | | | | | | | | | | because of the unresponsive tab logic. If we are short-cutting a slow beforeunload handler, we now avoid a redundant call to SetNavigationsSuspended. Also clarified a few comments, removed what appeared to be an unnecessary call to DidNavigateMainFrame, and re-enabled tests that were likely disabled due to this issue. BUG=6950 BUG=6698 TEST=SSLUITest.TestHTTPSExpiredCertAndDontProceed --single-process TEST=SSLUITest.TestHTTPWithBrokenHTTPSResource TEST=SSLUITest.TestOKHTTPS TEST=SSLUITest.TestHTTPSExpiredCertAndProceed Review URL: http://codereview.chromium.org/19006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8826 0039d316-1c4b-4281-b951-d872f2087c98
* Move security style into the tab_contents directory. This is the last part ofbrettw@chromium.org2009-01-231-1/+1
| | | | | | | the "Tab Contents (old)" group! Review URL: http://codereview.chromium.org/18686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8564 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of browser and into either renderer_host or tab_contents.brettw@chromium.org2009-01-222-2/+2
| | | | | | | This also fixes a crash in the web contents unit test in a commented-out test and re-enable it. Review URL: http://codereview.chromium.org/18504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8470 0039d316-1c4b-4281-b951-d872f2087c98
* Disables another SSL test as it is causing hangs.sky@google.com2009-01-221-1/+2
| | | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/18665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8461 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 6520 by ensuring that InfoBarClosed is called whenever a tab is ↵tim@chromium.org2009-01-211-2/+0
| | | | | | | | | | | closed or a navigation to a URL that is not supported by the current TabContentsType takes place by invoking it on all InfoBarDelegates from TabContents::Destroy(), which is the best least-common-denominator I've found for doing this work. Alternatively I could have made InfoBarDelegate listen for TAB_CONTENTS_DESTROYED and self-invoke InfoBarClosed but that seemed unorthodox (relatively speaking). This prevents InfoBarDelegates from leaking in these cases. BUG=6520 Review URL: http://codereview.chromium.org/18381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8406 0039d316-1c4b-4281-b951-d872f2087c98
* Disables a couple of consistently flakey/hanging tests.sky@google.com2009-01-201-2/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/18384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 6296 by using a dedicated delegate instance for each infobar that ↵tim@chromium.org2009-01-161-0/+2
| | | | | | | | | | | | | the PasswordManager opens, rather than always using the PasswordManager itself as the delegate. The crash was occuring because before one infobar completely finished closing (i.e during its close animation), another password infobar would be opened, and for a moment in time two infobars are pointing to the same delegate. When the initial closing animation completes, it would null-out a field (pending_decision_manager_), which the now visible infobar would depend on when the user clicks one of the native buttons. This click would dereference a null member, hence causing the crash. Other clients of infobars seem to be immune to this problem because they either all create dedicated delegate instances per infobar, or they don't reset any state on InfoBarClosed. I think (at the very least) the infobar code should document that it can be risky to use a "shared" delegate due to the possibility of two simultaneously visible infobars referring to the same delegate. Review URL: http://codereview.chromium.org/18065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8236 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the SSL stuff into its own subdirben@chromium.org2009-01-169-0/+3218
Review URL: http://codereview.chromium.org/18137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8165 0039d316-1c4b-4281-b951-d872f2087c98