summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ssl
Commit message (Collapse)AuthorAgeFilesLines
* Refactoring ui_test_utils codeisherman@chromium.org2010-09-281-9/+6
| | | | | | | | | BUG=none TEST=all tests that used to pass should continue to pass Review URL: http://codereview.chromium.org/3402030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60858 0039d316-1c4b-4281-b951-d872f2087c98
* The original intent of the test was to test badd HTTPS sub-resources inside ↵jcivelli@chromium.org2010-09-271-1/+1
| | | | | | | | | | | | | | a good HTTPS page. Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found. I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that. BUG=40932 TEST=Run the test Review URL: http://codereview.chromium.org/3452026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60722 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Remove the flaky mark from ↵phajdan.jr@chromium.org2010-09-231-10/+1
| | | | | | | | | | | | | | | SSLUITest.TestDisplaysInsecureContentLoadedFromJS The last test failure occurred on September 14th. TBR=jcivelli BUG=52557 TEST=browser_tests Review URL: http://codereview.chromium.org/3395013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60289 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-161-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 8)thestig@chromium.org2010-09-081-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58794 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup the SSLPolicyBackend class.tfarina@chromium.org2010-09-044-188/+3
| | | | | | | | | | | This removes some code that now are obsolete. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3337005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58577 0039d316-1c4b-4281-b951-d872f2087c98
* Do not say the connection is not encrypted if security_bitswtc@chromium.org2010-09-021-3/+4
| | | | | | | | | | | | | | | | | is -1 (unknown). Say nothing in that case. If the description for the connection section is empty, omit the connection section in the dialog. R=finnur,jcivelli BUG=53366,13049 TEST=Visit https://alioth.debian.org/. Bring up the Security info dialog while Chrome is displaying the SSL certificate error page. The security info dialog should not say "Your connection to alioth.debian.org is not encrypted." Review URL: http://codereview.chromium.org/3243008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58302 0039d316-1c4b-4281-b951-d872f2087c98
* Address a TODO in SSLPolicyBackend class.tfarina@chromium.org2010-08-312-56/+45
| | | | | | | | | | | | | | Fix the conversions from wide to string16 in this class and get rid of the base/utf_string_conversions.h. (Note: this was a TODO for evanm). BUG=None TEST=compiles locally and trybots Review URL: http://codereview.chromium.org/3284003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57987 0039d316-1c4b-4281-b951-d872f2087c98
* https: add support for DNS exclusion and switch to TXT records.agl@chromium.org2010-08-283-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (This code has no effect unless --enable-dnssec-certs is given.) The existing DNSSEC code will process embeded chains in certificates and validate CERT records there in. The format of the CERT record was just something made up as a proof of concept. This change switches that code to using TXT records which are at least used by some other code. Additionally, when --enable-dnssec-certs is given. TXT record lookups are triggered for each HTTPS connection. If DNSSEC secure, these lookups can validate a HTTPS certificate. Even without DNSSEC, they can by used for exclusion: if TLS fingerprints are given, but the certificate doesn't match any of them, then the certificate is rejected. The next step in this series will be to perform the TXT lookup for some percentage of dev channel users in order to measure the latency impact. For this experiment, all behavioural changes will be disabled. BUG=none TEST=net_unittests http://codereview.chromium.org/3148037/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57787 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-264-5/+5
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up unnecessary #includes of base/{scoped_ptr.h,string16.h}.viettrungluu@chromium.org2010-08-191-1/+0
| | | | | | | | | | | | Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in base/ref_counted.h, not in base/scoped_ptr.h. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3132024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SSLUITest.TestDisplaysInsecureContentLoadedFromJS as flaky on Win32.thestig@chromium.org2010-08-181-1/+10
| | | | | | | | BUG=52557 TEST=none Review URL: http://codereview.chromium.org/3125021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56497 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-219/+130
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* Remove remaining deprecated wstring methods from base/values.{cc,h}.viettrungluu@chromium.org2010-08-171-19/+22
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3109025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
* Convert infobar APIs to UTF-16.evan@chromium.org2010-08-131-7/+12
| | | | | | | | | | | | | | | | | The critical change is the base class in infobar_delegate.h. The remainder is just adapting all users to that change. I grepped for all instances of the three base functions whose types I changed to be more sure that I found all classes that tried to overload these functions. I sure wish C++ had an @Override annotation. :~( TEST=compiles BUG=23581 Review URL: http://codereview.chromium.org/3127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56066 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-121-3/+7
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 5)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3041049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55349 0039d316-1c4b-4281-b951-d872f2087c98
* Minor header cleanup of chrome/browser/[st]*/*.h minus c/b/sync/*.h.viettrungluu@chromium.org2010-08-061-2/+0
| | | | | | | | | | | | - Remove unnecessary forward decls. - Remove unnecessary inclusions of <set>, <map>, <vector>, <list>. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3023043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55222 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar after enrolling a client certificatedavidben@chromium.org2010-08-022-38/+56
| | | | | | | | | | | | This gives the user some feedback that we added a certificate. R=wtc,brettw TEST=none BUG=50782 Review URL: http://codereview.chromium.org/2815023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54602 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 3ziadh@chromium.org2010-07-301-0/+3
| | | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-3/+3
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-65/+67
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-291-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2611-0/+11
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-231-1/+1
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SSLClientAuthHandler and certificate selectiondavidben@chromium.org2010-07-215-478/+37
| | | | | | | | | | | | | | | | | | | | | | | | | This cleans up much of the code involved in displaying a certificate selection dialog to the user. - Adds a new inner class to RenderViewHostDelegate (later to be populated with more SSL things). - Adds a helper class for TabContents' implementation. - Moves the certificate dialogs themselves to have a common entry point. - Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the TabContents implementation displaying the dialogs. - Picks the correct parent window for the dialog on all platforms, instead of relying on BrowserList::GetLastActive - Makes the OS X implementation use an asynchronous sheet, now that we know the parent. - Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity. R=agl,brettw,mark BUG=148 TEST=selecting client certificates still works Review URL: http://codereview.chromium.org/2823038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53231 0039d316-1c4b-4281-b951-d872f2087c98
* Minor clean-up tasks that were TODO(snej)rsleevi@chromium.org2010-07-176-19/+19
| | | | | | | | | | | | | | Rename Principal->CertPrincipal, Policy->CertPolicy, both of which are merely syntatic fluff. Rename Fingerprint->SHA1Fingerprint, which is more important since those using the fingerprint, such as the unit tests, were truly hardcoded against SHA-1 fingerprints, and if the fingerprint ever changed, wouldn't cause errors until run time. R=wtc BUG=None TEST=Compilers stay green Review URL: http://codereview.chromium.org/2815048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52789 0039d316-1c4b-4281-b951-d872f2087c98
* Display the error code when certificates fail to adddavidben@chromium.org2010-07-151-2/+9
| | | | | | | | | | | We really want to make error strings, but this is a start. BUG=43906 TEST=none Review URL: http://codereview.chromium.org/2859026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52499 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb SSL connection information into the PageInfo model.agl@chromium.org2010-07-122-7/+16
| | | | | | | | | | | | | | | | | This plumbs two bits of information into the PageInfo model (the dialog which results from clicking on the padlock icon): whether or not we performed SSLv3 fallback and whether or not the server supported the renegotiation extension. It doesn't actually do anything with this information yet (except to add histograms of them), pending future CLs. BUG=none TEST=none http://codereview.chromium.org/2943001/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52079 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor certificate viewer code behind ShowCertificateViewerdavidben@chromium.org2010-07-071-3/+2
| | | | | | | | | | | | | This abstracts away the platform-specific certificate viewer behind a common function call. R=wtc,mattm BUG=none TEST=Viewing the certificate information on an SSL session continues to work Review URL: http://codereview.chromium.org/2815024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51793 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at Moving Browser::AddTypes to TabStripModel. The firstsky@chromium.org2010-06-281-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | attempt caused some flakiness on the new tab warm startup test. The only difference between this and the last is that I'm leaving some suspcious code in TabStripModel::InsertTabContents and Browser::AddTabWithURL. I'll try to isolate why those changes caused flakiness after I land the rest. Here's the description: Moves Browser::AddTypes to TabStripModel. This patch is primarily cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2866024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
* Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than ↵rsleevi@chromium.org2010-06-261-0/+1
| | | | | | | | | | | | assume ownership R=wtc BUG=47463 TEST=none Review URL: http://codereview.chromium.org/2867026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50938 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-5/+5
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Marking SSLUITest.TestCNInvalidStickiness as FLAKY on windows.robertshield@chromium.org2010-06-221-1/+8
| | | | | | | | | | BUG=47170 TEST=none TBR=avi,willchan Review URL: http://codereview.chromium.org/2875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50463 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some unneeded WebKit headers.thestig@chromium.org2010-06-181-2/+0
| | | | | | | | BUG=46666 TEST=none Review URL: http://codereview.chromium.org/2830012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50264 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-061-1/+1
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* Make SSLUITest.TestUnauthenticatedFramNavigation flaky for mac and linux, ↵jhawkins@chromium.org2010-06-041-2/+9
| | | | | | | | | | | | | disabled for windows. Contributed by tessamac@chromium.org BUG=43437 TEST=none Review URL: http://codereview.chromium.org/2536001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48951 0039d316-1c4b-4281-b951-d872f2087c98
* Make SSLUITest.TestHTTPSExpiredCertAndDontProceed flaky for mac and linux, ↵jhawkins@chromium.org2010-05-271-2/+9
| | | | | | | | | | | | | and disabled for windows. Contributed by tessamac@chromium.org BUG=43575 TEST=none Review URL: http://codereview.chromium.org/2224004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48435 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SSLUITest.TestGoodFrameNavigation, it flakily exceeds test timeout.phajdan.jr@chromium.org2010-05-191-1/+2
| | | | | | | | | | | TBR=jrg BUG=18626 TEST=disabled Review URL: http://codereview.chromium.org/2116009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47641 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the mostly-unused FilterPolicy class. Convert the only actually-used ↵pkasting@chromium.org2010-05-185-68/+9
| | | | | | | | | | | | bit, FILTER_EXTENSION_MESSAGES, into a bool that's only passed to places that really need it. Also renames ExtensionMessageFilterPeer to ExtensionLocalizationPeer in hopes of making its one use more apparent. I added a couple comments too. BUG=none TEST=none Review URL: http://codereview.chromium.org/2105006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47533 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "mixed content" to "insecure content" in as many places as possible, ↵pkasting@chromium.org2010-05-184-74/+68
| | | | | | | | | | to standardize on a consistent naming scheme. BUG=none TEST=none Review URL: http://codereview.chromium.org/2069005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47531 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r47347 [was reverted in r47357], this time without re-enabling a ↵pkasting@chromium.org2010-05-1710-325/+369
| | | | | | | | | | | | | | | | | | | | | DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 ) Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 Review URL: http://codereview.chromium.org/2126005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47347 - (Original patch reviewed at ↵rvargas@google.com2010-05-1510-370/+326
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/2067003 ) Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. Falied TestGoodFrameNavigation on Mac 10.5 browser tests among other things: /b/slave/chromium-rel-mac-builder/build/src/chrome/browser/ssl/ssl_browser_tests.cc:43: Failure Value of: entry->ssl().displayed_mixed_content() Actual: false Expected: displayed_mixed_content Which is: true BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2095006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47357 0039d316-1c4b-4281-b951-d872f2087c98
* (Original patch reviewed at http://codereview.chromium.org/2067003 )pkasting@chromium.org2010-05-1510-326/+370
| | | | | | | | | | | | | | | | | | Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47347 0039d316-1c4b-4281-b951-d872f2087c98
* L"" -> std::wstring(), try to avoid line breaks in the middle of statements, ↵pkasting@chromium.org2010-05-131-58/+47
| | | | | | | | | | and other misc. cleanup. BUG=none TEST=none Review URL: http://codereview.chromium.org/2100001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47170 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more dead code/strings relating to mixed/unsafe content.pkasting@chromium.org2010-05-132-16/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2098001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix logic error in SSLPolicy::UpdateStateForMixedContent().pkasting@chromium.org2010-05-111-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2052007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46988 0039d316-1c4b-4281-b951-d872f2087c98
* Remove vestiges of has_unsafe_content(), which is no longer used.pkasting@chromium.org2010-05-111-30/+23
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2049008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46965 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SSLUITest.TestHTTPSExpiredCertAndDontProceed, it flakilyphajdan.jr@chromium.org2010-05-071-1/+2
| | | | | | | | | | | | | exceeds test timeout. TBR=jcivelli TEST=none BUG=43575 Review URL: http://codereview.chromium.org/2019004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46691 0039d316-1c4b-4281-b951-d872f2087c98