summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ssl
Commit message (Collapse)AuthorAgeFilesLines
* More progress on ForceHTTPS.abarth@chromium.org2009-05-203-5/+27
| | | | | | | | | | | Instead of turning on strict HTTPS error processing for every site, we now track which sites have opted in. Our implementation is still experimental and hidden behing the command line switch --force-https. R=darin TEST=No tests yet because this is just an experiment. Review URL: http://codereview.chromium.org/113503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16464 0039d316-1c4b-4281-b951-d872f2087c98
* Try 16161 again. Third time is the charm.abarth@chromium.org2009-05-161-0/+174
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16228 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16164.abarth@chromium.org2009-05-153-193/+39
| | | | | | Review URL: http://codereview.chromium.org/113471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16165 0039d316-1c4b-4281-b951-d872f2087c98
* Try 16162 again. Hopefully should build with gcc.abarth@chromium.org2009-05-153-39/+193
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16164 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16161.abarth@chromium.org2009-05-151-179/+0
| | | | | | Review URL: http://codereview.chromium.org/113468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16162 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for SSLHostState.abarth@chromium.org2009-05-151-0/+179
| | | | | | | | | R=jcampan TEST=The whole CL is a test. :) Review URL: http://codereview.chromium.org/113446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16161 0039d316-1c4b-4281-b951-d872f2087c98
* Finish refactoring to make SSLPolicy and friends unit testable. Next stop: ↵abarth@chromium.org2009-05-1510-284/+280
| | | | | | | | | | | tests! TBR=jcampan BUG=http://crbug.com/8782 Review URL: http://codereview.chromium.org/115389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16145 0039d316-1c4b-4281-b951-d872f2087c98
* Update comments as requested by jcampan.abarth@chromium.org2009-05-142-3/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16063 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bad DCHECK.abarth@chromium.org2009-05-141-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16050 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.abarth@chromium.org2009-05-143-14/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16049 0039d316-1c4b-4281-b951-d872f2087c98
* Factor SSLPolicyBackend out of SSLManager.abarth@chromium.org2009-05-149-274/+354
| | | | | | | | | | | This reduces the complexity of SSLManager. The idea is eventually to be able to test SSLPolicy by substituting a fake SSLPolicyBackend. TBR=jcampan TEST=No behavior changes. Review URL: http://codereview.chromium.org/113395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16048 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit 16044 with typo fixed.abarth@chromium.org2009-05-144-42/+40
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16046 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16044abarth@chromium.org2009-05-144-40/+42
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16045 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of SSL UI code.abarth@chromium.org2009-05-144-42/+40
| | | | | | | | | TBR=jcampan TEST=No functionality change. Review URL: http://codereview.chromium.org/113392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16044 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the inner classes from SSLManager to their own files to reduce the ↵abarth@chromium.org2009-05-1411-593/+657
| | | | | | | | | | | | complexity of SSLManager. Heading towards unit testability of this code. TBR=jcampan TEST=No functionality change. Review URL: http://codereview.chromium.org/113391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16041 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak comment as requested by wtc.abarth@chromium.org2009-05-131-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15993 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify the semantics of some SSLHostState data structures.abarth@chromium.org2009-05-131-1/+6
| | | | | | | | | TBR=wtc TEST=No behavior changes Review URL: http://codereview.chromium.org/115289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15941 0039d316-1c4b-4281-b951-d872f2087c98
* Be slightly more precise in how we propagate mixed content state.abarth@chromium.org2009-05-126-30/+50
| | | | | | | | | | | Mixed content can't really propagate from one process to another, so we don't need to break the lock icon for every tab in the same origin when we see insecure content. We need only break the lock icon for all the tabs in the same process. R=jcampan TEST=SSLUITest.TestMixedContentsTwoTabs Review URL: http://codereview.chromium.org/115230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15858 0039d316-1c4b-4281-b951-d872f2087c98
* Remove executable bit from a bunch of files that shouldn't have it.evan@chromium.org2009-05-112-0/+0
| | | | | | | | | | (No code change.) git ls-tree -r HEAD | grep '^100755' | cut -f2 | egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' | xargs chmod a-x git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15809 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebKit API to src/webkit/api.darin@chromium.org2009-05-101-1/+1
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/113186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15739 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-061-2/+2
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-054-4/+4
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-053-3/+3
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-045-26/+17
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Stop the location bar from flashing white when navigating from one HTTPS ↵abarth@chromium.org2009-05-012-6/+5
| | | | | | | | | | | site to another. To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen. BUG=11157 TEST=Navigate from one HTTPS site to another and watch the location bar carefully. It shouln't flash anymore. Review URL: http://codereview.chromium.org/99247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15020 0039d316-1c4b-4281-b951-d872f2087c98
* Add some histograms to see how often users click through blocking pages.abarth@chromium.org2009-05-011-1/+22
| | | | | | | | | R=jar Review URL: http://codereview.chromium.org/99020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15018 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating the SSL UI tests to be browser tests.jcampan@chromium.org2009-04-291-8/+763
| | | | | | | | | | | | | Reenabling all of them. Hopefully it'll help with flakiness. Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux. BUG=6584,2136 TEST=Run the browser tests. Review URL: http://codereview.chromium.org/101013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this: jcampan@chromium.org2009-04-281-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a new kind of tests: browser tests. They are intended to provide an alternative to the UI tests, hopefully helping with flackiness. These tests are in-process browser test. There are 2 projects to build the tests: - the browser_test.dll that contains the tests, the gtest framework and the browser classes. - the browser_test_launcher.exe. The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly. This is Windows only for now. BUG=9764 TEST=Run browser_test.exe TBR=maruel Review URL: http://codereview.chromium.org/99097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14738 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my change it breaks release compilation on Windows.jcampan@chromium.org2009-04-271-20/+0
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14669 0039d316-1c4b-4281-b951-d872f2087c98
* This patch adds a new kind of tests: browser tests.jcampan@chromium.org2009-04-271-0/+20
| | | | | | | | | | | | | | | | | | They are intended to provide an alternative to the UI tests, hopefully helping with flackiness. These tests are in-process browser test. There are 2 projects to build the tests: - the browser_test.dll that contains the tests, the gtest framework and the browser classes. - the browser_test_launcher.exe. The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly. This is Windows only for now. BUG=9764 TEST=Run browser_test.exe Review URL: http://codereview.chromium.org/88066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14664 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 14569abarth@chromium.org2009-04-261-22/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14573 0039d316-1c4b-4281-b951-d872f2087c98
* Add some histograms to see how often users click through blocking pages.abarth@chromium.org2009-04-261-1/+22
| | | | | | | | R=jar Review URL: http://codereview.chromium.org/99020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14569 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-203-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-183-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-183-3/+3
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContentsType from the NavigationController external interface and inbrettw@chromium.org2009-04-151-4/+4
| | | | | | | some related areas. I removed all uses of this in the previous patch. Review URL: http://codereview.chromium.org/73057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13730 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more unneeded scaffolding.thestig@chromium.org2009-04-082-8/+3
| | | | | | Review URL: http://codereview.chromium.org/63129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13376 0039d316-1c4b-4281-b951-d872f2087c98
* Stop serializing WebString over IPC. The new rule is that only POD (plain olddarin@chromium.org2009-04-063-13/+8
| | | | | | | | | | | | | data) types from WebKit API are allowed to be used in the browser process. I added a big note about this to webkit_param_traits.h to explain the details of this decision. R=dglazkov Review URL: http://codereview.chromium.org/62032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13181 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more reliance on tab contents types.brettw@chromium.org2009-04-051-1/+0
| | | | | | Review URL: http://codereview.chromium.org/62041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13135 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some uses of custom tab contents types from some tests.brettw@chromium.org2009-04-041-3/+1
| | | | | | | | | | | | | | | This required redoing the tests that used it to use the new RenderViewHost test harness. This is mostly straightforward, but required more work for the NavigationController tests. I removed a few random places that were testing for the tab types. I also made different versions of a few functions that don't take tab contents types next to the existing ones that do, so my touched code won't have to be changed again when I remove the tab contents types. Review URL: http://codereview.chromium.org/62039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13132 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebConsoleMessage instead of ConsoleMessageLevel.darin@chromium.org2009-03-313-9/+17
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/57073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12916 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitted code from revision 12809. The bug in the Windows SSL stack thatmarkus@chromium.org2009-03-311-2/+10
| | | | | | | this code originally uncovered has been fixed in a separate changelist. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12876 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting, as this changelist broke unittests on Windows.markus@chromium.org2009-03-301-10/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12816 0039d316-1c4b-4281-b951-d872f2087c98
* Change the bad-certificate handler for SSL (using NSS) to return anmarkus@chromium.org2009-03-301-2/+10
| | | | | | | | | | | | | | | | | | | | | | | error. This requires a few additional changes in the rest of the code. In particular, we now have to teach HttpNetworkTransaction about how to restart connections with bad certificates. This was originally intended to be done by ReconnectIgnoringLastError(), but that API turns out be very difficult to implement in the SSLClientSocket. So, instead, we just create a completely new SSLClientSocket. We also have to be careful to store a copy of the certificate from within the bad-certificate handler, as it won't be available by the time GetSSLInfo() is called. And we fix a bug that would cause us to erroneously talk SSL on reconnected TCP sockets, even though we were still supposed to negotiate a proxy tunnel first. Review URL: http://codereview.chromium.org/43115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12809 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy fix: Step 9 of 9 (hopefully!).abarth@chromium.org2009-03-207-197/+241
| | | | | | | | | | | | Change our algorithm for computing the state of our SSL security indicators. Previously, we were computing this state for a single navigation entry. Although this matches other browsers, it fails to take the same-origin policy into account. For example, if one tab is contaminated with insecure content, that insecure content can spread to all the tabs in the same security origin. R=jcampan,wtc BUG=8706 TEST=SSLUITest.TestMixedContentsRandomizeHash,SSLUITest.TestMixedContentsTwoTabs Review URL: http://codereview.chromium.org/42314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12178 0039d316-1c4b-4281-b951-d872f2087c98
* Check return values for ReadInt in SSL manageragl@chromium.org2009-03-181-4/+3
| | | | | | | | | (found by Coverity) Review URL: http://codereview.chromium.org/42369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12030 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bogus DCHECKabarth@chromium.org2009-03-181-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11938 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 8.abarth@chromium.org2009-03-184-144/+267
| | | | | | | | | | | Cleanup the SSLPolicy API. This should be the last reorganization patch. The next step should be the substantive changes. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11937 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 7.abarth@chromium.org2009-03-172-263/+103
| | | | | | | | | | | Simplify SSLPolicy to prepare for changing its algorithm. This change should not change the SSLPolicy behavior at all. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11892 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-02 23:09:20 +0000